Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

save-analysis: use buffered writes #62164

Merged
merged 1 commit into from Jun 28, 2019

Conversation

Projects
None yet
7 participants
@jsgf
Copy link
Contributor

commented Jun 27, 2019

Otherwise it ends up writing the file byte at a time, which can be very slow for large outputs.

cc @ljw1004

save-analysis: use buffered writes
Otherwise it ends up writing the file byte at a time, which can be very slow for large outputs.
@rust-highfive

This comment has been minimized.

Copy link
Collaborator

commented Jun 27, 2019

r? @eddyb

(rust_highfive has picked a reviewer for you, use r? to override)

@Xanewok
Copy link
Member

left a comment

Makes sense, thanks!

@Xanewok

This comment has been minimized.

Copy link
Member

commented Jun 27, 2019

r? @Xanewok

@bors r+ rollup

@rust-highfive rust-highfive assigned Xanewok and unassigned eddyb Jun 27, 2019

@Xanewok

This comment has been minimized.

Copy link
Member

commented Jun 27, 2019

Let’s try separately...

@bors r+ rollup

@Centril am I doing something wrong?

@lzutao

This comment has been minimized.

Copy link
Contributor

commented Jun 27, 2019

@bors are you there?

@Centril Centril closed this Jun 27, 2019

@Centril Centril reopened this Jun 27, 2019

@Centril

This comment has been minimized.

Copy link
Member

commented Jun 27, 2019

@bors r+ rollup

@Xanewok

This comment has been minimized.

Copy link
Member

commented Jun 27, 2019

Seems like bors may be up, so let's...

@bors r+ rollup

@bors

This comment has been minimized.

Copy link
Contributor

commented Jun 27, 2019

📌 Commit 768d500 has been approved by Xanewok

@bors

This comment has been minimized.

Copy link
Contributor

commented Jun 27, 2019

🌲 The tree is currently closed for pull requests below priority 999, this pull request will be tested once the tree is reopened

Centril added a commit to Centril/rust that referenced this pull request Jun 27, 2019

Rollup merge of rust-lang#62164 - jsgf:buffer-save-analysis, r=Xanewok
save-analysis: use buffered writes

Otherwise it ends up writing the file byte at a time, which can be very slow for large outputs.

cc @ljw1004

bors added a commit that referenced this pull request Jun 27, 2019

Auto merge of #62178 - Centril:rollup-m9g77jr, r=Centril
Rollup of 16 pull requests

Successful merges:

 - #61767 (Update new_debug_unreachable)
 - #62043 (Remove `FnBox`)
 - #62067 (Add suggestion for missing `.await` keyword)
 - #62076 (Updated RELEASES.md for 1.36.0)
 - #62102 (call out explicitly that general read needs to be called with an initialized buffer)
 - #62103 (Add debug assertions to write_bytes and copy*)
 - #62106 (Add more tests for async/await)
 - #62124 (refactor lexer to use idiomatic borrowing)
 - #62131 (libsyntax: Fix some Clippy warnings)
 - #62150 (Implement mem::{zeroed,uninitialized} in terms of MaybeUninit.)
 - #62152 (Don't ICE on item in `.await` expression)
 - #62154 (Remove old fixme)
 - #62155 (Add regression test for MIR drop generation in async loops)
 - #62156 (Update books)
 - #62160 (Remove outdated question_mark_macro_sep lint)
 - #62164 (save-analysis: use buffered writes)

Failed merges:

r? @ghost

Centril added a commit to Centril/rust that referenced this pull request Jun 27, 2019

Rollup merge of rust-lang#62164 - jsgf:buffer-save-analysis, r=Xanewok
save-analysis: use buffered writes

Otherwise it ends up writing the file byte at a time, which can be very slow for large outputs.

cc @ljw1004

bors added a commit that referenced this pull request Jun 27, 2019

Auto merge of #62180 - Centril:rollup-g5jeoew, r=Centril
Rollup of 16 pull requests

Successful merges:

 - #61878 (improve pinning projection docs)
 - #62043 (Remove `FnBox`)
 - #62076 (Updated RELEASES.md for 1.36.0)
 - #62102 (call out explicitly that general read needs to be called with an initialized buffer)
 - #62103 (Add debug assertions to write_bytes and copy*)
 - #62106 (Add more tests for async/await)
 - #62131 (libsyntax: Fix some Clippy warnings)
 - #62150 (Implement mem::{zeroed,uninitialized} in terms of MaybeUninit.)
 - #62152 (Don't ICE on item in `.await` expression)
 - #62154 (Remove old fixme)
 - #62155 (Add regression test for MIR drop generation in async loops)
 - #62156 (Update books)
 - #62160 (Remove outdated question_mark_macro_sep lint)
 - #62164 (save-analysis: use buffered writes)
 - #62171 (rustc: Retry SIGILL linker invocations)
 - #62176 (Update RLS)

Failed merges:

r? @ghost

bors added a commit that referenced this pull request Jun 27, 2019

Auto merge of #62180 - Centril:rollup-g5jeoew, r=Centril
Rollup of 16 pull requests

Successful merges:

 - #61878 (improve pinning projection docs)
 - #62043 (Remove `FnBox`)
 - #62076 (Updated RELEASES.md for 1.36.0)
 - #62102 (call out explicitly that general read needs to be called with an initialized buffer)
 - #62103 (Add debug assertions to write_bytes and copy*)
 - #62106 (Add more tests for async/await)
 - #62131 (libsyntax: Fix some Clippy warnings)
 - #62150 (Implement mem::{zeroed,uninitialized} in terms of MaybeUninit.)
 - #62152 (Don't ICE on item in `.await` expression)
 - #62154 (Remove old fixme)
 - #62155 (Add regression test for MIR drop generation in async loops)
 - #62156 (Update books)
 - #62160 (Remove outdated question_mark_macro_sep lint)
 - #62164 (save-analysis: use buffered writes)
 - #62171 (rustc: Retry SIGILL linker invocations)
 - #62176 (Update RLS)

Failed merges:

r? @ghost

Centril added a commit to Centril/rust that referenced this pull request Jun 27, 2019

Rollup merge of rust-lang#62164 - jsgf:buffer-save-analysis, r=Xanewok
save-analysis: use buffered writes

Otherwise it ends up writing the file byte at a time, which can be very slow for large outputs.

cc @ljw1004

bors added a commit that referenced this pull request Jun 27, 2019

Auto merge of #62182 - Centril:rollup-reguimn, r=Centril
Rollup of 16 pull requests

Successful merges:

 - #61878 (improve pinning projection docs)
 - #62043 (Remove `FnBox`)
 - #62067 (Add suggestion for missing `.await` keyword)
 - #62076 (Updated RELEASES.md for 1.36.0)
 - #62102 (call out explicitly that general read needs to be called with an initialized buffer)
 - #62106 (Add more tests for async/await)
 - #62124 (refactor lexer to use idiomatic borrowing)
 - #62150 (Implement mem::{zeroed,uninitialized} in terms of MaybeUninit.)
 - #62152 (Don't ICE on item in `.await` expression)
 - #62154 (Remove old fixme)
 - #62155 (Add regression test for MIR drop generation in async loops)
 - #62156 (Update books)
 - #62160 (Remove outdated question_mark_macro_sep lint)
 - #62164 (save-analysis: use buffered writes)
 - #62171 (rustc: Retry SIGILL linker invocations)
 - #62176 (Update RLS)

Failed merges:

r? @ghost

Centril added a commit to Centril/rust that referenced this pull request Jun 27, 2019

Rollup merge of rust-lang#62164 - jsgf:buffer-save-analysis, r=Xanewok
save-analysis: use buffered writes

Otherwise it ends up writing the file byte at a time, which can be very slow for large outputs.

cc @ljw1004

bors added a commit that referenced this pull request Jun 27, 2019

Auto merge of #62192 - Centril:rollup-kssnlta, r=Centril
Rollup of 16 pull requests

Successful merges:

 - #61878 (improve pinning projection docs)
 - #62043 (Remove `FnBox`)
 - #62067 (Add suggestion for missing `.await` keyword)
 - #62076 (Updated RELEASES.md for 1.36.0)
 - #62102 (call out explicitly that general read needs to be called with an initialized buffer)
 - #62106 (Add more tests for async/await)
 - #62124 (refactor lexer to use idiomatic borrowing)
 - #62131 (libsyntax: Fix some Clippy warnings)
 - #62152 (Don't ICE on item in `.await` expression)
 - #62154 (Remove old fixme)
 - #62155 (Add regression test for MIR drop generation in async loops)
 - #62156 (Update books)
 - #62160 (Remove outdated question_mark_macro_sep lint)
 - #62164 (save-analysis: use buffered writes)
 - #62171 (rustc: Retry SIGILL linker invocations)
 - #62176 (Update RLS)

Failed merges:

r? @ghost

bors added a commit that referenced this pull request Jun 28, 2019

Auto merge of #62192 - Centril:rollup-kssnlta, r=Centril
Rollup of 16 pull requests

Successful merges:

 - #61878 (improve pinning projection docs)
 - #62043 (Remove `FnBox`)
 - #62067 (Add suggestion for missing `.await` keyword)
 - #62076 (Updated RELEASES.md for 1.36.0)
 - #62102 (call out explicitly that general read needs to be called with an initialized buffer)
 - #62106 (Add more tests for async/await)
 - #62124 (refactor lexer to use idiomatic borrowing)
 - #62131 (libsyntax: Fix some Clippy warnings)
 - #62152 (Don't ICE on item in `.await` expression)
 - #62154 (Remove old fixme)
 - #62155 (Add regression test for MIR drop generation in async loops)
 - #62156 (Update books)
 - #62160 (Remove outdated question_mark_macro_sep lint)
 - #62164 (save-analysis: use buffered writes)
 - #62171 (rustc: Retry SIGILL linker invocations)
 - #62176 (Update RLS)

Failed merges:

r? @ghost

bors added a commit that referenced this pull request Jun 28, 2019

Auto merge of #62192 - Centril:rollup-kssnlta, r=Centril
Rollup of 16 pull requests

Successful merges:

 - #61878 (improve pinning projection docs)
 - #62043 (Remove `FnBox`)
 - #62067 (Add suggestion for missing `.await` keyword)
 - #62076 (Updated RELEASES.md for 1.36.0)
 - #62102 (call out explicitly that general read needs to be called with an initialized buffer)
 - #62106 (Add more tests for async/await)
 - #62124 (refactor lexer to use idiomatic borrowing)
 - #62131 (libsyntax: Fix some Clippy warnings)
 - #62152 (Don't ICE on item in `.await` expression)
 - #62154 (Remove old fixme)
 - #62155 (Add regression test for MIR drop generation in async loops)
 - #62156 (Update books)
 - #62160 (Remove outdated question_mark_macro_sep lint)
 - #62164 (save-analysis: use buffered writes)
 - #62171 (rustc: Retry SIGILL linker invocations)
 - #62176 (Update RLS)

Failed merges:

r? @ghost

@bors bors merged commit 768d500 into rust-lang:master Jun 28, 2019

2 checks passed

Travis CI - Pull Request Build Passed
Details
pr Build #20190627.5 succeeded
Details

@jsgf jsgf deleted the jsgf:buffer-save-analysis branch Jun 29, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.