Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Implement va_arg for AArch64 Linux #62207
WIP. I would like some feedback before I tidy it up and properly verify it.
Is this approach of implementing it in rust instead of an intrinsic fine? I did it this way because it was simpler for me to write and should be simpler to understand. Does it matter that I added a hidden method to
How much complexity is left after all the decision-making based on the type is done?
referenced this pull request
Jul 10, 2019
dlrobertson left a comment
After a review of this, this seems like a reasonable way to prototype support for new architectures. It is similar to how
@joshtriplett @eddyb thoughts on implementing
In that case, you should be able to make this pretty general by having an int/float register decision based on the type and then emitting the appropriate IR.