Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustdoc: remove unused derives and variants #62224

Merged
merged 1 commit into from Jul 1, 2019

Conversation

Projects
None yet
4 participants
@euclio
Copy link
Contributor

commented Jun 29, 2019

Though many structs in rustdoc derive RustcEncodable and RustcDecodable, the impls do not appear to be used by the crate or its dependents. Removing them revealed some enum variants that are never constructed, too.

r? @GuillaumeGomez

@euclio euclio changed the title [rustdoc] remove unused derives and variants rustdoc: remove unused derives and variants Jun 29, 2019

@GuillaumeGomez

This comment has been minimized.

Copy link
Member

commented Jun 29, 2019

Thanks!

@bors: r+

@bors

This comment has been minimized.

Copy link
Contributor

commented Jun 29, 2019

📌 Commit e991abd has been approved by GuillaumeGomez

Centril added a commit to Centril/rust that referenced this pull request Jun 29, 2019

Rollup merge of rust-lang#62224 - euclio:remove-derives, r=GuillaumeG…
…omez

rustdoc: remove unused derives and variants

Though many structs in rustdoc derive `RustcEncodable` and `RustcDecodable`, the impls do not appear to be used by the crate or its dependents. Removing them revealed some enum variants that are never constructed, too.

r? @GuillaumeGomez

Centril added a commit to Centril/rust that referenced this pull request Jun 29, 2019

Rollup merge of rust-lang#62224 - euclio:remove-derives, r=GuillaumeG…
…omez

rustdoc: remove unused derives and variants

Though many structs in rustdoc derive `RustcEncodable` and `RustcDecodable`, the impls do not appear to be used by the crate or its dependents. Removing them revealed some enum variants that are never constructed, too.

r? @GuillaumeGomez

bors added a commit that referenced this pull request Jun 29, 2019

Auto merge of #62237 - Centril:rollup-nsrgek8, r=Centril
Rollup of 4 pull requests

Successful merges:

 - #60260 (Add support for UWP targets)
 - #62128 (Adjust warning of -C extra-filename with -o.)
 - #62153 (Update the `rust-installer` submodule)
 - #62224 (rustdoc: remove unused derives and variants)

Failed merges:

r? @ghost

Centril added a commit to Centril/rust that referenced this pull request Jun 29, 2019

Rollup merge of rust-lang#62224 - euclio:remove-derives, r=GuillaumeG…
…omez

rustdoc: remove unused derives and variants

Though many structs in rustdoc derive `RustcEncodable` and `RustcDecodable`, the impls do not appear to be used by the crate or its dependents. Removing them revealed some enum variants that are never constructed, too.

r? @GuillaumeGomez

bors added a commit that referenced this pull request Jun 29, 2019

Auto merge of #62242 - Centril:rollup-wuprmbu, r=Centril
Rollup of 5 pull requests

Successful merges:

 - #61767 (Update new_debug_unreachable)
 - #62128 (Adjust warning of -C extra-filename with -o.)
 - #62224 (rustdoc: remove unused derives and variants)
 - #62235 (Extend the `#[must_use]` lint to arrays)
 - #62239 (Fix a typo)

Failed merges:

r? @ghost

Centril added a commit to Centril/rust that referenced this pull request Jun 30, 2019

Rollup merge of rust-lang#62224 - euclio:remove-derives, r=GuillaumeG…
…omez

rustdoc: remove unused derives and variants

Though many structs in rustdoc derive `RustcEncodable` and `RustcDecodable`, the impls do not appear to be used by the crate or its dependents. Removing them revealed some enum variants that are never constructed, too.

r? @GuillaumeGomez

bors added a commit that referenced this pull request Jul 1, 2019

Auto merge of #62253 - Centril:rollup-115uuuq, r=Centril
Rollup of 8 pull requests

Successful merges:

 - #62062 (Use a more efficient iteration order for forward dataflow)
 - #62063 (Use a more efficient iteration order for backward dataflow)
 - #62224 (rustdoc: remove unused derives and variants)
 - #62228 (Extend the #[must_use] lint to boxed types)
 - #62235 (Extend the `#[must_use]` lint to arrays)
 - #62239 (Fix a typo)
 - #62241 (Always parse 'async unsafe fn' + properly ban in 2015)
 - #62248 (before_exec actually will only get deprecated with 1.37)

Failed merges:

r? @ghost

@bors bors merged commit e991abd into rust-lang:master Jul 1, 2019

1 check passed

pr Build #20190629.2 succeeded
Details

@euclio euclio deleted the euclio:remove-derives branch Jul 1, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.