Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always parse 'async unsafe fn' + properly ban in 2015 #62241

Merged
merged 1 commit into from Jul 1, 2019

Conversation

Projects
None yet
4 participants
@Centril
Copy link
Member

commented Jun 29, 2019

Parse async unsafe fn not unsafe async fn in implementations. We also take the opportunity to properly ban async fn in Rust 2015 when they are inside implementations.

Closes #62232.

cc #61319, #62121, and #62149.

r? @petrochenkov

@petrochenkov

This comment has been minimized.

Copy link
Contributor

commented Jun 30, 2019

@bors r+ rollup

@bors

This comment has been minimized.

Copy link
Contributor

commented Jun 30, 2019

📌 Commit ce1d95a has been approved by petrochenkov

Centril added a commit to Centril/rust that referenced this pull request Jun 30, 2019

Rollup merge of rust-lang#62241 - Centril:fix-async-unsafe-order, r=p…
…etrochenkov

Always parse 'async unsafe fn' + properly ban in 2015

Parse `async unsafe fn` not `unsafe async fn` in implementations. We also take the opportunity to properly ban `async fn` in Rust 2015 when they are inside implementations.

Closes rust-lang#62232.

cc rust-lang#61319, rust-lang#62121, and rust-lang#62149.

r? @petrochenkov

bors added a commit that referenced this pull request Jul 1, 2019

Auto merge of #62253 - Centril:rollup-115uuuq, r=Centril
Rollup of 8 pull requests

Successful merges:

 - #62062 (Use a more efficient iteration order for forward dataflow)
 - #62063 (Use a more efficient iteration order for backward dataflow)
 - #62224 (rustdoc: remove unused derives and variants)
 - #62228 (Extend the #[must_use] lint to boxed types)
 - #62235 (Extend the `#[must_use]` lint to arrays)
 - #62239 (Fix a typo)
 - #62241 (Always parse 'async unsafe fn' + properly ban in 2015)
 - #62248 (before_exec actually will only get deprecated with 1.37)

Failed merges:

r? @ghost

@bors bors merged commit ce1d95a into rust-lang:master Jul 1, 2019

1 check passed

pr Build #20190629.39 succeeded
Details

@Centril Centril deleted the Centril:fix-async-unsafe-order branch Jul 1, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.