Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace serialize with serde in rustdoc #62359

Open
wants to merge 1 commit into
base: master
from

Conversation

@euclio
Copy link
Contributor

commented Jul 4, 2019

This is a slightly less aggressive version of #61028.

r? @GuillaumeGomez

#[derive(Serialize)]
struct CrateData<'a> {
doc: String,
#[serde(rename = "i")]

This comment has been minimized.

Copy link
@GuillaumeGomez

GuillaumeGomez Jul 4, 2019

Member

That makes it so much simpler to understand! \o/

@GuillaumeGomez

This comment has been minimized.

Copy link
Member

commented Jul 4, 2019

If the generated index is the same as before, then it's all good for me. I'd just prefer if @QuietMisdreavus took a look to confirm and then here we go. Thanks a lot!

@edmilsonefs

This comment has been minimized.

Copy link

commented Jul 22, 2019

Hey! This is a ping from triage, we would like to know if you @QuietMisdreavus could give us a few minutes to share your thoughts on it.

Thanks.

@Dylan-DPC

This comment has been minimized.

Copy link
Member

commented Jul 22, 2019

r? @QuietMisdreavus

&self.desc,
self.parent_idx,
&self.search_type,
)

This comment has been minimized.

Copy link
@QuietMisdreavus

QuietMisdreavus Jul 25, 2019

Member

Is a tuple the right construct for this? Do serialize_tuple and serialize_seq come out the same when run through serde_json?

This comment has been minimized.

Copy link
@euclio

euclio Jul 27, 2019

Author Contributor

They will be serialized the same way. This way, it saves the intermediate step of serializing everything to Value to make a Vec<Value>.

@bors

This comment has been minimized.

Copy link
Contributor

commented Aug 2, 2019

☔️ The latest upstream changes (presumably #63207) made this pull request unmergeable. Please resolve the merge conflicts.

@gagan0723

This comment has been minimized.

Copy link
Member

commented Aug 6, 2019

Ping from triage, @euclio please resolve the merge conflicts. Thanks

@euclio euclio force-pushed the euclio:remove-serialize branch from 2603f32 to 698a239 Aug 10, 2019

@euclio

This comment has been minimized.

Copy link
Contributor Author

commented Aug 10, 2019

Rebased.

@JohnCSimon

This comment has been minimized.

Copy link

commented Aug 17, 2019

Ping from triage
@QuietMisdreavus @GuillaumeGomez - can you please review this?

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
9 participants
You can’t perform that action at this time.