Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing types' urls for slice type #62598

Open
wants to merge 1 commit into
base: master
from

Conversation

@GuillaumeGomez
Copy link
Member

commented Jul 11, 2019

@GuillaumeGomez GuillaumeGomez force-pushed the GuillaumeGomez:slice-missing-types branch from 2621a1b to b0a9296 Jul 12, 2019

@gagan0723

This comment has been minimized.

Copy link
Member

commented Jul 23, 2019

ping from triage @QuietMisdreavus any updates on this?

@GuillaumeGomez

This comment has been minimized.

Copy link
Member Author

commented Jul 23, 2019

I need to fix the PR first. Seems like the links are badly created.

@QuietMisdreavus

This comment has been minimized.

Copy link
Member

commented Aug 8, 2019

It looks like there's one too many ../ in the URLs when the methods are being rendered on the slice page (std/primitive.slice.html). I think this is one of those situations where relative-link URLs can't work because the methods are also rendered on the Vec page ((alloc|std)/vec/struct.Vec.html). These may have to stay un-linked.

@hdhoang

This comment has been minimized.

Copy link
Contributor

commented Aug 16, 2019

ping from triage @QuietMisdreavus, any updates on the reviewer's comment?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.