Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libtest: add --show-output flag to print stdout of successful tests #62600

Open
wants to merge 2 commits into
base: master
from

Conversation

@emmericp
Copy link

commented Jul 11, 2019

This pull request adds a new flag --show-output for tests to show the output of successful tests. For most formatters this was already supported just not exposed via the CLI (apparently only used by librustdoc). I've also added support for this option in the JSON formatter.

This kind of fixes #54669 which wants --format json to work with --nocapture, which is... well, impossible. What this issue really calls for is --show-output as implemented here.

libtest: add --show-output option
this new flag enables printing the captured stdout of successful tests
utilizing the already existing display_output test runner option
@Centril

This comment has been minimized.

Copy link
Member

commented Jul 11, 2019

Assigning random T-compiler member...

r? @varkor

@rust-highfive rust-highfive assigned varkor and unassigned bluss Jul 11, 2019

@emmericp emmericp force-pushed the emmericp:libtest-add-show-output branch from 33c9bc5 to 09c0c03 Jul 11, 2019

@emmericp emmericp force-pushed the emmericp:libtest-add-show-output branch from 09c0c03 to 409a41d Jul 12, 2019

@emmericp

This comment has been minimized.

Copy link
Author

commented Jul 12, 2019

updated with a new test case for the json output

@varkor

This comment has been minimized.

Copy link
Member

commented Jul 22, 2019

Assigning someone more familiar with libtest JSON output as in #46450.

r? @nrc

@ProgrammaticNajel

This comment has been minimized.

Copy link

commented Aug 2, 2019

Ping from triage. @nrc any updates on this? Thank you.

@JohnTitor

This comment has been minimized.

Copy link
Member

commented Aug 11, 2019

Ping from triage: @nrc do you have time to review?

@Centril Centril modified the milestones: 1.38, 1.39 Aug 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
8 participants
You can’t perform that action at this time.