Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stabilize checked_duration_since for 1.38.0 #62860

Open
wants to merge 3 commits into
base: master
from

Conversation

@vi
Copy link
Contributor

commented Jul 21, 2019

Looks like it has already found some use in projects.

Resolves #58402.

@rust-highfive

This comment has been minimized.

Copy link
Collaborator

commented Jul 21, 2019

r? @cramertj

(rust_highfive has picked a reviewer for you, use r? to override)

@Centril

This comment has been minimized.

Copy link
Member

commented Jul 21, 2019

@joelpalmer

This comment has been minimized.

Copy link

commented Jul 29, 2019

Ping from Triage. @dtolnay @rust-lang/libs checking on the status of a review for this PR.

@alexcrichton

This comment has been minimized.

Copy link
Member

commented Jul 29, 2019

Looks reasonable to me to merge, so let's...

@rfcbot fcp merge

New functions here are:

impl Instant {
    pub fn checked_duration_since(&self, earlier: Instant) -> Option<Duration>;
    pub fn saturating_duration_since(&self, earlier: Instant) -> Duration;
}
@rfcbot

This comment has been minimized.

Copy link

commented Jul 29, 2019

Team member @alexcrichton has proposed to merge this. The next step is review by the rest of the tagged team members:

No concerns currently listed.

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

@rfcbot

This comment has been minimized.

Copy link

commented Jul 30, 2019

🔔 This is now entering its final comment period, as per the review above. 🔔

@rfcbot

This comment has been minimized.

Copy link

commented Aug 9, 2019

The final comment period, with a disposition to merge, as per the review above, is now complete.

As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed.

The RFC will be merged soon.

@alexcrichton

This comment has been minimized.

Copy link
Member

commented Aug 9, 2019

@bors: r+

@bors

This comment has been minimized.

Copy link
Contributor

commented Aug 9, 2019

📌 Commit 01d9e57 has been approved by alexcrichton

Centril added a commit to Centril/rust that referenced this pull request Aug 9, 2019

Rollup merge of rust-lang#62860 - vi:stabilize_checked_duration_since…
…, r=alexcrichton

Stabilize checked_duration_since for 1.38.0

Looks like it has already found some use in projects.

Resolves rust-lang#58402.

@Centril Centril removed the needs-fcp label Aug 9, 2019

@Centril Centril referenced this pull request Aug 9, 2019

bors added a commit that referenced this pull request Aug 9, 2019

Auto merge of #63424 - Centril:rollup-2k5gn6b, r=Centril
Rollup of 8 pull requests

Successful merges:

 - #62756 (Stabilize duration_float)
 - #62860 (Stabilize checked_duration_since for 1.38.0)
 - #63337 (Tweak mismatched types error)
 - #63350 (Use associated_type_bounds where applicable - closes #61738)
 - #63352 (Sort the fat LTO modules to produce deterministic output.)
 - #63394 (Add test for issue 36804)
 - #63399 (More explicit diagnostic when using a `vec![]` in a pattern)
 - #63419 (check against more collisions for TypeId of fn pointer)

Failed merges:

r? @ghost
@bors

This comment has been minimized.

Copy link
Contributor

commented Aug 10, 2019

⌛️ Testing commit 01d9e57 with merge 9e4b6b4...

bors added a commit that referenced this pull request Aug 10, 2019

Auto merge of #62860 - vi:stabilize_checked_duration_since, r=alexcri…
…chton

Stabilize checked_duration_since for 1.38.0

Looks like it has already found some use in projects.

Resolves #58402.
@bors

This comment has been minimized.

Copy link
Contributor

commented Aug 10, 2019

💔 Test failed - checks-azure

@rust-highfive

This comment has been minimized.

Copy link
Collaborator

commented Aug 10, 2019

The job i686-apple of your PR failed (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
2019-08-10T05:08:41.6131770Z [TIMING] ToolBuild { compiler: Compiler { stage: 0, host: "i686-apple-darwin" }, target: "i686-apple-darwin", tool: "tidy", path: "src/tools/tidy", mode: ToolBootstrap, is_optional_tool: false, source_type: InTree, extra_features: [] } -- 101.711
2019-08-10T05:08:41.6132800Z tidy check
2019-08-10T05:08:52.1732190Z * 578 error codes
2019-08-10T05:08:52.1732670Z * highest error code: E0733
2019-08-10T05:08:52.5661040Z tidy error: /Users/vsts/agent/2.155.1/work/1/s/src/tools/tidy/src/features/tests.rs:5: mismatches the `issue` in previous
2019-08-10T05:08:54.4722900Z some tidy checks failed
2019-08-10T05:08:54.4729450Z 
2019-08-10T05:08:54.4729450Z 
2019-08-10T05:08:54.4731430Z command did not execute successfully: "/Users/vsts/agent/2.155.1/work/1/s/build/i686-apple-darwin/stage0-tools-bin/tidy" "/Users/vsts/agent/2.155.1/work/1/s/src" "/Users/vsts/agent/2.155.1/work/1/s/build/i686-apple-darwin/stage0/bin/cargo" "--no-vendor"
2019-08-10T05:08:54.4732760Z 
2019-08-10T05:08:54.4733310Z 
2019-08-10T05:08:54.4741490Z failed to run: /Users/vsts/agent/2.155.1/work/1/s/build/bootstrap/debug/bootstrap test
2019-08-10T05:08:54.4742160Z Build completed unsuccessfully in 0:01:58
2019-08-10T05:08:54.4742160Z Build completed unsuccessfully in 0:01:58
2019-08-10T05:08:54.4989600Z ##[error]Bash exited with code '1'.
2019-08-10T05:08:54.5041490Z ##[section]Starting: Upload CPU usage statistics
2019-08-10T05:08:54.5046340Z ==============================================================================
2019-08-10T05:08:54.5046450Z Task         : Bash
2019-08-10T05:08:54.5046540Z Description  : Run a Bash script on macOS, Linux, or Windows

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

src/libstd/time.rs Outdated Show resolved Hide resolved
src/libstd/time.rs Outdated Show resolved Hide resolved

@Centril Centril modified the milestones: 1.38, 1.39 Aug 13, 2019

vi and others added some commits Aug 13, 2019

Update src/libstd/time.rs
Co-Authored-By: Mazdak Farrokhzad <twingoow@gmail.com>
Update src/libstd/time.rs
Co-Authored-By: Mazdak Farrokhzad <twingoow@gmail.com>
@vi

This comment has been minimized.

Copy link
Contributor Author

commented Aug 22, 2019

Shall something else be done about this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.