Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[E0183] Add missing error code explanation #63022

Open
wants to merge 4 commits into
base: master
from

Conversation

@Karrq
Copy link

commented Jul 26, 2019

This is the continuation of #61225

CC #61137

Let me know if there's anything that needs change

ewk and others added some commits May 27, 2019

Add missing error code explanation for E0183
This is part of the ongoing work for #61137
@rust-highfive

This comment has been minimized.

Copy link
Collaborator

commented Jul 26, 2019

Some changes occurred in diagnostic error codes

cc @GuillaumeGomez

@rust-highfive

This comment has been minimized.

Copy link
Collaborator

commented Jul 26, 2019

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @varkor (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive

This comment has been minimized.

Copy link
Collaborator

commented Jul 26, 2019

The job x86_64-gnu-llvm-6.0 of your PR failed (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
2019-07-26T19:46:20.0780415Z ##[command]git remote add origin https://github.com/rust-lang/rust
2019-07-26T19:46:20.1021076Z ##[command]git config gc.auto 0
2019-07-26T19:46:20.1095592Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2019-07-26T19:46:20.1150525Z ##[command]git config --get-all http.proxy
2019-07-26T19:46:20.1292200Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/63022/merge:refs/remotes/pull/63022/merge
---
2019-07-26T19:46:54.0587008Z do so (now or later) by using -b with the checkout command again. Example:
2019-07-26T19:46:54.0587042Z 
2019-07-26T19:46:54.0587269Z   git checkout -b <new-branch-name>
2019-07-26T19:46:54.0587300Z 
2019-07-26T19:46:54.0587369Z HEAD is now at 638dbe97f Merge 08b8b7d4924d0902eadc5a03f289c922157fb0bc into 1a563362865e6051d4c350544131228e8eff5138
2019-07-26T19:46:54.0773908Z ##[section]Starting: Collect CPU-usage statistics in the background
2019-07-26T19:46:54.0777763Z ==============================================================================
2019-07-26T19:46:54.0777824Z Task         : Bash
2019-07-26T19:46:54.0777888Z Description  : Run a Bash script on macOS, Linux, or Windows
---
2019-07-26T19:53:10.0004936Z    Compiling serde_json v1.0.40
2019-07-26T19:53:14.3531960Z    Compiling tidy v0.1.0 (/checkout/src/tools/tidy)
2019-07-26T19:53:23.2054365Z     Finished release [optimized] target(s) in 1m 28s
2019-07-26T19:53:23.2124767Z tidy check
2019-07-26T19:53:23.3655914Z tidy error: /checkout/src/librustc_typeck/error_codes.rs:1592: trailing whitespace
2019-07-26T19:53:23.3656849Z tidy error: /checkout/src/librustc_typeck/error_codes.rs:1596: trailing whitespace
2019-07-26T19:53:25.1944725Z some tidy checks failed
2019-07-26T19:53:25.1945202Z 
2019-07-26T19:53:25.1945202Z 
2019-07-26T19:53:25.1947123Z command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/tidy" "/checkout/src" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "--no-vendor"
2019-07-26T19:53:25.1947352Z 
2019-07-26T19:53:25.1947376Z 
2019-07-26T19:53:25.1960429Z failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test src/tools/tidy
2019-07-26T19:53:25.1960714Z Build completed unsuccessfully in 0:01:31
2019-07-26T19:53:25.1960714Z Build completed unsuccessfully in 0:01:31
2019-07-26T19:53:26.5772658Z ##[error]Bash exited with code '1'.
2019-07-26T19:53:26.5826138Z ##[section]Starting: Checkout
2019-07-26T19:53:26.5828819Z ==============================================================================
2019-07-26T19:53:26.5828867Z Task         : Get sources
2019-07-26T19:53:26.5828924Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@GuillaumeGomez
Copy link
Member

left a comment

Good work, but not in the expected order. 😄 So, beyond my small fix requests, the global format of the explanation isn't "good". Steps:

  1. First you should state what the error.
  2. Followed then by "Erroneous code example:".
  3. Then comes the erroneous code example.
  4. Here goes the explanation of the error and how to solve it.
  5. Here comes the fixed code example from 3..

Also, please remember that those long error explanations are not only rendered into html but can also be seen into terminals when running rustc --explain [ERROR CODE] (which explains why I asked you to put empty lines before code blocks).

@Karrq

This comment has been minimized.

Copy link
Author

commented Jul 26, 2019

I tried to gather info from the surrounding errors about the format to follow but I wasn't really able.
Thanks for the complete explanation, I'll reformat the error to adhere to your guidelines

@Karrq

This comment has been minimized.

Copy link
Author

commented Jul 26, 2019

I was wondering tho, what's the actual error? When is this error emitted?
I don't seem to be able to get the compiler to emit the error...

Using self doesn't emit any error, and actually works... bug?
Not providing the tuple argument ICEs on cargo run.
Not adding the feature gate emits E0658.

@rust-highfive

This comment has been minimized.

Copy link
Collaborator

commented Jul 26, 2019

The job x86_64-gnu-llvm-6.0 of your PR failed (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
2019-07-26T20:11:30.7850846Z ##[command]git remote add origin https://github.com/rust-lang/rust
2019-07-26T20:11:30.8034310Z ##[command]git config gc.auto 0
2019-07-26T20:11:30.8107924Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2019-07-26T20:11:30.8165596Z ##[command]git config --get-all http.proxy
2019-07-26T20:11:30.8296477Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/63022/merge:refs/remotes/pull/63022/merge
---
2019-07-26T20:12:06.1148506Z do so (now or later) by using -b with the checkout command again. Example:
2019-07-26T20:12:06.1148538Z 
2019-07-26T20:12:06.1148756Z   git checkout -b <new-branch-name>
2019-07-26T20:12:06.1148785Z 
2019-07-26T20:12:06.1148835Z HEAD is now at f7ecaf5c2 Merge 3615cc28d0664191d680a963267515f7abb83c20 into 1a563362865e6051d4c350544131228e8eff5138
2019-07-26T20:12:06.1335613Z ##[section]Starting: Collect CPU-usage statistics in the background
2019-07-26T20:12:06.1339151Z ==============================================================================
2019-07-26T20:12:06.1339211Z Task         : Bash
2019-07-26T20:12:06.1339258Z Description  : Run a Bash script on macOS, Linux, or Windows
---
2019-07-26T20:18:24.7679924Z    Compiling serde_json v1.0.40
2019-07-26T20:18:29.1322223Z    Compiling tidy v0.1.0 (/checkout/src/tools/tidy)
2019-07-26T20:18:37.8355605Z     Finished release [optimized] target(s) in 1m 30s
2019-07-26T20:18:37.8422147Z tidy check
2019-07-26T20:18:38.0009820Z tidy error: /checkout/src/librustc_typeck/error_codes.rs:1592: trailing whitespace
2019-07-26T20:18:38.0010627Z tidy error: /checkout/src/librustc_typeck/error_codes.rs:1596: trailing whitespace
2019-07-26T20:18:39.7303145Z some tidy checks failed
2019-07-26T20:18:39.7305147Z 
2019-07-26T20:18:39.7305147Z 
2019-07-26T20:18:39.7306695Z command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/tidy" "/checkout/src" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "--no-vendor"
2019-07-26T20:18:39.7307670Z 
2019-07-26T20:18:39.7307768Z 
2019-07-26T20:18:39.7318078Z failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test src/tools/tidy
2019-07-26T20:18:39.7318210Z Build completed unsuccessfully in 0:01:33
2019-07-26T20:18:39.7318210Z Build completed unsuccessfully in 0:01:33
2019-07-26T20:18:41.0684123Z ##[error]Bash exited with code '1'.
2019-07-26T20:18:41.0717667Z ##[section]Starting: Checkout
2019-07-26T20:18:41.0719166Z ==============================================================================
2019-07-26T20:18:41.0719232Z Task         : Get sources
2019-07-26T20:18:41.0719271Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@GuillaumeGomez

This comment has been minimized.

Copy link
Member

commented Jul 27, 2019

I was wondering tho, what's the actual error? When is this error emitted?
I don't seem to be able to get the compiler to emit the error...

@Karrq That's part of why we ask to show the error. It also helps to check that the error is still emitted. It's however a bit surprising that the error doesn't show up... I can only recommend you to take a look at how it's emitted in the compiler (generally it's not very complicated). Look for the error code directly.

If you still can't figure out, maybe you can give a try to another error code?

@Karrq

This comment has been minimized.

Copy link
Author

commented Jul 27, 2019

@GuillaumeGomez I was able to figure out when the error is supposed to be emitted: librustc_typeck::coherence::enforce_trait_manually_implementable, and it should be emitted when the user tries to implement any of the Fn* traits manually (line 78 of mod.rs). I tried doing that but I wasn't able to get it to produce the error, again.

Upon digging more (searching rust-call ABI is subject to change) I was able to find some tests run for this feature. One of these files does the test to check what errors are emitted when trying to manually implement the Fn* traits (src/test/compile-fail/feature-gate-unboxed-closures-manual-impls.rs). As can be seen in the file there's a note that specifies that the error never triggers because other errors are raised before that. That note has been there since commit 09783d1dab, dated Jan 12 2015.

I believe there's no way from us to trigger this specific error, yet. Nevertheless, now that I know what's supposed to emit this error I'll update the description accordingly in the next commit.

@Karrq

This comment has been minimized.

Copy link
Author

commented Jul 27, 2019

According to the unstable book, unboxed_closures should be used to enable the user to use the "rust-call" ABI, but the compiler suggests to enable fn_traits instead.

From what I gathered:

  1. E0183 should tell the user to enable fn_traits since it's emitted when checking for the Fn* traits.
  2. When trying to use the "rust-call" ABI, the compiler should suggest to enable unboxed_closures. I wasn't enable to find where this error is emitted.
Error now suggests to add `fn_traits`
previous guidelines followed regarding formatting
@rust-highfive

This comment has been minimized.

Copy link
Collaborator

commented Jul 27, 2019

The job x86_64-gnu-llvm-6.0 of your PR failed (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
2019-07-27T17:39:07.0319721Z ##[command]git remote add origin https://github.com/rust-lang/rust
2019-07-27T17:39:07.0544298Z ##[command]git config gc.auto 0
2019-07-27T17:39:07.0613482Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2019-07-27T17:39:07.0675644Z ##[command]git config --get-all http.proxy
2019-07-27T17:39:07.0810319Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/63022/merge:refs/remotes/pull/63022/merge
---
2019-07-27T17:39:39.3636971Z do so (now or later) by using -b with the checkout command again. Example:
2019-07-27T17:39:39.3637391Z 
2019-07-27T17:39:39.3637695Z   git checkout -b <new-branch-name>
2019-07-27T17:39:39.3637740Z 
2019-07-27T17:39:39.3637903Z HEAD is now at f9868ed19 Merge 00bde392f8a55ba01cfa4b15e8c1bee3ebe0c523 into 0e9b465d729d07101b29b4d096d83edf9be82df0
2019-07-27T17:39:39.3791283Z ##[section]Starting: Collect CPU-usage statistics in the background
2019-07-27T17:39:39.3794369Z ==============================================================================
2019-07-27T17:39:39.3794446Z Task         : Bash
2019-07-27T17:39:39.3794495Z Description  : Run a Bash script on macOS, Linux, or Windows
---
2019-07-27T18:41:07.1477978Z .................................................................................................... 700/5870
2019-07-27T18:41:11.3353944Z .................................................................................................... 800/5870
2019-07-27T18:41:17.0377012Z .................................................................................................... 900/5870
2019-07-27T18:41:22.2180335Z .................................................................................................... 1000/5870
2019-07-27T18:41:27.9058374Z i...........i....................................................................................... 1100/5870
2019-07-27T18:41:31.9903620Z ..............................iiiii................................................................. 1200/5870
2019-07-27T18:41:38.3474213Z .................................................................................................... 1400/5870
2019-07-27T18:41:41.1960797Z .................................................................................................... 1500/5870
2019-07-27T18:41:45.0961614Z .................................................................................................... 1600/5870
2019-07-27T18:41:47.9485970Z .................................................................................................... 1700/5870
---
2019-07-27T18:43:04.1498973Z .................................................................................................... 3400/5870
2019-07-27T18:43:09.3659388Z .................................................................................................... 3500/5870
2019-07-27T18:43:13.4997242Z ..........................i......................................................................... 3600/5870
2019-07-27T18:43:17.9230100Z .................................................................................................... 3700/5870
2019-07-27T18:43:21.6413172Z ....ii...i..ii...................................................................................... 3800/5870
2019-07-27T18:43:30.6542234Z .................................................................................................... 4000/5870
2019-07-27T18:43:34.6673389Z .......................ii........................................................................... 4100/5870
2019-07-27T18:43:37.1527207Z ............................................i....................................................... 4200/5870
2019-07-27T18:43:39.3428063Z .................................................................................................... 4300/5870
---
2019-07-27T18:54:04.4247260Z  finished in 22.852
2019-07-27T18:54:04.4427564Z Check compiletest suite=codegen mode=codegen (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-07-27T18:54:04.6118554Z 
2019-07-27T18:54:04.6118706Z running 146 tests
2019-07-27T18:54:08.0490567Z i....iii......iii..iiii....i............................i..i................i....i.........ii.i.i..i 100/146
2019-07-27T18:54:09.9164837Z iii..............i.........iii.i......ii......
2019-07-27T18:54:09.9166404Z 
2019-07-27T18:54:09.9169774Z  finished in 5.474
2019-07-27T18:54:09.9377064Z Check compiletest suite=codegen-units mode=codegen-units (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-07-27T18:54:10.1037783Z 
---
2019-07-27T18:54:12.2155547Z  finished in 2.277
2019-07-27T18:54:12.2337393Z Check compiletest suite=assembly mode=assembly (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-07-27T18:54:12.3886017Z 
2019-07-27T18:54:12.3887404Z running 9 tests
2019-07-27T18:54:12.3888233Z iiiiiiiii
2019-07-27T18:54:12.3888545Z 
2019-07-27T18:54:12.3890641Z  finished in 0.154
2019-07-27T18:54:12.4071039Z Check compiletest suite=incremental mode=incremental (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-07-27T18:54:12.5652661Z 
---
2019-07-27T18:54:30.9524839Z  finished in 18.545
2019-07-27T18:54:30.9716110Z Check compiletest suite=debuginfo mode=debuginfo-gdb+lldb (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-07-27T18:54:31.1507643Z 
2019-07-27T18:54:31.1508780Z running 122 tests
2019-07-27T18:54:55.5328748Z .iiiii...i.....i..i...i..i.i.i..i.ii..i.i.....i..i....i..........iiii..........i...ii...i.......ii.i 100/122
2019-07-27T18:55:00.1447125Z .i.i......iii.i.....ii
2019-07-27T18:55:00.1447595Z 
2019-07-27T18:55:00.1452237Z  finished in 29.173
2019-07-27T18:55:00.1460168Z Uplifting stage1 rustc (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-07-27T18:55:00.1462403Z Copying stage2 rustc from stage1 (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu / x86_64-unknown-linux-gnu)
---
2019-07-27T19:09:25.7589779Z 
2019-07-27T19:09:25.7590859Z    Doc-tests core
2019-07-27T19:09:29.9167945Z 
2019-07-27T19:09:29.9176069Z running 2379 tests
2019-07-27T19:09:43.4559553Z ......iiiii......................................................................................... 100/2379
2019-07-27T19:09:56.0863923Z .........................................................................ii......................... 200/2379
2019-07-27T19:10:26.0461752Z .................................................................................................... 400/2379
2019-07-27T19:10:26.0461752Z .................................................................................................... 400/2379
2019-07-27T19:10:37.4711671Z ..............................i..i.................iiii............................................. 500/2379
2019-07-27T19:11:01.4485857Z .................................................................................................... 700/2379
2019-07-27T19:11:13.7018064Z .................................................................................................... 800/2379
2019-07-27T19:11:25.7993804Z .................................................................................................... 900/2379
2019-07-27T19:11:37.9421083Z .................................................................................................... 1000/2379
---
2019-07-27T19:16:43.1501686Z .................................................................................................... 500/756
2019-07-27T19:16:43.1729180Z .............thread '<unnamed>' panicked at 'called `Result::unwrap()` on an `Err` value: RecvError', src/libcore/result.rs:1084:5
2019-07-27T19:16:43.1740766Z ....thread '<unnamed>' panicked at 'called `Result::unwrap()` on an `Err` value: "SendError(..)"', src/libcore/result.rs:1084:5
2019-07-27T19:16:43.1741721Z thread '<unnamed>' panicked at 'called `Result::unwrap()` on an `Err` value: RecvError', src/libcore/result.rs:1084:5
2019-07-27T19:16:43.1770448Z ..............thread '<unnamed>' panicked at 'called `Result::unwrap()` on an `Err` value: RecvError', src/libcore/result.rs:1084:5
2019-07-27T19:16:43.4116720Z ...................................thread '<unnamed>' panicked at 'called `Result::unwrap()` on an `Err` value: RecvError', src/libcore/result.rs:1084:5
2019-07-27T19:16:43.4140447Z ....thread '<unnamed>' panicked at 'called `Result::unwrap()` on an `Err` value: "SendError(..)"', src/libcore/result.rs:1084:5
2019-07-27T19:16:43.4149924Z thread '<unnamed>.' panicked at 'called `Result::unwrap()` on an `Err` value: RecvError', src/libcore/result.rs:1084:5
2019-07-27T19:16:43.4178211Z ......thread '<unnamed>' panicked at 'called `Result::unwrap()` on an `Err` value: RecvError', src/libcore/result.rs:1084:5
2019-07-27T19:16:45.4949196Z ...............thread '<unnamed>' panicked at 'explicit panic', src/libstd/sync/mutex.rs:629:13
2019-07-27T19:16:45.4959746Z ..thread '<unnamed>' panicked at 'test panic in inner thread to poison mutex', src/libstd/sync/mutex.rs:584:13
2019-07-27T19:16:45.4966482Z ...thread '<unnamed>' panicked at 'test panic in inner thread to poison mutex', src/libstd/sync/mutex.rs:561:13
2019-07-27T19:16:45.4971555Z .thread '<unnamed>' panicked at 'explicit panic', src/libstd/sync/mutex.rs:689:13
---
2019-07-27T19:16:54.9153258Z 
2019-07-27T19:16:54.9153402Z running 989 tests
2019-07-27T19:17:19.2717175Z i................................................................................................... 100/989
2019-07-27T19:17:32.8928617Z .................................................................................................... 200/989
2019-07-27T19:17:41.7068335Z .................iii......i......i...i......i....................................................... 300/989
2019-07-27T19:17:46.6088106Z .................................................................................................... 400/989
2019-07-27T19:17:55.0725530Z ................................i..i.................................ii............................. 500/989
2019-07-27T19:18:10.3314238Z .................................................................................................... 700/989
2019-07-27T19:18:10.3314238Z .................................................................................................... 700/989
2019-07-27T19:18:19.0575796Z ...............iiii................................................................................. 800/989
2019-07-27T19:18:34.0740871Z .................................................................................................... 900/989
2019-07-27T19:18:41.8870266Z .....................................iiii................................................
2019-07-27T19:18:41.8871136Z 
2019-07-27T19:18:41.9068726Z  finished in 244.342
2019-07-27T19:18:41.9086524Z Testing unwind stage1 (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-07-27T19:18:42.0964975Z     Finished release [optimized] target(s) in 0.18s
---
2019-07-27T19:38:19.9517353Z Testing error-index stage2
2019-07-27T19:38:19.9668079Z doc tests for: /checkout/obj/build/x86_64-unknown-linux-gnu/test/error-index.md
2019-07-27T19:38:54.0607076Z 
2019-07-27T19:38:54.0607285Z 
2019-07-27T19:38:54.0608274Z command did not execute successfully: "/checkout/obj/build/bootstrap/debug/rustdoc" "--test" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/error-index.md" "--test-args" ""
2019-07-27T19:38:54.0631598Z 
2019-07-27T19:38:54.0632739Z stdout ----
2019-07-27T19:38:54.0632961Z 
2019-07-27T19:38:54.0633115Z running 712 tests
---
2019-07-27T19:38:54.0929671Z test /checkout/obj/build/x86_64-unknown-linux-gnu/test/error-index.md - Rust_Compiler_Error_Index::E0732 (line 11888) ... ok
2019-07-27T19:38:54.0929713Z 
2019-07-27T19:38:54.0929764Z failures:
2019-07-27T19:38:54.0929788Z 
2019-07-27T19:38:54.0930048Z ---- /checkout/obj/build/x86_64-unknown-linux-gnu/test/error-index.md - Rust_Compiler_Error_Index::E0183 (line 2954) stdout ----
2019-07-27T19:38:54.0930259Z error[E0658]: use of unstable library feature 'fn_traits'
2019-07-27T19:38:54.0930493Z   --> /checkout/obj/build/x86_64-unknown-linux-gnu/test/error-index.md:2960:5
2019-07-27T19:38:54.0930535Z    |
2019-07-27T19:38:54.0930748Z 8  | /     extern "rust-call" fn call_once(self, args: (A,)) -> Self::Output {
2019-07-27T19:38:54.0930805Z 9  | |         args.0
2019-07-27T19:38:54.0930876Z    | |_____^
2019-07-27T19:38:54.0930926Z    |
2019-07-27T19:38:54.0930926Z    |
2019-07-27T19:38:54.0931259Z    = note: for more information, see ***/issues/29625
2019-07-27T19:38:54.0931309Z    = help: add `#![feature(fn_traits)]` to the crate attributes to enable
2019-07-27T19:38:54.0931933Z error: aborting due to previous error
2019-07-27T19:38:54.0931966Z 
2019-07-27T19:38:54.0932283Z For more information about this error, try `rustc --explain E0658`.
2019-07-27T19:38:54.0932283Z For more information about this error, try `rustc --explain E0658`.
2019-07-27T19:38:54.0932354Z Some expected error codes were not found: ["E0183"]
2019-07-27T19:38:54.0932422Z failures:
2019-07-27T19:38:54.0932711Z     /checkout/obj/build/x86_64-unknown-linux-gnu/test/error-index.md - Rust_Compiler_Error_Index::E0183 (line 2954)
2019-07-27T19:38:54.0932761Z 
2019-07-27T19:38:54.0932807Z test result: FAILED. 687 passed; 1 failed; 24 ignored; 0 measured; 0 filtered out
---
2019-07-27T19:38:54.0933115Z 
2019-07-27T19:38:54.0933140Z 
2019-07-27T19:38:54.0933185Z failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
2019-07-27T19:38:54.0933247Z Build completed unsuccessfully in 1:51:43
2019-07-27T19:38:54.9879298Z ##[error]Bash exited with code '1'.
2019-07-27T19:38:54.9920545Z ##[section]Starting: Checkout
2019-07-27T19:38:54.9922952Z ==============================================================================
2019-07-27T19:38:54.9923014Z Task         : Get sources
2019-07-27T19:38:54.9923064Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@varkor

This comment has been minimized.

Copy link
Member

commented Jul 28, 2019

@JohnTitor

This comment has been minimized.

Copy link
Member

commented Aug 4, 2019

Ping from triage: @Karrq and @GuillaumeGomez any updates on this?

@GuillaumeGomez

This comment has been minimized.

Copy link
Member

commented Aug 4, 2019

I'm waiting on @Karrq. :)

@Karrq

This comment has been minimized.

Copy link
Author

commented Aug 4, 2019

Doesn't look like that to me. I added 2 comments to the issue and a commit based on those comments. Haven't received a review/reply since.

I see that github says that there are changes requested, but I can't figure out how to remove that since the changes have happened.

@GuillaumeGomez @JohnTitor

@Karrq
Copy link
Author

left a comment

Outdated

@Karrq

This comment has been minimized.

Copy link
Author

commented Aug 4, 2019

So, @GuillaumeGomez, as I commented previously there are some concerns that I think need to be discussed.

I'd like to know what you are waiting on me for. Is is the build errors for the pipeline? If that's so I'd like some guidance on how to resolve them, since I'm not able to figure out why they are being generated in the first place.

@GuillaumeGomez

This comment has been minimized.

Copy link
Member

commented Aug 5, 2019

The error index aren't generated automatically, when you generate a new compiler error, you create a new error index alongside and normally you also provide the long error explanation (and a test where the error is checked to be emitted). It's possible that the path to the error isn't possible anymore and then you should just try your luck with another error code (one which has a test).

@hdhoang

This comment has been minimized.

Copy link
Contributor

commented Aug 16, 2019

ping from triage @Karrq, any updates on this? Thanks for your time!

@Karrq

This comment has been minimized.

Copy link
Author

commented Aug 16, 2019

Unfortunately I've been very busy recently and couldn't really take a look at the error index, but since the error itself doesn't seem to be able to be emitted I don't think there's much more I can do

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.