Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the placement of two functions. #63045

Open
wants to merge 1 commit into
base: master
from

Conversation

@Rosto75
Copy link
Contributor

commented Jul 27, 2019

Right now, the order is as follows:
pop_front()
push_front()
push_back()
pop_back()

swap_remove_back()
swap_remove_front()

I believe it would be more natural, and easier to follow, if we place pop_back() right after the pop_front(), and swap_remove_back() after the swap_remove_front() like this:
pop_front()
pop_back()
push_front()
push_back()

swap_remove_front()
swap_remove_back()

The rest of the documentation (at least in this module) adheres to the same logic, where the 'front' function always precedes its 'back' equivalent.

@rust-highfive

This comment has been minimized.

Copy link
Collaborator

commented Jul 27, 2019

r? @aidanhs

(rust_highfive has picked a reviewer for you, use r? to override)

Change the placement of two functions.
Right now, the order is as follows:
`pop_front()`
`push_front()`
`push_back()`
`pop_back()`

`swap_remove_back()`
`swap_remove_front()`

I believe it would be more natural, and easier to follow, if we place `pop_back()` right after the `pop_front()`, and `swap_remove_back()` after the `swap_remove_front()` like this:
`pop_front()`
`pop_back()`
`push_front()`
`push_back()`

`swap_remove_front()`
`swap_remove_back()`

The rest of the documentation (at least in this module) adheres to the same logic, where the 'front' function always precedes its 'back' equivalent.

@Rosto75 Rosto75 force-pushed the Rosto75:master branch from ba12865 to 98c50eb Jul 27, 2019

@Rosto75 Rosto75 changed the title Change the placement of two function. Change the placement of two functions. Jul 27, 2019

@JohnTitor

This comment has been minimized.

Copy link
Member

commented Aug 4, 2019

Ping from triage: @aidanhs, waiting on your review.

@joelpalmer

This comment has been minimized.

Copy link

commented Aug 12, 2019

Ping from triage: @aidanhs, any update on the review?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.