Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In which we constantly improve the Vec(Deque) array PartialEq impls #63061

Merged
merged 3 commits into from Jul 28, 2019

Conversation

@Centril
Copy link
Member

commented Jul 28, 2019

Use the same approach as in #62435 as sanctioned by #61415 (comment).

r? @scottmcm

@Centril

This comment has been minimized.

Copy link
Member Author

commented Jul 28, 2019

@bors try

@bors

This comment has been minimized.

Copy link
Contributor

commented Jul 28, 2019

⌛️ Trying commit bfdfa85 with merge 39cf970...

bors added a commit that referenced this pull request Jul 28, 2019

Auto merge of #63061 - Centril:constantly-improving, r=<try>
In which we constantly improve the Vec(Deque) array PartialEq impls

Use the same approach as in #62435 as sanctioned by #61415 (comment).

r? @scottmcm
@scottmcm

This comment has been minimized.

Copy link
Member

commented Jul 28, 2019

Diff looks good; r=me when you're through whatever perf stuff you're verifying.

@bors

This comment has been minimized.

Copy link
Contributor

commented Jul 28, 2019

☀️ Try build successful - checks-azure
Build commit: 39cf970

@Centril

This comment has been minimized.

Copy link
Member Author

commented Jul 28, 2019

@Centril

This comment has been minimized.

Copy link
Member Author

commented Jul 28, 2019

Argh... the timer bot seems broken... Let's not wait for it =P

@bors r=scottmcm

@bors

This comment has been minimized.

Copy link
Contributor

commented Jul 28, 2019

📌 Commit bfdfa85 has been approved by scottmcm

Centril added a commit to Centril/rust that referenced this pull request Jul 28, 2019

Rollup merge of rust-lang#63061 - Centril:constantly-improving, r=sco…
…ttmcm

In which we constantly improve the Vec(Deque) array PartialEq impls

Use the same approach as in rust-lang#62435 as sanctioned by rust-lang#61415 (comment).

r? @scottmcm

bors added a commit that referenced this pull request Jul 28, 2019

Auto merge of #63072 - Centril:rollup-u9u7ijy, r=Centril
Rollup of 5 pull requests

Successful merges:

 - #62806 (Fix few Clippy warnings)
 - #63051 (Avoid ICE when referencing desugared local binding in borrow error)
 - #63061 (In which we constantly improve the Vec(Deque) array PartialEq impls)
 - #63067 (Add test for issue-50900)
 - #63071 (Allow rustbot to add `F-*` + `requires-nightly`.)

Failed merges:

r? @ghost

Centril added a commit to Centril/rust that referenced this pull request Jul 28, 2019

Rollup merge of rust-lang#63061 - Centril:constantly-improving, r=sco…
…ttmcm

In which we constantly improve the Vec(Deque) array PartialEq impls

Use the same approach as in rust-lang#62435 as sanctioned by rust-lang#61415 (comment).

r? @scottmcm

bors added a commit that referenced this pull request Jul 28, 2019

Auto merge of #63074 - Centril:rollup-k1a8z0n, r=Centril
Rollup of 8 pull requests

Successful merges:

 - #62550 (Implement RFC 2707 + Parser recovery for range patterns)
 - #62759 (Actually add rustc-guide to toolstate, don't fail builds for the guide)
 - #62806 (Fix few Clippy warnings)
 - #62974 (bump crossbeam-epoch dependency)
 - #63051 (Avoid ICE when referencing desugared local binding in borrow error)
 - #63061 (In which we constantly improve the Vec(Deque) array PartialEq impls)
 - #63067 (Add test for issue-50900)
 - #63071 (Allow rustbot to add `F-*` + `requires-nightly`.)

Failed merges:

r? @ghost
@Mark-Simulacrum

This comment has been minimized.

Copy link
Member

commented Jul 28, 2019

@bors bors merged commit bfdfa85 into rust-lang:master Jul 28, 2019

5 checks passed

homu Test successful
Details
pr Build #20190728.8 succeeded
Details
pr (Linux mingw-check) Linux mingw-check succeeded
Details
pr (Linux x86_64-gnu-llvm-6.0) Linux x86_64-gnu-llvm-6.0 succeeded
Details
pr (LinuxTools) LinuxTools succeeded
Details
@rust-timer

This comment has been minimized.

Copy link

commented Jul 28, 2019

Success: Queued 39cf970 with parent c798dff, comparison URL.

@Centril Centril deleted the Centril:constantly-improving branch Jul 28, 2019

@rust-timer

This comment has been minimized.

Copy link

commented Jul 28, 2019

Finished benchmarking try commit 39cf970, comparison URL.

@Centril

This comment has been minimized.

Copy link
Member Author

commented Jul 28, 2019

Nice; this caused some 0.5% to 2.2% improvements in some cases. 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.