Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds language to CONTRIBUTING to mention contributor licenses #63187

Open
wants to merge 1 commit into
base: master
from

Conversation

@mrice
Copy link

commented Aug 1, 2019

Adds a brief paragraph to remind contributors that they are granting a dual license under MIT and Apache 2.

DISCLAIMER: this isn't intended as legal advice by any means. I just think it would be useful to add this paragraph for contributors, but I'm by no means suggesting it has any legal effect, is the right thing to do, or offering any advice. Just thinking of it as a common sense addition.

@rust-highfive

This comment has been minimized.

Copy link
Collaborator

commented Aug 1, 2019

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@mrice

This comment has been minimized.

Copy link
Author

commented Aug 1, 2019

@alexcrichton - dropped you an offline email on this one. Happy to talk in either forum.

@alexcrichton

This comment has been minimized.

Copy link
Member

commented Aug 2, 2019

Thanks for the PR @mrice! I think it'd be great though to avoid duplicating license text in a few locations, could this perhaps be a leading blurb which points to a different location to remind readers of the license and such?

@JohnCSimon

This comment has been minimized.

Copy link

commented Aug 10, 2019

Hello from triage @mrice @alexcrichton ...
It looks like there are some changes that still need to be made to this PR, so I'm changing the status to S-waiting-on-author as this has sat idle for a week or more.

@JohnCSimon

This comment has been minimized.

Copy link

commented Aug 17, 2019

@mrice @alexcrichton Pinging again from triage, can you please resolve this? Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.