Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue#63183: Add fs::read_dir() and ReadDir warning about iterator order + example #63356

Open
wants to merge 3 commits into
base: master
from

Conversation

@ali-raheem
Copy link

commented Aug 7, 2019

As per #63183

Add warning about iterator order to read_dir and ReadDir, add example of explicitly ordering direntrys.

@rust-highfive

This comment has been minimized.

Copy link
Collaborator

commented Aug 7, 2019

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @KodrAus (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

Show resolved Hide resolved src/libstd/fs.rs Outdated
Show resolved Hide resolved src/libstd/fs.rs Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.