Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apfloat: improve doc comments #63416

Open
wants to merge 1 commit into
base: master
from

Conversation

@RalfJung
Copy link
Member

commented Aug 9, 2019

@eddyb

This comment has been minimized.

Copy link
Member

commented Aug 10, 2019

I'd rather not change rustc_apfloat directly, but rather upstream it to LLVM and then port it back to rustc_apfloat. I need to go through the few changes that were made to rustc_apfloat and not reviewed by me, to make sure there aren't more instances like this.

@RalfJung

This comment has been minimized.

Copy link
Member Author

commented Aug 10, 2019

Submitting patches to LLVM is super painful though. :/
So what do we do with this PR?

@RalfJung

This comment has been minimized.

Copy link
Member Author

commented Aug 17, 2019

@eddyb so what do we do with this PR now? Just close it? Seems like a waste of a good docs improvement, but then it's not like his took long to write.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.