Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Add HashMap to std's prelude #63418

Open
wants to merge 3 commits into
base: master
from

Conversation

@lzutao
Copy link
Contributor

commented Aug 9, 2019

r? @Centril

@@ -123,3 +123,6 @@ pub use crate::string::{String, ToString};
#[stable(feature = "rust1", since = "1.0.0")]
#[doc(no_inline)]
pub use crate::vec::Vec;
#[unstable(feature = "hashmap_prelude", issue = "0")]

This comment has been minimized.

Copy link
@Centril

Centril Aug 9, 2019

Member

@petrochenkov Does this have any effect? Probably not?

This comment has been minimized.

Copy link
@petrochenkov

petrochenkov Aug 9, 2019

Contributor

It has effect on documentation.
(It will also have effect if someone bothers to move stability checking to its proper place - resolve.)

@rust-highfive

This comment was marked as resolved.

Copy link
Collaborator

commented Aug 9, 2019

The job x86_64-gnu-llvm-6.0 of your PR failed (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
2019-08-09T18:09:55.0402666Z ##[command]git remote add origin https://github.com/rust-lang/rust
2019-08-09T18:09:55.0571971Z ##[command]git config gc.auto 0
2019-08-09T18:09:55.0645614Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2019-08-09T18:09:55.0702965Z ##[command]git config --get-all http.proxy
2019-08-09T18:09:55.0843112Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/63418/merge:refs/remotes/pull/63418/merge
---
2019-08-09T18:10:30.5626975Z do so (now or later) by using -b with the checkout command again. Example:
2019-08-09T18:10:30.5627027Z 
2019-08-09T18:10:30.5627265Z   git checkout -b <new-branch-name>
2019-08-09T18:10:30.5627301Z 
2019-08-09T18:10:30.5627367Z HEAD is now at 9bdaaf63e Merge 3687617cd36b1c97d293bacdc7c0635721921ebd into 534b42394d743511db1335d5ed08d507ab7c6e73
2019-08-09T18:10:30.5802477Z ##[section]Starting: Collect CPU-usage statistics in the background
2019-08-09T18:10:30.5805501Z ==============================================================================
2019-08-09T18:10:30.5805566Z Task         : Bash
2019-08-09T18:10:30.5805617Z Description  : Run a Bash script on macOS, Linux, or Windows
---
2019-08-09T19:12:02.7146700Z .................................................................................................... 1300/8860
2019-08-09T19:12:09.4659668Z .................................................................................................... 1400/8860
2019-08-09T19:12:15.6887341Z .................................................................................................... 1500/8860
2019-08-09T19:12:26.2515387Z ....................................................................................i............... 1600/8860
2019-08-09T19:12:33.9379213Z i................................................................................................... 1700/8860
2019-08-09T19:12:40.6874643Z ...........................................................................iiiii.................... 1800/8860
2019-08-09T19:13:02.9767770Z .................................................................................................... 2000/8860
2019-08-09T19:13:05.5316951Z .................................................................................................... 2100/8860
2019-08-09T19:13:08.3403867Z .................................................................................................... 2200/8860
2019-08-09T19:13:16.1519632Z .................................................................................................... 2300/8860
---
2019-08-09T19:17:03.7849262Z .................................................................................................... 5200/8860
2019-08-09T19:17:14.7199063Z .................................................................................................... 5300/8860
2019-08-09T19:17:22.4651785Z .i.................................................................................................. 5400/8860
2019-08-09T19:17:27.7325233Z .................................................................................................... 5500/8860
2019-08-09T19:17:39.7942745Z ...............................................................................................ii... 5600/8860
2019-08-09T19:17:54.5297580Z i..ii...........i................................................................................... 5700/8860
2019-08-09T19:18:07.9700915Z .................................................................................................... 5900/8860
2019-08-09T19:18:12.8713344Z ................................................................................................i..i 6000/8860
2019-08-09T19:18:27.2150819Z i................................................................................................... 6100/8860
2019-08-09T19:18:43.8756319Z .................................................................................................... 6200/8860
---
2019-08-09T19:23:40.5129151Z  finished in 22.966
2019-08-09T19:23:40.5312693Z Check compiletest suite=codegen mode=codegen (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-08-09T19:23:40.7041098Z 
2019-08-09T19:23:40.7041950Z running 146 tests
2019-08-09T19:23:43.9777723Z i....iii......iii..iiii....i............................i..i................i....i.........ii.i.i..i 100/146
2019-08-09T19:23:45.8876357Z iii..............i.........iii.i......ii......
2019-08-09T19:23:45.8883655Z 
2019-08-09T19:23:45.8893759Z  finished in 5.358
2019-08-09T19:23:45.9079013Z Check compiletest suite=codegen-units mode=codegen-units (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-08-09T19:23:46.0655310Z 
---
2019-08-09T19:23:48.1659149Z  finished in 2.258
2019-08-09T19:23:48.1854099Z Check compiletest suite=assembly mode=assembly (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-08-09T19:23:48.3498652Z 
2019-08-09T19:23:48.3498944Z running 9 tests
2019-08-09T19:23:48.3500283Z iiiiiiiii
2019-08-09T19:23:48.3502324Z 
2019-08-09T19:23:48.3503579Z  finished in 0.165
2019-08-09T19:23:48.3682151Z Check compiletest suite=incremental mode=incremental (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-08-09T19:23:48.5355745Z 
---
2019-08-09T19:24:06.8729527Z  finished in 18.504
2019-08-09T19:24:06.8942298Z Check compiletest suite=debuginfo mode=debuginfo-gdb+lldb (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-08-09T19:24:07.0542788Z 
2019-08-09T19:24:07.0543033Z running 122 tests
2019-08-09T19:24:32.0293613Z .iiiii...i.....i..i...i..i.i.i..i.ii..i.i.....i..i....i..........iiii..........i...ii...i.......ii.i 100/122
2019-08-09T19:24:36.8453539Z .i.i......iii.i.....ii
2019-08-09T19:24:36.8454093Z 
2019-08-09T19:24:36.8461000Z  finished in 29.952
2019-08-09T19:24:36.8469667Z Uplifting stage1 rustc (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-08-09T19:24:36.8470037Z Copying stage2 rustc from stage1 (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu / x86_64-unknown-linux-gnu)
---
2019-08-09T19:38:55.3725701Z 
2019-08-09T19:38:55.3729196Z    Doc-tests core
2019-08-09T19:38:59.5731994Z 
2019-08-09T19:38:59.5733318Z running 2379 tests
2019-08-09T19:39:12.3977620Z ......iiiii......................................................................................... 100/2379
2019-08-09T19:39:25.2870333Z .........................................................................ii......................... 200/2379
2019-08-09T19:39:55.7364168Z .................................................................................................... 400/2379
2019-08-09T19:39:55.7364168Z .................................................................................................... 400/2379
2019-08-09T19:40:07.2612099Z ..............................i..i.................iiii............................................. 500/2379
2019-08-09T19:40:31.2159400Z .................................................................................................... 700/2379
2019-08-09T19:40:43.4978776Z .................................................................................................... 800/2379
2019-08-09T19:40:55.6984271Z .................................................................................................... 900/2379
2019-08-09T19:41:07.7789747Z .................................................................................................... 1000/2379
---
2019-08-09T19:43:56.5170809Z ........................................................................................i........... 2300/2379
2019-08-09T19:44:06.8857948Z ...............................................................................
2019-08-09T19:44:06.8859411Z failures:
2019-08-09T19:44:06.8861411Z 
2019-08-09T19:44:06.8862411Z ---- hash/mod.rs - hash::BuildHasherDefault (line 467) stdout ----
2019-08-09T19:44:06.8862650Z error: the item `HashMap` is imported redundantly
2019-08-09T19:44:06.8863095Z  --> hash/mod.rs:468:5
2019-08-09T19:44:06.8863460Z 4 | use std::collections::HashMap;
2019-08-09T19:44:06.8863647Z   |     ^^^^^^^^^^^^^^^^^^^^^^^^^
2019-08-09T19:44:06.8863801Z   |
2019-08-09T19:44:06.8863952Z note: lint level defined here
---
2019-08-09T19:44:06.8865851Z 
2019-08-09T19:44:06.8866029Z error: aborting due to previous error
2019-08-09T19:44:06.8866166Z 
2019-08-09T19:44:06.8866552Z Couldn't compile the test.
2019-08-09T19:44:06.8867062Z ---- option.rs - option::Option<T>::expect_none (line 1004) stdout ----
2019-08-09T19:44:06.8867289Z error: the item `HashMap` is imported redundantly
2019-08-09T19:44:06.8867664Z  --> option.rs:1007:5
2019-08-09T19:44:06.8868042Z 6 | use std::collections::HashMap;
2019-08-09T19:44:06.8868199Z   |     ^^^^^^^^^^^^^^^^^^^^^^^^^
2019-08-09T19:44:06.8868373Z   |
2019-08-09T19:44:06.8868527Z note: lint level defined here
---
2019-08-09T19:44:06.8869740Z 
2019-08-09T19:44:06.8869899Z error: aborting due to previous error
2019-08-09T19:44:06.8870052Z 
2019-08-09T19:44:06.8870421Z Couldn't compile the test.
2019-08-09T19:44:06.8870897Z ---- option.rs - option::Option<T>::expect_none (line 993) stdout ----
2019-08-09T19:44:06.8871152Z error: the item `HashMap` is imported redundantly
2019-08-09T19:44:06.8871531Z  --> option.rs:996:5
2019-08-09T19:44:06.8871904Z 6 | use std::collections::HashMap;
2019-08-09T19:44:06.8872409Z   |     ^^^^^^^^^^^^^^^^^^^^^^^^^
2019-08-09T19:44:06.8872608Z   |
2019-08-09T19:44:06.8872763Z note: lint level defined here
---
2019-08-09T19:44:06.8874560Z 
2019-08-09T19:44:06.8874759Z error: aborting due to previous error
2019-08-09T19:44:06.8874895Z 
2019-08-09T19:44:06.8875359Z Couldn't compile the test.
2019-08-09T19:44:06.8875830Z ---- option.rs - option::Option<T>::unwrap_none (line 1035) stdout ----
2019-08-09T19:44:06.8876036Z error: the item `HashMap` is imported redundantly
2019-08-09T19:44:06.8876649Z  --> option.rs:1038:5
2019-08-09T19:44:06.8877094Z 6 | use std::collections::HashMap;
2019-08-09T19:44:06.8877255Z   |     ^^^^^^^^^^^^^^^^^^^^^^^^^
2019-08-09T19:44:06.8877405Z   |
2019-08-09T19:44:06.8877582Z note: lint level defined here
---
2019-08-09T19:44:06.8878904Z 
2019-08-09T19:44:06.8879064Z error: aborting due to previous error
2019-08-09T19:44:06.8879199Z 
2019-08-09T19:44:06.8956048Z Couldn't compile the test.
2019-08-09T19:44:06.8956383Z ---- option.rs - option::Option<T>::unwrap_none (line 1046) stdout ----
2019-08-09T19:44:06.8956449Z error: the item `HashMap` is imported redundantly
2019-08-09T19:44:06.8956710Z  --> option.rs:1049:5
2019-08-09T19:44:06.8957000Z 6 | use std::collections::HashMap;
2019-08-09T19:44:06.8957072Z   |     ^^^^^^^^^^^^^^^^^^^^^^^^^
2019-08-09T19:44:06.8957117Z   |
2019-08-09T19:44:06.8957163Z note: lint level defined here
---
2019-08-09T19:44:06.8963409Z 
2019-08-09T19:44:06.9159935Z error: test failed, to rerun pass '--doc'
2019-08-09T19:44:06.9172226Z 
2019-08-09T19:44:06.9172317Z 
2019-08-09T19:44:06.9173143Z command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "test" "--target" "x86_64-unknown-linux-gnu" "-j" "2" "--release" "--locked" "--color" "always" "--features" "panic-unwind backtrace compiler-builtins-c" "--manifest-path" "/checkout/src/libstd/Cargo.toml" "-p" "core" "--" "--quiet"
2019-08-09T19:44:06.9173285Z 
2019-08-09T19:44:06.9173318Z 
2019-08-09T19:44:06.9177953Z failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
2019-08-09T19:44:06.9178042Z Build completed unsuccessfully in 1:27:09
2019-08-09T19:44:06.9178042Z Build completed unsuccessfully in 1:27:09
2019-08-09T19:44:07.4525603Z ##[error]Bash exited with code '1'.
2019-08-09T19:44:07.4570954Z ##[section]Starting: Checkout
2019-08-09T19:44:07.4572809Z ==============================================================================
2019-08-09T19:44:07.4572887Z Task         : Get sources
2019-08-09T19:44:07.4572939Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

Show resolved Hide resolved src/test/ui/derived-errors/issue-31997-1.stderr Outdated
Show resolved Hide resolved src/test/ui/error-codes/E0433.stderr Outdated
Show resolved Hide resolved src/test/ui/resolve/use_suggestion_placement.stderr Outdated

@lzutao lzutao force-pushed the lzutao:hashmap-prelude branch 2 times, most recently from f1cb215 to b46f828 Aug 10, 2019

@rust-highfive

This comment was marked as resolved.

Copy link
Collaborator

commented Aug 10, 2019

The job x86_64-gnu-llvm-6.0 of your PR failed (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
2019-08-10T05:03:00.9320035Z ##[command]git remote add origin https://github.com/rust-lang/rust
2019-08-10T05:03:00.9505469Z ##[command]git config gc.auto 0
2019-08-10T05:03:00.9581416Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2019-08-10T05:03:00.9634564Z ##[command]git config --get-all http.proxy
2019-08-10T05:03:00.9761993Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/63418/merge:refs/remotes/pull/63418/merge
---
2019-08-10T05:03:12.3805754Z do so (now or later) by using -b with the checkout command again. Example:
2019-08-10T05:03:12.3805783Z 
2019-08-10T05:03:12.3805975Z   git checkout -b <new-branch-name>
2019-08-10T05:03:12.3806003Z 
2019-08-10T05:03:12.3806253Z HEAD is now at 2a458af39 Merge b46f8288554f2e8b68f5a3b57fd18b8e8f4986e0 into be8bbb06976c8065425b18e9cbe24a6d1d4e7515
2019-08-10T05:03:12.3960569Z ##[section]Starting: Collect CPU-usage statistics in the background
2019-08-10T05:03:12.3963478Z ==============================================================================
2019-08-10T05:03:12.3963557Z Task         : Bash
2019-08-10T05:03:12.3963596Z Description  : Run a Bash script on macOS, Linux, or Windows
---
2019-08-10T06:04:29.9677373Z .................................................................................................... 1300/8860
2019-08-10T06:04:36.6755250Z .................................................................................................... 1400/8860
2019-08-10T06:04:43.2878561Z .................................................................................................... 1500/8860
2019-08-10T06:04:54.6829590Z ....................................................................................i............... 1600/8860
2019-08-10T06:05:02.8525381Z i................................................................................................... 1700/8860
2019-08-10T06:05:10.0906950Z ...........................................................................iiiii.................... 1800/8860
2019-08-10T06:05:33.5692294Z .................................................................................................... 2000/8860
2019-08-10T06:05:36.1720949Z .................................................................................................... 2100/8860
2019-08-10T06:05:39.1279077Z .................................................................................................... 2200/8860
2019-08-10T06:05:47.4054937Z .................................................................................................... 2300/8860
---
2019-08-10T06:09:43.0639616Z .................................................................................................... 5200/8860
2019-08-10T06:09:54.1602894Z .................................................................................................... 5300/8860
2019-08-10T06:10:01.9108987Z .i.................................................................................................. 5400/8860
2019-08-10T06:10:07.3731634Z .................................................................................................... 5500/8860
2019-08-10T06:10:20.3150600Z ...............................................................................................ii... 5600/8860
2019-08-10T06:10:36.7213109Z i..ii...........i................................................................................... 5700/8860
2019-08-10T06:10:51.6863342Z .................................................................................................... 5900/8860
2019-08-10T06:10:56.6706339Z ................................................................................................i..i 6000/8860
2019-08-10T06:11:11.7289256Z i................................................................................................... 6100/8860
2019-08-10T06:11:28.8515912Z .................................................................................................... 6200/8860
---
2019-08-10T06:16:30.2276147Z  finished in 21.110
2019-08-10T06:16:30.2486760Z Check compiletest suite=codegen mode=codegen (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-08-10T06:16:30.4163109Z 
2019-08-10T06:16:30.4164489Z running 146 tests
2019-08-10T06:16:33.9809492Z i....iii......iii..iiii....i............................i..i................i....i.........ii.i.i..i 100/146
2019-08-10T06:16:35.8924373Z iii..............i.........iii.i......ii......
2019-08-10T06:16:35.8924970Z 
2019-08-10T06:16:35.8928923Z  finished in 5.644
2019-08-10T06:16:35.9117309Z Check compiletest suite=codegen-units mode=codegen-units (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-08-10T06:16:36.0761495Z 
---
2019-08-10T06:16:38.2039265Z  finished in 2.291
2019-08-10T06:16:38.2254288Z Check compiletest suite=assembly mode=assembly (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-08-10T06:16:38.3900602Z 
2019-08-10T06:16:38.3901170Z running 9 tests
2019-08-10T06:16:38.3902539Z iiiiiiiii
2019-08-10T06:16:38.3903022Z 
2019-08-10T06:16:38.3906182Z  finished in 0.165
2019-08-10T06:16:38.4089421Z Check compiletest suite=incremental mode=incremental (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-08-10T06:16:38.5915540Z 
---
2019-08-10T06:16:57.4292714Z  finished in 19.019
2019-08-10T06:16:57.4482533Z Check compiletest suite=debuginfo mode=debuginfo-gdb+lldb (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-08-10T06:16:57.6152809Z 
2019-08-10T06:16:57.6153894Z running 122 tests
2019-08-10T06:17:21.9487268Z .iiiii...i.....i..i...i..i.i.i..i.ii..i.i.....i..i....i..........iiii..........i...ii...i.......ii.i 100/122
2019-08-10T06:17:26.6897961Z .i.i......iii.i.....ii
2019-08-10T06:17:26.6898854Z 
2019-08-10T06:17:26.6898899Z  finished in 29.241
2019-08-10T06:17:26.6905137Z Uplifting stage1 rustc (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-08-10T06:17:26.6905538Z Copying stage2 rustc from stage1 (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu / x86_64-unknown-linux-gnu)
---
2019-08-10T06:32:12.3861866Z 
2019-08-10T06:32:12.3870107Z    Doc-tests core
2019-08-10T06:32:16.6425758Z 
2019-08-10T06:32:16.6426575Z running 2379 tests
2019-08-10T06:32:29.2820646Z ......iiiii......................................................................................... 100/2379
2019-08-10T06:32:41.7660788Z .........................................................................ii......................... 200/2379
2019-08-10T06:33:14.6470867Z .................................................................................................... 400/2379
2019-08-10T06:33:14.6470867Z .................................................................................................... 400/2379
2019-08-10T06:33:26.4629779Z ..............................i..i.................iiii............................................. 500/2379
2019-08-10T06:33:51.6874747Z .................................................................................................... 700/2379
2019-08-10T06:34:04.0264503Z .................................................................................................... 800/2379
2019-08-10T06:34:16.7355710Z .................................................................................................... 900/2379
2019-08-10T06:34:29.5787737Z .................................................................................................... 1000/2379
---
2019-08-10T06:39:58.0245600Z .......thread '<unnamed>' panicked at 'called `Result::unwrap()` on an `Err` value: RecvError', src/libcore/result.rs:1084:5
2019-08-10T06:39:58.0443296Z ................. 600/762
2019-08-10T06:40:00.0731526Z .......................thread '<unnamed>' panicked at 'explicit panic', src/libstd/sync/mutex.rs:629:13
2019-08-10T06:40:00.0733759Z thread '<unnamed>' panicked at 'test panic in inner thread to poison mutex', src/libstd/sync/mutex.rs:584:13
2019-08-10T06:40:00.0737797Z thread '...<unnamed>' panicked at 'test panic in inner thread to poison mutex', src/libstd/sync/mutex.rs:561:13
2019-08-10T06:40:00.0742882Z .thread '<unnamed>' panicked at 'explicit panic', src/libstd/sync/mutex.rs:689:13
2019-08-10T06:40:00.0750858Z ...thread '<unnamed>' panicked at 'assertion failed: `(left == right)`
2019-08-10T06:40:00.0752015Z  right: `2`', src/libstd/sync/mutex.rs:653:13
2019-08-10T06:40:00.0790570Z ..........thread '<unnamed>' panicked at 'test panic in inner thread to poison RwLock', src/libstd/sync/rwlock.rs:791:13
2019-08-10T06:40:00.0799255Z ...thread '<unnamed>' panicked at 'test panic in inner thread to poison RwLock', src/libstd/sync/rwlock.rs:768:13
2019-08-10T06:40:00.0812401Z ..thread '<unnamed>' panicked at 'explicit panic', src/libstd/sync/rwlock.rs:705:13
2019-08-10T06:40:00.0812401Z ..thread '<unnamed>' panicked at 'explicit panic', src/libstd/sync/rwlock.rs:705:13
2019-08-10T06:40:00.0817685Z thread '<unnamed>.' panicked at 'explicit panic', src/libstd/sync/rwlock.rs:635:13
2019-08-10T06:40:00.0822335Z .thread '<unnamed>' panicked at 'explicit panic', src/libstd/sync/rwlock.rs:646:13
2019-08-10T06:40:00.0828200Z .thread '<unnamed>' panicked at 'explicit panic', src/libstd/sync/rwlock.rs:611:13
2019-08-10T06:40:00.0832607Z thread '.<unnamed>' panicked at 'explicit panic', src/libstd/sync/rwlock.rs:623:13
2019-08-10T06:40:02.1472995Z ...........................thread '<unnamed>' panicked at 'What the answer to my lifetimes dilemma is?', src/libstd/sys_common/remutex.rs:233:13
2019-08-10T06:40:02.1572768Z ..................................thread '<unnamed>' panicked at 'explicit panic', src/libstd/thread/mod.rs:1535:13
2019-08-10T06:40:02.7662874Z ............thread '<unnamed>' panicked at 'Box<Any>', src/libstd/thread/mod.rs:1667:13
2019-08-10T06:40:02.7666919Z ..thread '<unnamed>' panicked at 'owned string', src/libstd/thread/mod.rs:1653:13
2019-08-10T06:40:02.7671973Z thread '<unnamed>' panicked at 'static string', src/libstd/thread/mod.rs:1639:13
---
2019-08-10T06:40:08.2706012Z 
2019-08-10T06:40:08.2709686Z    Doc-tests std
2019-08-10T06:40:09.4700402Z 
2019-08-10T06:40:09.4708060Z running 991 tests
2019-08-10T06:40:22.3963958Z i...F.FFFFFFFFFFFF.FFFFFFFFFFFFFFFFFFFF.FFFFFFFFFFFFFFFF.FFF........................................ 100/991
2019-08-10T06:40:35.5494079Z .................................................................................................... 200/991
2019-08-10T06:40:44.3277814Z .................iii......i......i...i......i....................................................... 300/991
2019-08-10T06:40:49.3226208Z .................................................................................................... 400/991
2019-08-10T06:40:57.3577322Z ..................................i..i.................................ii........................... 500/991
2019-08-10T06:41:12.0675617Z .................................................................................................... 700/991
2019-08-10T06:41:12.0675617Z .................................................................................................... 700/991
2019-08-10T06:41:20.2680927Z .................iiii..........................................F.................................... 800/991
2019-08-10T06:41:35.2657636Z .................................................................................................... 900/991
2019-08-10T06:41:42.9181633Z .......................................iiii................................................
2019-08-10T06:41:42.9185228Z 
2019-08-10T06:41:42.9186520Z ---- collections/hash/map.rs - collections::hash::map::Entry::and_modify (line 2010) stdout ----
2019-08-10T06:41:42.9186520Z ---- collections/hash/map.rs - collections::hash::map::Entry::and_modify (line 2010) stdout ----
2019-08-10T06:41:42.9186834Z error: the item `HashMap` is imported redundantly
2019-08-10T06:41:42.9187763Z  --> collections/hash/map.rs:2011:5
2019-08-10T06:41:42.9188157Z 4 | use std::collections::HashMap;
2019-08-10T06:41:42.9188283Z   |     ^^^^^^^^^^^^^^^^^^^^^^^^^
2019-08-10T06:41:42.9188396Z   |
2019-08-10T06:41:42.9188531Z note: lint level defined here
---
2019-08-10T06:41:42.9189716Z error: aborting due to previous error
2019-08-10T06:41:42.9189816Z 
2019-08-10T06:41:42.9190129Z Couldn't compile the test.
2019-08-10T06:41:42.9190795Z ---- collections/hash/map.rs - collections::hash::map::Entry::key (line 1990) stdout ----
2019-08-10T06:41:42.9190961Z error: the item `HashMap` is imported redundantly
2019-08-10T06:41:42.9191279Z  --> collections/hash/map.rs:1991:5
2019-08-10T06:41:42.9191545Z 4 | use std::collections::HashMap;
2019-08-10T06:41:42.9191680Z   |     ^^^^^^^^^^^^^^^^^^^^^^^^^
2019-08-10T06:41:42.9192427Z   |
2019-08-10T06:41:42.9192569Z note: lint level defined here
---
2019-08-10T06:41:42.9193898Z error: aborting due to previous error
2019-08-10T06:41:42.9194018Z 
2019-08-10T06:41:42.9194353Z Couldn't compile the test.
2019-08-10T06:41:42.9194805Z ---- collections/hash/map.rs - collections::hash::map::Entry::or_default (line 2048) stdout ----
2019-08-10T06:41:42.9195003Z error: the item `HashMap` is imported redundantly
2019-08-10T06:41:42.9195497Z  --> collections/hash/map.rs:2050:5
2019-08-10T06:41:42.9195782Z 4 | use std::collections::HashMap;
2019-08-10T06:41:42.9195898Z   |     ^^^^^^^^^^^^^^^^^^^^^^^^^
2019-08-10T06:41:42.9196028Z   |
2019-08-10T06:41:42.9196143Z note: lint level defined here
---
2019-08-10T06:41:42.9197411Z error: aborting due to previous error
2019-08-10T06:41:42.9197670Z 
2019-08-10T06:41:42.9197975Z Couldn't compile the test.
2019-08-10T06:41:42.9198330Z ---- collections/hash/map.rs - collections::hash::map::Entry::or_insert (line 1943) stdout ----
2019-08-10T06:41:42.9198512Z error: the item `HashMap` is imported redundantly
2019-08-10T06:41:42.9198797Z  --> collections/hash/map.rs:1944:5
2019-08-10T06:41:42.9199092Z 4 | use std::collections::HashMap;
2019-08-10T06:41:42.9199207Z   |     ^^^^^^^^^^^^^^^^^^^^^^^^^
2019-08-10T06:41:42.9199334Z   |
2019-08-10T06:41:42.9199446Z note: lint level defined here
---
2019-08-10T06:41:42.9200470Z error: aborting due to previous error
2019-08-10T06:41:42.9200565Z 
2019-08-10T06:41:42.9200857Z Couldn't compile the test.
2019-08-10T06:41:42.9201217Z ---- collections/hash/map.rs - collections::hash::map::Entry::or_insert_with (line 1968) stdout ----
2019-08-10T06:41:42.9201399Z error: the item `HashMap` is imported redundantly
2019-08-10T06:41:42.9201728Z  --> collections/hash/map.rs:1969:5
2019-08-10T06:41:42.9202284Z 4 | use std::collections::HashMap;
2019-08-10T06:41:42.9202423Z   |     ^^^^^^^^^^^^^^^^^^^^^^^^^
2019-08-10T06:41:42.9202557Z   |
2019-08-10T06:41:42.9202711Z note: lint level defined here
---
2019-08-10T06:41:42.9203967Z error: aborting due to previous error
2019-08-10T06:41:42.9204085Z 
2019-08-10T06:41:42.9204432Z Couldn't compile the test.
2019-08-10T06:41:42.9204850Z ---- collections/hash/map.rs - collections::hash::map::HashMap (line 123) stdout ----
2019-08-10T06:41:42.9205185Z error: the item `HashMap` is imported redundantly
2019-08-10T06:41:42.9205721Z  --> collections/hash/map.rs:124:5
2019-08-10T06:41:42.9206187Z 4 | use std::collections::HashMap;
2019-08-10T06:41:42.9206329Z   |     ^^^^^^^^^^^^^^^^^^^^^^^^^
2019-08-10T06:41:42.9206449Z   |
2019-08-10T06:41:42.9206571Z note: lint level defined here
---
2019-08-10T06:41:42.9207875Z error: aborting due to previous error
2019-08-10T06:41:42.9208139Z 
2019-08-10T06:41:42.9208419Z Couldn't compile the test.
2019-08-10T06:41:42.9208788Z ---- collections/hash/map.rs - collections::hash::map::HashMap (line 161) stdout ----
2019-08-10T06:41:42.9209117Z error: the item `HashMap` is imported redundantly
2019-08-10T06:41:42.9209403Z  --> collections/hash/map.rs:162:5
2019-08-10T06:41:42.9209872Z 4 | use std::collections::HashMap;
2019-08-10T06:41:42.9210010Z   |     ^^^^^^^^^^^^^^^^^^^^^^^^^
2019-08-10T06:41:42.9210140Z   |
2019-08-10T06:41:42.9210332Z note: lint level defined here
---
2019-08-10T06:41:42.9211605Z error: aborting due to previous error
2019-08-10T06:41:42.9211863Z 
2019-08-10T06:41:42.9212442Z Couldn't compile the test.
2019-08-10T06:41:42.9212912Z ---- collections/hash/map.rs - collections::hash::map::HashMap (line 65) stdout ----
2019-08-10T06:41:42.9213121Z error: the item `HashMap` is imported redundantly
2019-08-10T06:41:42.9213486Z  --> collections/hash/map.rs:66:5
2019-08-10T06:41:42.9213828Z 4 | use std::collections::HashMap;
2019-08-10T06:41:42.9213987Z   |     ^^^^^^^^^^^^^^^^^^^^^^^^^
2019-08-10T06:41:42.9214127Z   |
2019-08-10T06:41:42.9214266Z note: lint level defined here
---
2019-08-10T06:41:42.9215904Z error: aborting due to previous error
2019-08-10T06:41:42.9216212Z 
2019-08-10T06:41:42.9216514Z Couldn't compile the test.
2019-08-10T06:41:42.9217023Z ---- collections/hash/map.rs - collections::hash::map::HashMap<K, V, RandomState>::new (line 219) stdout ----
2019-08-10T06:41:42.9217231Z error: the item `HashMap` is imported redundantly
2019-08-10T06:41:42.9217558Z  --> collections/hash/map.rs:220:5
2019-08-10T06:41:42.9217875Z 4 | use std::collections::HashMap;
2019-08-10T06:41:42.9217999Z   |     ^^^^^^^^^^^^^^^^^^^^^^^^^
2019-08-10T06:41:42.9218138Z   |
2019-08-10T06:41:42.9218260Z note: lint level defined here
---
2019-08-10T06:41:42.9220038Z error: aborting due to previous error
2019-08-10T06:41:42.9220146Z 
2019-08-10T06:41:42.9220452Z Couldn't compile the test.
2019-08-10T06:41:42.9220845Z ---- collections/hash/map.rs - collections::hash::map::HashMap<K, V, RandomState>::with_capacity (line 236) stdout ----
2019-08-10T06:41:42.9221006Z error: the item `HashMap` is imported redundantly
2019-08-10T06:41:42.9221774Z  --> collections/hash/map.rs:237:5
2019-08-10T06:41:42.9222228Z 4 | use std::collections::HashMap;
2019-08-10T06:41:42.9222369Z   |     ^^^^^^^^^^^^^^^^^^^^^^^^^
2019-08-10T06:41:42.9222502Z   |
2019-08-10T06:41:42.9222659Z note: lint level defined here
---
2019-08-10T06:41:42.9223919Z error: aborting due to previous error
2019-08-10T06:41:42.9224052Z 
2019-08-10T06:41:42.9224391Z Couldn't compile the test.
2019-08-10T06:41:42.9224868Z ---- collections/hash/map.rs - collections::hash::map::HashMap<K, V, S>::capacity (line 255) stdout ----
2019-08-10T06:41:42.9225062Z error: the item `HashMap` is imported redundantly
2019-08-10T06:41:42.9225845Z  --> collections/hash/map.rs:256:5
2019-08-10T06:41:42.9226153Z 4 | use std::collections::HashMap;
2019-08-10T06:41:42.9226277Z   |     ^^^^^^^^^^^^^^^^^^^^^^^^^
2019-08-10T06:41:42.9226560Z   |
2019-08-10T06:41:42.9226689Z note: lint level defined here
---
2019-08-10T06:41:42.9227949Z error: aborting due to previous error
2019-08-10T06:41:42.9228048Z 
2019-08-10T06:41:42.9228421Z Couldn't compile the test.
2019-08-10T06:41:42.9228854Z ---- collections/hash/map.rs - collections::hash::map::HashMap<K, V, S>::clear (line 452) stdout ----
2019-08-10T06:41:42.9229035Z error: the item `HashMap` is imported redundantly
2019-08-10T06:41:42.9229352Z  --> collections/hash/map.rs:453:5
2019-08-10T06:41:42.9229633Z 4 | use std::collections::HashMap;
2019-08-10T06:41:42.9229774Z   |     ^^^^^^^^^^^^^^^^^^^^^^^^^
2019-08-10T06:41:42.9229889Z   |
2019-08-10T06:41:42.9230004Z note: lint level defined here
---
2019-08-10T06:41:42.9231083Z error: aborting due to previous error
2019-08-10T06:41:42.9231183Z 
2019-08-10T06:41:42.9231562Z Couldn't compile the test.
2019-08-10T06:41:42.9232269Z ---- collections/hash/map.rs - collections::hash::map::HashMap<K, V, S>::contains_key (line 746) stdout ----
2019-08-10T06:41:42.9232461Z error: the item `HashMap` is imported redundantly
2019-08-10T06:41:42.9232852Z  --> collections/hash/map.rs:747:5
2019-08-10T06:41:42.9233184Z 4 | use std::collections::HashMap;
2019-08-10T06:41:42.9233349Z   |     ^^^^^^^^^^^^^^^^^^^^^^^^^
2019-08-10T06:41:42.9233507Z   |
2019-08-10T06:41:42.9233648Z note: lint level defined here
---
2019-08-10T06:41:42.9234937Z error: aborting due to previous error
2019-08-10T06:41:42.9235058Z 
2019-08-10T06:41:42.9235566Z Couldn't compile the test.
2019-08-10T06:41:42.9236003Z ---- collections/hash/map.rs - collections::hash::map::HashMap<K, V, S>::drain (line 427) stdout ----
2019-08-10T06:41:42.9236383Z error: the item `HashMap` is imported redundantly
2019-08-10T06:41:42.9236732Z  --> collections/hash/map.rs:428:5
2019-08-10T06:41:42.9237190Z 4 | use std::collections::HashMap;
2019-08-10T06:41:42.9237321Z   |     ^^^^^^^^^^^^^^^^^^^^^^^^^
2019-08-10T06:41:42.9237454Z   |
2019-08-10T06:41:42.9237605Z note: lint level defined here
---
2019-08-10T06:41:42.9239091Z error: aborting due to previous error
2019-08-10T06:41:42.9239200Z 
2019-08-10T06:41:42.9239514Z Couldn't compile the test.
2019-08-10T06:41:42.9243135Z ---- collections/hash/map.rs - collections::hash::map::HashMap<K, V, S>::entry (line 655) stdout ----
2019-08-10T06:41:42.9243945Z error: the item `HashMap` is imported redundantly
2019-08-10T06:41:42.9245358Z  --> collections/hash/map.rs:656:5
2019-08-10T06:41:42.9247122Z 4 | use std::collections::HashMap;
2019-08-10T06:41:42.9247409Z   |     ^^^^^^^^^^^^^^^^^^^^^^^^^
2019-08-10T06:41:42.9248786Z   |
2019-08-10T06:41:42.9248832Z note: lint level defined here
---
2019-08-10T06:41:42.9271413Z error: aborting due to previous error
2019-08-10T06:41:42.9271511Z 
2019-08-10T06:41:42.9273353Z Couldn't compile the test.
2019-08-10T06:41:42.9276006Z ---- collections/hash/map.rs - collections::hash::map::HashMap<K, V, S>::get (line 687) stdout ----
2019-08-10T06:41:42.9276436Z error: the item `HashMap` is imported redundantly
2019-08-10T06:41:42.9276837Z  --> collections/hash/map.rs:688:5
2019-08-10T06:41:42.9277421Z 4 | use std::collections::HashMap;
2019-08-10T06:41:42.9277542Z   |     ^^^^^^^^^^^^^^^^^^^^^^^^^
2019-08-10T06:41:42.9277680Z   |
2019-08-10T06:41:42.9277799Z note: lint level defined here
---
2019-08-10T06:41:42.9278903Z error: aborting due to previous error
2019-08-10T06:41:42.9279003Z 
2019-08-10T06:41:42.9279275Z Couldn't compile the test.
2019-08-10T06:41:42.9279936Z ---- collections/hash/map.rs - collections::hash::map::HashMap<K, V, S>::get_key_value (line 716) stdout ----
2019-08-10T06:41:42.9280107Z error: the item `HashMap` is imported redundantly
2019-08-10T06:41:42.9280410Z  --> collections/hash/map.rs:718:5
2019-08-10T06:41:42.9280701Z 5 | use std::collections::HashMap;
2019-08-10T06:41:42.9280815Z   |     ^^^^^^^^^^^^^^^^^^^^^^^^^
2019-08-10T06:41:42.9280923Z   |
2019-08-10T06:41:42.9281057Z note: lint level defined here
---
2019-08-10T06:41:42.9282850Z error: aborting due to previous error
2019-08-10T06:41:42.9282969Z 
2019-08-10T06:41:42.9283351Z Couldn't compile the test.
2019-08-10T06:41:42.9283842Z ---- collections/hash/map.rs - collections::hash::map::HashMap<K, V, S>::get_mut (line 775) stdout ----
2019-08-10T06:41:42.9284031Z error: the item `HashMap` is imported redundantly
2019-08-10T06:41:42.9284370Z  --> collections/hash/map.rs:776:5
2019-08-10T06:41:42.9287426Z 4 | use std::collections::HashMap;
2019-08-10T06:41:42.9287817Z   |     ^^^^^^^^^^^^^^^^^^^^^^^^^
2019-08-10T06:41:42.9288302Z   |
2019-08-10T06:41:42.9288470Z note: lint level defined here
---
2019-08-10T06:41:42.9312498Z error: aborting due to previous error
2019-08-10T06:41:42.9312528Z 
2019-08-10T06:41:42.9313562Z Couldn't compile the test.
2019-08-10T06:41:42.9314074Z ---- collections/hash/map.rs - collections::hash::map::HashMap<K, V, S>::hasher (line 535) stdout ----
2019-08-10T06:41:42.9314142Z error: the item `HashMap` is imported redundantly
2019-08-10T06:41:42.9314386Z  --> collections/hash/map.rs:536:5
2019-08-10T06:41:42.9314476Z 4 | use std::collections::HashMap;
2019-08-10T06:41:42.9314531Z   |     ^^^^^^^^^^^^^^^^^^^^^^^^^
2019-08-10T06:41:42.9314591Z   |
2019-08-10T06:41:42.9314634Z note: lint level defined here
---
2019-08-10T06:41:42.9315135Z error: aborting due to previous error
2019-08-10T06:41:42.9315165Z 
2019-08-10T06:41:42.9315376Z Couldn't compile the test.
2019-08-10T06:41:42.9316530Z ---- collections/hash/map.rs - collections::hash::map::HashMap<K, V, S>::into_iter (line 1715) stdout ----
2019-08-10T06:41:42.9316604Z error: the item `HashMap` is imported redundantly
2019-08-10T06:41:42.9316863Z  --> collections/hash/map.rs:1716:5
2019-08-10T06:41:42.9316949Z 4 | use std::collections::HashMap;
2019-08-10T06:41:42.9317001Z   |     ^^^^^^^^^^^^^^^^^^^^^^^^^
2019-08-10T06:41:42.9317058Z   |
2019-08-10T06:41:42.9317099Z note: lint level defined here
---
2019-08-10T06:41:42.9317582Z error: aborting due to previous error
2019-08-10T06:41:42.9317609Z 
2019-08-10T06:41:42.9317796Z Couldn't compile the test.
2019-08-10T06:41:42.9318081Z ---- collections/hash/map.rs - collections::hash::map::HashMap<K, V, S>::insert (line 809) stdout ----
2019-08-10T06:41:42.9318135Z error: the item `HashMap` is imported redundantly
2019-08-10T06:41:42.9318335Z  --> collections/hash/map.rs:810:5
2019-08-10T06:41:42.9318433Z 4 | use std::collections::HashMap;
2019-08-10T06:41:42.9318477Z   |     ^^^^^^^^^^^^^^^^^^^^^^^^^
2019-08-10T06:41:42.9318539Z   |
2019-08-10T06:41:42.9318738Z note: lint level defined here
---
2019-08-10T06:41:42.9319200Z error: aborting due to previous error
2019-08-10T06:41:42.9319227Z 
2019-08-10T06:41:42.9319409Z Couldn't compile the test.
2019-08-10T06:41:42.9319684Z ---- collections/hash/map.rs - collections::hash::map::HashMap<K, V, S>::is_empty (line 408) stdout ----
2019-08-10T06:41:42.9319737Z error: the item `HashMap` is imported redundantly
2019-08-10T06:41:42.9319931Z  --> collections/hash/map.rs:409:5
2019-08-10T06:41:42.9320027Z 4 | use std::collections::HashMap;
2019-08-10T06:41:42.9320067Z   |     ^^^^^^^^^^^^^^^^^^^^^^^^^
2019-08-10T06:41:42.9320192Z   |
2019-08-10T06:41:42.9320249Z note: lint level defined here
---
2019-08-10T06:41:42.9320727Z error: aborting due to previous error
2019-08-10T06:41:42.9320754Z 
2019-08-10T06:41:42.9321112Z Couldn't compile the test.
2019-08-10T06:41:42.9321386Z ---- collections/hash/map.rs - collections::hash::map::HashMap<K, V, S>::iter (line 342) stdout ----
2019-08-10T06:41:42.9321450Z error: the item `HashMap` is imported redundantly
2019-08-10T06:41:42.9324636Z  --> collections/hash/map.rs:343:5
2019-08-10T06:41:42.9324769Z 4 | use std::collections::HashMap;
2019-08-10T06:41:42.9324815Z   |     ^^^^^^^^^^^^^^^^^^^^^^^^^
2019-08-10T06:41:42.9324874Z   |
2019-08-10T06:41:42.9324937Z note: lint level defined here
---
2019-08-10T06:41:42.9326200Z error: aborting due to previous error
2019-08-10T06:41:42.9326229Z 
2019-08-10T06:41:42.9326499Z Couldn't compile the test.
2019-08-10T06:41:42.9326924Z ---- collections/hash/map.rs - collections::hash::map::HashMap<K, V, S>::keys (line 271) stdout ----
2019-08-10T06:41:42.9327148Z error: the item `HashMap` is imported redundantly
2019-08-10T06:41:42.9327398Z  --> collections/hash/map.rs:272:5
2019-08-10T06:41:42.9327499Z 4 | use std::collections::HashMap;
2019-08-10T06:41:42.9327542Z   |     ^^^^^^^^^^^^^^^^^^^^^^^^^
2019-08-10T06:41:42.9327592Z   |
2019-08-10T06:41:42.9327649Z note: lint level defined here
---
2019-08-10T06:41:42.9328132Z error: aborting due to previous error
2019-08-10T06:41:42.9328160Z 
2019-08-10T06:41:42.9328348Z Couldn't compile the test.
2019-08-10T06:41:42.9328766Z ---- collections/hash/map.rs - collections::hash::map::HashMap<K, V, S>::iter_mut (line 365) stdout ----
2019-08-10T06:41:42.9328840Z error: the item `HashMap` is imported redundantly
2019-08-10T06:41:42.9329032Z  --> collections/hash/map.rs:366:5
2019-08-10T06:41:42.9329131Z 4 | use std::collections::HashMap;
2019-08-10T06:41:42.9329172Z   |     ^^^^^^^^^^^^^^^^^^^^^^^^^
2019-08-10T06:41:42.9329210Z   |
2019-08-10T06:41:42.9329257Z note: lint level defined here
---
2019-08-10T06:41:42.9329719Z error: aborting due to previous error
2019-08-10T06:41:42.9329761Z 
2019-08-10T06:41:42.9329944Z Couldn't compile the test.
2019-08-10T06:41:42.9330193Z ---- collections/hash/map.rs - collections::hash::map::HashMap<K, V, S>::len (line 391) stdout ----
2019-08-10T06:41:42.9330269Z error: the item `HashMap` is imported redundantly
2019-08-10T06:41:42.9330464Z  --> collections/hash/map.rs:392:5
2019-08-10T06:41:42.9330543Z 4 | use std::collections::HashMap;
2019-08-10T06:41:42.9330602Z   |     ^^^^^^^^^^^^^^^^^^^^^^^^^
2019-08-10T06:41:42.9330640Z   |
2019-08-10T06:41:42.9330680Z note: lint level defined here
---
2019-08-10T06:41:42.9331433Z error: aborting due to previous error
2019-08-10T06:41:42.9331477Z 
2019-08-10T06:41:42.9331666Z Couldn't compile the test.
2019-08-10T06:41:42.9332381Z ---- collections/hash/map.rs - collections::hash::map::HashMap<K, V, S>::remove (line 838) stdout ----
2019-08-10T06:41:42.9332447Z error: the item `HashMap` is imported redundantly
2019-08-10T06:41:42.9332683Z  --> collections/hash/map.rs:839:5
2019-08-10T06:41:42.9335259Z 4 | use std::collections::HashMap;
2019-08-10T06:41:42.9335404Z   |     ^^^^^^^^^^^^^^^^^^^^^^^^^
2019-08-10T06:41:42.9335446Z   |
2019-08-10T06:41:42.9335488Z note: lint level defined here
---
2019-08-10T06:41:42.9336146Z error: aborting due to previous error
2019-08-10T06:41:42.9336336Z 
2019-08-10T06:41:42.9336546Z Couldn't compile the test.
2019-08-10T06:41:42.9336811Z ---- collections/hash/map.rs - collections::hash::map::HashMap<K, V, S>::reserve (line 561) stdout ----
2019-08-10T06:41:42.9336865Z error: the item `HashMap` is imported redundantly
2019-08-10T06:41:42.9337228Z  --> collections/hash/map.rs:562:5
2019-08-10T06:41:42.9337323Z 4 | use std::collections::HashMap;
2019-08-10T06:41:42.9337381Z   |     ^^^^^^^^^^^^^^^^^^^^^^^^^
2019-08-10T06:41:42.9337421Z   |
2019-08-10T06:41:42.9337461Z note: lint level defined here
---
2019-08-10T06:41:42.9338134Z error: aborting due to previous error
2019-08-10T06:41:42.9338161Z 
2019-08-10T06:41:42.9338533Z Couldn't compile the test.
2019-08-10T06:41:42.9338793Z ---- collections/hash/map.rs - collections::hash::map::HashMap<K, V, S>::retain (line 894) stdout ----
2019-08-10T06:41:42.9338846Z error: the item `HashMap` is imported redundantly
2019-08-10T06:41:42.9339387Z  --> collections/hash/map.rs:895:5
2019-08-10T06:41:42.9339811Z 4 | use std::collections::HashMap;
2019-08-10T06:41:42.9339869Z   |     ^^^^^^^^^^^^^^^^^^^^^^^^^
2019-08-10T06:41:42.9339909Z   |
2019-08-10T06:41:42.9339949Z note: lint level defined here
---
2019-08-10T06:41:42.9342700Z error: aborting due to previous error
2019-08-10T06:41:42.9342729Z 
2019-08-10T06:41:42.9343598Z Couldn't compile the test.
2019-08-10T06:41:42.9343895Z ---- collections/hash/map.rs - collections::hash::map::HashMap<K, V, S>::shrink_to (line 628) stdout ----
2019-08-10T06:41:42.9343954Z error: the item `HashMap` is imported redundantly
2019-08-10T06:41:42.9344177Z  --> collections/hash/map.rs:630:5
2019-08-10T06:41:42.9344277Z 5 | use std::collections::HashMap;
2019-08-10T06:41:42.9344322Z   |     ^^^^^^^^^^^^^^^^^^^^^^^^^
2019-08-10T06:41:42.9344378Z   |
2019-08-10T06:41:42.9344421Z note: lint level defined here
---
2019-08-10T06:41:42.9345078Z error: aborting due to previous error
2019-08-10T06:41:42.9345107Z 
2019-08-10T06:41:42.9345334Z Couldn't compile the test.
2019-08-10T06:41:42.9345632Z ---- collections/hash/map.rs - collections::hash::map::HashMap<K, V, S>::shrink_to_fit (line 603) stdout ----
2019-08-10T06:41:42.9345689Z error: the item `HashMap` is imported redundantly
2019-08-10T06:41:42.9345893Z  --> collections/hash/map.rs:604:5
2019-08-10T06:41:42.9346004Z 4 | use std::collections::HashMap;
2019-08-10T06:41:42.9346048Z   |     ^^^^^^^^^^^^^^^^^^^^^^^^^
2019-08-10T06:41:42.9346104Z   |
2019-08-10T06:41:42.9346146Z note: lint level defined here
---
2019-08-10T06:41:42.9346643Z error: aborting due to previous error
2019-08-10T06:41:42.9346671Z 
2019-08-10T06:41:42.9346866Z Couldn't compile the test.
2019-08-10T06:41:42.9347159Z ---- collections/hash/map.rs - collections::hash::map::HashMap<K, V, S>::try_reserve (line 583) stdout ----
2019-08-10T06:41:42.9347216Z error: the item `HashMap` is imported redundantly
2019-08-10T06:41:42.9350935Z  --> collections/hash/map.rs:585:5
2019-08-10T06:41:42.9351222Z 5 | use std::collections::HashMap;
2019-08-10T06:41:42.9351262Z   |     ^^^^^^^^^^^^^^^^^^^^^^^^^
2019-08-10T06:41:42.9351316Z   |
2019-08-10T06:41:42.9351355Z note: lint level defined here
---
2019-08-10T06:41:42.9353101Z error: aborting due to previous error
2019-08-10T06:41:42.9353131Z 
2019-08-10T06:41:42.9353365Z Couldn't compile the test.
2019-08-10T06:41:42.9353659Z ---- collections/hash/map.rs - collections::hash::map::HashMap<K, V, S>::values (line 293) stdout ----
2019-08-10T06:41:42.9353717Z error: the item `HashMap` is imported redundantly
2019-08-10T06:41:42.9353923Z  --> collections/hash/map.rs:294:5
2019-08-10T06:41:42.9354035Z 4 | use std::collections::HashMap;
2019-08-10T06:41:42.9354080Z   |     ^^^^^^^^^^^^^^^^^^^^^^^^^
2019-08-10T06:41:42.9354121Z   |
2019-08-10T06:41:42.9357710Z note: lint level defined here
---
2019-08-10T06:41:42.9358821Z error: aborting due to previous error
2019-08-10T06:41:42.9358848Z 
2019-08-10T06:41:42.9359035Z Couldn't compile the test.
2019-08-10T06:41:42.9359303Z ---- collections/hash/map.rs - collections::hash::map::HashMap<K, V, S>::with_capacity_and_hasher (line 513) stdout ----
2019-08-10T06:41:42.9359374Z error: the item `HashMap` is imported redundantly
2019-08-10T06:41:42.9359567Z  --> collections/hash/map.rs:514:5
2019-08-10T06:41:42.9359675Z 4 | use std::collections::HashMap;
2019-08-10T06:41:42.9359717Z   |     ^^^^^^^^^^^^^^^^^^^^^^^^^
2019-08-10T06:41:42.9359756Z   |
2019-08-10T06:41:42.9359950Z note: lint level defined here
---
2019-08-10T06:41:42.9360789Z error: aborting due to previous error
2019-08-10T06:41:42.9360817Z 
2019-08-10T06:41:42.9361039Z Couldn't compile the test.
2019-08-10T06:41:42.9361306Z ---- collections/hash/map.rs - collections::hash::map::HashMap<K, V, S>::values_mut (line 315) stdout ----
2019-08-10T06:41:42.9361375Z error: the item `HashMap` is imported redundantly
2019-08-10T06:41:42.9361573Z  --> collections/hash/map.rs:316:5
2019-08-10T06:41:42.9361707Z 4 | use std::collections::HashMap;
2019-08-10T06:41:42.9361750Z   |     ^^^^^^^^^^^^^^^^^^^^^^^^^
2019-08-10T06:41:42.9361790Z   |
2019-08-10T06:41:42.9361847Z note: lint level defined here
---
2019-08-10T06:41:42.9364156Z error: aborting due to previous error
2019-08-10T06:41:42.9364186Z 
2019-08-10T06:41:42.9364467Z Couldn't compile the test.
2019-08-10T06:41:42.9368376Z ---- collections/hash/map.rs - collections::hash::map::HashMap<K, V, S>::with_hasher (line 484) stdout ----
2019-08-10T06:41:42.9368479Z error: the item `HashMap` is imported redundantly
2019-08-10T06:41:42.9369020Z  --> collections/hash/map.rs:485:5
2019-08-10T06:41:42.9369339Z 4 | use std::collections::HashMap;
2019-08-10T06:41:42.9371058Z   |     ^^^^^^^^^^^^^^^^^^^^^^^^^
2019-08-10T06:41:42.9371119Z   |
2019-08-10T06:41:42.9371160Z note: lint level defined here
---
2019-08-10T06:41:42.9373037Z error: aborting due to previous error
2019-08-10T06:41:42.9373083Z 
2019-08-10T06:41:42.9373883Z Couldn't compile the test.
2019-08-10T06:41:42.9374376Z ---- collections/hash/map.rs - collections::hash::map::OccupiedEntry::get (line 2113) stdout ----
2019-08-10T06:41:42.9374456Z error: the item `HashMap` is imported redundantly
2019-08-10T06:41:42.9374698Z  --> collections/hash/map.rs:2114:5
2019-08-10T06:41:42.9374787Z 4 | use std::collections::HashMap;
2019-08-10T06:41:42.9374860Z   |     ^^^^^^^^^^^^^^^^^^^^^^^^^
2019-08-10T06:41:42.9374901Z   |
2019-08-10T06:41:42.9374943Z note: lint level defined here
---
2019-08-10T06:41:42.9375608Z error: aborting due to previous error
2019-08-10T06:41:42.9375636Z 
2019-08-10T06:41:42.9375844Z Couldn't compile the test.
2019-08-10T06:41:42.9376105Z ---- collections/hash/map.rs - collections::hash::map::OccupiedEntry::get_mut (line 2139) stdout ----
2019-08-10T06:41:42.9376316Z error: the item `HashMap` is imported redundantly
2019-08-10T06:41:42.9376526Z  --> collections/hash/map.rs:2140:5
2019-08-10T06:41:42.9376607Z 4 | use std::collections::HashMap;
2019-08-10T06:41:42.9376673Z   |     ^^^^^^^^^^^^^^^^^^^^^^^^^
2019-08-10T06:41:42.9376713Z   |
2019-08-10T06:41:42.9376752Z note: lint level defined here
---
2019-08-10T06:41:42.9380204Z error: aborting due to previous error
2019-08-10T06:41:42.9380231Z 
2019-08-10T06:41:42.9380550Z Couldn't compile the test.
2019-08-10T06:41:42.9380800Z ---- collections/hash/map.rs - collections::hash::map::OccupiedEntry::insert (line 2196) stdout ----
2019-08-10T06:41:42.9380852Z error: the item `HashMap` is imported redundantly
2019-08-10T06:41:42.9381056Z  --> collections/hash/map.rs:2197:5
2019-08-10T06:41:42.9381135Z 4 | use std::collections::HashMap;
2019-08-10T06:41:42.9381203Z   |     ^^^^^^^^^^^^^^^^^^^^^^^^^
2019-08-10T06:41:42.9381241Z   |
2019-08-10T06:41:42.9381440Z note: lint level defined here
---
2019-08-10T06:41:42.9382697Z error: aborting due to previous error
2019-08-10T06:41:42.9382726Z 
2019-08-10T06:41:42.9383011Z Couldn't compile the test.
2019-08-10T06:41:42.9383288Z ---- collections/hash/map.rs - collections::hash::map::OccupiedEntry::into_mut (line 2172) stdout ----
2019-08-10T06:41:42.9383345Z error: the item `HashMap` is imported redundantly
2019-08-10T06:41:42.9383569Z  --> collections/hash/map.rs:2173:5
2019-08-10T06:41:42.9383655Z 4 | use std::collections::HashMap;
2019-08-10T06:41:42.9383847Z   |     ^^^^^^^^^^^^^^^^^^^^^^^^^
2019-08-10T06:41:42.9383919Z   |
2019-08-10T06:41:42.9383961Z note: lint level defined here
---
2019-08-10T06:41:42.9384502Z error: aborting due to previous error
2019-08-10T06:41:42.9384530Z 
2019-08-10T06:41:42.9384726Z Couldn't compile the test.
2019-08-10T06:41:42.9385009Z ---- collections/hash/map.rs - collections::hash::map::OccupiedEntry::key (line 2072) stdout ----
2019-08-10T06:41:42.9385066Z error: the item `HashMap` is imported redundantly
2019-08-10T06:41:42.9385473Z  --> collections/hash/map.rs:2073:5
2019-08-10T06:41:42.9385563Z 4 | use std::collections::HashMap;
2019-08-10T06:41:42.9385601Z   |     ^^^^^^^^^^^^^^^^^^^^^^^^^
2019-08-10T06:41:42.9385660Z   |
2019-08-10T06:41:42.9385697Z note: lint level defined here
---
2019-08-10T06:41:42.9386133Z error: aborting due to previous error
2019-08-10T06:41:42.9386158Z 
2019-08-10T06:41:42.9386329Z Couldn't compile the test.
2019-08-10T06:41:42.9386742Z ---- collections/hash/map.rs - collections::hash::map::OccupiedEntry::remove (line 2219) stdout ----
2019-08-10T06:41:42.9386789Z error: the item `HashMap` is imported redundantly
2019-08-10T06:41:42.9386963Z  --> collections/hash/map.rs:2220:5
2019-08-10T06:41:42.9387051Z 4 | use std::collections::HashMap;
2019-08-10T06:41:42.9387088Z   |     ^^^^^^^^^^^^^^^^^^^^^^^^^
2019-08-10T06:41:42.9387138Z   |
2019-08-10T06:41:42.9387180Z note: lint level defined here
---
2019-08-10T06:41:42.9387724Z error: aborting due to previous error
2019-08-10T06:41:42.9387749Z 
2019-08-10T06:41:42.9387954Z Couldn't compile the test.
2019-08-10T06:41:42.9388202Z ---- collections/hash/map.rs - collections::hash::map::OccupiedEntry::remove_entry (line 2089) stdout ----
2019-08-10T06:41:42.9388251Z error: the item `HashMap` is imported redundantly
2019-08-10T06:41:42.9388427Z  --> collections/hash/map.rs:2090:5
2019-08-10T06:41:42.9388514Z 4 | use std::collections::HashMap;
2019-08-10T06:41:42.9388552Z   |     ^^^^^^^^^^^^^^^^^^^^^^^^^
2019-08-10T06:41:42.9388586Z   |
2019-08-10T06:41:42.9388648Z note: lint level defined here
---
2019-08-10T06:41:42.9389072Z error: aborting due to previous error
2019-08-10T06:41:42.9389096Z 
2019-08-10T06:41:42.9389261Z Couldn't compile the test.
2019-08-10T06:41:42.9389506Z ---- collections/hash/map.rs - collections::hash::map::OccupiedEntry::replace_entry (line 2243) stdout ----
2019-08-10T06:41:42.9389555Z error: the item `HashMap` is imported redundantly
2019-08-10T06:41:42.9389730Z  --> collections/hash/map.rs:2245:41
2019-08-10T06:41:42.9389769Z   |
2019-08-10T06:41:42.9389823Z 5 | use std::collections::hash_map::{Entry, HashMap};
2019-08-10T06:41:42.9389966Z   |
2019-08-10T06:41:42.9390025Z note: lint level defined here
2019-08-10T06:41:42.9390222Z  --> collections/hash/map.rs:2241:9
2019-08-10T06:41:42.9390259Z   |
---
2019-08-10T06:41:42.9390471Z error: aborting due to previous error
2019-08-10T06:41:42.9390495Z 
2019-08-10T06:41:42.9390661Z Couldn't compile the test.
2019-08-10T06:41:42.9390889Z ---- collections/hash/map.rs - collections::hash::map::OccupiedEntry::replace_key (line 2269) stdout ----
2019-08-10T06:41:42.9390952Z error: the item `HashMap` is imported redundantly
2019-08-10T06:41:42.9391128Z  --> collections/hash/map.rs:2271:41
2019-08-10T06:41:42.9391165Z   |
2019-08-10T06:41:42.9446148Z 5 | use std::collections::hash_map::{Entry, HashMap};
2019-08-10T06:41:42.9446316Z   |
2019-08-10T06:41:42.9446354Z note: lint level defined here
2019-08-10T06:41:42.9446769Z  --> collections/hash/map.rs:2267:9
2019-08-10T06:41:42.9446814Z   |
---
2019-08-10T06:41:42.9447016Z error: aborting due to previous error
2019-08-10T06:41:42.9447049Z 
2019-08-10T06:41:42.9447230Z Couldn't compile the test.
2019-08-10T06:41:42.9447449Z ---- collections/hash/map.rs - collections::hash::map::RandomState (line 2407) stdout ----
2019-08-10T06:41:42.9447551Z error: the item `HashMap` is imported redundantly
2019-08-10T06:41:42.9447730Z  --> collections/hash/map.rs:2408:5
2019-08-10T06:41:42.9447813Z 4 | use std::collections::HashMap;
2019-08-10T06:41:42.9447851Z   |     ^^^^^^^^^^^^^^^^^^^^^^^^^
2019-08-10T06:41:42.9447893Z   |
2019-08-10T06:41:42.9447928Z note: lint level defined here
---
2019-08-10T06:41:42.9448519Z error: aborting due to previous error
2019-08-10T06:41:42.9448552Z 
2019-08-10T06:41:42.9448931Z Couldn't compile the test.
2019-08-10T06:41:42.9449164Z ---- collections/hash/map.rs - collections::hash::map::RawEntryMut::and_modify (line 1420) stdout ----
2019-08-10T06:41:42.9449218Z error: the item `HashMap` is imported redundantly
2019-08-10T06:41:42.9449393Z  --> collections/hash/map.rs:1422:5
2019-08-10T06:41:42.9449467Z 5 | use std::collections::HashMap;
2019-08-10T06:41:42.9449511Z   |     ^^^^^^^^^^^^^^^^^^^^^^^^^
2019-08-10T06:41:42.9449546Z   |
2019-08-10T06:41:42.9449590Z note: lint level defined here
---
2019-08-10T06:41:42.9450002Z error: aborting due to previous error
2019-08-10T06:41:42.9450033Z 
2019-08-10T06:41:42.9450199Z Couldn't compile the test.
2019-08-10T06:41:42.9453084Z ---- collections/hash/map.rs - collections::hash::map::RawEntryMut::or_insert (line 1356) stdout ----
2019-08-10T06:41:42.9453168Z error: the item `HashMap` is imported redundantly
2019-08-10T06:41:42.9453426Z  --> collections/hash/map.rs:1358:5
2019-08-10T06:41:42.9453515Z 5 | use std::collections::HashMap;
2019-08-10T06:41:42.9453568Z   |     ^^^^^^^^^^^^^^^^^^^^^^^^^
2019-08-10T06:41:42.9453609Z   |
2019-08-10T06:41:42.9453813Z note: lint level defined here
---
2019-08-10T06:41:42.9454365Z error: aborting due to previous error
2019-08-10T06:41:42.9454394Z 
2019-08-10T06:41:42.9454605Z Couldn't compile the test.
2019-08-10T06:41:42.9455045Z ---- collections/hash/map.rs - collections::hash::map::RawEntryMut::or_insert_with (line 1386) stdout ----
2019-08-10T06:41:42.9455094Z error: the item `HashMap` is imported redundantly
2019-08-10T06:41:42.9455284Z  --> collections/hash/map.rs:1388:5
2019-08-10T06:41:42.9500692Z 5 | use std::collections::HashMap;
2019-08-10T06:41:42.9500750Z   |     ^^^^^^^^^^^^^^^^^^^^^^^^^
2019-08-10T06:41:42.9500786Z   |
2019-08-10T06:41:42.9500838Z note: lint level defined here
---
2019-08-10T06:41:42.9501884Z error: aborting due to previous error
2019-08-10T06:41:42.9502183Z 
2019-08-10T06:41:42.9502744Z Couldn't compile the test.
2019-08-10T06:41:42.9503023Z ---- collections/hash/map.rs - collections::hash::map::VacantEntry::into_key (line 2319) stdout ----
2019-08-10T06:41:42.9503082Z error: the item `HashMap` is imported redundantly
2019-08-10T06:41:42.9503303Z  --> collections/hash/map.rs:2320:5
2019-08-10T06:41:42.9503394Z 4 | use std::collections::HashMap;
2019-08-10T06:41:42.9503439Z   |     ^^^^^^^^^^^^^^^^^^^^^^^^^
2019-08-10T06:41:42.9503494Z   |
2019-08-10T06:41:42.9503536Z note: lint level defined here
---
2019-08-10T06:41:42.9504217Z error: aborting due to previous error
2019-08-10T06:41:42.9504246Z 
2019-08-10T06:41:42.9504501Z Couldn't compile the test.
2019-08-10T06:41:42.9504772Z ---- collections/hash/map.rs - collections::hash::map::VacantEntry::insert (line 2340) stdout ----
2019-08-10T06:41:42.9504828Z error: the item `HashMap` is imported redundantly
2019-08-10T06:41:42.9505036Z  --> collections/hash/map.rs:2341:5
2019-08-10T06:41:42.9505141Z 4 | use std::collections::HashMap;
2019-08-10T06:41:42.9505187Z   |     ^^^^^^^^^^^^^^^^^^^^^^^^^
2019-08-10T06:41:42.9505240Z   |
2019-08-10T06:41:42.9505283Z note: lint level defined here
---
2019-08-10T06:41:42.9505948Z error: aborting due to previous error
2019-08-10T06:41:42.9505973Z 
2019-08-10T06:41:42.9506305Z Couldn't compile the test.
2019-08-10T06:41:42.9506709Z ---- collections/hash/map.rs - collections::hash::map::VacantEntry::key (line 2303) stdout ----
2019-08-10T06:41:42.9506758Z error: the item `HashMap` is imported redundantly
2019-08-10T06:41:42.9506937Z  --> collections/hash/map.rs:2304:5
2019-08-10T06:41:42.9507025Z 4 | use std::collections::HashMap;
2019-08-10T06:41:42.9507064Z   |     ^^^^^^^^^^^^^^^^^^^^^^^^^
2019-08-10T06:41:42.9507113Z   |
2019-08-10T06:41:42.9507150Z note: lint level defined here
---
2019-08-10T06:41:42.9507634Z 
2019-08-10T06:41:42.9507678Z error: aborting due to previous error
2019-08-10T06:41:42.9507703Z 
2019-08-10T06:41:42.9507898Z Couldn't compile the test.
2019-08-10T06:41:42.9508117Z ---- process.rs - process::Command::envs (line 575) stdout ----
2019-08-10T06:41:42.9508163Z error: the item `HashMap` is imported redundantly
2019-08-10T06:41:42.9508331Z  --> process.rs:578:5
2019-08-10T06:41:42.9508423Z 6 | use std::collections::HashMap;
2019-08-10T06:41:42.9508461Z   |     ^^^^^^^^^^^^^^^^^^^^^^^^^
2019-08-10T06:41:42.9508497Z   |
2019-08-10T06:41:42.9508545Z note: lint level defined here
---
2019-08-10T06:41:42.9534230Z 
2019-08-10T06:41:42.9534541Z error: test failed, to rerun pass '--doc'
2019-08-10T06:41:42.9534576Z 
2019-08-10T06:41:42.9534602Z 
2019-08-10T06:41:42.9535197Z command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "test" "--target" "x86_64-unknown-linux-gnu" "-j" "2" "--release" "--locked" "--color" "always" "--features" "panic-unwind backtrace compiler-builtins-c" "--manifest-path" "/checkout/src/libstd/Cargo.toml" "-p" "std" "--" "--quiet"
2019-08-10T06:41:42.9535322Z 
2019-08-10T06:41:42.9535537Z 
2019-08-10T06:41:42.9535578Z failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
2019-08-10T06:41:42.9535624Z Build completed unsuccessfully in 1:32:33
2019-08-10T06:41:42.9535624Z Build completed unsuccessfully in 1:32:33
2019-08-10T06:41:43.5390189Z ##[error]Bash exited with code '1'.
2019-08-10T06:41:43.5429324Z ##[section]Starting: Checkout
2019-08-10T06:41:43.5430898Z ==============================================================================
2019-08-10T06:41:43.5430943Z Task         : Get sources
2019-08-10T06:41:43.5430981Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@rust-highfive

This comment was marked as resolved.

Copy link
Collaborator

commented Aug 10, 2019

The job x86_64-gnu-llvm-6.0 of your PR failed (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
2019-08-10T09:53:25.3415844Z ##[command]git remote add origin https://github.com/rust-lang/rust
2019-08-10T09:53:25.3667888Z ##[command]git config gc.auto 0
2019-08-10T09:53:25.3699178Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2019-08-10T09:53:25.3748671Z ##[command]git config --get-all http.proxy
2019-08-10T09:53:25.3875474Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/63418/merge:refs/remotes/pull/63418/merge
---
2019-08-10T09:54:00.0218925Z do so (now or later) by using -b with the checkout command again. Example:
2019-08-10T09:54:00.0218961Z 
2019-08-10T09:54:00.0219204Z   git checkout -b <new-branch-name>
2019-08-10T09:54:00.0219235Z 
2019-08-10T09:54:00.0219289Z HEAD is now at e692a2a38 Merge fd466cbbd30dab6d16912ca4d57f1c9bd72ae259 into be8bbb06976c8065425b18e9cbe24a6d1d4e7515
2019-08-10T09:54:00.0372509Z ##[section]Starting: Collect CPU-usage statistics in the background
2019-08-10T09:54:00.0375497Z ==============================================================================
2019-08-10T09:54:00.0375548Z Task         : Bash
2019-08-10T09:54:00.0375592Z Description  : Run a Bash script on macOS, Linux, or Windows
---
2019-08-10T10:56:11.6841924Z .................................................................................................... 1300/8860
2019-08-10T10:56:18.2975346Z .................................................................................................... 1400/8860
2019-08-10T10:56:24.6697027Z .................................................................................................... 1500/8860
2019-08-10T10:56:35.3407192Z ....................................................................................i............... 1600/8860
2019-08-10T10:56:43.1318706Z i................................................................................................... 1700/8860
2019-08-10T10:56:50.0792031Z ...........................................................................iiiii.................... 1800/8860
2019-08-10T10:57:12.6655508Z .................................................................................................... 2000/8860
2019-08-10T10:57:15.1783539Z .................................................................................................... 2100/8860
2019-08-10T10:57:17.9587352Z .................................................................................................... 2200/8860
2019-08-10T10:57:25.6838750Z .................................................................................................... 2300/8860
---
2019-08-10T11:01:16.1755361Z .................................................................................................... 5200/8860
2019-08-10T11:01:27.1862232Z .................................................................................................... 5300/8860
2019-08-10T11:01:34.9420595Z .i.................................................................................................. 5400/8860
2019-08-10T11:01:40.3967007Z .................................................................................................... 5500/8860
2019-08-10T11:01:52.6495249Z ...............................................................................................ii... 5600/8860
2019-08-10T11:02:07.4374843Z i..ii...........i................................................................................... 5700/8860
2019-08-10T11:02:24.1461716Z .................................................................................................... 5900/8860
2019-08-10T11:02:29.0846681Z ................................................................................................i..i 6000/8860
2019-08-10T11:02:43.6012116Z i................................................................................................... 6100/8860
2019-08-10T11:03:00.2271650Z .................................................................................................... 6200/8860
---
2019-08-10T11:07:58.9642006Z  finished in 23.163
2019-08-10T11:07:58.9820716Z Check compiletest suite=codegen mode=codegen (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-08-10T11:07:59.1610722Z 
2019-08-10T11:07:59.1612765Z running 146 tests
2019-08-10T11:08:02.9724893Z i....iii......iii..iiii....i............................i..i................i....i.........ii.i.i..i 100/146
2019-08-10T11:08:04.4973850Z iii..............i.........iii.i......ii......
2019-08-10T11:08:04.4974405Z 
2019-08-10T11:08:04.4979025Z  finished in 5.515
2019-08-10T11:08:04.5192066Z Check compiletest suite=codegen-units mode=codegen-units (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-08-10T11:08:04.6959428Z 
---
2019-08-10T11:08:06.8062662Z  finished in 2.286
2019-08-10T11:08:06.8240367Z Check compiletest suite=assembly mode=assembly (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-08-10T11:08:07.0063990Z 
2019-08-10T11:08:07.0064669Z running 9 tests
2019-08-10T11:08:07.0067916Z iiiiiiiii
2019-08-10T11:08:07.0068475Z 
2019-08-10T11:08:07.0094965Z  finished in 0.183
2019-08-10T11:08:07.0322029Z Check compiletest suite=incremental mode=incremental (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-08-10T11:08:07.1863540Z 
---
2019-08-10T11:08:25.6139797Z  finished in 18.583
2019-08-10T11:08:25.6341114Z Check compiletest suite=debuginfo mode=debuginfo-gdb+lldb (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-08-10T11:08:25.8025824Z 
2019-08-10T11:08:25.8026077Z running 122 tests
2019-08-10T11:08:50.3124961Z .iiiii...i.....i..i...i..i.i.i..i.ii..i.i.....i..i....i..........iiii..........i...ii...i.......ii.i 100/122
2019-08-10T11:08:55.0135159Z .i.i......iii.i.....ii
2019-08-10T11:08:55.0136499Z 
2019-08-10T11:08:55.0140714Z  finished in 29.380
2019-08-10T11:08:55.0149334Z Uplifting stage1 rustc (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-08-10T11:08:55.0149726Z Copying stage2 rustc from stage1 (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu / x86_64-unknown-linux-gnu)
---
2019-08-10T11:23:23.6965737Z 
2019-08-10T11:23:23.6978308Z    Doc-tests core
2019-08-10T11:23:28.0289536Z 
2019-08-10T11:23:28.0294664Z running 2379 tests
2019-08-10T11:23:40.6580671Z ......iiiii......................................................................................... 100/2379
2019-08-10T11:23:53.5296082Z .........................................................................ii......................... 200/2379
2019-08-10T11:24:24.4220857Z .................................................................................................... 400/2379
2019-08-10T11:24:24.4220857Z .................................................................................................... 400/2379
2019-08-10T11:24:35.9560240Z ..............................i..i.................iiii............................................. 500/2379
2019-08-10T11:25:00.3589548Z .................................................................................................... 700/2379
2019-08-10T11:25:12.6051184Z .................................................................................................... 800/2379
2019-08-10T11:25:25.0062209Z .................................................................................................... 900/2379
2019-08-10T11:25:37.3042193Z .................................................................................................... 1000/2379
---
2019-08-10T11:31:07.2967720Z 
2019-08-10T11:31:07.2967968Z running 991 tests
2019-08-10T11:31:31.1013941Z i................................................FF................................................. 100/991
2019-08-10T11:31:44.6681061Z .................................................................................................... 200/991
2019-08-10T11:31:53.5940533Z .................iii......i......i...i......i....................................................... 300/991
2019-08-10T11:31:58.8479027Z .................................................................................................... 400/991
2019-08-10T11:32:07.0972557Z ..................................i..i.................................ii........................... 500/991
2019-08-10T11:32:22.3449943Z .................................................................................................... 700/991
2019-08-10T11:32:22.3449943Z .................................................................................................... 700/991
2019-08-10T11:32:30.9470131Z .................iiii............................................................................... 800/991
2019-08-10T11:32:46.1752306Z .................................................................................................... 900/991
2019-08-10T11:32:54.0752079Z .......................................iiii................................................
2019-08-10T11:32:54.0754458Z 
2019-08-10T11:32:54.0755598Z ---- collections/hash/map.rs - collections::hash::map::OccupiedEntry::replace_entry (line 2161) stdout ----
2019-08-10T11:32:54.0755598Z ---- collections/hash/map.rs - collections::hash::map::OccupiedEntry::replace_entry (line 2161) stdout ----
2019-08-10T11:32:54.0758291Z error: the item `HashMap` is imported redundantly
2019-08-10T11:32:54.0758765Z  --> collections/hash/map.rs:2163:41
2019-08-10T11:32:54.0759399Z   |
2019-08-10T11:32:54.0759598Z 5 | use std::collections::hash_map::{Entry, HashMap};
2019-08-10T11:32:54.0760307Z   |
2019-08-10T11:32:54.0760479Z note: lint level defined here
2019-08-10T11:32:54.0760989Z  --> collections/hash/map.rs:2159:9
2019-08-10T11:32:54.0761238Z   |
---
2019-08-10T11:32:54.0762138Z error: aborting due to previous error
2019-08-10T11:32:54.0763285Z 
2019-08-10T11:32:54.0763843Z Couldn't compile the test.
2019-08-10T11:32:54.0814167Z ---- collections/hash/map.rs - collections::hash::map::OccupiedEntry::replace_key (line 2187) stdout ----
2019-08-10T11:32:54.0814501Z error: the item `HashMap` is imported redundantly
2019-08-10T11:32:54.0814966Z  --> collections/hash/map.rs:2189:41
2019-08-10T11:32:54.0815203Z   |
2019-08-10T11:32:54.0815454Z 5 | use std::collections::hash_map::{Entry, HashMap};
2019-08-10T11:32:54.0815822Z   |
2019-08-10T11:32:54.0815995Z note: lint level defined here
2019-08-10T11:32:54.0816836Z  --> collections/hash/map.rs:2185:9
2019-08-10T11:32:54.0817165Z   |
---
2019-08-10T11:32:54.0820656Z 
2019-08-10T11:32:54.0965068Z error: test failed, to rerun pass '--doc'
2019-08-10T11:32:54.0984643Z 
2019-08-10T11:32:54.0984723Z 
2019-08-10T11:32:54.0985444Z command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "test" "--target" "x86_64-unknown-linux-gnu" "-j" "2" "--release" "--locked" "--color" "always" "--features" "panic-unwind backtrace compiler-builtins-c" "--manifest-path" "/checkout/src/libstd/Cargo.toml" "-p" "std" "--" "--quiet"
2019-08-10T11:32:54.0985559Z 
2019-08-10T11:32:54.0985605Z 
2019-08-10T11:32:54.0998322Z failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
2019-08-10T11:32:54.0998426Z Build completed unsuccessfully in 1:32:25
2019-08-10T11:32:54.0998426Z Build completed unsuccessfully in 1:32:25
2019-08-10T11:32:54.6649622Z ##[error]Bash exited with code '1'.
2019-08-10T11:32:54.6794256Z ##[section]Starting: Checkout
2019-08-10T11:32:54.6796037Z ==============================================================================
2019-08-10T11:32:54.6796110Z Task         : Get sources
2019-08-10T11:32:54.6796156Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@lzutao lzutao force-pushed the lzutao:hashmap-prelude branch from fd466cb to ffb85f3 Aug 10, 2019

@rust-highfive

This comment was marked as resolved.

Copy link
Collaborator

commented Aug 10, 2019

The job x86_64-gnu-llvm-6.0 of your PR failed (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
2019-08-10T13:08:58.0030488Z ##[command]git remote add origin https://github.com/rust-lang/rust
2019-08-10T13:08:58.0221845Z ##[command]git config gc.auto 0
2019-08-10T13:08:58.0306530Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2019-08-10T13:08:58.0355565Z ##[command]git config --get-all http.proxy
2019-08-10T13:08:58.0512937Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/63418/merge:refs/remotes/pull/63418/merge
---
2019-08-10T13:09:31.6665788Z do so (now or later) by using -b with the checkout command again. Example:
2019-08-10T13:09:31.6665836Z 
2019-08-10T13:09:31.6666042Z   git checkout -b <new-branch-name>
2019-08-10T13:09:31.6666071Z 
2019-08-10T13:09:31.6666137Z HEAD is now at 3ffd5cf06 Merge ffb85f39250593dd0f8d166616321cdd5f7dee61 into d19a359444295bab01de7ff44a9d72302e573bc9
2019-08-10T13:09:31.6839007Z ##[section]Starting: Collect CPU-usage statistics in the background
2019-08-10T13:09:31.6842219Z ==============================================================================
2019-08-10T13:09:31.6842279Z Task         : Bash
2019-08-10T13:09:31.6842342Z Description  : Run a Bash script on macOS, Linux, or Windows
---
2019-08-10T14:09:02.9161051Z .................................................................................................... 1300/8868
2019-08-10T14:09:09.1227366Z .................................................................................................... 1400/8868
2019-08-10T14:09:15.1418405Z .................................................................................................... 1500/8868
2019-08-10T14:09:25.8873494Z ....................................................................................i............... 1600/8868
2019-08-10T14:09:33.2923859Z i................................................................................................... 1700/8868
2019-08-10T14:09:39.7686556Z ...........................................................................iiiii.................... 1800/8868
2019-08-10T14:10:00.9831109Z .................................................................................................... 2000/8868
2019-08-10T14:10:03.4334605Z .................................................................................................... 2100/8868
2019-08-10T14:10:06.0847464Z .................................................................................................... 2200/8868
2019-08-10T14:10:13.5010186Z .................................................................................................... 2300/8868
---
2019-08-10T14:13:50.4253114Z .................................................................................................... 5200/8868
2019-08-10T14:14:00.6897623Z .................................................................................................... 5300/8868
2019-08-10T14:14:07.8306150Z ....i............................................................................................... 5400/8868
2019-08-10T14:14:12.9818611Z .................................................................................................... 5500/8868
2019-08-10T14:14:24.8169549Z ...................................................................................................i 5600/8868
2019-08-10T14:14:38.7129329Z i...i..ii...........i............................................................................... 5700/8868
2019-08-10T14:14:52.2424811Z .................................................................................................... 5900/8868
2019-08-10T14:14:56.8368723Z .................................................................................................... 6000/8868
2019-08-10T14:14:56.8368723Z .................................................................................................... 6000/8868
2019-08-10T14:15:10.6878920Z i..ii............................................................................................... 6100/8868
2019-08-10T14:15:28.6196564Z ...........................................i........................................................ 6300/8868
2019-08-10T14:15:30.7005934Z .................................................................................................... 6400/8868
2019-08-10T14:15:33.1227122Z ...............i.................................................................................... 6500/8868
2019-08-10T14:15:37.5270982Z .................................................................................................... 6600/8868
---
2019-08-10T14:20:09.1798143Z  finished in 21.691
2019-08-10T14:20:09.1961533Z Check compiletest suite=codegen mode=codegen (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-08-10T14:20:09.3479216Z 
2019-08-10T14:20:09.3479351Z running 146 tests
2019-08-10T14:20:12.5029400Z i....iii......iii..iiii....i............................i..i................i....i.........ii.i.i..i 100/146
2019-08-10T14:20:14.3131657Z iii..............i.........iii.i......ii......
2019-08-10T14:20:14.3132302Z 
2019-08-10T14:20:14.3136956Z  finished in 5.117
2019-08-10T14:20:14.3315209Z Check compiletest suite=codegen-units mode=codegen-units (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-08-10T14:20:14.4910072Z 
---
2019-08-10T14:20:16.4607962Z  finished in 2.129
2019-08-10T14:20:16.4785737Z Check compiletest suite=assembly mode=assembly (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-08-10T14:20:16.6275999Z 
2019-08-10T14:20:16.6276240Z running 9 tests
2019-08-10T14:20:16.6277108Z iiiiiiiii
2019-08-10T14:20:16.6277696Z 
2019-08-10T14:20:16.6281383Z  finished in 0.149
2019-08-10T14:20:16.6455136Z Check compiletest suite=incremental mode=incremental (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-08-10T14:20:16.8026873Z 
---
2019-08-10T14:20:34.5361985Z  finished in 17.890
2019-08-10T14:20:34.5554766Z Check compiletest suite=debuginfo mode=debuginfo-gdb+lldb (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-08-10T14:20:34.7126176Z 
2019-08-10T14:20:34.7126405Z running 122 tests
2019-08-10T14:20:57.6049630Z .iiiii...i.....i..i...i..i.i.i..i.ii..i.i.....i..i....i..........iiii..........i...ii...i.......ii.i 100/122
2019-08-10T14:21:02.0776916Z .i.i......iii.i.....ii
2019-08-10T14:21:02.0777434Z 
2019-08-10T14:21:02.0782234Z  finished in 27.523
2019-08-10T14:21:02.0790903Z Uplifting stage1 rustc (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-08-10T14:21:02.0791209Z Copying stage2 rustc from stage1 (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu / x86_64-unknown-linux-gnu)
---
2019-08-10T14:35:04.9841154Z 
2019-08-10T14:35:04.9841936Z    Doc-tests core
2019-08-10T14:35:09.1191147Z 
2019-08-10T14:35:09.1192722Z running 2379 tests
2019-08-10T14:35:21.3717935Z ......iiiii......................................................................................... 100/2379
2019-08-10T14:35:33.4817189Z .........................................................................ii......................... 200/2379
2019-08-10T14:36:02.2453406Z .................................................................................................... 400/2379
2019-08-10T14:36:02.2453406Z .................................................................................................... 400/2379
2019-08-10T14:36:13.3954139Z ..............................i..i.................iiii............................................. 500/2379
2019-08-10T14:36:36.3460261Z .................................................................................................... 700/2379
2019-08-10T14:36:47.8375252Z .................................................................................................... 800/2379
2019-08-10T14:36:59.3064537Z .................................................................................................... 900/2379
2019-08-10T14:37:10.7035661Z .................................................................................................... 1000/2379
---
2019-08-10T14:42:10.9049715Z .................................................................................................... 100/762
2019-08-10T14:42:11.2450081Z .................................................................................................... 200/762
2019-08-10T14:42:11.3284556Z .....................................................thread '<unnamed>' panicked at 'explicit panic', src/libstd/io/buffered.rs:1401:17
2019-08-10T14:42:11.3420099Z ............................................... 300/762
2019-08-10T14:42:11.3431987Z thread '<unnamed>.' panicked at 'explicit panic', src/libstd/io/stdio.rs:854:13
2019-08-10T14:42:13.5296610Z .................................................................................................... 500/762
2019-08-10T14:42:13.5548406Z ...................thread '<unnamed>' panicked at 'called `Result::unwrap()` on an `Err` value: RecvError', src/libcore/result.rs:1084:5
2019-08-10T14:42:13.5569464Z ....thread '<unnamed>' panicked at 'called `Result::unwrap()` on an `Err` value: "SendError(..)"', src/libcore/result.rs:1084:5
2019-08-10T14:42:13.5591183Z .thread '<unnamed>' panicked at 'called `Result::unwrap()` on an `Err` value: RecvError', src/libcore/result.rs:1084:5
2019-08-10T14:42:13.5591183Z .thread '<unnamed>' panicked at 'called `Result::unwrap()` on an `Err` value: RecvError', src/libcore/result.rs:1084:5
2019-08-10T14:42:13.5615988Z ......thread '<unnamed>' panicked at 'called `Result::unwrap()` on an `Err` value: RecvError', src/libcore/result.rs:1084:5
2019-08-10T14:42:13.7756579Z ..........................................thread '<unnamed>' panicked at 'called `Result::unwrap()` on an `Err` value: RecvError', src/libcore/result.rs:1084:5
2019-08-10T14:42:13.7775758Z ....thread '<unnamed>thread '<unnamed>' panicked at 'called `Result::unwrap()` on an `Err` value: "SendError(..)"', src/libcore/result.rs:1084:5
2019-08-10T14:42:13.7787137Z .' panicked at 'called `Result::unwrap()` on an `Err` value: RecvError', src/libcore/result.rs:1084:5.
2019-08-10T14:42:13.7806081Z .....thread '<unnamed>' panicked at 'called `Result::unwrap()` on an `Err` value: RecvError', src/libcore/result.rs:1084:5
2019-08-10T14:42:15.8467606Z ......................thread '<unnamed>' panicked at 'explicit panic', src/libstd/sync/mutex.rs:629:13
2019-08-10T14:42:15.8468661Z .thread '<unnamed>' panicked at 'test panic in inner thread to poison mutex', src/libstd/sync/mutex.rs:584:13
2019-08-10T14:42:15.8478079Z ...thread '<unnamed>' panicked at 'test panic in inner thread to poison mutex', src/libstd/sync/mutex.rs:561:13
2019-08-10T14:42:15.8484302Z .thread '<unnamed>' panicked at 'explicit panic', src/libstd/sync/mutex.rs:689:13
---
2019-08-10T14:42:25.2163928Z 
2019-08-10T14:42:25.2164697Z running 991 tests
2019-08-10T14:42:48.7063367Z i................................................................................................... 100/991
2019-08-10T14:43:01.6733648Z .................................................................................................... 200/991
2019-08-10T14:43:10.3437162Z .................iii......i......i...i......i....................................................... 300/991
2019-08-10T14:43:15.6765251Z .................................................................................................... 400/991
2019-08-10T14:43:23.4513765Z ..................................i..i.................................ii........................... 500/991
2019-08-10T14:43:38.1894179Z .................................................................................................... 700/991
2019-08-10T14:43:38.1894179Z .................................................................................................... 700/991
2019-08-10T14:43:46.2484155Z .................iiii............................................................................... 800/991
2019-08-10T14:44:00.7920702Z .................................................................................................... 900/991
2019-08-10T14:44:08.4304336Z .......................................iiii................................................
2019-08-10T14:44:08.4305398Z 
2019-08-10T14:44:08.4506333Z  finished in 246.167
2019-08-10T14:44:08.4523960Z Testing unwind stage1 (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-08-10T14:44:08.6375742Z     Finished release [optimized] target(s) in 0.18s
---
2019-08-10T15:01:51.5799920Z   |
2019-08-10T15:01:51.5799962Z 3 | let map = HashMap::new();
2019-08-10T15:01:51.5800205Z   |     ---   ^^^^^^^^^^^^ cannot infer type for `K`
2019-08-10T15:01:51.5800252Z   |     |
2019-08-10T15:01:51.5800304Z   |     consider giving `map` the explicit type `std::collections::HashMap<K, V>`, where the type parameter `K` is specified
2019-08-10T15:01:51.5800407Z error: aborting due to previous error
2019-08-10T15:01:51.5800435Z 
2019-08-10T15:01:51.5800680Z For more information about this error, try `rustc --explain E0282`.
2019-08-10T15:01:51.5800680Z For more information about this error, try `rustc --explain E0282`.
2019-08-10T15:01:51.5800749Z Some expected error codes were not found: ["E0433"]
2019-08-10T15:01:51.5800817Z failures:
2019-08-10T15:01:51.5801101Z     /checkout/obj/build/x86_64-unknown-linux-gnu/test/error-index.md - Rust_Compiler_Error_Index::E0433 (line 7030)
2019-08-10T15:01:51.5801153Z 
2019-08-10T15:01:51.5801199Z test result: FAILED. 687 passed; 1 failed; 24 ignored; 0 measured; 0 filtered out
---
2019-08-10T15:01:51.5801503Z 
2019-08-10T15:01:51.5802126Z 
2019-08-10T15:01:51.5802189Z failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
2019-08-10T15:01:51.5802253Z Build completed unsuccessfully in 1:46:10
2019-08-10T15:01:52.7259178Z ##[error]Bash exited with code '1'.
2019-08-10T15:01:52.7324735Z ##[section]Starting: Checkout
2019-08-10T15:01:52.7326529Z ==============================================================================
2019-08-10T15:01:52.7326591Z Task         : Get sources
2019-08-10T15:01:52.7326632Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@lzutao

This comment has been minimized.

Copy link
Contributor Author

commented Aug 10, 2019

I cannot run the full test suite with x.py in local machine because of #63436.

// The file so far is equivalent to src/libcore/prelude/v1.rs,
// and below to src/liballoc/prelude.rs.
// The file so far is equivalent to `src/libcore/prelude/v1.rs`,
// and below to `src/liballoc/prelude/v1.rs` (except `HashMap`).
// Those files are duplicated rather than using glob imports
// because we want docs to show these re-exports as pointing to within `std`.

This comment has been minimized.

Copy link
@lzutao

lzutao Aug 10, 2019

Author Contributor

Should I remove these comments or not? @RalfJung

This comment has been minimized.

Copy link
@RalfJung

RalfJung Aug 10, 2019

Member

Sorry, no idea. I just observed an inconsistency.

@RalfJung

This comment has been minimized.

Copy link
Member

commented Aug 10, 2019

I cannot run the full test suite with x.py in local machine because of #63436.

I hardly ever run more than ./x.py test src/test/ui --pass check, then I let the PR CI point me to what else might be problematic. Things just take too long.^^

@steveklabnik

This comment has been minimized.

Copy link
Member

commented Aug 13, 2019

I don't personally think HashMap is used often enough to deserve a spot in the prelude.

@Centril

This comment has been minimized.

Copy link
Member

commented Aug 13, 2019

IMO we should rethink the prelude and not have it be so limited. I think the bar set by:

It's kept as small as possible, and is focused on things, particularly traits, which are used in almost every single Rust program.

is just too high. For example, I do not think that ToOwned meets that bar.

@steveklabnik

This comment has been minimized.

Copy link
Member

commented Aug 13, 2019

I think that messing with something so important, and that affects imports to every single program, is something to be done with extreme care.

@joshtriplett
Copy link
Member

left a comment

Typo: HashpMap should be HashMap

@joshtriplett

This comment has been minimized.

Copy link
Member

commented Aug 15, 2019

I'd love to see this happen.

I'm concerned about it generating warnings about redundant imports, as evidenced by the extensive test suite changes, but I don't see any reasonable way around that.

@joshtriplett

This comment has been minimized.

Copy link
Member

commented Aug 15, 2019

Could you please rebase the series and squash some patches together to avoid fixing bugs introduced by the same series? For instance, you have several commits making the same kind of change to tests, and you have a commit changing a test incorrectly followed by a commit fixing the test correctly.

@joshtriplett

This comment has been minimized.

Copy link
Member

commented Aug 15, 2019

We discussed this in the lang team meeting, and we developed a consensus that the lang team wants to defer decisions about the content of the prelude to the libs team, unless the libs team specifically wants to consult the lang team (such as for issues of coherence or alignment with new language features). As such, un-tagging the lang team.

@joshtriplett

This comment has been minimized.

Copy link
Member

commented Aug 15, 2019

Now, taking my lang team hat off and speaking only for myself:

Yes, please, I'd love to see HashMap in the prelude. I'd also like to see a few other things added to the prelude that people commonly use.

We'll need to take some care about traits, but types should not cause issues to introduce.

lzutao added some commits Aug 9, 2019

Fix `HashMap` redundantly import errors
Replace HashMap by BTreeMap in tests suggested by Jonas

@lzutao lzutao force-pushed the lzutao:hashmap-prelude branch from ac72da7 to c066237 Aug 16, 2019

@ssokolow

This comment has been minimized.

Copy link

commented Aug 16, 2019

For example, I do not think that ToOwned meets that bar.

I always use it when going from &str to String because it best communicates the purpose of the conversion to anyone else reading the code.

@RalfJung

This comment has been minimized.

Copy link
Member

commented Aug 16, 2019

I always use it when going from &str to String because it best communicates the purpose of the conversion to anyone else reading the code.

I've been bitten by that quite badly when, for some reason, I ended up with an &&str. Then to_owned turns that into an &str.
Since then, I am using .to_string(), and for literals sometimes format!.

@ssokolow

This comment has been minimized.

Copy link

commented Aug 16, 2019

I'm having trouble imagining a situation where I'd use .to_owned(), that might happen, and the type system wouldn't catch it.

(If the borrow checker is happy with a reference, then why would I be calling .to_owned() in the first place?)

...and, in that case, I'd say that it's a good thing for the same reason that I don't want string+integer concatenation doing automatic type conversion.

As far as I'm concerned, if .to_string() or format! let an unexpected && Just Work™, then it's a design flaw because I want to catch, understand, and make an explicit decision about that unexpected &&.

@RalfJung

This comment has been minimized.

Copy link
Member

commented Aug 16, 2019

I disagree, I think if what I want is a string I should express that -- "to owned" doesn't convey enough information about what we own then. This is related to accidentally cloning a shared reference instead of what it points to. But I'll stop digressing here now. ;)

@ssokolow

This comment has been minimized.

Copy link

commented Aug 16, 2019

Fair enough. I won't keep things off-topic either but I will say that I hadn't considered shared references.

(I'm still used to choosing project ideas where Rust is just serving as a more maintainable alternative to Python and, given Python's Global Interpreter Lock, that means I don't do much parallel stuff.)

@chris-morgan

This comment has been minimized.

Copy link
Member

commented Aug 17, 2019

Quite apart from the question of what items are in the prelude: I had understood that if items were added to the prelude in future, they’d be in a different module than v1. Otherwise I’m not particularly sure what the purpose of the v1 bit would be.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.