Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Place 2.0] Convert Place's projection to a boxed slice #63420

Draft
wants to merge 1 commit into
base: master
from

Conversation

@spastorino
Copy link
Member

commented Aug 9, 2019

This is still work in progress, it's not compiling right now I need to review a bit more to see what's going on but wanted to open the PR to start discussing it.

r? @oli-obk

@rust-highfive

This comment has been minimized.

Copy link
Collaborator

commented Aug 9, 2019

The job x86_64-gnu-llvm-6.0 of your PR failed (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
2019-08-09T18:58:56.1753702Z ##[command]git remote add origin https://github.com/rust-lang/rust
2019-08-09T18:58:57.0631482Z ##[command]git config gc.auto 0
2019-08-09T18:58:57.0638203Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2019-08-09T18:58:57.0644501Z ##[command]git config --get-all http.proxy
2019-08-09T18:58:57.0650685Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/63420/merge:refs/remotes/pull/63420/merge
---
2019-08-09T18:59:33.8038702Z do so (now or later) by using -b with the checkout command again. Example:
2019-08-09T18:59:33.8040515Z 
2019-08-09T18:59:33.8041821Z   git checkout -b <new-branch-name>
2019-08-09T18:59:33.8042711Z 
2019-08-09T18:59:33.8131939Z HEAD is now at ea669ca31 Merge 6167608f4df2aae92a3e8dcecb81507e63655107 into 534b42394d743511db1335d5ed08d507ab7c6e73
2019-08-09T18:59:33.8208172Z ##[section]Starting: Collect CPU-usage statistics in the background
2019-08-09T18:59:33.8211330Z ==============================================================================
2019-08-09T18:59:33.8211390Z Task         : Bash
2019-08-09T18:59:33.8211435Z Description  : Run a Bash script on macOS, Linux, or Windows
---
2019-08-09T19:05:34.7726278Z    Compiling serde_json v1.0.40
2019-08-09T19:05:39.1898687Z    Compiling tidy v0.1.0 (/checkout/src/tools/tidy)
2019-08-09T19:05:47.9965855Z     Finished release [optimized] target(s) in 1m 31s
2019-08-09T19:05:48.0034284Z tidy check
2019-08-09T19:05:48.4119332Z tidy error: /checkout/src/librustc_mir/build/expr/as_rvalue.rs:524: line longer than 100 chars
2019-08-09T19:05:48.4140065Z tidy error: /checkout/src/librustc_mir/dataflow/move_paths/builder.rs:122: line longer than 100 chars
2019-08-09T19:05:48.4140161Z tidy error: /checkout/src/librustc_mir/dataflow/move_paths/builder.rs:125: line longer than 100 chars
2019-08-09T19:05:48.4140256Z tidy error: /checkout/src/librustc_mir/dataflow/move_paths/builder.rs:126: line longer than 100 chars
2019-08-09T19:05:48.4145268Z tidy error: /checkout/src/librustc_mir/dataflow/move_paths/builder.rs:127: line longer than 100 chars
2019-08-09T19:05:48.4145664Z tidy error: /checkout/src/librustc_mir/dataflow/move_paths/builder.rs:129: line longer than 100 chars
2019-08-09T19:05:48.4145865Z tidy error: /checkout/src/librustc_mir/dataflow/move_paths/builder.rs:131: line longer than 100 chars
2019-08-09T19:05:48.4146041Z tidy error: /checkout/src/librustc_mir/dataflow/move_paths/builder.rs:132: line longer than 100 chars
2019-08-09T19:05:48.4146266Z tidy error: /checkout/src/librustc_mir/dataflow/move_paths/builder.rs:133: line longer than 100 chars
2019-08-09T19:05:48.4146473Z tidy error: /checkout/src/librustc_mir/dataflow/move_paths/builder.rs:134: line longer than 100 chars
2019-08-09T19:05:48.4146662Z tidy error: /checkout/src/librustc_mir/dataflow/move_paths/builder.rs:137: line longer than 100 chars
2019-08-09T19:05:48.4146834Z tidy error: /checkout/src/librustc_mir/dataflow/move_paths/builder.rs:138: line longer than 100 chars
2019-08-09T19:05:48.4147004Z tidy error: /checkout/src/librustc_mir/dataflow/move_paths/builder.rs:139: line longer than 100 chars
2019-08-09T19:05:48.4147416Z tidy error: /checkout/src/librustc_mir/dataflow/move_paths/builder.rs:141: line longer than 100 chars
2019-08-09T19:05:48.4147643Z tidy error: /checkout/src/librustc_mir/dataflow/move_paths/builder.rs:142: line longer than 100 chars
2019-08-09T19:05:48.4147837Z tidy error: /checkout/src/librustc_mir/dataflow/move_paths/builder.rs:145: line longer than 100 chars
2019-08-09T19:05:48.4170834Z tidy error: /checkout/src/librustc_mir/borrow_check/move_errors.rs:314: line longer than 100 chars
2019-08-09T19:05:48.4275590Z tidy error: /checkout/src/librustc_mir/borrow_check/prefixes.rs:156: line longer than 100 chars
2019-08-09T19:05:48.4275717Z tidy error: /checkout/src/librustc_mir/borrow_check/places_conflict.rs:162: line longer than 100 chars
2019-08-09T19:05:48.4275792Z tidy error: /checkout/src/librustc_mir/borrow_check/places_conflict.rs:180: line longer than 100 chars
2019-08-09T19:05:48.4275861Z tidy error: /checkout/src/librustc_mir/borrow_check/places_conflict.rs:211: line longer than 100 chars
2019-08-09T19:05:48.4276175Z tidy error: /checkout/src/librustc_mir/borrow_check/places_conflict.rs:292: line longer than 100 chars
2019-08-09T19:05:48.4310419Z tidy error: /checkout/src/librustc_mir/transform/qualify_consts.rs:826: line longer than 100 chars
2019-08-09T19:05:48.8498312Z tidy error: /checkout/src/librustc/mir/visit.rs:698: line longer than 100 chars
2019-08-09T19:05:50.0183022Z some tidy checks failed
2019-08-09T19:05:50.0187925Z 
2019-08-09T19:05:50.0187925Z 
2019-08-09T19:05:50.0188780Z command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/tidy" "/checkout/src" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "--no-vendor"
2019-08-09T19:05:50.0188925Z 
2019-08-09T19:05:50.0188951Z 
2019-08-09T19:05:50.0203994Z failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test src/tools/tidy
2019-08-09T19:05:50.0204086Z Build completed unsuccessfully in 0:01:34
2019-08-09T19:05:50.0204086Z Build completed unsuccessfully in 0:01:34
2019-08-09T19:05:51.3409270Z ##[error]Bash exited with code '1'.
2019-08-09T19:05:51.3444948Z ##[section]Starting: Checkout
2019-08-09T19:05:51.3446734Z ==============================================================================
2019-08-09T19:05:51.3446812Z Task         : Get sources
2019-08-09T19:05:51.3446865Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@@ -1553,7 +1552,7 @@ pub struct Statement<'tcx> {

// `Statement` is used a lot. Make sure it doesn't unintentionally get bigger.
#[cfg(target_arch = "x86_64")]
static_assert_size!(Statement<'_>, 56);
static_assert_size!(Statement<'_>, 64);

impl<'tcx> Statement<'tcx> {

This comment has been minimized.

Copy link
@Centril

Centril Aug 10, 2019

Member
Suggested change
impl<'tcx> Statement<'tcx> {
impl Statement<'_> {

Drive by :)

}

impl<'p, 'tcx> FusedIterator for ProjectionsIter<'p, 'tcx> {}

impl<'tcx> Debug for Place<'tcx> {

This comment has been minimized.

Copy link
@Centril

Centril Aug 10, 2019

Member
Suggested change
impl<'tcx> Debug for Place<'tcx> {
impl Debug for Place<'_> {

This comment has been minimized.

Copy link
@oli-obk

oli-obk Aug 13, 2019

Contributor

No drive by cleanups in a 2k change pr please

This comment has been minimized.

Copy link
@Centril

Centril Aug 13, 2019

Member

Heh fair :)

This comment has been minimized.

Copy link
@spastorino

spastorino Aug 13, 2019

Author Member

Anyway, it's still good to point these things out. I'm probably going to place a different PR for those ;).

for proj in place_projections {
place_ty = place_ty.projection_ty(tcx, &proj.elem);
}
for elem in projection.iter().rev() {

This comment has been minimized.

Copy link
@Centril

Centril Aug 10, 2019

Member
Suggested change
for elem in projection.iter().rev() {
projection.iter().rev().fold(
base.ty(local_decls),
|place_ty, elem| place_ty.projection_ty(tcx, elem)
)
match elem {
ProjectionElem::Deref => {
}
ProjectionElem::Subslice { from: _, to: _ } => {

This comment has been minimized.

Copy link
@Centril

Centril Aug 10, 2019

Member

Join this arm's pattern with the one above since the bodies are the same.

location
);
}
ProjectionElem::ConstantIndex { offset: _,

This comment has been minimized.

Copy link
@Centril

Centril Aug 10, 2019

Member

Also join the two arms above with the first arm.

projection: box [.., elem],
}) = rvalue {
if *elem == ProjectionElem::Deref {
// FIXME remove this once we can use slices patterns

This comment has been minimized.

Copy link
@Centril

Centril Aug 10, 2019

Member
Suggested change
// FIXME remove this once we can use slices patterns
// FIXME: cfg(bootstrap) -- remove this once we can use slice patterns
@@ -184,26 +184,27 @@ trait Qualif {
cx: &ConstCx<'_, 'tcx>,
place: PlaceRef<'_, 'tcx>,
) -> bool {
let proj = place.projection.as_ref().unwrap();
let elem = &place.projection[place.projection.len() - 1];

This comment has been minimized.

Copy link
@Centril

Centril Aug 10, 2019

Member

Invent a function to split a slice into [init @ .., last]? (this idea is repeated a few times in this PR...)

let mut reborrow_place: &[PlaceElem<'tcx>] = &[];
if let box [.., elem] = &place.projection {
if *elem == ProjectionElem::Deref {
let proj_base = &place.projection[..place.projection.len() - 1];

This comment has been minimized.

Copy link
@Centril

Centril Aug 10, 2019

Member
Suggested change
let proj_base = &place.projection[..place.projection.len() - 1];
// FIXME: cfg(bootstrap) -- include in pattern with new bootstrap compiler
let proj_base = &place.projection[..place.projection.len() - 1];
@@ -61,14 +61,16 @@ impl<'a, 'tcx> Visitor<'tcx> for UniformArrayMoveOutVisitor<'a, 'tcx> {
rvalue: &Rvalue<'tcx>,
location: Location) {
if let Rvalue::Use(Operand::Move(ref src_place)) = rvalue {
if let Some(ref proj) = src_place.projection {
if let box [.., elem] = &src_place.projection {
let proj_base = &src_place.projection[..src_place.projection.len() - 1];

This comment has been minimized.

Copy link
@Centril

Centril Aug 10, 2019

Member
Suggested change
let proj_base = &src_place.projection[..src_place.projection.len() - 1];
// FIXME: cfg(bootstrap) -- include in pattern with new bootstrap compiler
let proj_base = &src_place.projection[..src_place.projection.len() - 1];
}],
})),
) = &statement.kind {
// FIXME remove once we can use slices patterns

This comment has been minimized.

Copy link
@Centril

Centril Aug 10, 2019

Member
Suggested change
// FIXME remove once we can use slices patterns
// FIXME: cfg(bootstrap) -- remove once we can use slice patterns

@spastorino spastorino force-pushed the spastorino:place2_5 branch from 6167608 to d384b63 Aug 13, 2019

@rust-highfive

This comment has been minimized.

Copy link
Collaborator

commented Aug 13, 2019

The job x86_64-gnu-llvm-6.0 of your PR failed (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
2019-08-13T15:26:17.6897599Z ##[command]git remote add origin https://github.com/rust-lang/rust
2019-08-13T15:26:17.7058682Z ##[command]git config gc.auto 0
2019-08-13T15:26:17.7132420Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2019-08-13T15:26:17.7195444Z ##[command]git config --get-all http.proxy
2019-08-13T15:26:17.7345722Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/63420/merge:refs/remotes/pull/63420/merge
---
2019-08-13T15:26:53.0664207Z do so (now or later) by using -b with the checkout command again. Example:
2019-08-13T15:26:53.0664803Z 
2019-08-13T15:26:53.0666121Z   git checkout -b <new-branch-name>
2019-08-13T15:26:53.0666926Z 
2019-08-13T15:26:53.0668851Z HEAD is now at 976bbd9ee Merge d384b63ccce9203761004da18bd88f5a47190cd5 into 60960a260f7b5c695fd0717311d72ce62dd4eb43
2019-08-13T15:26:53.0818216Z ##[section]Starting: Collect CPU-usage statistics in the background
2019-08-13T15:26:53.0821374Z ==============================================================================
2019-08-13T15:26:53.0821433Z Task         : Bash
2019-08-13T15:26:53.0821479Z Description  : Run a Bash script on macOS, Linux, or Windows
---
2019-08-13T15:32:47.8135364Z    Compiling serde_json v1.0.40
2019-08-13T15:32:51.9386855Z    Compiling tidy v0.1.0 (/checkout/src/tools/tidy)
2019-08-13T15:33:00.2549408Z     Finished release [optimized] target(s) in 1m 26s
2019-08-13T15:33:00.2618302Z tidy check
2019-08-13T15:33:00.7231889Z tidy error: /checkout/src/librustc_mir/build/expr/as_rvalue.rs:524: line longer than 100 chars
2019-08-13T15:33:00.7257419Z tidy error: /checkout/src/librustc_mir/dataflow/move_paths/builder.rs:122: line longer than 100 chars
2019-08-13T15:33:00.7257501Z tidy error: /checkout/src/librustc_mir/dataflow/move_paths/builder.rs:125: line longer than 100 chars
2019-08-13T15:33:00.7257583Z tidy error: /checkout/src/librustc_mir/dataflow/move_paths/builder.rs:126: line longer than 100 chars
2019-08-13T15:33:00.7267408Z tidy error: /checkout/src/librustc_mir/dataflow/move_paths/builder.rs:127: line longer than 100 chars
2019-08-13T15:33:00.7267487Z tidy error: /checkout/src/librustc_mir/dataflow/move_paths/builder.rs:129: line longer than 100 chars
2019-08-13T15:33:00.7267613Z tidy error: /checkout/src/librustc_mir/dataflow/move_paths/builder.rs:131: line longer than 100 chars
2019-08-13T15:33:00.7267684Z tidy error: /checkout/src/librustc_mir/dataflow/move_paths/builder.rs:132: line longer than 100 chars
2019-08-13T15:33:00.7267739Z tidy error: /checkout/src/librustc_mir/dataflow/move_paths/builder.rs:133: line longer than 100 chars
2019-08-13T15:33:00.7267813Z tidy error: /checkout/src/librustc_mir/dataflow/move_paths/builder.rs:134: line longer than 100 chars
2019-08-13T15:33:00.7267867Z tidy error: /checkout/src/librustc_mir/dataflow/move_paths/builder.rs:137: line longer than 100 chars
2019-08-13T15:33:00.7267936Z tidy error: /checkout/src/librustc_mir/dataflow/move_paths/builder.rs:138: line longer than 100 chars
2019-08-13T15:33:00.7267996Z tidy error: /checkout/src/librustc_mir/dataflow/move_paths/builder.rs:139: line longer than 100 chars
2019-08-13T15:33:00.7268247Z tidy error: /checkout/src/librustc_mir/dataflow/move_paths/builder.rs:141: line longer than 100 chars
2019-08-13T15:33:00.7268322Z tidy error: /checkout/src/librustc_mir/dataflow/move_paths/builder.rs:142: line longer than 100 chars
2019-08-13T15:33:00.7268387Z tidy error: /checkout/src/librustc_mir/dataflow/move_paths/builder.rs:145: line longer than 100 chars
2019-08-13T15:33:00.7290793Z tidy error: /checkout/src/librustc_mir/borrow_check/move_errors.rs:314: line longer than 100 chars
2019-08-13T15:33:00.7374499Z tidy error: /checkout/src/librustc_mir/borrow_check/prefixes.rs:156: line longer than 100 chars
2019-08-13T15:33:00.7379211Z tidy error: /checkout/src/librustc_mir/borrow_check/places_conflict.rs:162: line longer than 100 chars
2019-08-13T15:33:00.7379311Z tidy error: /checkout/src/librustc_mir/borrow_check/places_conflict.rs:180: line longer than 100 chars
2019-08-13T15:33:00.7379372Z tidy error: /checkout/src/librustc_mir/borrow_check/places_conflict.rs:211: line longer than 100 chars
2019-08-13T15:33:00.7379441Z tidy error: /checkout/src/librustc_mir/borrow_check/places_conflict.rs:292: line longer than 100 chars
2019-08-13T15:33:00.7408302Z tidy error: /checkout/src/librustc_mir/transform/qualify_consts.rs:826: line longer than 100 chars
2019-08-13T15:33:01.0999687Z tidy error: /checkout/src/librustc/mir/visit.rs:698: line longer than 100 chars
2019-08-13T15:33:02.1418038Z some tidy checks failed
2019-08-13T15:33:02.1418846Z 
2019-08-13T15:33:02.1418846Z 
2019-08-13T15:33:02.1420360Z command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/tidy" "/checkout/src" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "--no-vendor"
2019-08-13T15:33:02.1420543Z 
2019-08-13T15:33:02.1420572Z 
2019-08-13T15:33:02.1427907Z failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test src/tools/tidy
2019-08-13T15:33:02.1428223Z Build completed unsuccessfully in 0:01:29
2019-08-13T15:33:02.1428223Z Build completed unsuccessfully in 0:01:29
2019-08-13T15:33:03.4262458Z ##[error]Bash exited with code '1'.
2019-08-13T15:33:03.4294423Z ##[section]Starting: Checkout
2019-08-13T15:33:03.4295853Z ==============================================================================
2019-08-13T15:33:03.4295897Z Task         : Get sources
2019-08-13T15:33:03.4295952Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@rust-highfive

This comment has been minimized.

Copy link
Collaborator

commented Aug 13, 2019

The job x86_64-gnu-llvm-6.0 of your PR failed (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
2019-08-13T16:26:34.8951060Z ##[command]git remote add origin https://github.com/rust-lang/rust
2019-08-13T16:26:34.9144223Z ##[command]git config gc.auto 0
2019-08-13T16:26:34.9225964Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2019-08-13T16:26:34.9302426Z ##[command]git config --get-all http.proxy
2019-08-13T16:26:34.9429028Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/63420/merge:refs/remotes/pull/63420/merge
---
2019-08-13T16:27:09.6084022Z do so (now or later) by using -b with the checkout command again. Example:
2019-08-13T16:27:09.6084054Z 
2019-08-13T16:27:09.6084274Z   git checkout -b <new-branch-name>
2019-08-13T16:27:09.6084304Z 
2019-08-13T16:27:09.6084352Z HEAD is now at ccedcbf60 Merge 60f80e7ea570cda669f2eb67bbbdc78397f81322 into 60960a260f7b5c695fd0717311d72ce62dd4eb43
2019-08-13T16:27:09.6232317Z ##[section]Starting: Collect CPU-usage statistics in the background
2019-08-13T16:27:09.6235650Z ==============================================================================
2019-08-13T16:27:09.6235710Z Task         : Bash
2019-08-13T16:27:09.6235758Z Description  : Run a Bash script on macOS, Linux, or Windows
---
2019-08-13T16:33:01.7818769Z    Compiling serde_json v1.0.40
2019-08-13T16:33:06.3466365Z    Compiling tidy v0.1.0 (/checkout/src/tools/tidy)
2019-08-13T16:33:15.2745438Z     Finished release [optimized] target(s) in 1m 33s
2019-08-13T16:33:15.2822378Z tidy check
2019-08-13T16:33:15.7105603Z tidy error: /checkout/src/librustc_mir/build/expr/as_rvalue.rs:524: line longer than 100 chars
2019-08-13T16:33:15.7125831Z tidy error: /checkout/src/librustc_mir/dataflow/move_paths/builder.rs:122: line longer than 100 chars
2019-08-13T16:33:15.7125939Z tidy error: /checkout/src/librustc_mir/dataflow/move_paths/builder.rs:125: line longer than 100 chars
2019-08-13T16:33:15.7126030Z tidy error: /checkout/src/librustc_mir/dataflow/move_paths/builder.rs:126: line longer than 100 chars
2019-08-13T16:33:15.7126082Z tidy error: /checkout/src/librustc_mir/dataflow/move_paths/builder.rs:127: line longer than 100 chars
2019-08-13T16:33:15.7126134Z tidy error: /checkout/src/librustc_mir/dataflow/move_paths/builder.rs:129: line longer than 100 chars
2019-08-13T16:33:15.7126201Z tidy error: /checkout/src/librustc_mir/dataflow/move_paths/builder.rs:131: line longer than 100 chars
2019-08-13T16:33:15.7126254Z tidy error: /checkout/src/librustc_mir/dataflow/move_paths/builder.rs:132: line longer than 100 chars
2019-08-13T16:33:15.7126305Z tidy error: /checkout/src/librustc_mir/dataflow/move_paths/builder.rs:133: line longer than 100 chars
2019-08-13T16:33:15.7126375Z tidy error: /checkout/src/librustc_mir/dataflow/move_paths/builder.rs:134: line longer than 100 chars
2019-08-13T16:33:15.7126432Z tidy error: /checkout/src/librustc_mir/dataflow/move_paths/builder.rs:137: line longer than 100 chars
2019-08-13T16:33:15.7126666Z tidy error: /checkout/src/librustc_mir/dataflow/move_paths/builder.rs:138: line longer than 100 chars
2019-08-13T16:33:15.7126747Z tidy error: /checkout/src/librustc_mir/dataflow/move_paths/builder.rs:139: line longer than 100 chars
2019-08-13T16:33:15.7126799Z tidy error: /checkout/src/librustc_mir/dataflow/move_paths/builder.rs:141: line longer than 100 chars
2019-08-13T16:33:15.7126850Z tidy error: /checkout/src/librustc_mir/dataflow/move_paths/builder.rs:142: line longer than 100 chars
2019-08-13T16:33:15.7127100Z tidy error: /checkout/src/librustc_mir/dataflow/move_paths/builder.rs:145: line longer than 100 chars
2019-08-13T16:33:15.7156750Z tidy error: /checkout/src/librustc_mir/borrow_check/move_errors.rs:314: line longer than 100 chars
2019-08-13T16:33:15.7255097Z tidy error: /checkout/src/librustc_mir/borrow_check/prefixes.rs:156: line longer than 100 chars
2019-08-13T16:33:15.7255210Z tidy error: /checkout/src/librustc_mir/borrow_check/places_conflict.rs:162: line longer than 100 chars
2019-08-13T16:33:15.7255284Z tidy error: /checkout/src/librustc_mir/borrow_check/places_conflict.rs:180: line longer than 100 chars
2019-08-13T16:33:15.7255340Z tidy error: /checkout/src/librustc_mir/borrow_check/places_conflict.rs:211: line longer than 100 chars
2019-08-13T16:33:15.7255410Z tidy error: /checkout/src/librustc_mir/borrow_check/places_conflict.rs:292: line longer than 100 chars
2019-08-13T16:33:15.7286159Z tidy error: /checkout/src/librustc_mir/transform/qualify_consts.rs:826: line longer than 100 chars
2019-08-13T16:33:16.1130225Z tidy error: /checkout/src/librustc/mir/visit.rs:698: line longer than 100 chars
2019-08-13T16:33:17.1761840Z some tidy checks failed
2019-08-13T16:33:17.1763280Z 
2019-08-13T16:33:17.1763280Z 
2019-08-13T16:33:17.1764664Z command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/tidy" "/checkout/src" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "--no-vendor"
2019-08-13T16:33:17.1765024Z 
2019-08-13T16:33:17.1765062Z 
2019-08-13T16:33:17.1774849Z failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test src/tools/tidy
2019-08-13T16:33:17.1775157Z Build completed unsuccessfully in 0:01:36
2019-08-13T16:33:17.1775157Z Build completed unsuccessfully in 0:01:36
2019-08-13T16:33:18.5310166Z ##[error]Bash exited with code '1'.
2019-08-13T16:33:18.5343306Z ##[section]Starting: Checkout
2019-08-13T16:33:18.5345232Z ==============================================================================
2019-08-13T16:33:18.5345463Z Task         : Get sources
2019-08-13T16:33:18.5345521Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@spastorino spastorino force-pushed the spastorino:place2_5 branch from 60f80e7 to bf23ce8 Aug 13, 2019

@rust-highfive

This comment has been minimized.

Copy link
Collaborator

commented Aug 14, 2019

The job x86_64-gnu-llvm-6.0 of your PR failed (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
2019-08-14T15:24:03.9809397Z ##[command]git remote add origin https://github.com/rust-lang/rust
2019-08-14T15:24:03.9985087Z ##[command]git config gc.auto 0
2019-08-14T15:24:04.0073741Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2019-08-14T15:24:04.0140884Z ##[command]git config --get-all http.proxy
2019-08-14T15:24:04.0296882Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/63420/merge:refs/remotes/pull/63420/merge
---
2019-08-14T15:24:41.4227751Z do so (now or later) by using -b with the checkout command again. Example:
2019-08-14T15:24:41.4227781Z 
2019-08-14T15:24:41.4227992Z   git checkout -b <new-branch-name>
2019-08-14T15:24:41.4228019Z 
2019-08-14T15:24:41.4228064Z HEAD is now at e51c2bcad Merge 33e24d8b515b80eef47d0aa7048a7a5d28f8aa26 into c43d03a19f326f4a323569328cc501e86eb6d22e
2019-08-14T15:24:41.4386056Z ##[section]Starting: Collect CPU-usage statistics in the background
2019-08-14T15:24:41.4389043Z ==============================================================================
2019-08-14T15:24:41.4389100Z Task         : Bash
2019-08-14T15:24:41.4389147Z Description  : Run a Bash script on macOS, Linux, or Windows
---
2019-08-14T15:31:05.7850305Z    Compiling serde_json v1.0.40
2019-08-14T15:31:10.5104353Z    Compiling tidy v0.1.0 (/checkout/src/tools/tidy)
2019-08-14T15:31:19.6355771Z     Finished release [optimized] target(s) in 1m 35s
2019-08-14T15:31:19.6429573Z tidy check
2019-08-14T15:31:20.0740212Z tidy error: /checkout/src/librustc_mir/build/expr/as_rvalue.rs:524: line longer than 100 chars
2019-08-14T15:31:20.0740375Z tidy error: /checkout/src/librustc_mir/dataflow/move_paths/builder.rs:122: line longer than 100 chars
2019-08-14T15:31:20.0740511Z tidy error: /checkout/src/librustc_mir/dataflow/move_paths/builder.rs:125: line longer than 100 chars
2019-08-14T15:31:20.0740569Z tidy error: /checkout/src/librustc_mir/dataflow/move_paths/builder.rs:126: line longer than 100 chars
2019-08-14T15:31:20.0740625Z tidy error: /checkout/src/librustc_mir/dataflow/move_paths/builder.rs:127: line longer than 100 chars
2019-08-14T15:31:20.0740700Z tidy error: /checkout/src/librustc_mir/dataflow/move_paths/builder.rs:129: line longer than 100 chars
2019-08-14T15:31:20.0740755Z tidy error: /checkout/src/librustc_mir/dataflow/move_paths/builder.rs:131: line longer than 100 chars
2019-08-14T15:31:20.0740810Z tidy error: /checkout/src/librustc_mir/dataflow/move_paths/builder.rs:132: line longer than 100 chars
2019-08-14T15:31:20.0740884Z tidy error: /checkout/src/librustc_mir/dataflow/move_paths/builder.rs:133: line longer than 100 chars
2019-08-14T15:31:20.0740946Z tidy error: /checkout/src/librustc_mir/dataflow/move_paths/builder.rs:134: line longer than 100 chars
2019-08-14T15:31:20.0741008Z tidy error: /checkout/src/librustc_mir/dataflow/move_paths/builder.rs:137: line longer than 100 chars
2019-08-14T15:31:20.0741081Z tidy error: /checkout/src/librustc_mir/dataflow/move_paths/builder.rs:138: line longer than 100 chars
2019-08-14T15:31:20.0741136Z tidy error: /checkout/src/librustc_mir/dataflow/move_paths/builder.rs:139: line longer than 100 chars
2019-08-14T15:31:20.0741190Z tidy error: /checkout/src/librustc_mir/dataflow/move_paths/builder.rs:141: line longer than 100 chars
2019-08-14T15:31:20.0741263Z tidy error: /checkout/src/librustc_mir/dataflow/move_paths/builder.rs:142: line longer than 100 chars
2019-08-14T15:31:20.0741481Z tidy error: /checkout/src/librustc_mir/dataflow/move_paths/builder.rs:145: line longer than 100 chars
2019-08-14T15:31:20.0747397Z tidy error: /checkout/src/librustc_mir/borrow_check/move_errors.rs:314: line longer than 100 chars
2019-08-14T15:31:20.0847327Z tidy error: /checkout/src/librustc_mir/borrow_check/prefixes.rs:156: line longer than 100 chars
2019-08-14T15:31:20.0847450Z tidy error: /checkout/src/librustc_mir/borrow_check/places_conflict.rs:162: line longer than 100 chars
2019-08-14T15:31:20.0847537Z tidy error: /checkout/src/librustc_mir/borrow_check/places_conflict.rs:180: line longer than 100 chars
2019-08-14T15:31:20.0847597Z tidy error: /checkout/src/librustc_mir/borrow_check/places_conflict.rs:211: line longer than 100 chars
2019-08-14T15:31:20.0847655Z tidy error: /checkout/src/librustc_mir/borrow_check/places_conflict.rs:292: line longer than 100 chars
2019-08-14T15:31:20.0880680Z tidy error: /checkout/src/librustc_mir/transform/qualify_consts.rs:826: line longer than 100 chars
2019-08-14T15:31:20.5236130Z tidy error: /checkout/src/librustc/mir/visit.rs:698: line longer than 100 chars
2019-08-14T15:31:21.7527244Z some tidy checks failed
2019-08-14T15:31:21.7528574Z 
2019-08-14T15:31:21.7528574Z 
2019-08-14T15:31:21.7530165Z command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/tidy" "/checkout/src" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "--no-vendor"
2019-08-14T15:31:21.7531079Z 
2019-08-14T15:31:21.7531187Z 
2019-08-14T15:31:21.7541259Z failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test src/tools/tidy
2019-08-14T15:31:21.7541541Z Build completed unsuccessfully in 0:01:38
2019-08-14T15:31:21.7541541Z Build completed unsuccessfully in 0:01:38
2019-08-14T15:31:21.7598859Z == clock drift check ==
2019-08-14T15:31:21.7607773Z   local time: Wed Aug 14 15:31:21 UTC 2019
2019-08-14T15:31:21.9205496Z   network time: Wed, 14 Aug 2019 15:31:21 GMT
2019-08-14T15:31:21.9205667Z == end clock drift check ==
2019-08-14T15:31:24.0464697Z ##[error]Bash exited with code '1'.
2019-08-14T15:31:24.0497871Z ##[section]Starting: Checkout
2019-08-14T15:31:24.0499492Z ==============================================================================
2019-08-14T15:31:24.0499558Z Task         : Get sources
2019-08-14T15:31:24.0499619Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@spastorino spastorino force-pushed the spastorino:place2_5 branch from 33e24d8 to c6dead0 Aug 14, 2019

@@ -105,7 +105,10 @@ impl<Bx: BuilderMethods<'a, 'tcx>> LocalAnalyzer<'mir, 'a, 'tcx, Bx> {
) {
let cx = self.fx.cx;

if let Some(proj) = place_ref.projection {
if let [.., elem] = place_ref.projection {

This comment has been minimized.

Copy link
@oli-obk

oli-obk Aug 14, 2019

Contributor

Use split_last

from_end: _ } => {
}
ProjectionElem::Downcast(_name, _variant_index) => {
for elem in projection {

This comment has been minimized.

Copy link
@oli-obk

oli-obk Aug 14, 2019

Contributor

Not recursing is a change in behaviour that's likely going to break things. Keep the recursion for now

@rust-highfive

This comment has been minimized.

Copy link
Collaborator

commented Aug 14, 2019

The job x86_64-gnu-llvm-6.0 of your PR failed (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
2019-08-14T16:23:10.2199607Z ##[command]git remote add origin https://github.com/rust-lang/rust
2019-08-14T16:23:10.2383149Z ##[command]git config gc.auto 0
2019-08-14T16:23:11.0195915Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2019-08-14T16:23:11.0206458Z ##[command]git config --get-all http.proxy
2019-08-14T16:23:11.0212755Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/63420/merge:refs/remotes/pull/63420/merge
---
2019-08-14T16:23:45.6182977Z do so (now or later) by using -b with the checkout command again. Example:
2019-08-14T16:23:45.6183040Z 
2019-08-14T16:23:45.6183264Z   git checkout -b <new-branch-name>
2019-08-14T16:23:45.6183294Z 
2019-08-14T16:23:45.6183341Z HEAD is now at ad82b65fa Merge c6dead04371f736a1098ad395d637ec237eafa74 into c43d03a19f326f4a323569328cc501e86eb6d22e
2019-08-14T16:23:45.6330948Z ##[section]Starting: Collect CPU-usage statistics in the background
2019-08-14T16:23:45.6334348Z ==============================================================================
2019-08-14T16:23:45.6334405Z Task         : Bash
2019-08-14T16:23:45.6334450Z Description  : Run a Bash script on macOS, Linux, or Windows
---
2019-08-14T16:29:31.5699346Z    Compiling serde_json v1.0.40
2019-08-14T16:29:35.7562094Z    Compiling tidy v0.1.0 (/checkout/src/tools/tidy)
2019-08-14T16:29:44.2501859Z     Finished release [optimized] target(s) in 1m 27s
2019-08-14T16:29:44.2569136Z tidy check
2019-08-14T16:29:44.6608571Z tidy error: /checkout/src/librustc_mir/build/expr/as_rvalue.rs:524: line longer than 100 chars
2019-08-14T16:29:44.6630257Z tidy error: /checkout/src/librustc_mir/dataflow/move_paths/builder.rs:122: line longer than 100 chars
2019-08-14T16:29:44.6630344Z tidy error: /checkout/src/librustc_mir/dataflow/move_paths/builder.rs:125: line longer than 100 chars
2019-08-14T16:29:44.6630428Z tidy error: /checkout/src/librustc_mir/dataflow/move_paths/builder.rs:126: line longer than 100 chars
2019-08-14T16:29:44.6630514Z tidy error: /checkout/src/librustc_mir/dataflow/move_paths/builder.rs:127: line longer than 100 chars
2019-08-14T16:29:44.6630581Z tidy error: /checkout/src/librustc_mir/dataflow/move_paths/builder.rs:129: line longer than 100 chars
2019-08-14T16:29:44.6630658Z tidy error: /checkout/src/librustc_mir/dataflow/move_paths/builder.rs:131: line longer than 100 chars
2019-08-14T16:29:44.6630715Z tidy error: /checkout/src/librustc_mir/dataflow/move_paths/builder.rs:132: line longer than 100 chars
2019-08-14T16:29:44.6630786Z tidy error: /checkout/src/librustc_mir/dataflow/move_paths/builder.rs:133: line longer than 100 chars
2019-08-14T16:29:44.6630843Z tidy error: /checkout/src/librustc_mir/dataflow/move_paths/builder.rs:134: line longer than 100 chars
2019-08-14T16:29:44.6630899Z tidy error: /checkout/src/librustc_mir/dataflow/move_paths/builder.rs:137: line longer than 100 chars
2019-08-14T16:29:44.6630971Z tidy error: /checkout/src/librustc_mir/dataflow/move_paths/builder.rs:138: line longer than 100 chars
2019-08-14T16:29:44.6631338Z tidy error: /checkout/src/librustc_mir/dataflow/move_paths/builder.rs:139: line longer than 100 chars
2019-08-14T16:29:44.6631404Z tidy error: /checkout/src/librustc_mir/dataflow/move_paths/builder.rs:141: line longer than 100 chars
2019-08-14T16:29:44.6631475Z tidy error: /checkout/src/librustc_mir/dataflow/move_paths/builder.rs:142: line longer than 100 chars
2019-08-14T16:29:44.6631532Z tidy error: /checkout/src/librustc_mir/dataflow/move_paths/builder.rs:145: line longer than 100 chars
2019-08-14T16:29:44.6661109Z tidy error: /checkout/src/librustc_mir/borrow_check/move_errors.rs:314: line longer than 100 chars
2019-08-14T16:29:44.6764775Z tidy error: /checkout/src/librustc_mir/borrow_check/prefixes.rs:156: line longer than 100 chars
2019-08-14T16:29:44.6764889Z tidy error: /checkout/src/librustc_mir/borrow_check/places_conflict.rs:162: line longer than 100 chars
2019-08-14T16:29:44.6803296Z tidy error: /checkout/src/librustc_mir/borrow_check/places_conflict.rs:180: line longer than 100 chars
2019-08-14T16:29:44.6825715Z tidy error: /checkout/src/librustc_mir/borrow_check/places_conflict.rs:211: line longer than 100 chars
2019-08-14T16:29:44.6826113Z tidy error: /checkout/src/librustc_mir/borrow_check/places_conflict.rs:292: line longer than 100 chars
2019-08-14T16:29:44.6826303Z tidy error: /checkout/src/librustc_mir/transform/qualify_consts.rs:826: line longer than 100 chars
2019-08-14T16:29:45.0700866Z tidy error: /checkout/src/librustc/mir/visit.rs:698: line longer than 100 chars
2019-08-14T16:29:46.1795222Z some tidy checks failed
2019-08-14T16:29:46.1795394Z 
2019-08-14T16:29:46.1795394Z 
2019-08-14T16:29:46.1796291Z command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/tidy" "/checkout/src" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "--no-vendor"
2019-08-14T16:29:46.1796420Z 
2019-08-14T16:29:46.1796474Z 
2019-08-14T16:29:46.1803751Z failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test src/tools/tidy
2019-08-14T16:29:46.1803843Z Build completed unsuccessfully in 0:01:30
2019-08-14T16:29:46.1803843Z Build completed unsuccessfully in 0:01:30
2019-08-14T16:29:46.1851384Z == clock drift check ==
2019-08-14T16:29:46.1862183Z   local time: Wed Aug 14 16:29:46 UTC 2019
2019-08-14T16:29:46.4634165Z   network time: Wed, 14 Aug 2019 16:29:46 GMT
2019-08-14T16:29:46.4634275Z == end clock drift check ==
2019-08-14T16:29:47.8125953Z ##[error]Bash exited with code '1'.
2019-08-14T16:29:47.8156777Z ##[section]Starting: Checkout
2019-08-14T16:29:47.8158339Z ==============================================================================
2019-08-14T16:29:47.8158388Z Task         : Get sources
2019-08-14T16:29:47.8158428Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@@ -437,7 +437,7 @@ impl<'a, 'tcx, Bx: BuilderMethods<'a, 'tcx>> FunctionCx<'a, 'tcx, Bx> {
let result = match &place_ref {

This comment has been minimized.

Copy link
@oli-obk

oli-obk Aug 14, 2019

Contributor

You could match on (&place_ref.base, place_ref.projection.split_last()) here in order to simplify the later patterns

elem: ProjectionElem::Deref,
}),
projection: [..,
ProjectionElem::Deref,

This comment has been minimized.

Copy link
@oli-obk

oli-obk Aug 14, 2019

Contributor

🎉

})
// Reborrow of already borrowed data is ignored
// Any errors will be caught on the initial borrow
place.projection.iter().find(|&elem| *elem == ProjectionElem::Deref).is_none()

This comment has been minimized.

Copy link
@oli-obk

oli-obk Aug 14, 2019

Contributor

Use any instead of find

@spastorino spastorino force-pushed the spastorino:place2_5 branch from c6dead0 to 1ef4cfe Aug 14, 2019

@rust-highfive

This comment has been minimized.

Copy link
Collaborator

commented Aug 14, 2019

The job x86_64-gnu-llvm-6.0 of your PR failed (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
2019-08-14T18:34:13.4334937Z ##[command]git remote add origin https://github.com/rust-lang/rust
2019-08-14T18:34:13.4485273Z ##[command]git config gc.auto 0
2019-08-14T18:34:13.4560007Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2019-08-14T18:34:13.4612552Z ##[command]git config --get-all http.proxy
2019-08-14T18:34:13.4745391Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/63420/merge:refs/remotes/pull/63420/merge
---
2019-08-14T18:34:49.6053873Z do so (now or later) by using -b with the checkout command again. Example:
2019-08-14T18:34:49.6053951Z 
2019-08-14T18:34:49.6054534Z   git checkout -b <new-branch-name>
2019-08-14T18:34:49.6054615Z 
2019-08-14T18:34:49.6054700Z HEAD is now at f92dd7233 Merge 1ef4cfe61b0e465f12ecc87d2fdf3d4fabf76d3c into c43d03a19f326f4a323569328cc501e86eb6d22e
2019-08-14T18:34:49.6213373Z ##[section]Starting: Collect CPU-usage statistics in the background
2019-08-14T18:34:49.6216992Z ==============================================================================
2019-08-14T18:34:49.6217062Z Task         : Bash
2019-08-14T18:34:49.6217134Z Description  : Run a Bash script on macOS, Linux, or Windows
---
2019-08-14T18:40:47.4864473Z    Compiling serde_json v1.0.40
2019-08-14T18:40:51.7450554Z    Compiling tidy v0.1.0 (/checkout/src/tools/tidy)
2019-08-14T18:41:00.4586628Z     Finished release [optimized] target(s) in 1m 29s
2019-08-14T18:41:00.4656144Z tidy check
2019-08-14T18:41:00.8946868Z tidy error: /checkout/src/librustc_mir/build/expr/as_rvalue.rs:524: line longer than 100 chars
2019-08-14T18:41:00.8965832Z tidy error: /checkout/src/librustc_mir/dataflow/move_paths/builder.rs:122: line longer than 100 chars
2019-08-14T18:41:00.8966846Z tidy error: /checkout/src/librustc_mir/dataflow/move_paths/builder.rs:125: line longer than 100 chars
2019-08-14T18:41:00.8966951Z tidy error: /checkout/src/librustc_mir/dataflow/move_paths/builder.rs:126: line longer than 100 chars
2019-08-14T18:41:00.8967022Z tidy error: /checkout/src/librustc_mir/dataflow/move_paths/builder.rs:127: line longer than 100 chars
2019-08-14T18:41:00.8967092Z tidy error: /checkout/src/librustc_mir/dataflow/move_paths/builder.rs:129: line longer than 100 chars
2019-08-14T18:41:00.8967179Z tidy error: /checkout/src/librustc_mir/dataflow/move_paths/builder.rs:131: line longer than 100 chars
2019-08-14T18:41:00.8967266Z tidy error: /checkout/src/librustc_mir/dataflow/move_paths/builder.rs:132: line longer than 100 chars
2019-08-14T18:41:00.8967339Z tidy error: /checkout/src/librustc_mir/dataflow/move_paths/builder.rs:133: line longer than 100 chars
2019-08-14T18:41:00.8967439Z tidy error: /checkout/src/librustc_mir/dataflow/move_paths/builder.rs:134: line longer than 100 chars
2019-08-14T18:41:00.8967509Z tidy error: /checkout/src/librustc_mir/dataflow/move_paths/builder.rs:137: line longer than 100 chars
2019-08-14T18:41:00.8967595Z tidy error: /checkout/src/librustc_mir/dataflow/move_paths/builder.rs:138: line longer than 100 chars
2019-08-14T18:41:00.8967666Z tidy error: /checkout/src/librustc_mir/dataflow/move_paths/builder.rs:139: line longer than 100 chars
2019-08-14T18:41:00.8967735Z tidy error: /checkout/src/librustc_mir/dataflow/move_paths/builder.rs:141: line longer than 100 chars
2019-08-14T18:41:00.8967819Z tidy error: /checkout/src/librustc_mir/dataflow/move_paths/builder.rs:142: line longer than 100 chars
2019-08-14T18:41:00.8967897Z tidy error: /checkout/src/librustc_mir/dataflow/move_paths/builder.rs:145: line longer than 100 chars
2019-08-14T18:41:00.9029056Z tidy error: /checkout/src/librustc_mir/borrow_check/move_errors.rs:314: line longer than 100 chars
2019-08-14T18:41:00.9104256Z tidy error: /checkout/src/librustc_mir/borrow_check/prefixes.rs:156: line longer than 100 chars
2019-08-14T18:41:00.9104640Z tidy error: /checkout/src/librustc_mir/borrow_check/places_conflict.rs:162: line longer than 100 chars
2019-08-14T18:41:00.9104724Z tidy error: /checkout/src/librustc_mir/borrow_check/places_conflict.rs:180: line longer than 100 chars
2019-08-14T18:41:00.9114283Z tidy error: /checkout/src/librustc_mir/borrow_check/places_conflict.rs:211: line longer than 100 chars
2019-08-14T18:41:00.9114402Z tidy error: /checkout/src/librustc_mir/borrow_check/places_conflict.rs:292: line longer than 100 chars
2019-08-14T18:41:00.9144451Z tidy error: /checkout/src/librustc_mir/transform/qualify_consts.rs:826: line longer than 100 chars
2019-08-14T18:41:01.2921141Z tidy error: /checkout/src/librustc/mir/visit.rs:698: line longer than 100 chars
2019-08-14T18:41:02.3793361Z some tidy checks failed
2019-08-14T18:41:02.3795535Z 
2019-08-14T18:41:02.3795535Z 
2019-08-14T18:41:02.3800290Z command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/tidy" "/checkout/src" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "--no-vendor"
2019-08-14T18:41:02.3801096Z 
2019-08-14T18:41:02.3801193Z 
2019-08-14T18:41:02.3813854Z failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test src/tools/tidy
2019-08-14T18:41:02.3813973Z Build completed unsuccessfully in 0:01:32
2019-08-14T18:41:02.3813973Z Build completed unsuccessfully in 0:01:32
2019-08-14T18:41:02.3868298Z == clock drift check ==
2019-08-14T18:41:02.3878053Z   local time: Wed Aug 14 18:41:02 UTC 2019
2019-08-14T18:41:02.4549668Z   network time: Wed, 14 Aug 2019 18:41:02 GMT
2019-08-14T18:41:02.4550455Z == end clock drift check ==
2019-08-14T18:41:04.4426484Z ##[error]Bash exited with code '1'.
2019-08-14T18:41:04.4484452Z ##[section]Starting: Checkout
2019-08-14T18:41:04.4486538Z ==============================================================================
2019-08-14T18:41:04.4486608Z Task         : Get sources
2019-08-14T18:41:04.4486683Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@spastorino spastorino force-pushed the spastorino:place2_5 branch from 1ef4cfe to 009442b Aug 15, 2019

@rust-highfive

This comment has been minimized.

Copy link
Collaborator

commented Aug 15, 2019

The job x86_64-gnu-llvm-6.0 of your PR failed (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
2019-08-15T03:00:00.1946169Z ##[command]git remote add origin https://github.com/rust-lang/rust
2019-08-15T03:00:00.2149175Z ##[command]git config gc.auto 0
2019-08-15T03:00:00.2232092Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2019-08-15T03:00:00.2275401Z ##[command]git config --get-all http.proxy
2019-08-15T03:00:00.2419690Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/63420/merge:refs/remotes/pull/63420/merge
---
2019-08-15T03:00:34.1833981Z do so (now or later) by using -b with the checkout command again. Example:
2019-08-15T03:00:34.1834029Z 
2019-08-15T03:00:34.1834258Z   git checkout -b <new-branch-name>
2019-08-15T03:00:34.1834291Z 
2019-08-15T03:00:34.1834344Z HEAD is now at 63f797e93 Merge 009442b3ff52a54f62aec9bae9d89bf0d6a1e8d9 into 082cf2f9d136166cd1d552d3fb5abb1c46c99a14
2019-08-15T03:00:34.1994156Z ##[section]Starting: Collect CPU-usage statistics in the background
2019-08-15T03:00:34.1997263Z ==============================================================================
2019-08-15T03:00:34.1997323Z Task         : Bash
2019-08-15T03:00:34.1997383Z Description  : Run a Bash script on macOS, Linux, or Windows
---
2019-08-15T03:03:01.8119139Z Looks like docker image is the same as before, not uploading
2019-08-15T03:03:11.2642948Z [CI_JOB_NAME=x86_64-gnu-llvm-6.0]
2019-08-15T03:03:11.4218296Z [CI_JOB_NAME=x86_64-gnu-llvm-6.0]
2019-08-15T03:03:11.4248396Z == clock drift check ==
2019-08-15T03:03:11.4257281Z   local time: Thu Aug 15 03:03:11 UTC 2019
2019-08-15T03:03:11.5113008Z   network time: Thu, 15 Aug 2019 03:03:11 GMT
2019-08-15T03:03:11.5140128Z Starting sccache server...
2019-08-15T03:03:11.6043573Z configure: processing command line
2019-08-15T03:03:11.6043734Z configure: 
2019-08-15T03:03:11.6044624Z configure: rust.dist-src        := False
---
2019-08-15T03:06:59.0009885Z    Compiling serde_json v1.0.40
2019-08-15T03:07:00.9265517Z    Compiling tidy v0.1.0 (/checkout/src/tools/tidy)
2019-08-15T03:07:11.8856470Z     Finished release [optimized] target(s) in 1m 30s
2019-08-15T03:07:11.8930281Z tidy check
2019-08-15T03:07:12.3084406Z tidy error: /checkout/src/librustc_mir/build/expr/as_rvalue.rs:524: line longer than 100 chars
2019-08-15T03:07:12.3103182Z tidy error: /checkout/src/librustc_mir/dataflow/move_paths/builder.rs:122: line longer than 100 chars
2019-08-15T03:07:12.3103337Z tidy error: /checkout/src/librustc_mir/dataflow/move_paths/builder.rs:125: line longer than 100 chars
2019-08-15T03:07:12.3103433Z tidy error: /checkout/src/librustc_mir/dataflow/move_paths/builder.rs:126: line longer than 100 chars
2019-08-15T03:07:12.3103499Z tidy error: /checkout/src/librustc_mir/dataflow/move_paths/builder.rs:127: line longer than 100 chars
2019-08-15T03:07:12.3103581Z tidy error: /checkout/src/librustc_mir/dataflow/move_paths/builder.rs:129: line longer than 100 chars
2019-08-15T03:07:12.3103644Z tidy error: /checkout/src/librustc_mir/dataflow/move_paths/builder.rs:131: line longer than 100 chars
2019-08-15T03:07:12.3103719Z tidy error: /checkout/src/librustc_mir/dataflow/move_paths/builder.rs:132: line longer than 100 chars
2019-08-15T03:07:12.3103801Z tidy error: /checkout/src/librustc_mir/dataflow/move_paths/builder.rs:133: line longer than 100 chars
2019-08-15T03:07:12.3103864Z tidy error: /checkout/src/librustc_mir/dataflow/move_paths/builder.rs:134: line longer than 100 chars
2019-08-15T03:07:12.3103927Z tidy error: /checkout/src/librustc_mir/dataflow/move_paths/builder.rs:137: line longer than 100 chars
2019-08-15T03:07:12.3104210Z tidy error: /checkout/src/librustc_mir/dataflow/move_paths/builder.rs:138: line longer than 100 chars
2019-08-15T03:07:12.3104285Z tidy error: /checkout/src/librustc_mir/dataflow/move_paths/builder.rs:139: line longer than 100 chars
2019-08-15T03:07:12.3104349Z tidy error: /checkout/src/librustc_mir/dataflow/move_paths/builder.rs:141: line longer than 100 chars
2019-08-15T03:07:12.3104427Z tidy error: /checkout/src/librustc_mir/dataflow/move_paths/builder.rs:142: line longer than 100 chars
2019-08-15T03:07:12.3104500Z tidy error: /checkout/src/librustc_mir/dataflow/move_paths/builder.rs:145: line longer than 100 chars
2019-08-15T03:07:12.3129828Z tidy error: /checkout/src/librustc_mir/borrow_check/move_errors.rs:314: line longer than 100 chars
2019-08-15T03:07:12.3250548Z tidy error: /checkout/src/librustc_mir/borrow_check/prefixes.rs:156: line longer than 100 chars
2019-08-15T03:07:12.3250673Z tidy error: /checkout/src/librustc_mir/borrow_check/places_conflict.rs:162: line longer than 100 chars
2019-08-15T03:07:12.3250755Z tidy error: /checkout/src/librustc_mir/borrow_check/places_conflict.rs:180: line longer than 100 chars
2019-08-15T03:07:12.3290331Z tidy error: /checkout/src/librustc_mir/borrow_check/places_conflict.rs:211: line longer than 100 chars
2019-08-15T03:07:12.3290438Z tidy error: /checkout/src/librustc_mir/borrow_check/places_conflict.rs:292: line longer than 100 chars
2019-08-15T03:07:12.3290498Z tidy error: /checkout/src/librustc_mir/transform/qualify_consts.rs:826: line longer than 100 chars
2019-08-15T03:07:12.7435154Z tidy error: /checkout/src/librustc/mir/visit.rs:698: line longer than 100 chars
2019-08-15T03:07:13.9045919Z some tidy checks failed
2019-08-15T03:07:13.9046041Z 
2019-08-15T03:07:13.9046041Z 
2019-08-15T03:07:13.9046869Z command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/tidy" "/checkout/src" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "--no-vendor"
2019-08-15T03:07:13.9047027Z 
2019-08-15T03:07:13.9047054Z 
2019-08-15T03:07:13.9052518Z failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test src/tools/tidy
2019-08-15T03:07:13.9052591Z Build completed unsuccessfully in 0:01:34
2019-08-15T03:07:13.9052591Z Build completed unsuccessfully in 0:01:34
2019-08-15T03:07:13.9101104Z == clock drift check ==
2019-08-15T03:07:13.9114698Z   local time: Thu Aug 15 03:07:13 UTC 2019
2019-08-15T03:07:14.2015469Z   network time: Thu, 15 Aug 2019 03:07:14 GMT
2019-08-15T03:07:14.2016873Z == end clock drift check ==
2019-08-15T03:07:15.6631932Z ##[error]Bash exited with code '1'.
2019-08-15T03:07:15.6677297Z ##[section]Starting: Checkout
2019-08-15T03:07:15.6679278Z ==============================================================================
2019-08-15T03:07:15.6679363Z Task         : Get sources
2019-08-15T03:07:15.6679420Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@rust-highfive

This comment has been minimized.

Copy link
Collaborator

commented Aug 15, 2019

The job x86_64-gnu-llvm-6.0 of your PR failed (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
2019-08-15T22:04:49.3944107Z ##[command]git remote add origin https://github.com/rust-lang/rust
2019-08-15T22:04:49.4143255Z ##[command]git config gc.auto 0
2019-08-15T22:04:49.4231229Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2019-08-15T22:04:49.4284170Z ##[command]git config --get-all http.proxy
2019-08-15T22:04:49.4441642Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/63420/merge:refs/remotes/pull/63420/merge
---
2019-08-15T22:05:23.8310107Z do so (now or later) by using -b with the checkout command again. Example:
2019-08-15T22:05:23.8310143Z 
2019-08-15T22:05:23.8310507Z   git checkout -b <new-branch-name>
2019-08-15T22:05:23.8310544Z 
2019-08-15T22:05:23.8310597Z HEAD is now at c90ea6c31 Merge 944375d1070d32195d33de02e2896575bfb1cfab into f7af19c279b8b7ea3d2c21fcbd67164af8d5d968
2019-08-15T22:05:23.8485193Z ##[section]Starting: Collect CPU-usage statistics in the background
2019-08-15T22:05:23.8488203Z ==============================================================================
2019-08-15T22:05:23.8488285Z Task         : Bash
2019-08-15T22:05:23.8488340Z Description  : Run a Bash script on macOS, Linux, or Windows
---
2019-08-15T22:12:00.6038027Z    Compiling serde_json v1.0.40
2019-08-15T22:12:02.4797323Z    Compiling tidy v0.1.0 (/checkout/src/tools/tidy)
2019-08-15T22:12:13.6704668Z     Finished release [optimized] target(s) in 1m 33s
2019-08-15T22:12:13.6771096Z tidy check
2019-08-15T22:12:14.0982359Z tidy error: /checkout/src/librustc_mir/build/expr/as_rvalue.rs:524: line longer than 100 chars
2019-08-15T22:12:14.1001956Z tidy error: /checkout/src/librustc_mir/dataflow/move_paths/builder.rs:122: line longer than 100 chars
2019-08-15T22:12:14.1002054Z tidy error: /checkout/src/librustc_mir/dataflow/move_paths/builder.rs:125: line longer than 100 chars
2019-08-15T22:12:14.1002218Z tidy error: /checkout/src/librustc_mir/dataflow/move_paths/builder.rs:126: line longer than 100 chars
2019-08-15T22:12:14.1002301Z tidy error: /checkout/src/librustc_mir/dataflow/move_paths/builder.rs:127: line longer than 100 chars
2019-08-15T22:12:14.1002380Z tidy error: /checkout/src/librustc_mir/dataflow/move_paths/builder.rs:129: line longer than 100 chars
2019-08-15T22:12:14.1002444Z tidy error: /checkout/src/librustc_mir/dataflow/move_paths/builder.rs:131: line longer than 100 chars
2019-08-15T22:12:14.1002524Z tidy error: /checkout/src/librustc_mir/dataflow/move_paths/builder.rs:132: line longer than 100 chars
2019-08-15T22:12:14.1002587Z tidy error: /checkout/src/librustc_mir/dataflow/move_paths/builder.rs:133: line longer than 100 chars
2019-08-15T22:12:14.1002651Z tidy error: /checkout/src/librustc_mir/dataflow/move_paths/builder.rs:134: line longer than 100 chars
2019-08-15T22:12:14.1002732Z tidy error: /checkout/src/librustc_mir/dataflow/move_paths/builder.rs:137: line longer than 100 chars
2019-08-15T22:12:14.1002805Z tidy error: /checkout/src/librustc_mir/dataflow/move_paths/builder.rs:138: line longer than 100 chars
2019-08-15T22:12:14.1002869Z tidy error: /checkout/src/librustc_mir/dataflow/move_paths/builder.rs:139: line longer than 100 chars
2019-08-15T22:12:14.1002957Z tidy error: /checkout/src/librustc_mir/dataflow/move_paths/builder.rs:141: line longer than 100 chars
2019-08-15T22:12:14.1003022Z tidy error: /checkout/src/librustc_mir/dataflow/move_paths/builder.rs:142: line longer than 100 chars
2019-08-15T22:12:14.1003101Z tidy error: /checkout/src/librustc_mir/dataflow/move_paths/builder.rs:145: line longer than 100 chars
2019-08-15T22:12:14.1030257Z tidy error: /checkout/src/librustc_mir/borrow_check/move_errors.rs:314: line longer than 100 chars
2019-08-15T22:12:14.1139256Z tidy error: /checkout/src/librustc_mir/borrow_check/prefixes.rs:156: line longer than 100 chars
2019-08-15T22:12:14.1139380Z tidy error: /checkout/src/librustc_mir/borrow_check/places_conflict.rs:162: line longer than 100 chars
2019-08-15T22:12:14.1139662Z tidy error: /checkout/src/librustc_mir/borrow_check/places_conflict.rs:180: line longer than 100 chars
2019-08-15T22:12:14.1139746Z tidy error: /checkout/src/librustc_mir/borrow_check/places_conflict.rs:211: line longer than 100 chars
2019-08-15T22:12:14.1139843Z tidy error: /checkout/src/librustc_mir/borrow_check/places_conflict.rs:292: line longer than 100 chars
2019-08-15T22:12:14.1174008Z tidy error: /checkout/src/librustc_mir/transform/qualify_consts.rs:826: line longer than 100 chars
2019-08-15T22:12:14.5611338Z tidy error: /checkout/src/librustc/mir/visit.rs:698: line longer than 100 chars
2019-08-15T22:12:15.7534436Z some tidy checks failed
2019-08-15T22:12:15.7535763Z 
2019-08-15T22:12:15.7535763Z 
2019-08-15T22:12:15.7536973Z command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/tidy" "/checkout/src" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "--no-vendor"
2019-08-15T22:12:15.7537642Z 
2019-08-15T22:12:15.7537898Z 
2019-08-15T22:12:15.7541711Z failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test src/tools/tidy
2019-08-15T22:12:15.7542358Z Build completed unsuccessfully in 0:01:36
2019-08-15T22:12:15.7542358Z Build completed unsuccessfully in 0:01:36
2019-08-15T22:12:15.7598847Z == clock drift check ==
2019-08-15T22:12:15.7612490Z   local time: Thu Aug 15 22:12:15 UTC 2019
2019-08-15T22:12:15.9151139Z   network time: Thu, 15 Aug 2019 22:12:15 GMT
2019-08-15T22:12:15.9153280Z == end clock drift check ==
2019-08-15T22:12:17.5699040Z ##[error]Bash exited with code '1'.
2019-08-15T22:12:17.5747277Z ##[section]Starting: Checkout
2019-08-15T22:12:17.5749191Z ==============================================================================
2019-08-15T22:12:17.5749251Z Task         : Get sources
2019-08-15T22:12:17.5749319Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@spastorino spastorino force-pushed the spastorino:place2_5 branch from 944375d to e6c89d3 Aug 16, 2019

@rust-highfive

This comment has been minimized.

Copy link
Collaborator

commented Aug 16, 2019

The job x86_64-gnu-llvm-6.0 of your PR failed (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
2019-08-16T19:38:33.6389952Z ##[command]git remote add origin https://github.com/rust-lang/rust
2019-08-16T19:38:33.6616888Z ##[command]git config gc.auto 0
2019-08-16T19:38:33.6698091Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2019-08-16T19:38:33.6771385Z ##[command]git config --get-all http.proxy
2019-08-16T19:38:34.5944160Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/63420/merge:refs/remotes/pull/63420/merge
---
2019-08-16T19:39:07.9561391Z do so (now or later) by using -b with the checkout command again. Example:
2019-08-16T19:39:07.9561423Z 
2019-08-16T19:39:07.9561684Z   git checkout -b <new-branch-name>
2019-08-16T19:39:07.9561734Z 
2019-08-16T19:39:07.9561787Z HEAD is now at 9babba00b Merge e6c89d3965ed16433502fb4e1a23a68501d4b00e into 9a32ad0dd51f8451aa6e39d7e9ea89483cb8fcfa
2019-08-16T19:39:07.9721073Z ##[section]Starting: Collect CPU-usage statistics in the background
2019-08-16T19:39:07.9723904Z ==============================================================================
2019-08-16T19:39:07.9723959Z Task         : Bash
2019-08-16T19:39:07.9724003Z Description  : Run a Bash script on macOS, Linux, or Windows
---
2019-08-16T19:45:29.0731698Z    Compiling serde_json v1.0.40
2019-08-16T19:45:30.8764102Z    Compiling tidy v0.1.0 (/checkout/src/tools/tidy)
2019-08-16T19:45:41.7777948Z     Finished release [optimized] target(s) in 1m 31s
2019-08-16T19:45:41.7909904Z tidy check
2019-08-16T19:45:42.2014869Z tidy error: /checkout/src/librustc_mir/build/expr/as_rvalue.rs:524: line longer than 100 chars
2019-08-16T19:45:42.2040313Z tidy error: /checkout/src/librustc_mir/dataflow/move_paths/builder.rs:122: line longer than 100 chars
2019-08-16T19:45:42.2040413Z tidy error: /checkout/src/librustc_mir/dataflow/move_paths/builder.rs:125: line longer than 100 chars
2019-08-16T19:45:42.2040478Z tidy error: /checkout/src/librustc_mir/dataflow/move_paths/builder.rs:126: line longer than 100 chars
2019-08-16T19:45:42.2040561Z tidy error: /checkout/src/librustc_mir/dataflow/move_paths/builder.rs:127: line longer than 100 chars
2019-08-16T19:45:42.2040626Z tidy error: /checkout/src/librustc_mir/dataflow/move_paths/builder.rs:129: line longer than 100 chars
2019-08-16T19:45:42.2047068Z tidy error: /checkout/src/librustc_mir/dataflow/move_paths/builder.rs:131: line longer than 100 chars
2019-08-16T19:45:42.2047560Z tidy error: /checkout/src/librustc_mir/dataflow/move_paths/builder.rs:132: line longer than 100 chars
2019-08-16T19:45:42.2047813Z tidy error: /checkout/src/librustc_mir/dataflow/move_paths/builder.rs:133: line longer than 100 chars
2019-08-16T19:45:42.2048097Z tidy error: /checkout/src/librustc_mir/dataflow/move_paths/builder.rs:134: line longer than 100 chars
2019-08-16T19:45:42.2048281Z tidy error: /checkout/src/librustc_mir/dataflow/move_paths/builder.rs:137: line longer than 100 chars
2019-08-16T19:45:42.2048478Z tidy error: /checkout/src/librustc_mir/dataflow/move_paths/builder.rs:138: line longer than 100 chars
2019-08-16T19:45:42.2048649Z tidy error: /checkout/src/librustc_mir/dataflow/move_paths/builder.rs:139: line longer than 100 chars
2019-08-16T19:45:42.2048837Z tidy error: /checkout/src/librustc_mir/dataflow/move_paths/builder.rs:141: line longer than 100 chars
2019-08-16T19:45:42.2049010Z tidy error: /checkout/src/librustc_mir/dataflow/move_paths/builder.rs:142: line longer than 100 chars
2019-08-16T19:45:42.2049190Z tidy error: /checkout/src/librustc_mir/dataflow/move_paths/builder.rs:145: line longer than 100 chars
2019-08-16T19:45:42.2074815Z tidy error: /checkout/src/librustc_mir/borrow_check/move_errors.rs:314: line longer than 100 chars
2019-08-16T19:45:42.2182960Z tidy error: /checkout/src/librustc_mir/borrow_check/prefixes.rs:156: line longer than 100 chars
2019-08-16T19:45:42.2183089Z tidy error: /checkout/src/librustc_mir/borrow_check/places_conflict.rs:162: line longer than 100 chars
2019-08-16T19:45:42.2183162Z tidy error: /checkout/src/librustc_mir/borrow_check/places_conflict.rs:180: line longer than 100 chars
2019-08-16T19:45:42.2183230Z tidy error: /checkout/src/librustc_mir/borrow_check/places_conflict.rs:211: line longer than 100 chars
2019-08-16T19:45:42.2183316Z tidy error: /checkout/src/librustc_mir/borrow_check/places_conflict.rs:292: line longer than 100 chars
2019-08-16T19:45:42.2220940Z tidy error: /checkout/src/librustc_mir/transform/qualify_consts.rs:826: line longer than 100 chars
2019-08-16T19:45:42.6236653Z tidy error: /checkout/src/librustc/mir/visit.rs:698: line longer than 100 chars
2019-08-16T19:45:43.7827791Z some tidy checks failed
2019-08-16T19:45:43.7829258Z 
2019-08-16T19:45:43.7829258Z 
2019-08-16T19:45:43.7830304Z command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/tidy" "/checkout/src" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "--no-vendor"
2019-08-16T19:45:43.7830640Z 
2019-08-16T19:45:43.7830770Z 
2019-08-16T19:45:43.7850598Z failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test src/tools/tidy
2019-08-16T19:45:43.7850671Z Build completed unsuccessfully in 0:01:34
2019-08-16T19:45:43.7850671Z Build completed unsuccessfully in 0:01:34
2019-08-16T19:45:43.7902554Z == clock drift check ==
2019-08-16T19:45:43.7917370Z   local time: Fri Aug 16 19:45:43 UTC 2019
2019-08-16T19:45:43.9419691Z   network time: Fri, 16 Aug 2019 19:45:43 GMT
2019-08-16T19:45:43.9421564Z == end clock drift check ==
2019-08-16T19:45:45.3126075Z ##[error]Bash exited with code '1'.
2019-08-16T19:45:45.3160173Z ##[section]Starting: Checkout
2019-08-16T19:45:45.3162036Z ==============================================================================
2019-08-16T19:45:45.3162099Z Task         : Get sources
2019-08-16T19:45:45.3162168Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@spastorino spastorino force-pushed the spastorino:place2_5 branch from e6c89d3 to fb527f0 Aug 16, 2019

@rust-highfive

This comment has been minimized.

Copy link
Collaborator

commented Aug 16, 2019

The job x86_64-gnu-llvm-6.0 of your PR failed (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
2019-08-16T20:20:42.4044195Z ##[command]git remote add origin https://github.com/rust-lang/rust
2019-08-16T20:20:42.4212200Z ##[command]git config gc.auto 0
2019-08-16T20:20:42.4281616Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2019-08-16T20:20:42.4322599Z ##[command]git config --get-all http.proxy
2019-08-16T20:20:42.4464033Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/63420/merge:refs/remotes/pull/63420/merge
---
2019-08-16T20:21:18.4149190Z do so (now or later) by using -b with the checkout command again. Example:
2019-08-16T20:21:18.4149910Z 
2019-08-16T20:21:18.4151087Z   git checkout -b <new-branch-name>
2019-08-16T20:21:18.4151526Z 
2019-08-16T20:21:18.4151937Z HEAD is now at 446844bd9 Merge fb527f0bf7d46822f31747a6461fec0f9dd4bdfd into 9a32ad0dd51f8451aa6e39d7e9ea89483cb8fcfa
2019-08-16T20:21:18.4317954Z ##[section]Starting: Collect CPU-usage statistics in the background
2019-08-16T20:21:18.4321347Z ==============================================================================
2019-08-16T20:21:18.4321424Z Task         : Bash
2019-08-16T20:21:18.4321468Z Description  : Run a Bash script on macOS, Linux, or Windows
---
2019-08-16T20:53:05.2926818Z    Compiling semver v0.9.0
2019-08-16T20:53:07.5661238Z error: failed to run custom build command for `libc v0.2.60`
2019-08-16T20:53:07.5662119Z 
2019-08-16T20:53:07.5662438Z Caused by:
2019-08-16T20:53:07.5663201Z   process didn't exit successfully: `/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-rustc/release/build/libc-c9db8456b64370fd/build-script-build` (signal: 6, SIGABRT: process abort signal)
2019-08-16T20:53:07.5663728Z --- stderr
2019-08-16T20:53:07.5664552Z *** Error in `/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-rustc/release/build/libc-c9db8456b64370fd/build-script-build': double free or corruption (fasttop): 0x000055f13dc65040 ***
2019-08-16T20:53:07.5664807Z ======= Backtrace: =========
2019-08-16T20:53:07.5665211Z /lib/x86_64-linux-gnu/libc.so.6(+0x777e5)[0x7f1516fc47e5]
2019-08-16T20:53:07.5665701Z /lib/x86_64-linux-gnu/libc.so.6(+0x8037a)[0x7f1516fcd37a]
2019-08-16T20:53:07.5666139Z /lib/x86_64-linux-gnu/libc.so.6(cfree+0x4c)[0x7f1516fd153c]
2019-08-16T20:53:07.5666695Z /checkout/obj/build/x86_64-unknown-linux-gnu/stage1-rustc/release/build/libc-c9db8456b64370fd/build-script-build(_ZN3std3env7_var_os17h933be281538e872fE+0x1ae)[0x55f13c3a14de]
2019-08-16T20:53:07.5667233Z /checkout/obj/build/x86_64-unknown-linux-gnu/stage1-rustc/release/build/libc-c9db8456b64370fd/build-script-build(+0x16cbf)[0x55f13c3a8cbf]
2019-08-16T20:53:07.5667800Z /checkout/obj/build/x86_64-unknown-linux-gnu/stage1-rustc/release/build/libc-c9db8456b64370fd/build-script-build(_ZN3std9panicking20rust_panic_with_hook17hdb2ec2a272270ba3E+0x190)[0x55f13c3a99a0]
2019-08-16T20:53:07.5668341Z /checkout/obj/build/x86_64-unknown-linux-gnu/stage1-rustc/release/build/libc-c9db8456b64370fd/build-script-build(+0x17522)[0x55f13c3a9522]
2019-08-16T20:53:07.5668862Z /checkout/obj/build/x86_64-unknown-linux-gnu/stage1-rustc/release/build/libc-c9db8456b64370fd/build-script-build(rust_begin_unwind+0x6)[0x55f13c3a9406]
2019-08-16T20:53:07.5669450Z /checkout/obj/build/x86_64-unknown-linux-gnu/stage1-rustc/release/build/libc-c9db8456b64370fd/build-script-build(_ZN4core9panicking9panic_fmt17h72a7b8c354b02815E+0x3d)[0x55f13c3becad]
2019-08-16T20:53:07.5670181Z /checkout/obj/build/x86_64-unknown-linux-gnu/stage1-rustc/release/build/libc-c9db8456b64370fd/build-script-build(_ZN4core6result13unwrap_failed17ha44dc08558b1b9e3E+0x87)[0x55f13c3beda7]
2019-08-16T20:53:07.5671469Z /checkout/obj/build/x86_64-unknown-linux-gnu/stage1-rustc/release/build/libc-c9db8456b64370fd/build-script-build(_ZN3std6thread6Thread3new17h17b3868de0128787E+0x2f1)[0x55f13c3a0921]
2019-08-16T20:53:07.5672207Z /checkout/obj/build/x86_64-unknown-linux-gnu/stage1-rustc/release/build/libc-c9db8456b64370fd/build-script-build(_ZN3std2rt19lang_start_internal17h39cb00454892d415E+0x2bf)[0x55f13c3a9e0f]
2019-08-16T20:53:07.5672856Z /checkout/obj/build/x86_64-unknown-linux-gnu/stage1-rustc/release/build/libc-c9db8456b64370fd/build-script-build(+0x9d45)[0x55f13c39bd45]
2019-08-16T20:53:07.5673447Z /lib/x86_64-linux-gnu/libc.so.6(__libc_start_main+0xf0)[0x7f1516f6d830]
2019-08-16T20:53:07.5674064Z /checkout/obj/build/x86_64-unknown-linux-gnu/stage1-rustc/release/build/libc-c9db8456b64370fd/build-script-build(+0x8349)[0x55f13c39a349]
2019-08-16T20:53:07.5674383Z ======= Memory map: ========
2019-08-16T20:53:07.5675021Z 55f13c392000-55f13c3d3000 r-xp 00000000 08:01 12832758                   /checkout/obj/build/x86_64-unknown-linux-gnu/stage1-rustc/release/build/libc-c9db8456b64370fd/build-script-build
2019-08-16T20:53:07.5675764Z 55f13c5d2000-55f13c5d5000 r--p 00040000 08:01 12832758                   /checkout/obj/build/x86_64-unknown-linux-gnu/stage1-rustc/release/build/libc-c9db8456b64370fd/build-script-build
2019-08-16T20:53:07.5677297Z 55f13c5d5000-55f13c5d6000 rw-p 00043000 08:01 12832758                   /checkout/obj/build/x86_64-unknown-linux-gnu/stage1-rustc/release/build/libc-c9db8456b64370fd/build-script-build
2019-08-16T20:53:07.5678293Z 55f13dc65000-55f13dc86000 rw-p 00000000 00:00 0                          [heap]
2019-08-16T20:53:07.5679164Z 7f1510000000-7f1510021000 rw-p 00000000 00:00 0 
2019-08-16T20:53:07.5679763Z 7f1510021000-7f1514000000 ---p 00000000 00:00 0 
2019-08-16T20:53:07.5680192Z 7f1516f4d000-7f151710d000 r-xp 00000000 08:01 7961938                    /lib/x86_64-linux-gnu/libc-2.23.so
2019-08-16T20:53:07.5680586Z 7f151710d000-7f151730d000 ---p 001c0000 08:01 7961938                    /lib/x86_64-linux-gnu/libc-2.23.so
2019-08-16T20:53:07.5681569Z 7f151730d000-7f1517311000 r--p 001c0000 08:01 7961938                    /lib/x86_64-linux-gnu/libc-2.23.so
2019-08-16T20:53:07.5682068Z 7f1517311000-7f1517313000 rw-p 001c4000 08:01 7961938                    /lib/x86_64-linux-gnu/libc-2.23.so
2019-08-16T20:53:07.5682504Z 7f1517313000-7f1517317000 rw-p 00000000 00:00 0 
2019-08-16T20:53:07.5682986Z 7f1517317000-7f151732d000 r-xp 00000000 08:01 7961959                    /lib/x86_64-linux-gnu/libgcc_s.so.1
2019-08-16T20:53:07.5683486Z 7f151732d000-7f151752c000 ---p 00016000 08:01 7961959                    /lib/x86_64-linux-gnu/libgcc_s.so.1
2019-08-16T20:53:07.5684090Z 7f151752c000-7f151752d000 rw-p 00015000 08:01 7961959                    /lib/x86_64-linux-gnu/libgcc_s.so.1
2019-08-16T20:53:07.5684712Z 7f151752d000-7f1517545000 r-xp 00000000 08:01 7962006                    /lib/x86_64-linux-gnu/libpthread-2.23.so
2019-08-16T20:53:07.5685143Z 7f1517545000-7f1517744000 ---p 00018000 08:01 7962006                    /lib/x86_64-linux-gnu/libpthread-2.23.so
2019-08-16T20:53:07.5685698Z 7f1517744000-7f1517745000 r--p 00017000 08:01 7962006                    /lib/x86_64-linux-gnu/libpthread-2.23.so
2019-08-16T20:53:07.5686088Z 7f1517745000-7f1517746000 rw-p 00018000 08:01 7962006                    /lib/x86_64-linux-gnu/libpthread-2.23.so
2019-08-16T20:53:07.5686609Z 7f1517746000-7f151774a000 rw-p 00000000 00:00 0 
2019-08-16T20:53:07.5686999Z 7f151774a000-7f1517751000 r-xp 00000000 08:01 7962012                    /lib/x86_64-linux-gnu/librt-2.23.so
2019-08-16T20:53:07.5687397Z 7f1517751000-7f1517950000 ---p 00007000 08:01 7962012                    /lib/x86_64-linux-gnu/librt-2.23.so
2019-08-16T20:53:07.5687778Z 7f1517950000-7f1517951000 r--p 00006000 08:01 7962012                    /lib/x86_64-linux-gnu/librt-2.23.so
2019-08-16T20:53:07.5688270Z 7f1517951000-7f1517952000 rw-p 00007000 08:01 7962012                    /lib/x86_64-linux-gnu/librt-2.23.so
2019-08-16T20:53:07.5688919Z 7f1517952000-7f1517955000 r-xp 00000000 08:01 7961951                    /lib/x86_64-linux-gnu/libdl-2.23.so
2019-08-16T20:53:07.5689831Z 7f1517955000-7f1517b54000 ---p 00003000 08:01 7961951                    /lib/x86_64-linux-gnu/libdl-2.23.so
2019-08-16T20:53:07.5690305Z 7f1517b54000-7f1517b55000 r--p 00002000 08:01 7961951                    /lib/x86_64-linux-gnu/libdl-2.23.so
2019-08-16T20:53:07.5690905Z 7f1517b55000-7f1517b56000 rw-p 00003000 08:01 7961951                    /lib/x86_64-linux-gnu/libdl-2.23.so
2019-08-16T20:53:07.5691331Z 7f1517b56000-7f1517b7c000 r-xp 00000000 08:01 7961918                    /lib/x86_64-linux-gnu/ld-2.23.so
2019-08-16T20:53:07.5691888Z 7f1517d71000-7f1517d76000 rw-p 00000000 00:00 0 
2019-08-16T20:53:07.5692407Z 7f1517d78000-7f1517d7b000 rw-p 00000000 00:00 0 
2019-08-16T20:53:07.5693201Z 7f1517d7b000-7f1517d7c000 r--p 00025000 08:01 7961918                    /lib/x86_64-linux-gnu/ld-2.23.so
2019-08-16T20:53:07.5694403Z 7f1517d7c000-7f1517d7d000 rw-p 00026000 08:01 7961918                    /lib/x86_64-linux-gnu/ld-2.23.so
2019-08-16T20:53:07.5694833Z 7f1517d7d000-7f1517d7e000 rw-p 00000000 00:00 0 
2019-08-16T20:53:07.5695303Z 7ffc980dd000-7ffc980ff000 rw-p 00000000 00:00 0                          [stack]
2019-08-16T20:53:07.5695744Z 7ffc9818e000-7ffc98191000 r--p 00000000 00:00 0                          [vvar]
2019-08-16T20:53:07.5696203Z 7ffc98191000-7ffc98193000 r-xp 00000000 00:00 0                          [vdso]
2019-08-16T20:53:07.5696846Z ffffffffff600000-ffffffffff601000 r-xp 00000000 00:00 0                  [vsyscall]
2019-08-16T20:53:07.5697608Z warning: build failed, waiting for other jobs to finish...
2019-08-16T20:53:10.9771389Z error: build failed
2019-08-16T20:53:10.9796432Z command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "build" "--target" "x86_64-unknown-linux-gnu" "-Zbinary-dep-depinfo" "-j" "2" "--release" "--locked" "--color" "always" "--features" "" "--manifest-path" "/checkout/src/rustc/Cargo.toml" "--message-format" "json-render-diagnostics"
2019-08-16T20:53:10.9796627Z expected success, got: exit code: 101
2019-08-16T20:53:10.9796627Z expected success, got: exit code: 101
2019-08-16T20:53:10.9812465Z failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
2019-08-16T20:53:10.9812553Z Build completed unsuccessfully in 0:25:23
2019-08-16T20:53:10.9864024Z == clock drift check ==
2019-08-16T20:53:10.9879976Z   local time: Fri Aug 16 20:53:10 UTC 2019
2019-08-16T20:53:11.0325687Z   network time: Fri, 16 Aug 2019 20:53:11 GMT
2019-08-16T20:53:11.0328386Z == end clock drift check ==
2019-08-16T20:53:12.1703959Z ##[error]Bash exited with code '1'.
2019-08-16T20:53:12.1758160Z ##[section]Starting: Checkout
2019-08-16T20:53:12.1760068Z ==============================================================================
2019-08-16T20:53:12.1760124Z Task         : Get sources
2019-08-16T20:53:12.1760185Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@spastorino spastorino force-pushed the spastorino:place2_5 branch from fb527f0 to bcd47c7 Aug 16, 2019

@rust-highfive

This comment has been minimized.

Copy link
Collaborator

commented Aug 16, 2019

The job x86_64-gnu-llvm-6.0 of your PR failed (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
2019-08-16T22:41:25.1321379Z ##[command]git remote add origin https://github.com/rust-lang/rust
2019-08-16T22:41:25.1503624Z ##[command]git config gc.auto 0
2019-08-16T22:41:25.1581441Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2019-08-16T22:41:25.1634568Z ##[command]git config --get-all http.proxy
2019-08-16T22:41:25.1792091Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/63420/merge:refs/remotes/pull/63420/merge
---
2019-08-16T22:42:01.1011222Z do so (now or later) by using -b with the checkout command again. Example:
2019-08-16T22:42:01.1012334Z 
2019-08-16T22:42:01.1013382Z   git checkout -b <new-branch-name>
2019-08-16T22:42:01.1014166Z 
2019-08-16T22:42:01.1014867Z HEAD is now at 7e23ae3cb Merge bcd47c727c1f92ba36545d253b26792819e71441 into bdfd698f37184da42254a03ed466ab1f90e6fb6c
2019-08-16T22:42:01.1193809Z ##[section]Starting: Collect CPU-usage statistics in the background
2019-08-16T22:42:01.1197562Z ==============================================================================
2019-08-16T22:42:01.1197628Z Task         : Bash
2019-08-16T22:42:01.1197680Z Description  : Run a Bash script on macOS, Linux, or Windows
---
2019-08-16T23:14:35.5509448Z    Compiling semver v0.9.0
2019-08-16T23:14:37.9564399Z error: failed to run custom build command for `libc v0.2.60`
2019-08-16T23:14:37.9564736Z 
2019-08-16T23:14:37.9564793Z Caused by:
2019-08-16T23:14:37.9565312Z   process didn't exit successfully: `/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-rustc/release/build/libc-c9db8456b64370fd/build-script-build` (signal: 6, SIGABRT: process abort signal)
2019-08-16T23:14:37.9565572Z --- stderr
2019-08-16T23:14:37.9565989Z *** Error in `/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-rustc/release/build/libc-c9db8456b64370fd/build-script-build': double free or corruption (fasttop): 0x00005561394de040 ***
2019-08-16T23:14:37.9566134Z ======= Backtrace: =========
2019-08-16T23:14:37.9566414Z /lib/x86_64-linux-gnu/libc.so.6(+0x777e5)[0x7f85dd3fa7e5]
2019-08-16T23:14:37.9566690Z /lib/x86_64-linux-gnu/libc.so.6(+0x8037a)[0x7f85dd40337a]
2019-08-16T23:14:37.9567003Z /lib/x86_64-linux-gnu/libc.so.6(cfree+0x4c)[0x7f85dd40753c]
2019-08-16T23:14:37.9567424Z /checkout/obj/build/x86_64-unknown-linux-gnu/stage1-rustc/release/build/libc-c9db8456b64370fd/build-script-build(_ZN3std3env7_var_os17he43e01a1302ce367E+0x1ae)[0x55613927b4de]
2019-08-16T23:14:37.9567814Z /checkout/obj/build/x86_64-unknown-linux-gnu/stage1-rustc/release/build/libc-c9db8456b64370fd/build-script-build(+0x16cbf)[0x556139282cbf]
2019-08-16T23:14:37.9568273Z /checkout/obj/build/x86_64-unknown-linux-gnu/stage1-rustc/release/build/libc-c9db8456b64370fd/build-script-build(_ZN3std9panicking20rust_panic_with_hook17hd2740c354aa5dd47E+0x190)[0x5561392839a0]
2019-08-16T23:14:37.9568649Z /checkout/obj/build/x86_64-unknown-linux-gnu/stage1-rustc/release/build/libc-c9db8456b64370fd/build-script-build(+0x17522)[0x556139283522]
2019-08-16T23:14:37.9569051Z /checkout/obj/build/x86_64-unknown-linux-gnu/stage1-rustc/release/build/libc-c9db8456b64370fd/build-script-build(rust_begin_unwind+0x6)[0x556139283406]
2019-08-16T23:14:37.9569491Z /checkout/obj/build/x86_64-unknown-linux-gnu/stage1-rustc/release/build/libc-c9db8456b64370fd/build-script-build(_ZN4core9panicking9panic_fmt17h72a7b8c354b02815E+0x3d)[0x556139298cad]
2019-08-16T23:14:37.9569935Z /checkout/obj/build/x86_64-unknown-linux-gnu/stage1-rustc/release/build/libc-c9db8456b64370fd/build-script-build(_ZN4core6result13unwrap_failed17ha44dc08558b1b9e3E+0x87)[0x556139298da7]
2019-08-16T23:14:37.9570380Z /checkout/obj/build/x86_64-unknown-linux-gnu/stage1-rustc/release/build/libc-c9db8456b64370fd/build-script-build(_ZN3std6thread6Thread3new17h92df7d02dd75ed4aE+0x2f1)[0x55613927a921]
2019-08-16T23:14:37.9570813Z /checkout/obj/build/x86_64-unknown-linux-gnu/stage1-rustc/release/build/libc-c9db8456b64370fd/build-script-build(_ZN3std2rt19lang_start_internal17ha639f564efb1c10cE+0x2bf)[0x556139283e0f]
2019-08-16T23:14:37.9571207Z /checkout/obj/build/x86_64-unknown-linux-gnu/stage1-rustc/release/build/libc-c9db8456b64370fd/build-script-build(+0x9d55)[0x556139275d55]
2019-08-16T23:14:37.9571633Z /lib/x86_64-linux-gnu/libc.so.6(__libc_start_main+0xf0)[0x7f85dd3a3830]
2019-08-16T23:14:37.9572043Z /checkout/obj/build/x86_64-unknown-linux-gnu/stage1-rustc/release/build/libc-c9db8456b64370fd/build-script-build(+0x8349)[0x556139274349]
2019-08-16T23:14:37.9572583Z ======= Memory map: ========
2019-08-16T23:14:37.9573093Z 55613926c000-5561392ad000 r-xp 00000000 08:01 12852489                   /checkout/obj/build/x86_64-unknown-linux-gnu/stage1-rustc/release/build/libc-c9db8456b64370fd/build-script-build
2019-08-16T23:14:37.9573542Z 5561394ac000-5561394af000 r--p 00040000 08:01 12852489                   /checkout/obj/build/x86_64-unknown-linux-gnu/stage1-rustc/release/build/libc-c9db8456b64370fd/build-script-build
2019-08-16T23:14:37.9573973Z 5561394af000-5561394b0000 rw-p 00043000 08:01 12852489                   /checkout/obj/build/x86_64-unknown-linux-gnu/stage1-rustc/release/build/libc-c9db8456b64370fd/build-script-build
2019-08-16T23:14:37.9574294Z 5561394de000-5561394ff000 rw-p 00000000 00:00 0                          [heap]
2019-08-16T23:14:37.9574588Z 7f85d8000000-7f85d8021000 rw-p 00000000 00:00 0 
2019-08-16T23:14:37.9574858Z 7f85d8021000-7f85dc000000 ---p 00000000 00:00 0 
2019-08-16T23:14:37.9575351Z 7f85dd383000-7f85dd543000 r-xp 00000000 08:01 7962024                    /lib/x86_64-linux-gnu/libc-2.23.so
2019-08-16T23:14:37.9575712Z 7f85dd543000-7f85dd743000 ---p 001c0000 08:01 7962024                    /lib/x86_64-linux-gnu/libc-2.23.so
2019-08-16T23:14:37.9576054Z 7f85dd743000-7f85dd747000 r--p 001c0000 08:01 7962024                    /lib/x86_64-linux-gnu/libc-2.23.so
2019-08-16T23:14:37.9576395Z 7f85dd747000-7f85dd749000 rw-p 001c4000 08:01 7962024                    /lib/x86_64-linux-gnu/libc-2.23.so
2019-08-16T23:14:37.9576686Z 7f85dd749000-7f85dd74d000 rw-p 00000000 00:00 0 
2019-08-16T23:14:37.9577019Z 7f85dd74d000-7f85dd763000 r-xp 00000000 08:01 7962045                    /lib/x86_64-linux-gnu/libgcc_s.so.1
2019-08-16T23:14:37.9577366Z 7f85dd763000-7f85dd962000 ---p 00016000 08:01 7962045                    /lib/x86_64-linux-gnu/libgcc_s.so.1
2019-08-16T23:14:37.9577727Z 7f85dd962000-7f85dd963000 rw-p 00015000 08:01 7962045                    /lib/x86_64-linux-gnu/libgcc_s.so.1
2019-08-16T23:14:37.9578087Z 7f85dd963000-7f85dd97b000 r-xp 00000000 08:01 7962092                    /lib/x86_64-linux-gnu/libpthread-2.23.so
2019-08-16T23:14:37.9578434Z 7f85dd97b000-7f85ddb7a000 ---p 00018000 08:01 7962092                    /lib/x86_64-linux-gnu/libpthread-2.23.so
2019-08-16T23:14:37.9578799Z 7f85ddb7a000-7f85ddb7b000 r--p 00017000 08:01 7962092                    /lib/x86_64-linux-gnu/libpthread-2.23.so
2019-08-16T23:14:37.9579146Z 7f85ddb7b000-7f85ddb7c000 rw-p 00018000 08:01 7962092                    /lib/x86_64-linux-gnu/libpthread-2.23.so
2019-08-16T23:14:37.9579434Z 7f85ddb7c000-7f85ddb80000 rw-p 00000000 00:00 0 
2019-08-16T23:14:37.9579771Z 7f85ddb80000-7f85ddb87000 r-xp 00000000 08:01 7962098                    /lib/x86_64-linux-gnu/librt-2.23.so
2019-08-16T23:14:37.9580117Z 7f85ddb87000-7f85ddd86000 ---p 00007000 08:01 7962098                    /lib/x86_64-linux-gnu/librt-2.23.so
2019-08-16T23:14:37.9580479Z 7f85ddd86000-7f85ddd87000 r--p 00006000 08:01 7962098                    /lib/x86_64-linux-gnu/librt-2.23.so
2019-08-16T23:14:37.9580832Z 7f85ddd87000-7f85ddd88000 rw-p 00007000 08:01 7962098                    /lib/x86_64-linux-gnu/librt-2.23.so
2019-08-16T23:14:37.9581169Z 7f85ddd88000-7f85ddd8b000 r-xp 00000000 08:01 7962037                    /lib/x86_64-linux-gnu/libdl-2.23.so
2019-08-16T23:14:37.9581527Z 7f85ddd8b000-7f85ddf8a000 ---p 00003000 08:01 7962037                    /lib/x86_64-linux-gnu/libdl-2.23.so
2019-08-16T23:14:37.9581865Z 7f85ddf8a000-7f85ddf8b000 r--p 00002000 08:01 7962037                    /lib/x86_64-linux-gnu/libdl-2.23.so
2019-08-16T23:14:37.9582641Z 7f85ddf8b000-7f85ddf8c000 rw-p 00003000 08:01 7962037                    /lib/x86_64-linux-gnu/libdl-2.23.so
2019-08-16T23:14:37.9583139Z 7f85ddf8c000-7f85ddfb2000 r-xp 00000000 08:01 7962004                    /lib/x86_64-linux-gnu/ld-2.23.so
2019-08-16T23:14:37.9583453Z 7f85de1a7000-7f85de1ac000 rw-p 00000000 00:00 0 
2019-08-16T23:14:37.9583720Z 7f85de1ae000-7f85de1b1000 rw-p 00000000 00:00 0 
2019-08-16T23:14:37.9584090Z 7f85de1b1000-7f85de1b2000 r--p 00025000 08:01 7962004                    /lib/x86_64-linux-gnu/ld-2.23.so
2019-08-16T23:14:37.9584425Z 7f85de1b2000-7f85de1b3000 rw-p 00026000 08:01 7962004                    /lib/x86_64-linux-gnu/ld-2.23.so
2019-08-16T23:14:37.9584696Z 7f85de1b3000-7f85de1b4000 rw-p 00000000 00:00 0 
2019-08-16T23:14:37.9585010Z 7ffe5833a000-7ffe5835c000 rw-p 00000000 00:00 0                          [stack]
2019-08-16T23:14:37.9585311Z 7ffe5836a000-7ffe5836d000 r--p 00000000 00:00 0                          [vvar]
2019-08-16T23:14:37.9585610Z 7ffe5836d000-7ffe5836f000 r-xp 00000000 00:00 0                          [vdso]
2019-08-16T23:14:37.9585930Z ffffffffff600000-ffffffffff601000 r-xp 00000000 00:00 0                  [vsyscall]
2019-08-16T23:14:37.9586271Z warning: build failed, waiting for other jobs to finish...
2019-08-16T23:14:40.9059790Z error: build failed
2019-08-16T23:14:40.9083537Z command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "build" "--target" "x86_64-unknown-linux-gnu" "-Zbinary-dep-depinfo" "-j" "2" "--release" "--locked" "--color" "always" "--features" "" "--manifest-path" "/checkout/src/rustc/Cargo.toml" "--message-format" "json-render-diagnostics"
2019-08-16T23:14:40.9084159Z expected success, got: exit code: 101
2019-08-16T23:14:40.9084159Z expected success, got: exit code: 101
2019-08-16T23:14:40.9095421Z failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
2019-08-16T23:14:40.9095907Z Build completed unsuccessfully in 0:26:02
2019-08-16T23:14:40.9155975Z == clock drift check ==
2019-08-16T23:14:40.9172076Z   local time: Fri Aug 16 23:14:40 UTC 2019
2019-08-16T23:14:41.1980210Z   network time: Fri, 16 Aug 2019 23:14:41 GMT
2019-08-16T23:14:41.1981189Z == end clock drift check ==
2019-08-16T23:14:42.3671457Z ##[error]Bash exited with code '1'.
2019-08-16T23:14:42.3718854Z ##[section]Starting: Checkout
2019-08-16T23:14:42.3720595Z ==============================================================================
2019-08-16T23:14:42.3720664Z Task         : Get sources
2019-08-16T23:14:42.3720711Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.