Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix Miri discriminant handling #63448

Open
wants to merge 4 commits into
base: master
from

Conversation

@RalfJung
Copy link
Member

commented Aug 10, 2019

This can be reviewed commit-by-commit fairly well.

The Miri side is at rust-lang/miri#903.

Fixes #62138

r? @eddyb @oli-obk

@eddyb

This comment has been minimized.

Copy link
Member

commented Aug 10, 2019

I'd prefer to block this on #63450.

@RalfJung RalfJung force-pushed the RalfJung:miri-discriminant branch from 4fc16d0 to 90d692b Aug 17, 2019

@RalfJung RalfJung force-pushed the RalfJung:miri-discriminant branch from 90d692b to bc8cde5 Aug 17, 2019

@RalfJung

This comment has been minimized.

Copy link
Member Author

commented Aug 17, 2019

I factored out the parts that are not blocked into a separate PR: #63658.

bors added a commit that referenced this pull request Aug 17, 2019

Auto merge of #63658 - RalfJung:miri-op, r=oli-obk
Refactor Miri ops (unary, binary) to have more types

This is the part of #63448 that is just a refactoring. It helps that PR by making it easier to perform machine arithmetic.

r? @oli-obk @eddyb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.