Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't special case the `Self` parameter by name #63463

Open
wants to merge 4 commits into
base: master
from

Conversation

@matthewjasper
Copy link
Contributor

commented Aug 11, 2019

This results in a couple of small diagnostic regressions. They could be avoided by keeping the special case just for diagnostics, but that seems worse.

closes #50125
cc #60869

Pre intern the `Self` parameter type
Use this to simplify the object safety code a bit.
@matthewjasper

This comment has been minimized.

Copy link
Contributor Author

commented Aug 13, 2019

@bors try

@bors

This comment has been minimized.

Copy link
Contributor

commented Aug 13, 2019

⌛️ Trying commit 4657ad1 with merge bbd6744...

bors added a commit that referenced this pull request Aug 13, 2019

Auto merge of #63463 - matthewjasper:ty_param_cleanup, r=<try>
Don't special case the `Self` parameter by name

This results in a couple of small diagnostic regressions. They could be avoided by keeping the special case just for diagnostics, but that seems worse.

closes #50125
cc #60869
@bors

This comment has been minimized.

Copy link
Contributor

commented Aug 13, 2019

☀️ Try build successful - checks-azure
Build commit: bbd6744

@matthewjasper

This comment has been minimized.

Copy link
Contributor Author

commented Aug 13, 2019

@rust-timer build

@petrochenkov

This comment has been minimized.

Copy link
Contributor

commented Aug 13, 2019

@rust-timer build bbd6744

AFAIK, rust-timer cannot detect the commit automatically.

@rust-timer

This comment has been minimized.

Copy link

commented Aug 13, 2019

Success: Queued bbd6744 with parent 60960a2, comparison URL.

@@ -2568,7 +2573,7 @@ impl<'tcx> TyCtxt<'tcx> {

#[inline]
pub fn mk_self_type(self) -> Ty<'tcx> {
self.mk_ty_param(0, kw::SelfUpper.as_interned_str())
self.types.self_param

This comment has been minimized.

Copy link
@petrochenkov

petrochenkov Aug 13, 2019

Contributor

Looks like mk_self_type isn't commonly used, perhaps it can be removed in favor of using self.types.self_param directly?

@rust-timer

This comment has been minimized.

Copy link

commented Aug 13, 2019

Finished benchmarking try commit bbd6744, comparison URL.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.