Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundancy from the implementation of C variadics. #63492

Open
wants to merge 4 commits into
base: master
from

Conversation

@eddyb
Copy link
Member

commented Aug 12, 2019

This cleanup was first described in #44930 (comment):

  • AST doesn't track c_variadic: bool anymore, relying solely on a trailing CVarArgs type in fn signatures
  • HIR doesn't have a CVarArgs anymore, relying solely on c_variadic: bool
    • same for ty::FnSig (see tests for diagnostics improvements from that)
    • {hir,mir}::Body have one extra argument than the signature when c_variadic == true
    • rustc_typeck and rustc_mir::{build,borrowck} need to give that argument the right type (which no longer uses a lifetime parameter, but a function-internal scope)
  • rustc_target::abi::call doesn't need special hacks anymore (since it never sees the VaListImpl now, it's all inside the body)

r? @nagisa / @rkruppe cc @dlrobertson @oli-obk

@rust-highfive

This comment was marked as resolved.

Copy link
Collaborator

commented Aug 12, 2019

The job x86_64-gnu-llvm-6.0 of your PR failed (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
2019-08-12T13:05:15.1176228Z ##[command]git remote add origin https://github.com/rust-lang/rust
2019-08-12T13:05:15.1376462Z ##[command]git config gc.auto 0
2019-08-12T13:05:15.1440652Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2019-08-12T13:05:15.1503096Z ##[command]git config --get-all http.proxy
2019-08-12T13:05:15.1652792Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/63492/merge:refs/remotes/pull/63492/merge
---
2019-08-12T13:05:51.0874513Z do so (now or later) by using -b with the checkout command again. Example:
2019-08-12T13:05:51.0874538Z 
2019-08-12T13:05:51.0874709Z   git checkout -b <new-branch-name>
2019-08-12T13:05:51.0874733Z 
2019-08-12T13:05:51.0874768Z HEAD is now at e8cf4572c Merge 7e57d8f396278e2c648e59e5c7b7dc9d2fb1028d into c01be67ea40266d6a4c3289654a07ddd7ce2a172
2019-08-12T13:05:51.1009929Z ##[section]Starting: Collect CPU-usage statistics in the background
2019-08-12T13:05:51.1013424Z ==============================================================================
2019-08-12T13:05:51.1013483Z Task         : Bash
2019-08-12T13:05:51.1013531Z Description  : Run a Bash script on macOS, Linux, or Windows
---
2019-08-12T14:07:36.2872190Z .................................................................................................... 1300/8876
2019-08-12T14:07:42.9184971Z .................................................................................................... 1400/8876
2019-08-12T14:07:49.2716849Z .................................................................................................... 1500/8876
2019-08-12T14:08:00.2197534Z .....................................................................................i.............. 1600/8876
2019-08-12T14:08:07.9420628Z .i.................................................................................................. 1700/8876
2019-08-12T14:08:14.8875195Z ............................................................................iiiii................... 1800/8876
2019-08-12T14:08:37.4366973Z .................................................................................................... 2000/8876
2019-08-12T14:08:39.9393178Z .................................................................................................... 2100/8876
2019-08-12T14:08:42.7105612Z .................................................................................................... 2200/8876
2019-08-12T14:08:50.6923324Z .................................................................................................... 2300/8876
---
2019-08-12T14:12:52.1833922Z .................................................................................................... 5300/8876
2019-08-12T14:12:59.8241492Z .........i.......................................................................................... 5400/8876
2019-08-12T14:13:05.5175965Z .................................................................................................... 5500/8876
2019-08-12T14:13:18.0391983Z .................................................................................................... 5600/8876
2019-08-12T14:13:32.3676642Z ....ii...i..ii...........i.......................................................................... 5700/8876
2019-08-12T14:13:47.9121017Z .................................................................................................... 5900/8876
2019-08-12T14:13:52.7684280Z .................................................................................................... 6000/8876
2019-08-12T14:13:52.7684280Z .................................................................................................... 6000/8876
2019-08-12T14:14:07.4242616Z .....i..ii.......................................................................................... 6100/8876
2019-08-12T14:14:26.6803622Z ................................................i................................................... 6300/8876
2019-08-12T14:14:28.8854664Z .................................................................................................... 6400/8876
2019-08-12T14:14:31.4060363Z ....................i............................................................................... 6500/8876
2019-08-12T14:14:36.0640465Z .................................................................................................... 6600/8876
---
2019-08-12T14:19:25.8346361Z  finished in 23.298
2019-08-12T14:19:25.8539270Z Check compiletest suite=codegen mode=codegen (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-08-12T14:19:26.0162670Z 
2019-08-12T14:19:26.0163631Z running 146 tests
2019-08-12T14:19:29.3558268Z i....iii......iii..iiii....i............................i..i................i....i.........ii.i.i..i 100/146
2019-08-12T14:19:31.2911312Z iii..............i.........iii.i......ii......
2019-08-12T14:19:31.2913484Z 
2019-08-12T14:19:31.2917937Z  finished in 5.438
2019-08-12T14:19:31.3101651Z Check compiletest suite=codegen-units mode=codegen-units (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-08-12T14:19:32.0998783Z 
---
2019-08-12T14:19:33.6061119Z  finished in 2.295
2019-08-12T14:19:33.6244681Z Check compiletest suite=assembly mode=assembly (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-08-12T14:19:33.7855225Z 
2019-08-12T14:19:33.7856486Z running 9 tests
2019-08-12T14:19:33.7858259Z iiiiiiiii
2019-08-12T14:19:33.7859408Z 
2019-08-12T14:19:33.7859593Z  finished in 0.161
2019-08-12T14:19:33.8051906Z Check compiletest suite=incremental mode=incremental (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-08-12T14:19:34.5968977Z 
---
2019-08-12T14:19:52.8186443Z  finished in 19.013
2019-08-12T14:19:52.8367806Z Check compiletest suite=debuginfo mode=debuginfo-gdb+lldb (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-08-12T14:19:52.9963852Z 
2019-08-12T14:19:52.9964105Z running 122 tests
2019-08-12T14:20:17.6455065Z .iiiii...i.....i..i...i..i.i.i..i.ii..i.i.....i..i....i..........iiii..........i...ii...i.......ii.i 100/122
2019-08-12T14:20:22.5924727Z .i.i......iii.i.....ii
2019-08-12T14:20:22.5926336Z 
2019-08-12T14:20:22.5926596Z  finished in 29.755
2019-08-12T14:20:22.5936909Z Uplifting stage1 rustc (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-08-12T14:20:22.5937480Z Copying stage2 rustc from stage1 (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu / x86_64-unknown-linux-gnu)
---
2019-08-12T14:21:13.0604357Z failures:
2019-08-12T14:21:13.0606859Z 
2019-08-12T14:21:13.0610699Z ---- [ui] ui-fulldeps/pprust-expr-roundtrip.rs stdout ----
2019-08-12T14:21:13.0610946Z 
2019-08-12T14:21:13.0611426Z error: test compilation failed although it shouldn't!
2019-08-12T14:21:13.0611639Z status: exit code: 1
2019-08-12T14:21:13.0612881Z command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui-fulldeps/pprust-expr-roundtrip.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "-o" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui-fulldeps/pprust-expr-roundtrip/a" "-Crpath" "-O" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui-fulldeps/pprust-expr-roundtrip/auxiliary" "-A" "unused"
2019-08-12T14:21:13.0613478Z ------------------------------------------
2019-08-12T14:21:13.0613624Z 
2019-08-12T14:21:13.0613945Z ------------------------------------------
2019-08-12T14:21:13.0614128Z stderr:
2019-08-12T14:21:13.0614128Z stderr:
2019-08-12T14:21:13.0614783Z ------------------------------------------
2019-08-12T14:21:13.0615145Z error[E0560]: struct `syntax::ast::FnDecl` has no field named `c_variadic`
2019-08-12T14:21:13.0615707Z    |
2019-08-12T14:21:13.0615707Z    |
2019-08-12T14:21:13.0616003Z LL |                     c_variadic: false,
2019-08-12T14:21:13.0616144Z    |                     ^^^^^^^^^^ `syntax::ast::FnDecl` does not have this field
2019-08-12T14:21:13.0616257Z    |
2019-08-12T14:21:13.0616384Z    = note: available fields are: `inputs`, `output`
2019-08-12T14:21:13.0616771Z error: aborting due to previous error
2019-08-12T14:21:13.0616864Z 
2019-08-12T14:21:13.0617191Z For more information about this error, try `rustc --explain E0560`.
2019-08-12T14:21:13.0617335Z 
---
2019-08-12T14:21:13.0624066Z thread 'main' panicked at 'Some tests failed', src/tools/compiletest/src/main.rs:536:22
2019-08-12T14:21:13.0624459Z note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace.
2019-08-12T14:21:13.0633025Z 
2019-08-12T14:21:13.0633233Z 
2019-08-12T14:21:13.0635287Z command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "--compile-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib" "--run-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "--rustc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "--src-base" "/checkout/src/test/ui-fulldeps" "--build-base" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui-fulldeps" "--stage-id" "stage2-x86_64-unknown-linux-gnu" "--mode" "ui" "--target" "x86_64-unknown-linux-gnu" "--host" "x86_64-unknown-linux-gnu" "--llvm-filecheck" "/usr/lib/llvm-6.0/bin/FileCheck" "--host-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--target-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--docck-python" "/usr/bin/python2.7" "--lldb-python" "/usr/bin/python2.7" "--gdb" "/usr/bin/gdb" "--quiet" "--llvm-version" "6.0.0\n" "--system-llvm" "--cc" "" "--cxx" "" "--cflags" "" "--llvm-components" "" "--llvm-cxxflags" "" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--color" "always"
2019-08-12T14:21:13.0635932Z 
2019-08-12T14:21:13.0636039Z 
2019-08-12T14:21:13.0643605Z failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
2019-08-12T14:21:13.0643726Z Build completed unsuccessfully in 1:09:23
2019-08-12T14:21:13.0643726Z Build completed unsuccessfully in 1:09:23
2019-08-12T14:21:14.2607734Z ##[error]Bash exited with code '1'.
2019-08-12T14:21:14.2664168Z ##[section]Starting: Checkout
2019-08-12T14:21:14.2665734Z ==============================================================================
2019-08-12T14:21:14.2665779Z Task         : Get sources
2019-08-12T14:21:14.2665821Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@eddyb eddyb force-pushed the eddyb:cvarargs branch from 7e57d8f to d2503bb Aug 12, 2019

@rust-highfive

This comment was marked as resolved.

Copy link
Collaborator

commented Aug 12, 2019

The job x86_64-gnu-llvm-6.0 of your PR failed (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
2019-08-12T16:02:40.1818953Z ##[command]git remote add origin https://github.com/rust-lang/rust
2019-08-12T16:02:40.2003315Z ##[command]git config gc.auto 0
2019-08-12T16:02:40.2044716Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2019-08-12T16:02:40.2121460Z ##[command]git config --get-all http.proxy
2019-08-12T16:02:40.2277421Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/63492/merge:refs/remotes/pull/63492/merge
---
2019-08-12T16:03:16.9887448Z do so (now or later) by using -b with the checkout command again. Example:
2019-08-12T16:03:16.9888730Z 
2019-08-12T16:03:16.9890204Z   git checkout -b <new-branch-name>
2019-08-12T16:03:16.9892037Z 
2019-08-12T16:03:16.9892874Z HEAD is now at 6c83613af Merge d2503bbe2fe54a133d0a1d49dc37cb81761d03f2 into c01be67ea40266d6a4c3289654a07ddd7ce2a172
2019-08-12T16:03:17.0037661Z ##[section]Starting: Collect CPU-usage statistics in the background
2019-08-12T16:03:17.0040140Z ==============================================================================
2019-08-12T16:03:17.0040190Z Task         : Bash
2019-08-12T16:03:17.0040230Z Description  : Run a Bash script on macOS, Linux, or Windows
---
2019-08-12T17:03:43.3239767Z .................................................................................................... 1300/8876
2019-08-12T17:03:49.7782317Z .................................................................................................... 1400/8876
2019-08-12T17:03:55.9974063Z .................................................................................................... 1500/8876
2019-08-12T17:04:06.4057177Z .....................................................................................i.............. 1600/8876
2019-08-12T17:04:13.8421243Z .i.................................................................................................. 1700/8876
2019-08-12T17:04:20.5590953Z ............................................................................iiiii................... 1800/8876
2019-08-12T17:04:42.0806192Z .................................................................................................... 2000/8876
2019-08-12T17:04:44.4779897Z .................................................................................................... 2100/8876
2019-08-12T17:04:47.1345589Z .................................................................................................... 2200/8876
2019-08-12T17:04:54.8110537Z .................................................................................................... 2300/8876
---
2019-08-12T17:08:47.1839673Z .................................................................................................... 5300/8876
2019-08-12T17:08:54.5120465Z .........i.......................................................................................... 5400/8876
2019-08-12T17:08:59.9375173Z .................................................................................................... 5500/8876
2019-08-12T17:09:12.0521139Z .................................................................................................... 5600/8876
2019-08-12T17:09:25.9943684Z ....ii...i..ii...........i.......................................................................... 5700/8876
2019-08-12T17:09:44.1447741Z .................................................................................................... 5900/8876
2019-08-12T17:09:48.8223649Z .................................................................................................... 6000/8876
2019-08-12T17:09:48.8223649Z .................................................................................................... 6000/8876
2019-08-12T17:10:02.7947379Z .....i..ii.......................................................................................... 6100/8876
2019-08-12T17:10:21.2748513Z ................................................i................................................... 6300/8876
2019-08-12T17:10:23.3912194Z .................................................................................................... 6400/8876
2019-08-12T17:10:25.8590214Z ....................i............................................................................... 6500/8876
2019-08-12T17:10:30.3537109Z .................................................................................................... 6600/8876
---
2019-08-12T17:15:09.2468390Z  finished in 22.872
2019-08-12T17:15:09.2641284Z Check compiletest suite=codegen mode=codegen (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-08-12T17:15:09.4234947Z 
2019-08-12T17:15:09.4236434Z running 146 tests
2019-08-12T17:15:12.6008535Z i....iii......iii..iiii....i............................i..i................i....i.........ii.i.i..i 100/146
2019-08-12T17:15:14.3910208Z iii..............i.........iii.i......ii......
2019-08-12T17:15:14.3913659Z 
2019-08-12T17:15:14.3914065Z  finished in 5.127
2019-08-12T17:15:14.4094642Z Check compiletest suite=codegen-units mode=codegen-units (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-08-12T17:15:14.5681012Z 
---
2019-08-12T17:15:16.6240044Z  finished in 2.213
2019-08-12T17:15:16.6412445Z Check compiletest suite=assembly mode=assembly (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-08-12T17:15:16.7910846Z 
2019-08-12T17:15:16.7913779Z running 9 tests
2019-08-12T17:15:16.7915477Z iiiiiiiii
2019-08-12T17:15:16.7918833Z 
2019-08-12T17:15:16.7918887Z  finished in 0.150
2019-08-12T17:15:16.8088151Z Check compiletest suite=incremental mode=incremental (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-08-12T17:15:16.9658805Z 
---
2019-08-12T17:15:35.0259437Z  finished in 18.214
2019-08-12T17:15:35.0444252Z Check compiletest suite=debuginfo mode=debuginfo-gdb+lldb (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-08-12T17:15:35.2031014Z 
2019-08-12T17:15:35.2031300Z running 122 tests
2019-08-12T17:15:58.9011828Z .iiiii...i.....i..i...i..i.i.i..i.ii..i.i.....i..i....i..........iiii..........i...ii...i.......ii.i 100/122
2019-08-12T17:16:03.5624635Z .i.i......iii.i.....ii
2019-08-12T17:16:03.5625560Z 
2019-08-12T17:16:03.5630156Z  finished in 28.518
2019-08-12T17:16:03.5636240Z Uplifting stage1 rustc (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-08-12T17:16:03.5637213Z Copying stage2 rustc from stage1 (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu / x86_64-unknown-linux-gnu)
---
2019-08-12T17:30:05.1485453Z 
2019-08-12T17:30:05.1487844Z    Doc-tests core
2019-08-12T17:30:09.2433886Z 
2019-08-12T17:30:09.2434114Z running 2380 tests
2019-08-12T17:30:21.9369171Z ......iiiii......................................................................................... 100/2380
2019-08-12T17:30:34.5638991Z .........................................................................ii......................... 200/2380
2019-08-12T17:31:05.4375648Z .................................................................................................... 400/2380
2019-08-12T17:31:05.4375648Z .................................................................................................... 400/2380
2019-08-12T17:31:15.9519537Z ..............................i..i.................iiii............................................. 500/2380
2019-08-12T17:31:39.8661049Z .................................................................................................... 700/2380
2019-08-12T17:31:52.9518412Z .................................................................................................... 800/2380
2019-08-12T17:32:04.5432331Z .................................................................................................... 900/2380
2019-08-12T17:32:16.6824900Z .................................................................................................... 1000/2380
---
2019-08-12T17:37:35.5924243Z 
2019-08-12T17:37:35.5925625Z running 991 tests
2019-08-12T17:37:59.2814880Z i................................................................................................... 100/991
2019-08-12T17:38:12.5686105Z .................................................................................................... 200/991
2019-08-12T17:38:21.4442668Z .................iii......i......i...i......i....................................................... 300/991
2019-08-12T17:38:26.5145385Z .................................................................................................... 400/991
2019-08-12T17:38:34.7421451Z ..................................i..i.................................ii........................... 500/991
2019-08-12T17:38:49.7122435Z .................................................................................................... 700/991
2019-08-12T17:38:49.7122435Z .................................................................................................... 700/991
2019-08-12T17:38:58.1491987Z .................iiii............................................................................... 800/991
2019-08-12T17:39:12.9263301Z .................................................................................................... 900/991
2019-08-12T17:39:20.7098819Z .......................................iiii................................................
2019-08-12T17:39:20.7099368Z 
2019-08-12T17:39:20.7302754Z  finished in 244.799
2019-08-12T17:39:20.7327227Z Testing unwind stage1 (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-08-12T17:39:20.9195103Z     Finished release [optimized] target(s) in 0.18s
---
2019-08-12T17:42:25.1627611Z 
2019-08-12T17:42:25.1704137Z  finished in 18.295
2019-08-12T17:42:25.1722933Z Testing syntax stage1 (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-08-12T17:42:25.3929100Z    Compiling syntax v0.0.0 (/checkout/src/libsyntax)
2019-08-12T17:42:31.7640058Z error[E0560]: struct `ast::FnDecl` has no field named `c_variadic`
2019-08-12T17:42:31.7641090Z   --> src/libsyntax/print/pprust/tests.rs:32:13
2019-08-12T17:42:31.7641601Z    |
2019-08-12T17:42:31.7642179Z 32 |             c_variadic: false
2019-08-12T17:42:31.7643012Z    |             ^^^^^^^^^^ `ast::FnDecl` does not have this field
2019-08-12T17:42:31.7643584Z    |
2019-08-12T17:42:31.7644185Z    = note: available fields are: `inputs`, `output`
2019-08-12T17:42:32.3781896Z error: aborting due to previous error
2019-08-12T17:42:32.3782414Z 
2019-08-12T17:42:32.3782768Z For more information about this error, try `rustc --explain E0560`.
2019-08-12T17:42:32.4598661Z error: Could not compile `syntax`.
2019-08-12T17:42:32.4598661Z error: Could not compile `syntax`.
2019-08-12T17:42:32.4598834Z 
2019-08-12T17:42:32.4599062Z To learn more, run the command again with --verbose.
2019-08-12T17:42:32.4618269Z 
2019-08-12T17:42:32.4618387Z 
2019-08-12T17:42:32.4619031Z command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "test" "--target" "x86_64-unknown-linux-gnu" "-j" "2" "--release" "--locked" "--color" "always" "--features" "" "--manifest-path" "/checkout/src/rustc/Cargo.toml" "-p" "syntax" "--" "--quiet"
2019-08-12T17:42:32.4619134Z 
2019-08-12T17:42:32.4619173Z 
2019-08-12T17:42:32.4633080Z failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
2019-08-12T17:42:32.4633153Z Build completed unsuccessfully in 1:33:12
2019-08-12T17:42:32.4633153Z Build completed unsuccessfully in 1:33:12
2019-08-12T17:42:33.0450231Z ##[error]Bash exited with code '1'.
2019-08-12T17:42:33.0491665Z ##[section]Starting: Checkout
2019-08-12T17:42:33.0493936Z ==============================================================================
2019-08-12T17:42:33.0493990Z Task         : Get sources
2019-08-12T17:42:33.0494037Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@eddyb eddyb force-pushed the eddyb:cvarargs branch from d2503bb to c8a56c5 Aug 13, 2019

@dlrobertson
Copy link
Contributor

left a comment

👍 Great stuff! This is much cleaner.

@@ -2102,7 +2097,14 @@ impl<'a> LoweringContext<'a> {
}

fn lower_fn_args_to_names(&mut self, decl: &FnDecl) -> hir::HirVec<Ident> {
decl.inputs
// Skip the `...` (`CVarArgs`) trailing arguments from the AST,

This comment has been minimized.

Copy link
@dlrobertson

dlrobertson Aug 13, 2019

Contributor

Good idea to skip this here.

Show resolved Hide resolved src/librustc_codegen_ssa/mir/block.rs Outdated
Show resolved Hide resolved src/librustc_mir/build/mod.rs

@eddyb eddyb force-pushed the eddyb:cvarargs branch from c8a56c5 to 8b9d92c Aug 13, 2019

@eddyb eddyb force-pushed the eddyb:cvarargs branch from 8b9d92c to f6d4b3b Aug 14, 2019

@bors

This comment has been minimized.

Copy link
Contributor

commented Aug 17, 2019

☔️ The latest upstream changes (presumably #63655) made this pull request unmergeable. Please resolve the merge conflicts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.