Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update installed compiler dependencies #63630

Open
wants to merge 1 commit into
base: master
from

Conversation

@andjo403
Copy link
Contributor

commented Aug 16, 2019

As llvm have updated the minimum toolchain
https://reviews.llvm.org/D66188

@rust-highfive

This comment has been minimized.

Copy link
Collaborator

commented Aug 16, 2019

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@nikic

This comment has been minimized.

Copy link
Contributor

commented Aug 16, 2019

The bump only happened for LLVM 10 (while we're on LLVM 9), so technically we still support older compiler versions at this point in time.

@andjo403

This comment has been minimized.

Copy link
Contributor Author

commented Aug 16, 2019

but to get it to work you need to set the allow-old-toolchain in the config.toml for llvm to receive LLVM_TEMPORARILY_ALLOW_OLD_TOOLCHAIN shall we add that to the description then?

@JohnCSimon

This comment has been minimized.

Copy link

commented Aug 24, 2019

Ping from triage -
Hello, this PR has sat idle for eight days, what else needs to happen to resolve this?
@nikic @andjo403 @nikomatsakis

Thank you.

@andjo403

This comment has been minimized.

Copy link
Contributor Author

commented Aug 24, 2019

maybe I shall point to the https://reviews.llvm.org/D57264 that is in the llvm version used and due to that commit there is an compile error if the LLVM_TEMPORARILY_ALLOW_OLD_TOOLCHAIN option is not set and as that is not described in the readme I think update the compiler version is a good solution when llvm 10 also removes that possibility anyway.

@nikomatsakis

This comment has been minimized.

Copy link
Contributor

commented Aug 30, 2019

I think it makes sense to list the more modern dependencies as the default, and perhaps add a "subbullet" or something saying "you can use the older versions if you set LLVM_TEMPORARILY_ALLOW_OLD_TOOLCHAIN". (IIUC, that env variable is needed to use the older versions?)

@andjo403 andjo403 force-pushed the andjo403:bump_compiler branch from cbf828e to 55c8e13 Aug 31, 2019

@andjo403

This comment has been minimized.

Copy link
Contributor Author

commented Aug 31, 2019

added a description in new chapter "Building rustc with older host toolchains"

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@JohnCSimon

This comment has been minimized.

Copy link

commented Sep 14, 2019

Ping from triage -
Hi! @andjo403 , can you please address the change request from @nikomatsakis?

Thank you.

Update installed compiler dependencies
there is a soft-error for older toolchains
from https://reviews.llvm.org/D57264 in preparation for the
hard error in https://reviews.llvm.org/D66188

@andjo403 andjo403 force-pushed the andjo403:bump_compiler branch from 55c8e13 to 166719a Sep 14, 2019

@andjo403

This comment has been minimized.

Copy link
Contributor Author

commented Sep 14, 2019

update the text according to the comments but also removed the range of compilers that was listed before due to the higher version listed did not need the option to be set

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.