Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Miri ops (unary, binary) to have more types #63658

Merged
merged 3 commits into from Aug 17, 2019

Conversation

@RalfJung
Copy link
Member

commented Aug 17, 2019

This is the part of #63448 that is just a refactoring. It helps that PR by making it easier to perform machine arithmetic.

r? @oli-obk @eddyb

@oli-obk

This comment has been minimized.

Copy link
Contributor

commented Aug 17, 2019

@bors r+

@bors

This comment has been minimized.

Copy link
Contributor

commented Aug 17, 2019

📌 Commit 5ac2045 has been approved by oli-obk

@bors

This comment has been minimized.

Copy link
Contributor

commented Aug 17, 2019

⌛️ Testing commit 5ac2045 with merge 2111aed...

bors added a commit that referenced this pull request Aug 17, 2019
Auto merge of #63658 - RalfJung:miri-op, r=oli-obk
Refactor Miri ops (unary, binary) to have more types

This is the part of #63448 that is just a refactoring. It helps that PR by making it easier to perform machine arithmetic.

r? @oli-obk @eddyb
@bors

This comment has been minimized.

Copy link
Contributor

commented Aug 17, 2019

☀️ Test successful - checks-azure
Approved by: oli-obk
Pushing 2111aed to master...

@bors bors added the merged-by-bors label Aug 17, 2019

@bors bors merged commit 5ac2045 into rust-lang:master Aug 17, 2019

5 checks passed

homu Test successful
Details
pr Build #20190817.12 succeeded
Details
pr (Linux mingw-check) Linux mingw-check succeeded
Details
pr (Linux x86_64-gnu-llvm-6.0) Linux x86_64-gnu-llvm-6.0 succeeded
Details
pr (LinuxTools) LinuxTools succeeded
Details
@rust-highfive

This comment has been minimized.

Copy link
Collaborator

commented Aug 17, 2019

📣 Toolstate changed by #63658!

Tested on commit 2111aed.
Direct link to PR: #63658

💔 miri on windows: test-pass → build-fail (cc @oli-obk @RalfJung @eddyb, @rust-lang/infra).
💔 miri on linux: test-pass → build-fail (cc @oli-obk @RalfJung @eddyb, @rust-lang/infra).

rust-highfive added a commit to rust-lang-nursery/rust-toolstate that referenced this pull request Aug 17, 2019
📣 Toolstate changed by rust-lang/rust#63658!
Tested on commit rust-lang/rust@2111aed.
Direct link to PR: <rust-lang/rust#63658>

💔 miri on windows: test-pass → build-fail (cc @oli-obk @RalfJung @eddyb, @rust-lang/infra).
💔 miri on linux: test-pass → build-fail (cc @oli-obk @RalfJung @eddyb, @rust-lang/infra).

@RalfJung RalfJung deleted the RalfJung:miri-op branch Aug 18, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.