Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved error message for break in async block #63659

Merged
merged 1 commit into from Aug 18, 2019

Conversation

@gilescope
Copy link
Contributor

commented Aug 17, 2019

Fixes #63391

@rust-highfive

This comment has been minimized.

Copy link
Collaborator

commented Aug 17, 2019

r? @varkor

(rust_highfive has picked a reviewer for you, use r? to override)

@gilescope gilescope changed the title Less confusing error message. Improved error message for break in async block Aug 17, 2019

src/librustc_passes/loops.rs Outdated Show resolved Hide resolved
@Centril

This comment has been minimized.

Copy link
Member

commented Aug 17, 2019

r? @Centril

r=me rollup with comment addressed.

@rust-highfive rust-highfive assigned Centril and unassigned varkor Aug 17, 2019

@gilescope gilescope force-pushed the gilescope:async-in-closure branch from 82133db to 1e02bc6 Aug 18, 2019

@Centril

This comment has been minimized.

Copy link
Member

commented Aug 18, 2019

@bors r+

@bors

This comment has been minimized.

Copy link
Contributor

commented Aug 18, 2019

📌 Commit 1e02bc6 has been approved by Centril

Centril added a commit to Centril/rust that referenced this pull request Aug 18, 2019
Rollup merge of rust-lang#63659 - gilescope:async-in-closure, r=Centril
Improved error message for break in async block

Fixes rust-lang#63391
bors added a commit that referenced this pull request Aug 18, 2019
Auto merge of #63683 - Centril:rollup-pnig1vc, r=Centril
Rollup of 3 pull requests

Successful merges:

 - #61626 (Get rid of special const intrinsic query in favour of `const_eval`)
 - #63635 (Do not generate allocations for zero sized allocations)
 - #63659 (Improved error message for break in async block)

Failed merges:

r? @ghost
@bors

This comment has been minimized.

Copy link
Contributor

commented Aug 18, 2019

⌛️ Testing commit 1e02bc6 with merge 4cf7673...

bors added a commit that referenced this pull request Aug 18, 2019
Auto merge of #63659 - gilescope:async-in-closure, r=Centril
Improved error message for break in async block

Fixes #63391
@bors

This comment has been minimized.

Copy link
Contributor

commented Aug 18, 2019

☀️ Test successful - checks-azure
Approved by: Centril
Pushing 4cf7673 to master...

@bors bors added the merged-by-bors label Aug 18, 2019

@bors bors merged commit 1e02bc6 into rust-lang:master Aug 18, 2019

5 checks passed

homu Test successful
Details
pr Build #20190818.10 succeeded
Details
pr (Linux mingw-check) Linux mingw-check succeeded
Details
pr (Linux x86_64-gnu-llvm-6.0) Linux x86_64-gnu-llvm-6.0 succeeded
Details
pr (LinuxTools) LinuxTools succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.