Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly suggest adding bounds to `impl Trait` argument #63811

Merged
merged 2 commits into from Aug 29, 2019

Conversation

@estebank
Copy link
Contributor

commented Aug 22, 2019

Fix #63706.

@rust-highfive

This comment has been minimized.

Copy link
Collaborator

commented Aug 22, 2019

r? @cramertj

(rust_highfive has picked a reviewer for you, use r? to override)

@estebank

This comment has been minimized.

Copy link
Contributor Author

commented Aug 28, 2019

ping

@cramertj

This comment has been minimized.

Copy link
Member

commented Aug 28, 2019

@bors r+

Thanks!

@bors

This comment has been minimized.

Copy link
Contributor

commented Aug 28, 2019

📌 Commit 055f7e2 has been approved by cramertj

Centril added a commit to Centril/rust that referenced this pull request Aug 29, 2019
Rollup merge of rust-lang#63811 - estebank:impl-trait-arg, r=cramertj
Correctly suggest adding bounds to `impl Trait` argument

Fix rust-lang#63706.
bors added a commit that referenced this pull request Aug 29, 2019
Auto merge of #63990 - Centril:rollup-q1nt0b0, r=Centril
Rollup of 11 pull requests

Successful merges:

 - #63811 (Correctly suggest adding bounds to `impl Trait` argument)
 - #63933 (Resolve some small issues related to #63580)
 - #63938 (or-pattern: fix typo in error message)
 - #63945 (Recover `mut $pat` and other improvements)
 - #63958 (const_prop: only call error_to_const_error if we are actually showing something)
 - #63961 (Add Option<Span> to `require_lang_item`)
 - #63963 (remove the reference to __cxa_thread_atexit_impl)
 - #63965 (Prevent syntax error in LD linker version script)
 - #63968 (rustc_apfloat: make the crate #![no_std] explicitly.)
 - #63970 (Notify me (flip1995) when Clippy toolstate changes)
 - #63980 (add missing `#[repr(C)]` on the Slices union)

Failed merges:

 - #63989 (Add Yaah to clippy toolstain notification list)

r? @ghost
@bors

This comment has been minimized.

Copy link
Contributor

commented Aug 29, 2019

⌛️ Testing commit 055f7e2 with merge 85ed538...

@bors bors merged commit 055f7e2 into rust-lang:master Aug 29, 2019

4 of 5 checks passed

homu Testing commit 055f7e2ec23f36e522e318a64eab414caba55e7e with merge 85ed538d6988c6c82aea8750b306cb793e874294...
Details
pr Build #20190823.10 succeeded
Details
pr (Linux mingw-check) Linux mingw-check succeeded
Details
pr (Linux x86_64-gnu-llvm-6.0) Linux x86_64-gnu-llvm-6.0 succeeded
Details
pr (LinuxTools) LinuxTools succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.