Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use hygiene for AST passes #63919

Merged
merged 10 commits into from Sep 7, 2019

Conversation

@matthewjasper
Copy link
Contributor

commented Aug 26, 2019

AST passes are now able to have resolve consider their expansions as if they were opaque macros defined either in some module in the current crate, or a fake empty module with #[no_implicit_prelude].

  • Add an ExpnKind for AST passes.
  • Remove gensyms in AST passes.
  • Remove gensyms in#[test], #[bench] and #[test_case].
  • Allow opaque macros to define tests.
  • Move tests for unit tests to their own directory.
  • Remove Ident::{gensym, is_gensymed} - Ident::gensym_if_underscore still exists.

cc #60869, #61019

r? @petrochenkov

@rust-highfive

This comment was marked as resolved.

Copy link
Collaborator

commented Aug 26, 2019

The job x86_64-gnu-llvm-6.0 of your PR failed (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
2019-08-26T17:08:07.4071455Z ##[command]git remote add origin https://github.com/rust-lang/rust
2019-08-26T17:08:07.4254141Z ##[command]git config gc.auto 0
2019-08-26T17:08:07.4331705Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2019-08-26T17:08:07.4376033Z ##[command]git config --get-all http.proxy
2019-08-26T17:08:07.4512138Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/63919/merge:refs/remotes/pull/63919/merge
---
2019-08-26T17:08:43.1351965Z do so (now or later) by using -b with the checkout command again. Example:
2019-08-26T17:08:43.1352001Z 
2019-08-26T17:08:43.1352244Z   git checkout -b <new-branch-name>
2019-08-26T17:08:43.1352275Z 
2019-08-26T17:08:43.1352322Z HEAD is now at 7668717f3 Merge 183ae29ccd221bf9109f1eda6040f37f041c029d into 555d7a2fd6165b614cfc01136d8e3f5c465a1582
2019-08-26T17:08:43.1530032Z ##[section]Starting: Collect CPU-usage statistics in the background
2019-08-26T17:08:43.1534639Z ==============================================================================
2019-08-26T17:08:43.1534696Z Task         : Bash
2019-08-26T17:08:43.1534762Z Description  : Run a Bash script on macOS, Linux, or Windows
---
2019-08-26T18:10:07.7124963Z .................................................................................................... 1500/8956
2019-08-26T18:10:13.2851489Z .................................................................................................... 1600/8956
2019-08-26T18:10:25.7681455Z .............................................i...............i...................................... 1700/8956
2019-08-26T18:10:33.8155479Z .................................................................................................... 1800/8956
2019-08-26T18:10:48.0232103Z .....................................iiiii.......................................................... 1900/8956
2019-08-26T18:10:58.3806845Z .................................................................................................... 2100/8956
2019-08-26T18:11:00.7958780Z .................................................................................................... 2200/8956
2019-08-26T18:11:05.0063363Z .................................................................................................... 2300/8956
2019-08-26T18:11:12.1560697Z .................................................................................................... 2400/8956
---
2019-08-26T18:14:06.8916878Z ..........................i...............i......................................................... 4700/8956
2019-08-26T18:14:18.5377175Z .................................................................................................... 4800/8956
2019-08-26T18:14:24.5413784Z .................................................................................................... 4900/8956
2019-08-26T18:14:35.1343089Z .................................................................................................... 5000/8956
2019-08-26T18:14:40.6551640Z .......ii.ii........................................................................................ 5100/8956
2019-08-26T18:14:54.6551330Z .................................................................................................... 5300/8956
2019-08-26T18:15:01.6637759Z ...............................................................i.................................... 5400/8956
2019-08-26T18:15:08.6523185Z .................................................................................................... 5500/8956
2019-08-26T18:15:16.0124417Z .................................................................................................... 5600/8956
2019-08-26T18:15:16.0124417Z .................................................................................................... 5600/8956
2019-08-26T18:15:26.0564787Z .........................................................ii...i..ii...........i..................... 5700/8956
2019-08-26T18:15:47.2089207Z .................................................................................................... 5900/8956
2019-08-26T18:15:51.9930491Z .................................................................................................... 6000/8956
2019-08-26T18:15:51.9930491Z .................................................................................................... 6000/8956
2019-08-26T18:15:58.8906930Z ..........................................................i..ii..................................... 6100/8956
2019-08-26T18:16:26.0733711Z .................................................................................................... 6300/8956
2019-08-26T18:16:28.2052802Z ....i............................................................................................... 6400/8956
2019-08-26T18:16:30.3508136Z ............................................................................i....................... 6500/8956
2019-08-26T18:16:32.9480492Z .................................................................................................... 6600/8956
---
2019-08-26T18:20:27.0058234Z -    |
2019-08-26T18:20:27.0058462Z - note: lint level defined here
2019-08-26T18:20:27.0059018Z -   --> $DIR/extern-crate-used.rs:6:9
2019-08-26T18:20:27.0059217Z -    |
2019-08-26T18:20:27.0059431Z - LL | #![deny(unused_extern_crates)]
2019-08-26T18:20:27.0059714Z 12 
2019-08-26T18:20:27.0059757Z 13 error: aborting due to previous error
2019-08-26T18:20:27.0059817Z 14 
2019-08-26T18:20:27.0059846Z 
2019-08-26T18:20:27.0059846Z 
2019-08-26T18:20:27.0060072Z 
2019-08-26T18:20:27.0060130Z The actual stderr differed from the expected stderr.
2019-08-26T18:20:27.0060514Z Actual stderr saved to /checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/imports/extern-crate-used/extern-crate-used.stderr
2019-08-26T18:20:27.0060773Z To update references, rerun the tests and pass the `--bless` flag
2019-08-26T18:20:27.0061078Z To only update this specific test, also pass `--test-args imports/extern-crate-used.rs`
2019-08-26T18:20:27.0061185Z error: 1 errors occurred comparing output.
2019-08-26T18:20:27.0061233Z status: exit code: 1
2019-08-26T18:20:27.0061233Z status: exit code: 1
2019-08-26T18:20:27.0062050Z command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/imports/extern-crate-used.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/imports/extern-crate-used" "-Crpath" "-O" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--edition=2018" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/imports/extern-crate-used/auxiliary" "-A" "unused"
2019-08-26T18:20:27.0062410Z ------------------------------------------
2019-08-26T18:20:27.0062448Z 
2019-08-26T18:20:27.0062689Z ------------------------------------------
2019-08-26T18:20:27.0062737Z stderr:
2019-08-26T18:20:27.0062737Z stderr:
2019-08-26T18:20:27.0062995Z ------------------------------------------
2019-08-26T18:20:27.0063045Z error: unused extern crate
2019-08-26T18:20:27.0063306Z   --> /checkout/src/test/ui/imports/extern-crate-used.rs:18:1
2019-08-26T18:20:27.0063505Z    |
2019-08-26T18:20:27.0063556Z LL | extern crate core; //~ ERROR unused extern crate
2019-08-26T18:20:27.0063660Z 
2019-08-26T18:20:27.0063707Z error: aborting due to previous error
2019-08-26T18:20:27.0063737Z 
2019-08-26T18:20:27.0063765Z 
---
2019-08-26T18:20:27.0064852Z -    |
2019-08-26T18:20:27.0065077Z - note: lint level defined here
2019-08-26T18:20:27.0065317Z -   --> $DIR/removing-extern-crate.rs:6:9
2019-08-26T18:20:27.0065556Z -    |
2019-08-26T18:20:27.0065787Z - LL | #![warn(rust_2018_idioms)]
2019-08-26T18:20:27.0066456Z -    |         ^^^^^^^^^^^^^^^^
2019-08-26T18:20:27.0066776Z -    = note: `#[warn(unused_extern_crates)]` implied by `#[warn(rust_2018_idioms)]`
2019-08-26T18:20:27.0066893Z 14 warning: unused extern crate
2019-08-26T18:20:27.0067163Z 15   --> $DIR/removing-extern-crate.rs:10:1
2019-08-26T18:20:27.0067198Z 
2019-08-26T18:20:27.0067226Z 
2019-08-26T18:20:27.0067226Z 
2019-08-26T18:20:27.0067273Z The actual stderr differed from the expected stderr.
2019-08-26T18:20:27.0067619Z Actual stderr saved to /checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/removing-extern-crate/removing-extern-crate.stderr
2019-08-26T18:20:27.0067890Z To update references, rerun the tests and pass the `--bless` flag
2019-08-26T18:20:27.0068173Z To only update this specific test, also pass `--test-args removing-extern-crate.rs`
2019-08-26T18:20:27.0068286Z error: 1 errors occurred comparing output.
2019-08-26T18:20:27.0068333Z status: exit code: 0
2019-08-26T18:20:27.0068333Z status: exit code: 0
2019-08-26T18:20:27.0069469Z command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/removing-extern-crate.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/removing-extern-crate" "-Crpath" "-O" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--edition=2018" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/removing-extern-crate/auxiliary" "-A" "unused"
2019-08-26T18:20:27.0069874Z ------------------------------------------
2019-08-26T18:20:27.0069910Z 
2019-08-26T18:20:27.0070135Z ------------------------------------------
2019-08-26T18:20:27.0070181Z stderr:
---
2019-08-26T18:20:27.0073789Z -    |
2019-08-26T18:20:27.0073994Z - note: lint level defined here
2019-08-26T18:20:27.0074232Z -   --> $DIR/extern-crate-idiomatic-in-2018.rs:9:9
2019-08-26T18:20:27.0074413Z -    |
2019-08-26T18:20:27.0074631Z - LL | #![deny(rust_2018_idioms)]
2019-08-26T18:20:27.0074837Z -    |         ^^^^^^^^^^^^^^^^
2019-08-26T18:20:27.0075120Z -    = note: `#[deny(unused_extern_crates)]` implied by `#[deny(rust_2018_idioms)]`
2019-08-26T18:20:27.0075226Z 14 error: aborting due to previous error
2019-08-26T18:20:27.0075287Z 15 
2019-08-26T18:20:27.0075313Z 
2019-08-26T18:20:27.0075337Z 
2019-08-26T18:20:27.0075337Z 
2019-08-26T18:20:27.0075381Z The actual stderr differed from the expected stderr.
2019-08-26T18:20:27.0075730Z Actual stderr saved to /checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/rust-2018/extern-crate-idiomatic-in-2018/extern-crate-idiomatic-in-2018.stderr
2019-08-26T18:20:27.0075978Z To update references, rerun the tests and pass the `--bless` flag
2019-08-26T18:20:27.0076301Z To only update this specific test, also pass `--test-args rust-2018/extern-crate-idiomatic-in-2018.rs`
2019-08-26T18:20:27.0076394Z error: 1 errors occurred comparing output.
2019-08-26T18:20:27.0076440Z status: exit code: 1
2019-08-26T18:20:27.0076440Z status: exit code: 1
2019-08-26T18:20:27.0077556Z command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/rust-2018/extern-crate-idiomatic-in-2018.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/rust-2018/extern-crate-idiomatic-in-2018" "-Crpath" "-O" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--extern" "edition_lint_paths" "--edition=2018" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/rust-2018/extern-crate-idiomatic-in-2018/auxiliary" "-A" "unused"
2019-08-26T18:20:27.0077935Z ------------------------------------------
2019-08-26T18:20:27.0077970Z 
2019-08-26T18:20:27.0078205Z ------------------------------------------
2019-08-26T18:20:27.0078272Z stderr:
---
2019-08-26T18:20:27.0080784Z -    |
2019-08-26T18:20:27.0080995Z - note: lint level defined here
2019-08-26T18:20:27.0081260Z -   --> $DIR/issue-54400-unused-extern-crate-attr-span.rs:6:9
2019-08-26T18:20:27.0081458Z -    |
2019-08-26T18:20:27.0081673Z - LL | #![deny(rust_2018_idioms)]
2019-08-26T18:20:27.0081906Z -    |         ^^^^^^^^^^^^^^^^
2019-08-26T18:20:27.0082172Z -    = note: `#[deny(unused_extern_crates)]` implied by `#[deny(rust_2018_idioms)]`
2019-08-26T18:20:27.0082284Z 17 error: aborting due to previous error
2019-08-26T18:20:27.0082325Z 18 
2019-08-26T18:20:27.0082353Z 
2019-08-26T18:20:27.0082379Z 
2019-08-26T18:20:27.0082379Z 
2019-08-26T18:20:27.0082423Z The actual stderr differed from the expected stderr.
2019-08-26T18:20:27.0082804Z Actual stderr saved to /checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/rust-2018/issue-54400-unused-extern-crate-attr-span/issue-54400-unused-extern-crate-attr-span.stderr
2019-08-26T18:20:27.0083078Z To update references, rerun the tests and pass the `--bless` flag
2019-08-26T18:20:27.0083574Z To only update this specific test, also pass `--test-args rust-2018/issue-54400-unused-extern-crate-attr-span.rs`
2019-08-26T18:20:27.0083663Z error: 1 errors occurred comparing output.
2019-08-26T18:20:27.0083706Z status: exit code: 1
2019-08-26T18:20:27.0083706Z status: exit code: 1
2019-08-26T18:20:27.0084591Z command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/rust-2018/issue-54400-unused-extern-crate-attr-span.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/rust-2018/issue-54400-unused-extern-crate-attr-span" "-Crpath" "-O" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--extern" "edition_lint_paths" "--cfg" "blandiloquence" "--edition=2018" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/rust-2018/issue-54400-unused-extern-crate-attr-span/auxiliary" "-A" "unused"
2019-08-26T18:20:27.0084939Z ------------------------------------------
2019-08-26T18:20:27.0084972Z 
2019-08-26T18:20:27.0085287Z ------------------------------------------
2019-08-26T18:20:27.0085339Z stderr:
2019-08-26T18:20:27.0085339Z stderr:
2019-08-26T18:20:27.0085574Z ------------------------------------------
2019-08-26T18:20:27.0085621Z error: unused extern crate
2019-08-26T18:20:27.0085905Z   --> /checkout/src/test/ui/rust-2018/issue-54400-unused-extern-crate-attr-span.rs:12:1
2019-08-26T18:20:27.0085956Z    |
2019-08-26T18:20:27.0086001Z LL | / #[cfg(blandiloquence)] //~ HELP remove it
2019-08-26T18:20:27.0086067Z LL | | extern crate edition_lint_paths;
2019-08-26T18:20:27.0086281Z    | | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^-
2019-08-26T18:20:27.0086404Z    |                                  help: remove it
2019-08-26T18:20:27.0086434Z 
2019-08-26T18:20:27.0086475Z error: aborting due to previous error
2019-08-26T18:20:27.0086503Z 
---
2019-08-26T18:20:27.0087476Z -    |
2019-08-26T18:20:27.0087677Z - note: lint level defined here
2019-08-26T18:20:27.0087911Z -   --> $DIR/remove-extern-crate.rs:7:9
2019-08-26T18:20:27.0088092Z -    |
2019-08-26T18:20:27.0088690Z - LL | #![warn(rust_2018_idioms)]
2019-08-26T18:20:27.0088937Z -    |         ^^^^^^^^^^^^^^^^
2019-08-26T18:20:27.0089323Z -    = note: `#[warn(unused_extern_crates)]` implied by `#[warn(rust_2018_idioms)]`
2019-08-26T18:20:27.0089373Z 13 
2019-08-26T18:20:27.0089441Z 14 warning: `extern crate` is not idiomatic in the new edition
2019-08-26T18:20:27.0089701Z 
2019-08-26T18:20:27.0089728Z 
2019-08-26T18:20:27.0089802Z The actual stderr differed from the expected stderr.
2019-08-26T18:20:27.0090127Z Actual stderr saved to /checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/rust-2018/remove-extern-crate/remove-extern-crate.stderr
2019-08-26T18:20:27.0090127Z Actual stderr saved to /checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/rust-2018/remove-extern-crate/remove-extern-crate.stderr
2019-08-26T18:20:27.0090381Z To update references, rerun the tests and pass the `--bless` flag
2019-08-26T18:20:27.0090705Z To only update this specific test, also pass `--test-args rust-2018/remove-extern-crate.rs`
2019-08-26T18:20:27.0090789Z error: 1 errors occurred comparing output.
2019-08-26T18:20:27.0090836Z status: exit code: 0
2019-08-26T18:20:27.0090836Z status: exit code: 0
2019-08-26T18:20:27.0091696Z command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/rust-2018/remove-extern-crate.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/rust-2018/remove-extern-crate" "-Crpath" "-O" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--edition=2018" "--extern" "remove_extern_crate" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/rust-2018/remove-extern-crate/auxiliary" "-A" "unused"
2019-08-26T18:20:27.0092060Z ------------------------------------------
2019-08-26T18:20:27.0092097Z 
2019-08-26T18:20:27.0092339Z ------------------------------------------
2019-08-26T18:20:27.0092407Z stderr:
2019-08-26T18:20:27.0092407Z stderr:
2019-08-26T18:20:27.0092643Z ------------------------------------------
2019-08-26T18:20:27.0092692Z warning: unused extern crate
2019-08-26T18:20:27.0092992Z   --> /checkout/src/test/ui/rust-2018/remove-extern-crate.rs:9:1
2019-08-26T18:20:27.0093044Z    |
2019-08-26T18:20:27.0093091Z LL | extern crate core;
2019-08-26T18:20:27.0093158Z    | ^^^^^^^^^^^^^^^^^^ help: remove it
2019-08-26T18:20:27.0093190Z 
2019-08-26T18:20:27.0093238Z warning: `extern crate` is not idiomatic in the new edition
2019-08-26T18:20:27.0093667Z    |
2019-08-26T18:20:27.0093712Z LL |     extern crate core;
2019-08-26T18:20:27.0093762Z    |     ^^^^^^^^^^^^^^^^^^ help: convert it to a `use`
2019-08-26T18:20:27.0093814Z 
---
2019-08-26T18:20:27.0094884Z -    |
2019-08-26T18:20:27.0095126Z - note: lint level defined here
2019-08-26T18:20:27.0095365Z -   --> $DIR/unnecessary-extern-crate.rs:3:9
2019-08-26T18:20:27.0095568Z -    |
2019-08-26T18:20:27.0095979Z - LL | #![deny(unused_extern_crates)]
2019-08-26T18:20:27.0096282Z 12 
2019-08-26T18:20:27.0096342Z 13 error: unused extern crate
2019-08-26T18:20:27.0096572Z 14   --> $DIR/unnecessary-extern-crate.rs:9:1
2019-08-26T18:20:27.0096605Z 
2019-08-26T18:20:27.0096605Z 
2019-08-26T18:20:27.0096630Z 
2019-08-26T18:20:27.0096674Z The actual stderr differed from the expected stderr.
2019-08-26T18:20:27.0097000Z Actual stderr saved to /checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/unnecessary-extern-crate/unnecessary-extern-crate.stderr
2019-08-26T18:20:27.0097246Z To update references, rerun the tests and pass the `--bless` flag
2019-08-26T18:20:27.0097647Z To only update this specific test, also pass `--test-args unnecessary-extern-crate.rs`
2019-08-26T18:20:27.0097728Z error: 1 errors occurred comparing output.
2019-08-26T18:20:27.0097772Z status: exit code: 1
2019-08-26T18:20:27.0097772Z status: exit code: 1
2019-08-26T18:20:27.0098907Z command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/unnecessary-extern-crate.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/unnecessary-extern-crate" "-Crpath" "-O" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--edition=2018" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/unnecessary-extern-crate/auxiliary" "-A" "unused"
2019-08-26T18:20:27.0099285Z ------------------------------------------
2019-08-26T18:20:27.0099330Z 
2019-08-26T18:20:27.0099559Z ------------------------------------------
2019-08-26T18:20:27.0099626Z stderr:
---
2019-08-26T18:20:27.0138372Z thread 'main' panicked at 'Some tests failed', src/tools/compiletest/src/main.rs:536:22
2019-08-26T18:20:27.0138451Z note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace.
2019-08-26T18:20:27.0157645Z 
2019-08-26T18:20:27.0159576Z 
2019-08-26T18:20:27.0161347Z command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "--compile-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib" "--run-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "--rustc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "--src-base" "/checkout/src/test/ui" "--build-base" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui" "--stage-id" "stage2-x86_64-unknown-linux-gnu" "--mode" "ui" "--target" "x86_64-unknown-linux-gnu" "--host" "x86_64-unknown-linux-gnu" "--llvm-filecheck" "/usr/lib/llvm-6.0/bin/FileCheck" "--host-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--target-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--docck-python" "/usr/bin/python2.7" "--lldb-python" "/usr/bin/python2.7" "--gdb" "/usr/bin/gdb" "--quiet" "--llvm-version" "6.0.0\n" "--system-llvm" "--cc" "" "--cxx" "" "--cflags" "" "--llvm-components" "" "--llvm-cxxflags" "" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--color" "always"
2019-08-26T18:20:27.0161889Z 
2019-08-26T18:20:27.0161926Z 
2019-08-26T18:20:27.0189026Z failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
2019-08-26T18:20:27.0189107Z Build completed unsuccessfully in 1:05:21
2019-08-26T18:20:27.0189107Z Build completed unsuccessfully in 1:05:21
2019-08-26T18:20:27.0222015Z == clock drift check ==
2019-08-26T18:20:27.0239181Z   local time: Mon Aug 26 18:20:27 UTC 2019
2019-08-26T18:20:27.1088692Z   network time: Mon, 26 Aug 2019 18:20:27 GMT
2019-08-26T18:20:27.1089433Z == end clock drift check ==
2019-08-26T18:20:28.1931064Z ##[error]Bash exited with code '1'.
2019-08-26T18:20:28.1974833Z ##[section]Starting: Checkout
2019-08-26T18:20:28.1976514Z ==============================================================================
2019-08-26T18:20:28.1976567Z Task         : Get sources
2019-08-26T18:20:28.1976630Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@rust-highfive

This comment was marked as resolved.

Copy link
Collaborator

commented Aug 27, 2019

The job x86_64-gnu-llvm-6.0 of your PR failed (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
2019-08-27T20:14:31.2014900Z ##[command]git remote add origin https://github.com/rust-lang/rust
2019-08-27T20:14:31.2208584Z ##[command]git config gc.auto 0
2019-08-27T20:14:31.2296650Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2019-08-27T20:14:31.2375070Z ##[command]git config --get-all http.proxy
2019-08-27T20:14:31.2521066Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/63919/merge:refs/remotes/pull/63919/merge
---
2019-08-27T20:15:04.4735177Z do so (now or later) by using -b with the checkout command again. Example:
2019-08-27T20:15:04.4735425Z 
2019-08-27T20:15:04.4735796Z   git checkout -b <new-branch-name>
2019-08-27T20:15:04.4735990Z 
2019-08-27T20:15:04.4776655Z HEAD is now at 3a6257f97 Merge 9f9ff32f00c8e588406b73583c5095578a4b2200 into 53df91a9b24ad999e7ca896447af6f5f74fe43bc
2019-08-27T20:15:04.4901002Z ##[section]Starting: Collect CPU-usage statistics in the background
2019-08-27T20:15:04.4905070Z ==============================================================================
2019-08-27T20:15:04.4905127Z Task         : Bash
2019-08-27T20:15:04.4905191Z Description  : Run a Bash script on macOS, Linux, or Windows
---
2019-08-27T20:48:00.8052869Z == clock drift check ==
2019-08-27T20:48:00.8070204Z   local time: Tue Aug 27 20:48:00 UTC 2019
2019-08-27T20:48:00.9596579Z   network time: Tue, 27 Aug 2019 20:48:00 GMT
2019-08-27T20:48:00.9597618Z == end clock drift check ==
2019-08-27T20:48:03.2548281Z ##[error]Bash exited with code '1'.
2019-08-27T20:48:03.2595346Z ##[section]Starting: Checkout
2019-08-27T20:48:03.2596992Z ==============================================================================
2019-08-27T20:48:03.2597305Z Task         : Get sources
2019-08-27T20:48:03.2597557Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@petrochenkov

This comment has been minimized.

Copy link
Contributor

commented Aug 27, 2019

Nice, nice. The end of gensyms is closer with every day.

}
visible_path.extend_from_slice(path);
visible_path
}

This comment has been minimized.

Copy link
@petrochenkov

petrochenkov Aug 27, 2019

Contributor

I see the test harness is rewritten significantly.
Could you document what is generated now?

If identifiers with carefully located def-site spans are used instead of reexports, then we should be able to support #[test] attributes everywhere, including inside functions, blocks etc.
This also should obviate the need in #[test_case], the whole purpose of which is to add pub which is no longer necessary if the privacy check is performed from the new def-site span's point of view.

This comment has been minimized.

Copy link
@petrochenkov

petrochenkov Sep 5, 2019

Contributor

Ok, looks like with the new hygienic ident approach the test infrastructure can indeed be simplified and improved further, but nothing prevents landing it in the current intermediate state.
(I think I'll going to investigate this myself a bit later, I still don't like that apply_mark has to be used.)

@petrochenkov

This comment has been minimized.

Copy link
Contributor

commented Aug 27, 2019

I've left some high-level comments, but didn't read the code in detail, will do that somewhere this week.

@rust-highfive

This comment was marked as resolved.

Copy link
Collaborator

commented Aug 30, 2019

The job x86_64-gnu-llvm-6.0 of your PR failed (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
2019-08-30T22:14:59.1218203Z ##[command]git remote add origin https://github.com/rust-lang/rust
2019-08-30T22:14:59.1426775Z ##[command]git config gc.auto 0
2019-08-30T22:14:59.1550038Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2019-08-30T22:14:59.1590772Z ##[command]git config --get-all http.proxy
2019-08-30T22:14:59.1737016Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/63919/merge:refs/remotes/pull/63919/merge
---
2019-08-30T22:21:58.5175288Z    Compiling serde_json v1.0.40
2019-08-30T22:22:00.2803316Z    Compiling tidy v0.1.0 (/checkout/src/tools/tidy)
2019-08-30T22:22:11.1839795Z     Finished release [optimized] target(s) in 1m 29s
2019-08-30T22:22:11.1917870Z tidy check
2019-08-30T22:22:11.8842985Z tidy error: /checkout/src/test/ui/definition-reachable/auxiliary/underscore.rs: too many trailing newlines (2)
2019-08-30T22:22:13.2249391Z some tidy checks failed
2019-08-30T22:22:13.2257617Z 
2019-08-30T22:22:13.2257617Z 
2019-08-30T22:22:13.2258542Z command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/tidy" "/checkout/src" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "--no-vendor"
2019-08-30T22:22:13.2260166Z 
2019-08-30T22:22:13.2261250Z 
2019-08-30T22:22:13.2264397Z failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test src/tools/tidy
2019-08-30T22:22:13.2264623Z Build completed unsuccessfully in 0:01:32
2019-08-30T22:22:13.2264623Z Build completed unsuccessfully in 0:01:32
2019-08-30T22:22:13.2321495Z == clock drift check ==
2019-08-30T22:22:13.2335375Z   local time: Fri Aug 30 22:22:13 UTC 2019
2019-08-30T22:22:13.3856834Z   network time: Fri, 30 Aug 2019 22:22:13 GMT
2019-08-30T22:22:13.3856963Z == end clock drift check ==
2019-08-30T22:22:14.8135952Z ##[error]Bash exited with code '1'.
2019-08-30T22:22:14.8178611Z ##[section]Starting: Checkout
2019-08-30T22:22:14.8180158Z ==============================================================================
2019-08-30T22:22:14.8180202Z Task         : Get sources
2019-08-30T22:22:14.8180239Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@matthewjasper matthewjasper force-pushed the matthewjasper:remove-gensymmed branch from a93b68f to b992aec Aug 30, 2019

src/librustc_resolve/macros.rs Outdated Show resolved Hide resolved
src/libsyntax_pos/hygiene.rs Outdated Show resolved Hide resolved
src/librustc_privacy/lib.rs Outdated Show resolved Hide resolved
src/libsyntax_ext/proc_macro_harness.rs Outdated Show resolved Hide resolved
src/libsyntax_ext/proc_macro_harness.rs Outdated Show resolved Hide resolved
@petrochenkov

This comment has been minimized.

Copy link
Contributor

commented Sep 2, 2019

(Still need to review test harness and stdlib injection.)

}
visible_path.extend_from_slice(path);
visible_path
}

This comment has been minimized.

Copy link
@petrochenkov

petrochenkov Sep 5, 2019

Contributor

Ok, looks like with the new hygienic ident approach the test infrastructure can indeed be simplified and improved further, but nothing prevents landing it in the current intermediate state.
(I think I'll going to investigate this myself a bit later, I still don't like that apply_mark has to be used.)

src/libsyntax_ext/standard_library_imports.rs Outdated Show resolved Hide resolved
src/libsyntax_ext/standard_library_imports.rs Outdated Show resolved Hide resolved
// Should not be used for the prelude import - not a concern in the 2015 edition
// because `std` is already declared in the crate root.
#[cfg(rust2018)]
extern crate not_libstd as std;

This comment has been minimized.

Copy link
@petrochenkov

petrochenkov Sep 5, 2019

Contributor

Well, this is kinda arguable.
If we can reroute standard library (including prelude imports) to somewhere else with --extern std=/path/to/my_std, then why can't we do the same thing in source code with extern crate my_std as std.
cc #63687 (comment)

This comment has been minimized.

Copy link
@matthewjasper

matthewjasper Sep 5, 2019

Author Contributor

I see it the other way --extern std=/path/to/my_std means that there doesn't need to be a way to override std in source code, especially one that only works on the 2018 edition.

Looking at the linked issue, the crate in question isn't #![no_std] and uses the 2015 edition, so it's not overriding anything there.

src/libsyntax_ext/standard_library_imports.rs Outdated Show resolved Hide resolved
matthewjasper and others added 4 commits Aug 25, 2019
Add `with_{def_site,call_site,legacy}_ctxt,` methods to `Span`
Use these to create call-site spans for AST passes when needed.
Document test harness generation
Also ensure that we're consistently using the def-site span when
appropriate.

@matthewjasper matthewjasper force-pushed the matthewjasper:remove-gensymmed branch from b992aec to ff45e72 Sep 5, 2019

@rust-highfive

This comment was marked as outdated.

Copy link
Collaborator

commented Sep 5, 2019

The job mingw-check of your PR failed (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
2019-09-05T15:19:47.8596323Z ##[command]git remote add origin https://github.com/rust-lang/rust
2019-09-05T15:19:47.8786993Z ##[command]git config gc.auto 0
2019-09-05T15:19:47.8853842Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2019-09-05T15:19:47.8897383Z ##[command]git config --get-all http.proxy
2019-09-05T15:19:47.9028883Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/63919/merge:refs/remotes/pull/63919/merge
---
2019-09-05T15:27:58.0552737Z     Checking syntax_pos v0.0.0 (/checkout/src/libsyntax_pos)
2019-09-05T15:27:59.4785312Z     Checking rustc_errors v0.0.0 (/checkout/src/librustc_errors)
2019-09-05T15:28:00.7414844Z     Checking fmt_macros v0.0.0 (/checkout/src/libfmt_macros)
2019-09-05T15:28:13.7373279Z     Checking syntax_ext v0.0.0 (/checkout/src/libsyntax_ext)
2019-09-05T15:28:15.4449508Z error[E0716]: temporary value dropped while borrowed
2019-09-05T15:28:15.4449991Z   --> src/libsyntax_ext/standard_library_imports.rs:65:9
2019-09-05T15:28:15.4450218Z    |
2019-09-05T15:28:15.4450451Z 64 |     let import_segements = if rust_2018 {
2019-09-05T15:28:15.4450806Z    |         ---------------- borrow later stored here
2019-09-05T15:28:15.4451049Z 65 |         [name, sym::prelude, sym::v1].iter()
2019-09-05T15:28:15.4452425Z    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ creates a temporary which is freed while still in use
2019-09-05T15:28:15.4453085Z    |     - temporary value is freed at the end of this statement
2019-09-05T15:28:15.4453359Z    |
2019-09-05T15:28:15.4453359Z    |
2019-09-05T15:28:15.4453660Z    = note: consider using a `let` binding to create a longer lived value
2019-09-05T15:28:15.4459001Z 
2019-09-05T15:28:15.4502437Z error[E0716]: temporary value dropped while borrowed
2019-09-05T15:28:15.4502770Z   --> src/libsyntax_ext/standard_library_imports.rs:67:9
2019-09-05T15:28:15.4503028Z    |
2019-09-05T15:28:15.4503326Z 64 |     let import_segements = if rust_2018 {
2019-09-05T15:28:15.4503656Z    |         ---------------- borrow later stored here
2019-09-05T15:28:15.4503896Z ...
2019-09-05T15:28:15.4504200Z 67 |         [kw::PathRoot, name, sym::prelude, sym::v1].iter()
2019-09-05T15:28:15.4504596Z    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ creates a temporary which is freed while still in use
2019-09-05T15:28:15.4506018Z    |     - temporary value is freed at the end of this statement
2019-09-05T15:28:15.4506265Z    |
2019-09-05T15:28:15.4506265Z    |
2019-09-05T15:28:15.4506723Z    = note: consider using a `let` binding to create a longer lived value
2019-09-05T15:28:15.4687605Z error: aborting due to 2 previous errors
2019-09-05T15:28:15.4692217Z 
2019-09-05T15:28:15.4699148Z For more information about this error, try `rustc --explain E0716`.
2019-09-05T15:28:15.4898741Z error: Could not compile `syntax_ext`.
---
2019-09-05T15:29:03.9076555Z == clock drift check ==
2019-09-05T15:29:03.9097956Z   local time: Thu Sep  5 15:29:03 UTC 2019
2019-09-05T15:29:04.0691149Z   network time: Thu, 05 Sep 2019 15:29:04 GMT
2019-09-05T15:29:04.0696261Z == end clock drift check ==
2019-09-05T15:29:05.1190126Z ##[error]Bash exited with code '1'.
2019-09-05T15:29:05.1232933Z ##[section]Starting: Checkout
2019-09-05T15:29:05.1234376Z ==============================================================================
2019-09-05T15:29:05.1234421Z Task         : Get sources
2019-09-05T15:29:05.1234474Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@matthewjasper matthewjasper force-pushed the matthewjasper:remove-gensymmed branch from ff45e72 to b299c4d Sep 5, 2019

@rust-highfive

This comment was marked as outdated.

Copy link
Collaborator

commented Sep 5, 2019

The job mingw-check of your PR failed (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
2019-09-05T17:19:26.2547684Z ##[command]git remote add origin https://github.com/rust-lang/rust
2019-09-05T17:19:26.2770659Z ##[command]git config gc.auto 0
2019-09-05T17:19:26.2854802Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2019-09-05T17:19:26.2926569Z ##[command]git config --get-all http.proxy
2019-09-05T17:19:26.3085896Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/63919/merge:refs/remotes/pull/63919/merge
---
2019-09-05T17:28:00.2930156Z     Checking syntax_pos v0.0.0 (/checkout/src/libsyntax_pos)
2019-09-05T17:28:01.8425849Z     Checking rustc_errors v0.0.0 (/checkout/src/librustc_errors)
2019-09-05T17:28:03.1590715Z     Checking fmt_macros v0.0.0 (/checkout/src/libfmt_macros)
2019-09-05T17:28:17.0039422Z     Checking syntax_ext v0.0.0 (/checkout/src/libsyntax_ext)
2019-09-05T17:28:17.3034532Z error[E0425]: cannot find value `import_path` in this scope
2019-09-05T17:28:17.3034999Z   --> src/libsyntax_ext/standard_library_imports.rs:77:35
2019-09-05T17:28:17.3035239Z    |
2019-09-05T17:28:17.3035537Z 77 |             prefix: cx.path(span, import_path),
2019-09-05T17:28:17.3036011Z 
2019-09-05T17:28:18.1597135Z error: aborting due to previous error
2019-09-05T17:28:18.1598038Z 
2019-09-05T17:28:18.1609085Z For more information about this error, try `rustc --explain E0425`.
---
2019-09-05T17:29:12.7676633Z == clock drift check ==
2019-09-05T17:29:12.7691719Z   local time: Thu Sep  5 17:29:12 UTC 2019
2019-09-05T17:29:12.9256255Z   network time: Thu, 05 Sep 2019 17:29:12 GMT
2019-09-05T17:29:12.9256596Z == end clock drift check ==
2019-09-05T17:29:14.0196044Z ##[error]Bash exited with code '1'.
2019-09-05T17:29:14.0234727Z ##[section]Starting: Checkout
2019-09-05T17:29:14.0236505Z ==============================================================================
2019-09-05T17:29:14.0236563Z Task         : Get sources
2019-09-05T17:29:14.0236631Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@petrochenkov

This comment has been minimized.

Copy link
Contributor

commented Sep 6, 2019

@bors r+

@bors

This comment has been minimized.

Copy link
Contributor

commented Sep 6, 2019

📌 Commit 3f3fc52 has been approved by petrochenkov

Centril added a commit to Centril/rust that referenced this pull request Sep 7, 2019
Rollup merge of rust-lang#63919 - matthewjasper:remove-gensymmed, r=p…
…etrochenkov

Use hygiene for AST passes

AST passes are now able to have resolve consider their expansions as if they were opaque macros defined either in some module in the current crate, or a fake empty module with `#[no_implicit_prelude]`.

* Add an ExpnKind for AST passes.
* Remove gensyms in AST passes.
* Remove gensyms in`#[test]`, `#[bench]` and `#[test_case]`.
* Allow opaque macros to define tests.
* Move tests for unit tests to their own directory.
* Remove `Ident::{gensym, is_gensymed}` - `Ident::gensym_if_underscore` still exists.

cc rust-lang#60869, rust-lang#61019

r? @petrochenkov
@bors

This comment has been minimized.

Copy link
Contributor

commented Sep 7, 2019

⌛️ Testing commit 3f3fc52 with merge bf5f724...

bors added a commit that referenced this pull request Sep 7, 2019
Auto merge of #63919 - matthewjasper:remove-gensymmed, r=petrochenkov
Use hygiene for AST passes

AST passes are now able to have resolve consider their expansions as if they were opaque macros defined either in some module in the current crate, or a fake empty module with `#[no_implicit_prelude]`.

* Add an ExpnKind for AST passes.
* Remove gensyms in AST passes.
* Remove gensyms in`#[test]`, `#[bench]` and `#[test_case]`.
* Allow opaque macros to define tests.
* Move tests for unit tests to their own directory.
* Remove `Ident::{gensym, is_gensymed}` - `Ident::gensym_if_underscore` still exists.

cc #60869, #61019

r? @petrochenkov
@Centril

This comment has been minimized.

Copy link
Member

commented Sep 7, 2019

@bors retry rolled up.

bors added a commit that referenced this pull request Sep 7, 2019
Auto merge of #64246 - Centril:rollup-zey4o09, r=Centril
Rollup of 10 pull requests

Successful merges:

 - #63919 (Use hygiene for AST passes)
 - #63927 (Filter linkcheck spurious failure)
 - #64149 (rustc_codegen_llvm: give names to non-alloca variable values.)
 - #64192 (Bail out when encountering likely missing turbofish in parser)
 - #64231 (Move the HIR CFG to `rustc_ast_borrowck`)
 - #64233 (Correct pluralisation of various diagnostic messages)
 - #64236 (reduce visibility)
 - #64240 (Include compiler-rt in the source tarball)
 - #64241 ([doc] Added more prereqs and note about default directory)
 - #64243 (Move injection of attributes from command line to `libsyntax_ext`)

Failed merges:

r? @ghost
@rust-highfive

This comment has been minimized.

Copy link
Collaborator

commented Sep 7, 2019

Your PR failed (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
2019-09-07T06:07:34.0822965Z ##[command]git config gc.auto 0
2019-09-07T06:07:34.1479006Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2019-09-07T06:07:34.1926917Z ##[command]git config --get-all http.proxy
2019-09-07T06:07:34.2427780Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin
2019-09-07T06:07:37.1476362Z fatal: remote error: upload-pack: not our ref bf5f7249fbcdf5ff7d91909fee0b4dc09ff5326ac_lib
2019-09-07T06:07:37.1566861Z fatal: the remote end hung up unexpectedly
2019-09-07T06:07:37.2696929Z ##[warning]Git fetch failed with exit code 128, back off 1.954 seconds before retry.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

bors added a commit that referenced this pull request Sep 7, 2019
Auto merge of #64246 - Centril:rollup-zey4o09, r=Centril
Rollup of 10 pull requests

Successful merges:

 - #63919 (Use hygiene for AST passes)
 - #63927 (Filter linkcheck spurious failure)
 - #64149 (rustc_codegen_llvm: give names to non-alloca variable values.)
 - #64192 (Bail out when encountering likely missing turbofish in parser)
 - #64231 (Move the HIR CFG to `rustc_ast_borrowck`)
 - #64233 (Correct pluralisation of various diagnostic messages)
 - #64236 (reduce visibility)
 - #64240 (Include compiler-rt in the source tarball)
 - #64241 ([doc] Added more prereqs and note about default directory)
 - #64243 (Move injection of attributes from command line to `libsyntax_ext`)

Failed merges:

r? @ghost

@bors bors merged commit 3f3fc52 into rust-lang:master Sep 7, 2019

4 of 5 checks passed

homu Testing commit 3f3fc52bfa255e68d84ca40a497137f5c6bae4a8 with merge bf5f7249fbcdf5ff7d91909fee0b4dc09ff5326a...
Details
pr Build #20190906.9 succeeded
Details
pr (Linux mingw-check) Linux mingw-check succeeded
Details
pr (Linux x86_64-gnu-llvm-6.0) Linux x86_64-gnu-llvm-6.0 succeeded
Details
pr (LinuxTools) LinuxTools succeeded
Details

@matthewjasper matthewjasper deleted the matthewjasper:remove-gensymmed branch Sep 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.