Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace file_stem by file_name in rustdoc markdown #64072

Merged
merged 1 commit into from Sep 11, 2019

Conversation

@limira
Copy link
Contributor

commented Sep 1, 2019

Before this PR, a file name like some.file.md will be output to a file named some.html with is not correct because the expected output file must be some.file.html

@ollie27

This comment has been minimized.

Copy link
Contributor

commented Sep 10, 2019

Nice catch!

cc @rust-lang/rustdoc as this is technically a breaking change but I'd argue it's a bug fix.

@bors r+

@bors

This comment has been minimized.

Copy link
Contributor

commented Sep 10, 2019

📌 Commit 7fdcbce has been approved by ollie27

tmandry added a commit to tmandry/rust that referenced this pull request Sep 10, 2019
Replace file_stem by file_name in rustdoc markdown

Before this PR, a file name like `some.file.md` will be output to a file named `some.html` with is not correct because the expected output file must be `some.file.html`
bors added a commit that referenced this pull request Sep 10, 2019
Rollup of 6 pull requests

Successful merges:

 - #64060 (Improve hygiene of `alloc::format!`)
 - #64072 (Replace file_stem by file_name in rustdoc markdown)
 - #64085 (Tweak unsatisfied HRTB errors)
 - #64188 (rustc: Allow the cdylib crate type with wasm32-wasi)
 - #64250 (save-analysis: Nest typeck tables when processing functions/methods)
 - #64349 (documentation for AtomicPtr CAS operations)

Failed merges:

r? @ghost
Centril added a commit to Centril/rust that referenced this pull request Sep 10, 2019
Replace file_stem by file_name in rustdoc markdown

Before this PR, a file name like `some.file.md` will be output to a file named `some.html` with is not correct because the expected output file must be `some.file.html`
bors added a commit that referenced this pull request Sep 10, 2019
Rollup of 6 pull requests

Successful merges:

 - #64060 (Improve hygiene of `alloc::format!`)
 - #64072 (Replace file_stem by file_name in rustdoc markdown)
 - #64085 (Tweak unsatisfied HRTB errors)
 - #64129 (vxWorks: set DEFAULT_MIN_STACK_SIZE to 256K and use min_stack to pass initial stack size to rtpSpawn)
 - #64188 (rustc: Allow the cdylib crate type with wasm32-wasi)
 - #64349 (documentation for AtomicPtr CAS operations)

Failed merges:

r? @ghost
Centril added a commit to Centril/rust that referenced this pull request Sep 11, 2019
Replace file_stem by file_name in rustdoc markdown

Before this PR, a file name like `some.file.md` will be output to a file named `some.html` with is not correct because the expected output file must be `some.file.html`
bors added a commit that referenced this pull request Sep 11, 2019
Rollup of 6 pull requests

Successful merges:

 - #64060 (Improve hygiene of `alloc::format!`)
 - #64072 (Replace file_stem by file_name in rustdoc markdown)
 - #64129 (vxWorks: set DEFAULT_MIN_STACK_SIZE to 256K and use min_stack to pass initial stack size to rtpSpawn)
 - #64188 (rustc: Allow the cdylib crate type with wasm32-wasi)
 - #64326 (Fixed documentation within c_str::from_ptr)
 - #64349 (documentation for AtomicPtr CAS operations)

Failed merges:

r? @ghost
@bors bors merged commit 7fdcbce into rust-lang:master Sep 11, 2019
4 checks passed
4 checks passed
pr Build #20190901.33 succeeded
Details
pr (Linux mingw-check) Linux mingw-check succeeded
Details
pr (Linux x86_64-gnu-llvm-6.0) Linux x86_64-gnu-llvm-6.0 succeeded
Details
pr (LinuxTools) LinuxTools succeeded
Details
@bors

This comment has been minimized.

Copy link
Contributor

commented Sep 11, 2019

⌛️ Testing commit 7fdcbce with merge 74d5c70...

@limira limira deleted the limira:patch-1 branch Sep 11, 2019
@pietroalbini

This comment has been minimized.

Copy link
Member

commented Sep 23, 2019

@bors r- retry

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.