Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Be accurate on `format!` parse error expectations #64080

Merged
merged 1 commit into from Sep 14, 2019

Conversation

@estebank
Copy link
Contributor

commented Sep 1, 2019

Fix #57277.

@rust-highfive

This comment has been minimized.

Copy link
Collaborator

commented Sep 1, 2019

r? @zackmdavis

(rust_highfive has picked a reviewer for you, use r? to override)

@estebank estebank force-pushed the estebank:parse-format-comma branch from 4afe574 to 4dec571 Sep 1, 2019

@estebank estebank changed the title Parse format comma @estebank Be accurate on `format!` parse error expectations Sep 2, 2019

@estebank estebank changed the title @estebank Be accurate on `format!` parse error expectations Be accurate on `format!` parse error expectations Sep 2, 2019

@JohnCSimon

This comment has been minimized.

Copy link

commented Sep 7, 2019

ping from triage

@zackmdavis Can you please review this?
CC @estebank
Thank you.

@zackmdavis

This comment has been minimized.

Copy link
Member

commented Sep 14, 2019

@bors r+

@bors

This comment has been minimized.

Copy link
Contributor

commented Sep 14, 2019

📌 Commit 4dec571 has been approved by zackmdavis

@bors

This comment has been minimized.

Copy link
Contributor

commented Sep 14, 2019

⌛️ Testing commit 4dec571 with merge 4576668...

bors added a commit that referenced this pull request Sep 14, 2019
Auto merge of #64080 - estebank:parse-format-comma, r=zackmdavis
Be accurate on `format!` parse error expectations

Fix #57277.
@bors

This comment has been minimized.

Copy link
Contributor

commented Sep 14, 2019

☀️ Test successful - checks-azure
Approved by: zackmdavis
Pushing 4576668 to master...

@bors bors added the merged-by-bors label Sep 14, 2019

@bors bors merged commit 4dec571 into rust-lang:master Sep 14, 2019

5 checks passed

homu Test successful
Details
pr Build #20190901.48 succeeded
Details
pr (Linux mingw-check) Linux mingw-check succeeded
Details
pr (Linux x86_64-gnu-llvm-6.0) Linux x86_64-gnu-llvm-6.0 succeeded
Details
pr (LinuxTools) LinuxTools succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.