Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make rustc_mir::dataflow module pub (for clippy) #64207

Open
wants to merge 1 commit into
base: master
from

Conversation

@sinkuu
Copy link
Contributor

commented Sep 6, 2019

I'm working on fixing false-positives of a MIR-based clippy lint (rust-lang/rust-clippy#4509), and in need of the dataflow infrastructure.

@rust-highfive

This comment has been minimized.

Copy link
Collaborator

commented Sep 6, 2019

r? @cramertj

(rust_highfive has picked a reviewer for you, use r? to override)

@cramertj

This comment has been minimized.

Copy link
Member

commented Sep 6, 2019

r? @tmandry or @eddyb -- wanted to check that this is reasonably stable enough to expose, and that this is the right thing to use in clippy.

@rust-highfive rust-highfive assigned tmandry and unassigned cramertj Sep 6, 2019

@tmandry

This comment has been minimized.

Copy link
Contributor

commented Sep 6, 2019

I think this is fine, but I'd like to double check with either @eddyb, @pnkfelix, or @matthewjasper.

What are you using to consume the results? Right now I think DataflowResultsCursor is the preferred way (see #62315).

@sinkuu

This comment has been minimized.

Copy link
Contributor Author

commented Sep 7, 2019

I'm using state_for_location and DataflowResultsCursor. I'll try to switch to the latter.

@JohnCSimon

This comment has been minimized.

Copy link

commented Sep 14, 2019

Ping from triage:

@sinkuu @tmandry This PR has not been updated in a week. What is the status of the PR?

Thanks.

@sinkuu

This comment has been minimized.

Copy link
Contributor Author

commented Sep 16, 2019

@JohnCSimon Waiting for an approval from

either @eddyb, @pnkfelix, or @matthewjasper.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.