Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update android.yml #64213

Closed
wants to merge 1 commit into from

Conversation

@morisbartyno
Copy link

commented Sep 6, 2019

No description provided.

@rust-highfive

This comment has been minimized.

Copy link
Collaborator

commented Sep 6, 2019

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nikomatsakis (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@varkor

This comment has been minimized.

Copy link
Member

commented Sep 6, 2019

@morisbartyno: can you explain what this pull request is for? This doesn't seem relevant to the repository.

@JohnCSimon

This comment has been minimized.

Copy link

commented Sep 14, 2019

ping from triage:
@morisbartyno can you please address @varkor 's comments?
Thanks

@varkor

This comment has been minimized.

Copy link
Member

commented Sep 14, 2019

I think this was a mistaken pull request. If there's legitimate motivation, we can reopen it.

@varkor varkor closed this Sep 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.