Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Continue refactoring MIR drop generation #64225

Open
wants to merge 4 commits into
base: master
from

Conversation

@matthewjasper
Copy link
Contributor

commented Sep 6, 2019

Split out from #61430

  • Removes the Ty parameter from schedule_drop.
  • Moves the handling of the stack of Scopes to its own module - the updated version of #61430 will make the logic significantly more complicated here.
@rust-highfive

This comment has been minimized.

Copy link
Collaborator

commented Sep 6, 2019

r? @zackmdavis

(rust_highfive has picked a reviewer for you, use r? to override)

@bors

This comment has been minimized.

Copy link
Contributor

commented Sep 13, 2019

☔️ The latest upstream changes (presumably #63420) made this pull request unmergeable. Please resolve the merge conflicts.

Make `Scope` private to `rustc_mir::build::scope::stack`
The logic for finding the correct unwind scopes is going to become more
complicated, so we want to limit the amount of code that can directly
access the fields of `Scope`.
Get the type of a local from `local_decls` in `schedule_drop`
Passing around a separate type is unnecessary and error-prone.

@matthewjasper matthewjasper force-pushed the matthewjasper:more-drop-refactor branch from af6826d to 899d10e Sep 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.