Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libstd: Fix typos in doc #64337

Open
wants to merge 1 commit into
base: master
from

Conversation

@rick68
Copy link
Contributor

commented Sep 10, 2019

No description provided.

@rust-highfive

This comment has been minimized.

Copy link
Collaborator

commented Sep 10, 2019

r? @Kimundi

(rust_highfive has picked a reviewer for you, use r? to override)

@rick68 rick68 force-pushed the rick68:patch-17 branch from 865f904 to cd047fc Sep 10, 2019

@@ -1627,7 +1627,7 @@ impl<'a> From<Cow<'a, Path>> for PathBuf {

#[stable(feature = "shared_from_slice2", since = "1.24.0")]
impl From<PathBuf> for Arc<Path> {
/// Converts a Path into a Rc by copying the Path data into a new Rc buffer.
/// Converts a PathBuf into a Arc by moving the PathBuf data into a new Arc buffer.

This comment has been minimized.

Copy link
@varkor

varkor Sep 10, 2019

Member
Suggested change
/// Converts a PathBuf into a Arc by moving the PathBuf data into a new Arc buffer.
/// Converts a `PathBuf` into an `Arc` by moving the `PathBuf` data into a new `Arc` buffer.
@@ -1647,7 +1647,7 @@ impl From<&Path> for Arc<Path> {

#[stable(feature = "shared_from_slice2", since = "1.24.0")]
impl From<PathBuf> for Rc<Path> {
/// Converts a Path into a Rc by copying the Path data into a new Rc buffer.
/// Converts a PathBuf into a Rc by moving the PathBuf data into a new Rc buffer.

This comment has been minimized.

Copy link
@varkor

varkor Sep 10, 2019

Member
Suggested change
/// Converts a PathBuf into a Rc by moving the PathBuf data into a new Rc buffer.
/// Converts a `PathBuf` into an `Rc` by moving the `PathBuf` data into a new `Rc` buffer.

This comment has been minimized.

Copy link
@varkor

varkor Sep 10, 2019

Member

It would be good to put backticks around the comment in impl From<&Path> for Rc<Path> too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.