Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustc_mir: buffer -Zdump-mir output instead of pestering the kernel constantly. #64344

Merged
merged 1 commit into from Sep 10, 2019

Conversation

@eddyb
Copy link
Member

commented Sep 10, 2019

This brings mir-opt tests from 197s (over 3 minutes!) to 2.85s, on my build server.
That's a nice speedup of about 69x and so it definitely fixes #58485, for me.

It's such a beginner mistake I feel like maybe clippy should lint against it?
(cc @Manishearth @oli-obk)

@rust-highfive

This comment has been minimized.

Copy link
Collaborator

commented Sep 10, 2019

r? @petrochenkov

(rust_highfive has picked a reviewer for you, use r? to override)

@oli-obk

This comment has been minimized.

Copy link
Contributor

commented Sep 10, 2019

@oli-obk

This comment has been minimized.

Copy link
Contributor

commented Sep 10, 2019

@bors r+ rollup

@bors

This comment has been minimized.

Copy link
Contributor

commented Sep 10, 2019

📌 Commit 1e7faef has been approved by oli-obk

Centril added a commit to Centril/rust that referenced this pull request Sep 10, 2019
…kernel, r=oli-obk

rustc_mir: buffer -Zdump-mir output instead of pestering the kernel constantly.

This brings `mir-opt` tests from `197s` (over 3 minutes!) to `2.85s`, on my build server.
That's a nice speedup of about `69x` and so it definitely fixes rust-lang#58485, for me.

It's such a beginner mistake I feel like maybe `clippy` should lint against it?
(cc @Manishearth @oli-obk)
bors added a commit that referenced this pull request Sep 10, 2019
Rollup of 8 pull requests

Successful merges:

 - #63786 (Make `abs`, `wrapping_abs`, `overflowing_abs` const functions)
 - #63989 (Add Yaah to clippy toolstain notification list)
 - #64256 (test/c-variadic: Fix patterns on powerpc64)
 - #64292 (lowering: extend temporary lifetimes around await)
 - #64311 (lldb: avoid mixing "Hit breakpoint" message with other output.)
 - #64330 (Clarify E0507 to note Fn/FnMut relationship to borrowing)
 - #64331 (Changed instant is earlier to instant is later)
 - #64344 (rustc_mir: buffer -Zdump-mir output instead of pestering the kernel constantly.)

Failed merges:

r? @ghost
@bors bors merged commit 1e7faef into rust-lang:master Sep 10, 2019
4 checks passed
4 checks passed
pr Build #20190910.18 succeeded
Details
pr (Linux mingw-check) Linux mingw-check succeeded
Details
pr (Linux x86_64-gnu-llvm-6.0) Linux x86_64-gnu-llvm-6.0 succeeded
Details
pr (LinuxTools) LinuxTools succeeded
Details
@eddyb eddyb deleted the eddyb:mir-opt-stop-shouting-at-the-kernel branch Sep 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.