Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

`AdtDef` is an algebraic data type, not abstract data type #64357

Merged
merged 1 commit into from Sep 17, 2019

Conversation

@Centril
Copy link
Member

commented Sep 10, 2019

r? @varkor

src/librustc/ty/mod.rs Outdated Show resolved Hide resolved
@varkor

This comment has been minimized.

Copy link
Member

commented Sep 10, 2019

I think both "abstract data type" and "algebraic data type" are incorrect. "Abstract" because it's actually concrete and "algebraic" because it includes unions and is also not as general as the usual sense of "algebraic data type". I think @eddyb wasn't happy with the existing name as well; maybe UserDataType is a better choice.

src/librustc/ty/mod.rs Outdated Show resolved Hide resolved

@Centril Centril force-pushed the adt-docs-fix branch from 482565f to 288c1b2 Sep 16, 2019

@Centril Centril force-pushed the adt-docs-fix branch from 288c1b2 to 2fd4e58 Sep 16, 2019

@Centril

This comment has been minimized.

Copy link
Member Author

commented Sep 16, 2019

@varkor Adjusted to "user-defined..." but also included a note at the bottom re. algebraic data types and how it is slightly wrong.

@varkor

This comment has been minimized.

Copy link
Member

commented Sep 16, 2019

@bors r+ rollup

@bors

This comment has been minimized.

Copy link
Contributor

commented Sep 16, 2019

📌 Commit 2fd4e58 has been approved by varkor

Centril added a commit to Centril/rust that referenced this pull request Sep 16, 2019
Rollup merge of rust-lang#64357 - rust-lang:adt-docs-fix, r=varkor
`AdtDef` is an algebraic data type, not abstract data type

r? @varkor
Centril added a commit to Centril/rust that referenced this pull request Sep 16, 2019
Rollup merge of rust-lang#64357 - rust-lang:adt-docs-fix, r=varkor
`AdtDef` is an algebraic data type, not abstract data type

r? @varkor
bors added a commit that referenced this pull request Sep 16, 2019
Auto merge of #64522 - Centril:rollup-3cirrli, r=Centril
Rollup of 5 pull requests

Successful merges:

 - #64357 (`AdtDef` is an algebraic data type, not abstract data type)
 - #64485 (update Miri)
 - #64509 (Make some adjustments to the documentation for `std::convert::identity`)
 - #64516 (update Nomicon and Reference)
 - #64518 (Use while let slice_pattern instead of carrying an index around)

Failed merges:

r? @ghost
Centril added a commit to Centril/rust that referenced this pull request Sep 16, 2019
Rollup merge of rust-lang#64357 - rust-lang:adt-docs-fix, r=varkor
`AdtDef` is an algebraic data type, not abstract data type

r? @varkor
bors added a commit that referenced this pull request Sep 16, 2019
Auto merge of #64526 - Centril:rollup-k4cz2xn, r=Centril
Rollup of 4 pull requests

Successful merges:

 - #64357 (`AdtDef` is an algebraic data type, not abstract data type)
 - #64485 (update Miri)
 - #64509 (Make some adjustments to the documentation for `std::convert::identity`)
 - #64518 (Use while let slice_pattern instead of carrying an index around)

Failed merges:

r? @ghost

@bors bors merged commit 2fd4e58 into master Sep 17, 2019

4 checks passed

pr Build #20190916.34 succeeded
Details
pr (Linux mingw-check) Linux mingw-check succeeded
Details
pr (Linux x86_64-gnu-llvm-6.0) Linux x86_64-gnu-llvm-6.0 succeeded
Details
pr (LinuxTools) LinuxTools succeeded
Details

@Centril Centril deleted the adt-docs-fix branch Sep 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.