Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

def_collector: Do not ICE on attributes on unnamed fields #64457

Merged
merged 2 commits into from Sep 15, 2019

Conversation

@petrochenkov
Copy link
Contributor

commented Sep 14, 2019

The primary issue here is that the expansion infra needs to visit a field in isolation, and fields don't know their own indices during expansion, so they have to be kept in some other place (e.g. struct Definitions).

Fixes #64385

@rust-highfive

This comment has been minimized.

Copy link
Collaborator

commented Sep 14, 2019

r? @matthewjasper

(rust_highfive has picked a reviewer for you, use r? to override)

@petrochenkov

This comment has been minimized.

Copy link
Contributor Author

commented Sep 14, 2019

@matthewjasper

This comment has been minimized.

Copy link
Contributor

commented Sep 14, 2019

@bors r+

@bors

This comment has been minimized.

Copy link
Contributor

commented Sep 14, 2019

📌 Commit c681cf7 has been approved by matthewjasper

Centril added a commit to Centril/rust that referenced this pull request Sep 15, 2019
…asper

def_collector: Do not ICE on attributes on unnamed fields

The primary issue here is that the expansion infra needs to visit a field in isolation, and fields don't know their own indices during expansion, so they have to be kept in some other place (e.g. `struct Definitions`).

Fixes rust-lang#64385
bors added a commit that referenced this pull request Sep 15, 2019
Rollup of 5 pull requests

Successful merges:

 - #64457 (def_collector: Do not ICE on attributes on unnamed fields)
 - #64463 (resolve: Tweak some expected/found wording)
 - #64471 (Warn on no_start, crate_id attribute use)
 - #64473 (Use try_fold instead of manually carrying an accumulator)
 - #64475 (simplify the initialization)

Failed merges:

r? @ghost
@bors

This comment has been minimized.

Copy link
Contributor

commented Sep 15, 2019

⌛️ Testing commit c681cf7 with merge 8bf776d...

@bors bors merged commit c681cf7 into rust-lang:master Sep 15, 2019
4 of 5 checks passed
4 of 5 checks passed
homu Testing commit c681cf781b440620aca8cad4be9b76a477fc6c1a with merge 8bf776d5c2fc88624d2562e493aab0d324a3b7d8...
Details
pr Build #20190914.20 succeeded
Details
pr (Linux mingw-check) Linux mingw-check succeeded
Details
pr (Linux x86_64-gnu-llvm-6.0) Linux x86_64-gnu-llvm-6.0 succeeded
Details
pr (LinuxTools) LinuxTools succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.