Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A more explanatory thread local storage panic message #64481

Merged
merged 2 commits into from Sep 25, 2019

Conversation

@tomtau
Copy link
Contributor

commented Sep 15, 2019

Outside rust-std internals, TLS is usually understood as Transport Layer Security, so the existing message could be a bit puzzling when one has TLS sessions in thread_local!.

(TLS is usually understood as Transport Layer Security
outside rust-std internals)
@rust-highfive

This comment has been minimized.

Copy link
Collaborator

commented Sep 15, 2019

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @KodrAus (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@euclio

This comment has been minimized.

Copy link
Contributor

commented Sep 16, 2019

While we're changing it, "during or after destruction" might read better.

@JohnCSimon

This comment has been minimized.

Copy link

commented Sep 21, 2019

Ping from triage

@tomtau @euclio - can you address the comment?
cc: @KodrAus

@tomtau

This comment has been minimized.

Copy link
Contributor Author

commented Sep 21, 2019

@KodrAus

This comment has been minimized.

Copy link
Contributor

commented Sep 23, 2019

Thanks @tomtau!

@bors r+ rollup

@bors

This comment has been minimized.

Copy link
Contributor

commented Sep 23, 2019

📌 Commit 68c3739 has been approved by KodrAus

Centril added a commit to Centril/rust that referenced this pull request Sep 23, 2019
…rAus

A more explanatory thread local storage panic message

Outside rust-std internals, TLS is usually understood as Transport Layer Security, so the existing message could be a bit puzzling when one has TLS sessions in `thread_local!`.
bors added a commit that referenced this pull request Sep 24, 2019
Rollup of 7 pull requests

Successful merges:

 - #63356 (Issue#63183: Add fs::read_dir() and ReadDir warning about iterator order + example)
 - #64296 (Document the unstable iter_order_by library feature)
 - #64428 (Error explanation e0524)
 - #64481 (A more explanatory thread local storage panic message)
 - #64663 (libtest: Add --report-time flag to print test execution time)
 - #64689 (Refactor macro by example)
 - #64702 (Remove unused dependencies)

Failed merges:

r? @ghost
Centril added a commit to Centril/rust that referenced this pull request Sep 24, 2019
…rAus

A more explanatory thread local storage panic message

Outside rust-std internals, TLS is usually understood as Transport Layer Security, so the existing message could be a bit puzzling when one has TLS sessions in `thread_local!`.
bors added a commit that referenced this pull request Sep 24, 2019
Rollup of 10 pull requests

Successful merges:

 - #63356 (Issue#63183: Add fs::read_dir() and ReadDir warning about iterator order + example)
 - #64296 (Document the unstable iter_order_by library feature)
 - #64428 (Error explanation e0524)
 - #64481 (A more explanatory thread local storage panic message)
 - #64546 (Bugfix/rfc 2451 rerebalance tests)
 - #64622 (Add a cycle detector for generic `Graph`s and `mir::Body`s)
 - #64689 (Refactor macro by example)
 - #64702 (Remove unused dependencies)
 - #64717 (update mem::discriminant test to use assert_eq and assert_ne over comparison operators)
 - #64725 (fix one typo)

Failed merges:

r? @ghost
bors added a commit that referenced this pull request Sep 24, 2019
Rollup of 10 pull requests

Successful merges:

 - #63356 (Issue#63183: Add fs::read_dir() and ReadDir warning about iterator order + example)
 - #64296 (Document the unstable iter_order_by library feature)
 - #64428 (Error explanation e0524)
 - #64481 (A more explanatory thread local storage panic message)
 - #64546 (Bugfix/rfc 2451 rerebalance tests)
 - #64622 (Add a cycle detector for generic `Graph`s and `mir::Body`s)
 - #64689 (Refactor macro by example)
 - #64702 (Remove unused dependencies)
 - #64717 (update mem::discriminant test to use assert_eq and assert_ne over comparison operators)
 - #64725 (fix one typo)

Failed merges:

r? @ghost
Centril added a commit to Centril/rust that referenced this pull request Sep 25, 2019
…rAus

A more explanatory thread local storage panic message

Outside rust-std internals, TLS is usually understood as Transport Layer Security, so the existing message could be a bit puzzling when one has TLS sessions in `thread_local!`.
bors added a commit that referenced this pull request Sep 25, 2019
Rollup of 7 pull requests

Successful merges:

 - #64324 (rustc: Fix mixing crates with different `share_generics`)
 - #64428 (Error explanation e0524)
 - #64481 (A more explanatory thread local storage panic message)
 - #64599 (Rustdoc render async function re-export)
 - #64743 (Update cargo)
 - #64746 (Remove blanket silencing of "type annotation needed" errors)
 - #64753 (Don't emit explain with json short messages.)

Failed merges:

r? @ghost
@bors bors merged commit 68c3739 into rust-lang:master Sep 25, 2019
4 checks passed
4 checks passed
pr Build #20190916.4 succeeded
Details
pr (Linux mingw-check) Linux mingw-check succeeded
Details
pr (Linux x86_64-gnu-llvm-6.0) Linux x86_64-gnu-llvm-6.0 succeeded
Details
pr (LinuxTools) LinuxTools succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.