Even more ObligationForest improvements
#64627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This gives a slight speed-up.
Optimizing for the common numbers of entries in `stalled_on` wins about 4% on `keccak` and `inflate`.
This is a big speed win for `keccak` and `inflate`.
We normally use `index` for indices to `ObligationForest::nodes`, but this is a `Nodes::dependents` index.
The name `waiting_cache` sounds like it is related to the states `NodeState::Waiting`, but it's not; the cache holds nodes of various states. This commit changes it to `active_state`.
Because the meaning of this `index` variable is quite different to all the other `index` variables in this file.
rust-highfive
added
the
S-waiting-on-review
|
@bors try @rust-timer queue |
|
Awaiting bors try build completion |
bors
added a commit
that referenced
this pull request
Sep 20, 2019
Even more `ObligationForest` improvements Following on from #64545, more speed and readability improvements. r? @nikomatsakis
|
💥 Test timed out |
|
Not sure what happened there. Let's try it the old-fashioned way: |
bors
added a commit
that referenced
this pull request
Sep 20, 2019
Even more `ObligationForest` improvements Following on from #64545, more speed and readability improvements. r? @nikomatsakis
|
Some local measurements: |
|
☀️ Try build successful - checks-azure |
|
Queued 85a4a15 with parent ea3ba36, future comparison URL. |
|
Finished benchmarking try commit 85a4a15, comparison URL. |
|
@nnethercote Do you every take a day off of optimizing rustc? 😄 |
nikomatsakis
approved these changes
Sep 23, 2019
|
@bors r+ |
|
📌 Commit aa10abb has been approved by |
bors
added
S-waiting-on-bors
|
@bors rollup=never |
bors
added a commit
that referenced
this pull request
Sep 25, 2019
Even more `ObligationForest` improvements Following on from #64545, more speed and readability improvements. r? @nikomatsakis
|
☀️ Test successful - checks-azure |
tmandry
added a commit
to tmandry/rust
that referenced
this pull request
Oct 2, 2019
… r=nikomatsakis Still more `ObligationForest` improvements. Following on from rust-lang#64627, more readability improvements, but negligible effects on speed. r? @nikomatsakis
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following on from #64545, more speed and readability improvements.
r? @nikomatsakis