Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix zebra-striping in generic dataflow visualization #64974

Merged
merged 2 commits into from Oct 2, 2019

Conversation

@ecstatic-morse
Copy link
Contributor

commented Oct 1, 2019

A small formatting improvement to #64828.

Prior to this, the background color of the first row of the table for each basic block changed seemingly at random. You can see this in basic block #5 under "New table". Now it is always light.

This also updates the example table to match the current output.

Now the first row of each basic block is always light instead of
changing seemingly at random.
@rust-highfive

This comment has been minimized.

Copy link
Collaborator

commented Oct 1, 2019

r? @petrochenkov

(rust_highfive has picked a reviewer for you, use r? to override)

@ecstatic-morse ecstatic-morse changed the title Fix zebra-striping in generic dataflow visualization. Fix zebra-striping in generic dataflow visualization Oct 1, 2019
@petrochenkov

This comment has been minimized.

Copy link
Contributor

commented Oct 2, 2019

@bors r+ rollup

@bors

This comment has been minimized.

Copy link
Contributor

commented Oct 2, 2019

📌 Commit ffc52a7 has been approved by petrochenkov

tmandry added a commit to tmandry/rust that referenced this pull request Oct 2, 2019
…ra, r=petrochenkov

Fix zebra-striping in generic dataflow visualization

A small formatting improvement to rust-lang#64828.

Prior to this, the background color of the first row of the table for each basic block changed seemingly at random. You can see this in [basic block rust-lang#5](rust-lang#64828 (comment)) under "New table". Now it is always light.

This also updates the example table to match the current output.
bors added a commit that referenced this pull request Oct 2, 2019
Rollup of 11 pull requests

Successful merges:

 - #64649 (Avoid ICE on return outside of fn with literal array)
 - #64722 (Make all alt builders produce parallel-enabled compilers)
 - #64801 (Avoid `chain()` in `find_constraint_paths_between_regions()`.)
 - #64805 (Still more `ObligationForest` improvements.)
 - #64840 (SelfProfiler API refactoring and part one of event review)
 - #64885 (use try_fold instead of try_for_each to reduce compile time)
 - #64942 (Fix clippy warnings)
 - #64952 (Update cargo.)
 - #64974 (Fix zebra-striping in generic dataflow visualization)
 - #64978 (Fully clear `HandlerInner` in `Handler::reset_err_count`)
 - #64979 (Update books)

Failed merges:

 - #64959 (syntax: improve parameter without type suggestions)

r? @ghost
@bors bors merged commit ffc52a7 into rust-lang:master Oct 2, 2019
4 checks passed
4 checks passed
pr Build #20191001.74 succeeded
Details
pr (Linux mingw-check) Linux mingw-check succeeded
Details
pr (Linux x86_64-gnu-llvm-6.0) Linux x86_64-gnu-llvm-6.0 succeeded
Details
pr (LinuxTools) LinuxTools succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.