Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use structured suggestion for removal of `as_str()` call #65194

Merged
merged 1 commit into from Oct 9, 2019

Conversation

@estebank
Copy link
Contributor

estebank commented Oct 7, 2019

Follow up to #64739.

@rust-highfive

This comment has been minimized.

Copy link
Collaborator

rust-highfive commented Oct 7, 2019

r? @petrochenkov

(rust_highfive has picked a reviewer for you, use r? to override)

@petrochenkov

This comment has been minimized.

Copy link
Contributor

petrochenkov commented Oct 8, 2019

@bors r+

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Oct 8, 2019

📌 Commit 5aa37a9 has been approved by petrochenkov

Centril added a commit to Centril/rust that referenced this pull request Oct 8, 2019
Use structured suggestion for removal of `as_str()` call

Follow up to rust-lang#64739.
@Centril Centril referenced this pull request Oct 8, 2019
bors added a commit that referenced this pull request Oct 8, 2019
Rollup of 7 pull requests

Successful merges:

 - #64284 (Warn if include macro fails to include entire file)
 - #65081 (Remove -Zprofile-queries)
 - #65133 (typeck: prohibit foreign statics w/ generics)
 - #65135 (Add check for missing tests for error codes)
 - #65141 (Replace code of conduct with link)
 - #65194 (Use structured suggestion for removal of `as_str()` call)
 - #65213 (Ignore `ExprKind::DropTemps` for some ref suggestions)

Failed merges:

r? @ghost
@bors bors merged commit 5aa37a9 into rust-lang:master Oct 9, 2019
4 checks passed
4 checks passed
pr Build #20191007.49 succeeded
Details
pr (Linux mingw-check) Linux mingw-check succeeded
Details
pr (Linux x86_64-gnu-llvm-6.0) Linux x86_64-gnu-llvm-6.0 succeeded
Details
pr (LinuxTools) LinuxTools succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.