Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print lifetimes with backticks #65292

Merged
merged 1 commit into from Oct 14, 2019

Conversation

@JohnTitor
Copy link
Member

JohnTitor commented Oct 10, 2019

Fixes #65287

r? @varkor

@varkor

This comment has been minimized.

Copy link
Member

varkor commented Oct 11, 2019

r=me when CI passes.

@Centril

This comment has been minimized.

Copy link
Member

Centril commented Oct 11, 2019

@JohnTitor can you please check that it also passes with --compare-mode=nll?

@JohnTitor

This comment has been minimized.

Copy link
Member Author

JohnTitor commented Oct 11, 2019

@Centril just checked and passed on my local

@JohnTitor

This comment has been minimized.

Copy link
Member Author

JohnTitor commented Oct 11, 2019

Ah, wait, I should commit with --bless

@JohnTitor JohnTitor force-pushed the JohnTitor:add-backticks branch from d85970e to 2ae5e34 Oct 11, 2019
@Centril

This comment has been minimized.

Copy link
Member

Centril commented Oct 11, 2019

@bors r=varkor,Centril :)

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Oct 11, 2019

📌 Commit 2ae5e34 has been approved by varkor,Centril

Centril added a commit to Centril/rust that referenced this pull request Oct 14, 2019
…entril

Print lifetimes with backticks

Fixes rust-lang#65287

r? @varkor
Centril added a commit to Centril/rust that referenced this pull request Oct 14, 2019
…entril

Print lifetimes with backticks

Fixes rust-lang#65287

r? @varkor
bors added a commit that referenced this pull request Oct 14, 2019
Rollup of 7 pull requests

Successful merges:

 - #65215 (Add long error explanation for E0697)
 - #65292 (Print lifetimes with backticks)
 - #65362 (syntax: consolidate function parsing in item.rs)
 - #65363 (Remove implicit dependencies on syntax::pprust)
 - #65379 (refactor session::config::build_session_options_and_crate_config)
 - #65392 (Move `Nonterminal::to_tokenstream` to parser & don't rely directly on parser in lowering)
 - #65395 (Add some tests for fixed ICEs)

Failed merges:

r? @ghost
bors added a commit that referenced this pull request Oct 14, 2019
Rollup of 7 pull requests

Successful merges:

 - #65215 (Add long error explanation for E0697)
 - #65292 (Print lifetimes with backticks)
 - #65362 (syntax: consolidate function parsing in item.rs)
 - #65363 (Remove implicit dependencies on syntax::pprust)
 - #65379 (refactor session::config::build_session_options_and_crate_config)
 - #65392 (Move `Nonterminal::to_tokenstream` to parser & don't rely directly on parser in lowering)
 - #65395 (Add some tests for fixed ICEs)

Failed merges:

r? @ghost
@bors bors merged commit 2ae5e34 into rust-lang:master Oct 14, 2019
4 checks passed
4 checks passed
pr Build #20191011.19 succeeded
Details
pr (Linux mingw-check) Linux mingw-check succeeded
Details
pr (Linux x86_64-gnu-llvm-6.0) Linux x86_64-gnu-llvm-6.0 succeeded
Details
pr (LinuxTools) LinuxTools succeeded
Details
@JohnTitor JohnTitor deleted the JohnTitor:add-backticks branch Oct 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.