Skip to content

/ rust

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize `BitIter` #65425

Merged
merged 2 commits into from Oct 16, 2019
Merged

Optimize `BitIter` #65425

merged 2 commits into from Oct 16, 2019

Conversation

@nnethercote
Copy link
Contributor

@nnethercote nnethercote commented Oct 15, 2019

A minor speed improvement.
@rust-highfive
Copy link
Collaborator

@rust-highfive rust-highfive commented Oct 15, 2019

r? @zackmdavis

(rust_highfive has picked a reviewer for you, use r? to override)
@zackmdavis
Copy link
Member

@zackmdavis zackmdavis commented Oct 15, 2019

@bors r+
@bors
Copy link
Contributor

@bors bors commented Oct 15, 2019

📌 Commit f5bfffd has been approved by zackmdavis
@nnethercote nnethercote force-pushed the nnethercote:optimize-BitIter branch from b780b3c to f5bfffd Oct 15, 2019
@nnethercote
Copy link
Contributor Author

@nnethercote nnethercote commented Oct 15, 2019

I added another commit, one that benefits from the faster BitIter. But I didn't see the r+ before that happened. I have now removed the additional commit; I will do it in a different PR.
@nnethercote
Copy link
Contributor Author

@nnethercote nnethercote commented Oct 15, 2019

@bors r=zackmdavis
@bors
Copy link
Contributor

@bors bors commented Oct 15, 2019

📌 Commit f5bfffd has been approved by zackmdavis
Centril added a commit to Centril/rust that referenced this pull request Oct 15, 2019
@Centril
Rollup merge of rust-lang#65425 - nnethercote:optimize-BitIter, r=zac…
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
ebead31 
…kmdavis

Optimize `BitIter`

A minor speed improvement.
@Centril Centril mentioned this pull request Oct 15, 2019
Closed
bors added a commit that referenced this pull request Oct 15, 2019
@bors
Auto merge of #65430 - Centril:rollup-emcva01, r=Centril
Loading status checks…
28e7fff 
Rollup of 4 pull requests

Successful merges:

 - #64035 (Stabilize proc macros generating `macro_rules` items)
 - #65376 (syntax: misc extractions)
 - #65425 (Optimize `BitIter`)
 - #65428 (Refactor: Rename `db` locals to `diag`)

Failed merges:

r? @ghost
@Centril
Copy link
Contributor

@Centril Centril commented Oct 15, 2019

Failed in #65430 (comment), @bors r-
nnethercote added 2 commits Oct 14, 2019
@nnethercote
Add `BitIter::new()`.
2918a7d 
This factors out some duplicated code.
@nnethercote
Optimize `BitSet` iteration.
Loading status checks…
60851b0 
This commit removes an `Option` check in `BitIter::next()`, avoids
calling `trailing_zeros()` when it's not necessary, and avoids the need
for `enumerate()`. This gives a tiny (0.2%) instruction count win on a
couple of benchmarks.

The commit also adds some comments, which is good because this iteration
code is moderately complex.
@nnethercote nnethercote force-pushed the nnethercote:optimize-BitIter branch from f5bfffd to 60851b0 Oct 15, 2019
@nnethercote
Copy link
Contributor Author

@nnethercote nnethercote commented Oct 15, 2019

I mistakenly thought it was ok for unsigned integers to wrap with +. wrapping_add fixes the problem.

@bors r=zackmdavis
@bors
Copy link
Contributor

@bors bors commented Oct 15, 2019

📌 Commit 60851b0 has been approved by zackmdavis
tmandry added a commit to tmandry/rust that referenced this pull request Oct 15, 2019
@tmandry
Rollup merge of rust-lang#65425 - nnethercote:optimize-BitIter, r=zac…
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
6416079 
…kmdavis

Optimize `BitIter`

A minor speed improvement.
@tmandry tmandry mentioned this pull request Oct 15, 2019
Merged
bors added a commit that referenced this pull request Oct 15, 2019
@bors
Auto merge of #65454 - tmandry:rollup-0k6jiik, r=tmandry
Loading status checks…
f54911c 
Rollup of 14 pull requests

Successful merges:

 - #64603 (Reducing spurious unused lifetime warnings.)
 - #64623 (Remove last uses of gensyms)
 - #65235 (don't assume we can *always* find a return type hint in async fn)
 - #65242 (Fix suggestion to constrain trait for method to be found)
 - #65265 (Cleanup librustc mir err codes)
 - #65293 (Optimize `try_expand_impl_trait_type`)
 - #65307 (Try fix incorrect "explicit lifetime name needed")
 - #65308 (Add long error explanation for E0574)
 - #65353 (save-analysis: Don't ICE when resolving qualified type paths in struct members)
 - #65389 (Return `false` from `needs_drop` for all zero-sized arrays.)
 - #65402 (Add troubleshooting section to PGO chapter in rustc book.)
 - #65425 (Optimize `BitIter`)
 - #65438 (Organize `never_type`  tests)
 - #65444 (Implement AsRef<[T]> for List<T>)

Failed merges:

 - #65390 (Add long error explanation for E0576)

r? @ghost
@bors bors merged commit 60851b0 into rust-lang:master Oct 16, 2019
4 checks passed
4 checks passed
pr Build #20191015.67 succeeded
Details
pr (Linux mingw-check) Linux mingw-check succeeded
Details
pr (Linux x86_64-gnu-llvm-6.0) Linux x86_64-gnu-llvm-6.0 succeeded
Details
pr (LinuxTools) LinuxTools succeeded
Details
@nnethercote nnethercote deleted the nnethercote:optimize-BitIter branch Oct 16, 2019
@nnethercote nnethercote mentioned this pull request Oct 16, 2019
Merged
bors added a commit that referenced this pull request Oct 16, 2019
@bors
Auto merge of #65480 - nnethercote:rm-iterate_until_fixed_size, r=<try>
Loading status checks…
e320fe5 
Speed up `LexicalResolve::expansion()`

A couple of improvements that speed up `unicode_normalization` by about 4%. The first commit was enabled by the improvements to `BitSet` iteration in #65425.

r? @nikomatsakis
tmandry added a commit to tmandry/rust that referenced this pull request Oct 18, 2019
@tmandry
Rollup merge of rust-lang#65480 - nnethercote:rm-iterate_until_fixed_…
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
8cb6225 
…size, r=nikomatsakis

Speed up `LexicalResolve::expansion()`

A couple of improvements that speed up `unicode_normalization` by about 4%. The first commit was enabled by the improvements to `BitSet` iteration in rust-lang#65425.

r? @nikomatsakis
tmandry added a commit to tmandry/rust that referenced this pull request Oct 18, 2019
@tmandry
Rollup merge of rust-lang#65480 - nnethercote:rm-iterate_until_fixed_…
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
7cc5c5a 
…size, r=nikomatsakis

Speed up `LexicalResolve::expansion()`

A couple of improvements that speed up `unicode_normalization` by about 4%. The first commit was enabled by the improvements to `BitSet` iteration in rust-lang#65425.

r? @nikomatsakis
tmandry added a commit to tmandry/rust that referenced this pull request Oct 18, 2019
@tmandry
Rollup merge of rust-lang#65480 - nnethercote:rm-iterate_until_fixed_…
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
4a76e6d 
…size, r=nikomatsakis

Speed up `LexicalResolve::expansion()`

A couple of improvements that speed up `unicode_normalization` by about 4%. The first commit was enabled by the improvements to `BitSet` iteration in rust-lang#65425.

r? @nikomatsakis
tmandry added a commit to tmandry/rust that referenced this pull request Oct 18, 2019
@tmandry
Rollup merge of rust-lang#65480 - nnethercote:rm-iterate_until_fixed_…
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
c6bb960 
…size, r=nikomatsakis

Speed up `LexicalResolve::expansion()`

A couple of improvements that speed up `unicode_normalization` by about 4%. The first commit was enabled by the improvements to `BitSet` iteration in rust-lang#65425.

r? @nikomatsakis
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@zackmdavis zackmdavis

Labels
S-waiting-on-bors
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@nnethercote @rust-highfive @zackmdavis @bors @Centril
You can’t perform that action at this time.