Skip to content

/ rust

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Speed up `LexicalResolve::expansion()` #65480

Merged
merged 2 commits into from Oct 19, 2019
Merged

Speed up `LexicalResolve::expansion()` #65480

merged 2 commits into from Oct 19, 2019

Conversation

@nnethercote
Copy link
Contributor

@nnethercote nnethercote commented Oct 16, 2019

A couple of improvements that speed up unicode_normalization by about 4%. The first commit was enabled by the improvements to BitSet iteration in #65425.

r? @nikomatsakis
nnethercote added 2 commits Oct 15, 2019
@nnethercote
Use a `BitSet` in `LexicalResolver::iterate_until_fixed_point()`.
70b136d 
This wins 3% on `unicode_normalization`.
@nnethercote
Inline and remove `iterate_until_fixed_point()`.
Loading status checks…
d51fee0 
The commit also removes the debug statement, because they annoyed me.
This change wins another 1% on `unicode_normalization`, at least partly
because it no longer needs to increment `iteration`.
@nnethercote
Copy link
Contributor Author

@nnethercote nnethercote commented Oct 16, 2019

@bors try @rust-timer queue
@rust-timer
Copy link
Collaborator

@rust-timer rust-timer commented Oct 16, 2019

Awaiting bors try build completion
@bors
Copy link
Contributor

@bors bors commented Oct 16, 2019

⌛ Trying commit d51fee0 with merge e320fe5...
bors added a commit that referenced this pull request Oct 16, 2019
@bors
Auto merge of #65480 - nnethercote:rm-iterate_until_fixed_size, r=<try>
Loading status checks…
e320fe5 
Speed up `LexicalResolve::expansion()`

A couple of improvements that speed up `unicode_normalization` by about 4%. The first commit was enabled by the improvements to `BitSet` iteration in #65425.

r? @nikomatsakis
@bors
Copy link
Contributor

@bors bors commented Oct 17, 2019

☀️ Try build successful - checks-azure
Build commit: e320fe5 (e320fe5a2960de892c68a3a8ae505cec846d53e6)
@rust-timer
Copy link
Collaborator

@rust-timer rust-timer commented Oct 17, 2019

Queued e320fe5 with parent 0e8a4b4, future comparison URL.
@rust-timer
Copy link
Collaborator

@rust-timer rust-timer commented Oct 17, 2019

Finished benchmarking try commit e320fe5, comparison URL.
@nnethercote
Copy link
Contributor Author

@nnethercote nnethercote commented Oct 17, 2019

5-7% wins on unicode_normalizationon CI, which is more than what I saw locally. I'll take it!
@nikomatsakis
nikomatsakis approved these changes Oct 17, 2019
View changes
@nikomatsakis
Copy link
Contributor

@nikomatsakis nikomatsakis commented Oct 17, 2019

@bors r+
@bors
Copy link
Contributor

@bors bors commented Oct 17, 2019

📌 Commit d51fee0 has been approved by nikomatsakis
tmandry added a commit to tmandry/rust that referenced this pull request Oct 18, 2019
@tmandry
Rollup merge of rust-lang#65480 - nnethercote:rm-iterate_until_fixed_…
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
8cb6225 
…size, r=nikomatsakis

Speed up `LexicalResolve::expansion()`

A couple of improvements that speed up `unicode_normalization` by about 4%. The first commit was enabled by the improvements to `BitSet` iteration in rust-lang#65425.

r? @nikomatsakis
@tmandry tmandry mentioned this pull request Oct 18, 2019
Closed
bors added a commit that referenced this pull request Oct 18, 2019
@bors
Auto merge of #65548 - tmandry:rollup-kvfjxt2, r=tmandry
Loading status checks…
cf57b72 
Rollup of 13 pull requests

Successful merges:

 - #64925 (Document JSON message output.)
 - #65201 (Disable Go and OCaml bindings when building LLVM)
 - #65334 (Add long error explanation for E0575)
 - #65417 (Add more coherence tests)
 - #65455 (Avoid unnecessary `TokenTree` to `TokenStream` conversions)
 - #65472 (Use a sharded dep node to dep node index map)
 - #65480 (Speed up `LexicalResolve::expansion()`)
 - #65493 (Add long error explanation for E0584)
 - #65496 (properly document panics in div_euclid and rem_euclid)
 - #65498 (Plugins deprecation: don’t suggest simply removing the attribute)
 - #65508 (add option to ping llvm ice-breakers to triagebot)
 - #65513 (reorder fmt docs for more clarity)
 - #65531 (Update backtrace to 0.3.40)

Failed merges:

 - #65390 (Add long error explanation for E0576)
 - #65434 (Add long error explanation for E0577)
 - #65471 (Add long error explanation for E0578)
 - #65501 (Remove `src/llvm-emscripten` submodule)

r? @ghost
tmandry added a commit to tmandry/rust that referenced this pull request Oct 18, 2019
@tmandry
Rollup merge of rust-lang#65480 - nnethercote:rm-iterate_until_fixed_…
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
7cc5c5a 
…size, r=nikomatsakis

Speed up `LexicalResolve::expansion()`

A couple of improvements that speed up `unicode_normalization` by about 4%. The first commit was enabled by the improvements to `BitSet` iteration in rust-lang#65425.

r? @nikomatsakis
@tmandry tmandry mentioned this pull request Oct 18, 2019
Closed
bors added a commit that referenced this pull request Oct 18, 2019
@bors
Auto merge of #65550 - tmandry:rollup-ft7n1b3, r=tmandry
Loading status checks…
0277765 
Rollup of 12 pull requests

Successful merges:

 - #64925 (Document JSON message output.)
 - #65201 (Disable Go and OCaml bindings when building LLVM)
 - #65334 (Add long error explanation for E0575)
 - #65417 (Add more coherence tests)
 - #65455 (Avoid unnecessary `TokenTree` to `TokenStream` conversions)
 - #65472 (Use a sharded dep node to dep node index map)
 - #65480 (Speed up `LexicalResolve::expansion()`)
 - #65493 (Add long error explanation for E0584)
 - #65496 (properly document panics in div_euclid and rem_euclid)
 - #65498 (Plugins deprecation: don’t suggest simply removing the attribute)
 - #65508 (add option to ping llvm ice-breakers to triagebot)
 - #65513 (reorder fmt docs for more clarity)

Failed merges:

 - #65390 (Add long error explanation for E0576)
 - #65434 (Add long error explanation for E0577)
 - #65471 (Add long error explanation for E0578)
 - #65501 (Remove `src/llvm-emscripten` submodule)

r? @ghost
tmandry added a commit to tmandry/rust that referenced this pull request Oct 18, 2019
@tmandry
Rollup merge of rust-lang#65480 - nnethercote:rm-iterate_until_fixed_…
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
4a76e6d 
…size, r=nikomatsakis

Speed up `LexicalResolve::expansion()`

A couple of improvements that speed up `unicode_normalization` by about 4%. The first commit was enabled by the improvements to `BitSet` iteration in rust-lang#65425.

r? @nikomatsakis
@tmandry tmandry mentioned this pull request Oct 18, 2019
Closed
bors added a commit that referenced this pull request Oct 18, 2019
@bors
Auto merge of #65565 - tmandry:rollup-s8n9bie, r=tmandry
Loading status checks…
3623bcc 
Rollup of 17 pull requests

Successful merges:

 - #65016 (Always inline `mem::{size_of,align_of}` in debug builds)
 - #65197 (Prepare `MutVisitor`s to handle interned projections)
 - #65201 (Disable Go and OCaml bindings when building LLVM)
 - #65364 (Collect occurrences of empty blocks for mismatched braces diagnostic)
 - #65417 (Add more coherence tests)
 - #65434 (Add long error explanation for E0577)
 - #65455 (Avoid unnecessary `TokenTree` to `TokenStream` conversions)
 - #65472 (Use a sharded dep node to dep node index map)
 - #65480 (Speed up `LexicalResolve::expansion()`)
 - #65496 (properly document panics in div_euclid and rem_euclid)
 - #65508 (add option to ping llvm ice-breakers to triagebot)
 - #65511 (save-analysis: Nest tables when processing impl block definitions)
 - #65513 (reorder fmt docs for more clarity)
 - #65532 (doc: make BitSet intro more short)
 - #65540 (show up some extra info when t!() fails)
 - #65549 (Fix left/right shift typo in wrapping rotate docs)
 - #65552 (Clarify diagnostics when using `~` as a unary op)

Failed merges:

 - #65471 (Add long error explanation for E0578)

r? @ghost
tmandry added a commit to tmandry/rust that referenced this pull request Oct 18, 2019
@tmandry
Rollup merge of rust-lang#65480 - nnethercote:rm-iterate_until_fixed_…
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
c6bb960 
…size, r=nikomatsakis

Speed up `LexicalResolve::expansion()`

A couple of improvements that speed up `unicode_normalization` by about 4%. The first commit was enabled by the improvements to `BitSet` iteration in rust-lang#65425.

r? @nikomatsakis
@tmandry tmandry mentioned this pull request Oct 18, 2019
Merged
bors added a commit that referenced this pull request Oct 18, 2019
@bors
Auto merge of #65570 - tmandry:rollup-hck39pf, r=tmandry
Loading status checks…
91c3cd8 
Rollup of 19 pull requests

Successful merges:

 - #65016 (Always inline `mem::{size_of,align_of}` in debug builds)
 - #65197 (Prepare `MutVisitor`s to handle interned projections)
 - #65201 (Disable Go and OCaml bindings when building LLVM)
 - #65334 (Add long error explanation for E0575)
 - #65364 (Collect occurrences of empty blocks for mismatched braces diagnostic)
 - #65455 (Avoid unnecessary `TokenTree` to `TokenStream` conversions)
 - #65472 (Use a sharded dep node to dep node index map)
 - #65480 (Speed up `LexicalResolve::expansion()`)
 - #65493 (Add long error explanation for E0584)
 - #65496 (properly document panics in div_euclid and rem_euclid)
 - #65498 (Plugins deprecation: don’t suggest simply removing the attribute)
 - #65508 (add option to ping llvm ice-breakers to triagebot)
 - #65511 (save-analysis: Nest tables when processing impl block definitions)
 - #65513 (reorder fmt docs for more clarity)
 - #65532 (doc: make BitSet intro more short)
 - #65535 (rustc: arena-allocate the slice in `ty::GenericsPredicate`, not the whole struct.)
 - #65540 (show up some extra info when t!() fails)
 - #65549 (Fix left/right shift typo in wrapping rotate docs)
 - #65552 (Clarify diagnostics when using `~` as a unary op)

Failed merges:

 - #65390 (Add long error explanation for E0576)
 - #65434 (Add long error explanation for E0577)
 - #65471 (Add long error explanation for E0578)

r? @ghost
bors added a commit that referenced this pull request Oct 19, 2019
@bors
Auto merge of #65570 - tmandry:rollup-hck39pf, r=tmandry
Loading status checks…
14f0ed6 
Rollup of 19 pull requests

Successful merges:

 - #65016 (Always inline `mem::{size_of,align_of}` in debug builds)
 - #65197 (Prepare `MutVisitor`s to handle interned projections)
 - #65201 (Disable Go and OCaml bindings when building LLVM)
 - #65334 (Add long error explanation for E0575)
 - #65364 (Collect occurrences of empty blocks for mismatched braces diagnostic)
 - #65455 (Avoid unnecessary `TokenTree` to `TokenStream` conversions)
 - #65472 (Use a sharded dep node to dep node index map)
 - #65480 (Speed up `LexicalResolve::expansion()`)
 - #65493 (Add long error explanation for E0584)
 - #65496 (properly document panics in div_euclid and rem_euclid)
 - #65498 (Plugins deprecation: don’t suggest simply removing the attribute)
 - #65508 (add option to ping llvm ice-breakers to triagebot)
 - #65511 (save-analysis: Nest tables when processing impl block definitions)
 - #65513 (reorder fmt docs for more clarity)
 - #65532 (doc: make BitSet intro more short)
 - #65535 (rustc: arena-allocate the slice in `ty::GenericsPredicate`, not the whole struct.)
 - #65540 (show up some extra info when t!() fails)
 - #65549 (Fix left/right shift typo in wrapping rotate docs)
 - #65552 (Clarify diagnostics when using `~` as a unary op)

Failed merges:

 - #65390 (Add long error explanation for E0576)
 - #65434 (Add long error explanation for E0577)
 - #65471 (Add long error explanation for E0578)

r? @ghost
@bors bors merged commit d51fee0 into rust-lang:master Oct 19, 2019
5 checks passed
5 checks passed
homu Test successful
Details
pr Build #20191016.56 succeeded
Details
pr (Linux mingw-check) Linux mingw-check succeeded
Details
pr (Linux x86_64-gnu-llvm-6.0) Linux x86_64-gnu-llvm-6.0 succeeded
Details
pr (LinuxTools) LinuxTools succeeded
Details
@nnethercote nnethercote mentioned this pull request Oct 19, 2019
Closed
@nnethercote nnethercote deleted the nnethercote:rm-iterate_until_fixed_size branch Oct 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikomatsakis nikomatsakis

Assignees

@nikomatsakis nikomatsakis

Labels
S-waiting-on-bors
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@nnethercote @rust-timer @bors @nikomatsakis @rust-highfive
You can’t perform that action at this time.