Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More symbol cleanups #65545

Merged
merged 4 commits into from Oct 19, 2019

Conversation

@nnethercote
Copy link
Contributor

nnethercote commented Oct 18, 2019

Some minor improvements, mostly aimed at reducing unimportant differences between Symbol and InternedString. Helps a little with #60869.

r? @petrochenkov

nnethercote added 4 commits Oct 17, 2019
Instead of `as_str()`, which unnecessarily involves `LocalInternedString`.
Currently, `Symbol::Debug` and `Symbol::Display` produce the same
output; neither wraps the symbol in double quotes.

This commit changes `Symbol::Debug` so it wraps the symbol in quotes.
This change brings `Symbol`'s behaviour in line with `String` and
`InternedString`. The change requires a couple of trivial test output
adjustments.
…efKey`.

They aren't used.
@petrochenkov

This comment has been minimized.

Copy link
Contributor

petrochenkov commented Oct 18, 2019

@bors r+ rollup

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Oct 18, 2019

📌 Commit d343ee8 has been approved by petrochenkov

Centril added a commit to Centril/rust that referenced this pull request Oct 19, 2019
…=petrochenkov

More symbol cleanups

Some minor improvements, mostly aimed at reducing unimportant differences between `Symbol` and `InternedString`. Helps a little with rust-lang#60869.

r? @petrochenkov
Centril added a commit to Centril/rust that referenced this pull request Oct 19, 2019
…=petrochenkov

More symbol cleanups

Some minor improvements, mostly aimed at reducing unimportant differences between `Symbol` and `InternedString`. Helps a little with rust-lang#60869.

r? @petrochenkov
bors added a commit that referenced this pull request Oct 19, 2019
Rollup of 7 pull requests

Successful merges:

 - #65174 (Fix zero-size uninitialized boxes)
 - #65241 (build-std compatible sanitizer support)
 - #65302 (Upgrade GCC to 8.3.0, glibc to 1.17.0 and crosstool-ng to 1.24.0 for dist-armv7-linux)
 - #65469 (Update libc to 0.2.64)
 - #65485 (Suppress ICE when validators disagree on `LiveDrop`s in presence of `&mut`)
 - #65542 (Refer to "associated functions" instead of "static methods")
 - #65545 (More symbol cleanups)

Failed merges:

 - #65501 (Remove `src/llvm-emscripten` submodule)

r? @ghost
Centril added a commit to Centril/rust that referenced this pull request Oct 19, 2019
…=petrochenkov

More symbol cleanups

Some minor improvements, mostly aimed at reducing unimportant differences between `Symbol` and `InternedString`. Helps a little with rust-lang#60869.

r? @petrochenkov
bors added a commit that referenced this pull request Oct 19, 2019
Rollup of 6 pull requests

Successful merges:

 - #65174 (Fix zero-size uninitialized boxes)
 - #65252 (expand: Simplify expansion of derives)
 - #65485 (Suppress ICE when validators disagree on `LiveDrop`s in presence of `&mut`)
 - #65542 (Refer to "associated functions" instead of "static methods")
 - #65545 (More symbol cleanups)
 - #65576 (Don't add `argc` and `argv` arguments to `main` on WASI.)

Failed merges:

r? @ghost
@bors bors merged commit d343ee8 into rust-lang:master Oct 19, 2019
4 checks passed
4 checks passed
pr Build #20191018.16 succeeded
Details
pr (Linux mingw-check) Linux mingw-check succeeded
Details
pr (Linux x86_64-gnu-llvm-6.0) Linux x86_64-gnu-llvm-6.0 succeeded
Details
pr (LinuxTools) LinuxTools succeeded
Details
@nnethercote nnethercote deleted the nnethercote:more-symbol-cleanups branch Oct 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.