Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix `canonicalize_const_var` leaking inference variables #65652

Merged
merged 1 commit into from Oct 21, 2019

Conversation

@skinny121
Copy link
Contributor

skinny121 commented Oct 21, 2019

Fixes #61338
Fixes #61516
Fixes #62536
Fixes #64087
Fixes #64863
Fixes #65623

I added regression tests for all these issues apart from #64863, which is very similar to #61338.

r? @varkor

@skinny121 skinny121 changed the title Fix `canonicalize_const_var` from leaking inference variables Fix `canonicalize_const_var` leaking inference variables Oct 21, 2019
@eddyb
eddyb approved these changes Oct 21, 2019
@eddyb

This comment has been minimized.

Copy link
Member

eddyb commented Oct 21, 2019

This is great, thanks!
@bors r+

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Oct 21, 2019

📌 Commit aa3d28f has been approved by eddyb

@varkor

This comment has been minimized.

Copy link
Member

varkor commented Oct 21, 2019

@skinny121: fantastic, thank you so much! I had completely overlooked this — great spot!

JohnTitor added a commit to JohnTitor/rust that referenced this pull request Oct 21, 2019
Fix `canonicalize_const_var` leaking inference variables

Fixes rust-lang#61338
Fixes rust-lang#61516
Fixes rust-lang#62536
Fixes rust-lang#64087
Fixes rust-lang#64863
Fixes rust-lang#65623

I added regression tests for all these issues apart from rust-lang#64863, which is very similar to rust-lang#61338.

r? @varkor
bors added a commit that referenced this pull request Oct 21, 2019
Rollup of 5 pull requests

Successful merges:

 - #65544 (Added doc on keyword break)
 - #65620 (Correctly note code as Ok not error for E0573)
 - #65624 ([mir-opt] Improve SimplifyLocals pass so it can remove unused consts)
 - #65650 (use unwrap_or in lint code)
 - #65652 (Fix `canonicalize_const_var` leaking inference variables)

Failed merges:

r? @ghost
bors added a commit that referenced this pull request Oct 21, 2019
Rollup of 5 pull requests

Successful merges:

 - #65544 (Added doc on keyword break)
 - #65620 (Correctly note code as Ok not error for E0573)
 - #65624 ([mir-opt] Improve SimplifyLocals pass so it can remove unused consts)
 - #65650 (use unwrap_or in lint code)
 - #65652 (Fix `canonicalize_const_var` leaking inference variables)

Failed merges:

r? @ghost
@bors bors merged commit aa3d28f into rust-lang:master Oct 21, 2019
4 checks passed
4 checks passed
pr Build #20191021.15 succeeded
Details
pr (Linux mingw-check) Linux mingw-check succeeded
Details
pr (Linux x86_64-gnu-llvm-6.0) Linux x86_64-gnu-llvm-6.0 succeeded
Details
pr (LinuxTools) LinuxTools succeeded
Details
@LukasKalbertodt LukasKalbertodt referenced this pull request Oct 21, 2019
5 of 5 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.