Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch CrateMetadata's source_map_import_info from RwLock to Once #65979

Merged
merged 3 commits into from Oct 31, 2019

Conversation

@spastorino
Copy link
Member

spastorino commented Oct 30, 2019

No description provided.

src/librustc_metadata/decoder.rs Outdated Show resolved Hide resolved
src/librustc_metadata/decoder.rs Outdated Show resolved Hide resolved
@Mark-Simulacrum

This comment has been minimized.

Copy link
Member

Mark-Simulacrum commented Oct 30, 2019

r=me modulo comments

This field is created lazily on first use and after that is read only.
That's exactly what Once is for.
@spastorino spastorino force-pushed the spastorino:crate-metadata-mutexes branch from 0cc9939 to 53f3e9b Oct 30, 2019
@spastorino spastorino marked this pull request as ready for review Oct 30, 2019
@spastorino spastorino force-pushed the spastorino:crate-metadata-mutexes branch from 53f3e9b to d8e9a63 Oct 30, 2019
@spastorino spastorino force-pushed the spastorino:crate-metadata-mutexes branch 2 times, most recently from 014cc3e to 12273cb Oct 30, 2019
@Mark-Simulacrum

This comment has been minimized.

Copy link
Member

Mark-Simulacrum commented Oct 30, 2019

@bors r+ rollup

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Oct 30, 2019

📌 Commit 12273cb has been approved by Mark-Simulacrum

Centril added a commit to Centril/rust that referenced this pull request Oct 31, 2019
…r=Mark-Simulacrum

Switch CrateMetadata's source_map_import_info from RwLock to Once
bors added a commit that referenced this pull request Oct 31, 2019
Rollup of 7 pull requests

Successful merges:

 - #65274 (Upload toolstates.json to rust-lang-ci2)
 - #65434 (Add long error explanation for E0577)
 - #65850 (Update comments re type parameter hack in object safety)
 - #65955 (ci: revert msys2 ca-certificates hack)
 - #65959 (Fix an incorrect docstring for Immediate in librustc_mir/interpret.)
 - #65979 (Switch CrateMetadata's source_map_import_info from RwLock to Once)
 - #65981 (work around aggressive syntax feature gating)

Failed merges:

r? @ghost
@bors bors merged commit 12273cb into rust-lang:master Oct 31, 2019
4 checks passed
4 checks passed
pr Build #20191030.80 succeeded
Details
pr (Linux mingw-check) Linux mingw-check succeeded
Details
pr (Linux x86_64-gnu-llvm-6.0) Linux x86_64-gnu-llvm-6.0 succeeded
Details
pr (Linux x86_64-gnu-tools) Linux x86_64-gnu-tools succeeded
Details
tmandry added a commit to tmandry/rust that referenced this pull request Oct 31, 2019
…, r=Mark-Simulacrum

Fix outdated rustdoc of Once::init_locking function

r? @Mark-Simulacrum

related to rust-lang#65979
tmandry added a commit to tmandry/rust that referenced this pull request Nov 1, 2019
…, r=Mark-Simulacrum

Fix outdated rustdoc of Once::init_locking function

r? @Mark-Simulacrum

related to rust-lang#65979
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.