Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

debuginfo: Support for std::collections::Hash* in windows debuggers. #66597

Merged
merged 1 commit into from Nov 23, 2019

Conversation

@MaulingMonkey
Copy link
Contributor

MaulingMonkey commented Nov 21, 2019

Okay, I finally needed to debug code involving a HashMap! Added support for HashSet s as well.

r? @michaelwoerister

Local Testing

Verified these are passing locally:

:: cmd.exe
python x.py test --stage 1 --build x86_64-pc-windows-msvc src/test/debuginfo
python x.py test --stage 1 --build i686-pc-windows-msvc src/test/debuginfo
python x.py test --stage 1 src/tools/tidy

:: MinGW MSYS2
./x.py test --stage 1 --build x86_64-pc-windows-gnu src/test/debuginfo

Related Issues

@michaelwoerister

This comment has been minimized.

Copy link
Contributor

michaelwoerister commented Nov 21, 2019

Thanks, @MaulingMonkey! Approving with the understanding that these natvis files are basically unsupported. cc @rust-lang/compiler & @alexcrichton: someone correct if that is not actually the case.

@bors r+

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Nov 21, 2019

📌 Commit 839d58c has been approved by michaelwoerister

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Nov 23, 2019

⌛️ Testing commit 839d58c with merge 9420ff4...

bors added a commit that referenced this pull request Nov 23, 2019
…r=michaelwoerister

debuginfo:  Support for std::collections::Hash* in windows debuggers.

Okay, I finally needed to debug code involving a HashMap!  Added support for HashSet s as well.

r? @michaelwoerister

### Local Testing

Verified these are passing locally:
```cmd
:: cmd.exe
python x.py test --stage 1 --build x86_64-pc-windows-msvc src/test/debuginfo
python x.py test --stage 1 --build i686-pc-windows-msvc src/test/debuginfo
python x.py test --stage 1 src/tools/tidy

:: MinGW MSYS2
./x.py test --stage 1 --build x86_64-pc-windows-gnu src/test/debuginfo
```

### Related Issues

* #36503
* #40460
* rust-gamedev/wg#20
@bors

This comment has been minimized.

Copy link
Contributor

bors commented Nov 23, 2019

☀️ Test successful - checks-azure
Approved by: michaelwoerister
Pushing 9420ff4 to master...

@bors bors added the merged-by-bors label Nov 23, 2019
@bors bors merged commit 839d58c into rust-lang:master Nov 23, 2019
5 checks passed
5 checks passed
homu Test successful
Details
pr #20191121.4 succeeded
Details
pr (Linux mingw-check) Linux mingw-check succeeded
Details
pr (Linux x86_64-gnu-llvm-6.0) Linux x86_64-gnu-llvm-6.0 succeeded
Details
pr (Linux x86_64-gnu-tools) Linux x86_64-gnu-tools succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.