Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allocate HIR on an arena 3/4 -- Ty #66942

Merged
merged 7 commits into from Dec 30, 2019
Merged

Allocate HIR on an arena 3/4 -- Ty #66942

merged 7 commits into from Dec 30, 2019

Conversation

@cjgillot
Copy link
Contributor

cjgillot commented Dec 1, 2019

This is the third PR in the series started by #66931 and #66936

Once again, commits don't really make sense on their own.
They are mostly split by type of compile error.

The additional diff is here: cjgillot/rust@hirene-expr...hirene-ty

@rust-highfive

This comment was marked as outdated.

Copy link
Collaborator

rust-highfive commented Dec 1, 2019

The job x86_64-gnu-llvm-6.0 of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
2019-12-01T22:02:32.3698109Z ##[command]git remote add origin https://github.com/rust-lang/rust
2019-12-01T22:02:32.3713102Z ##[command]git config gc.auto 0
2019-12-01T22:02:32.3716705Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2019-12-01T22:02:32.3720980Z ##[command]git config --get-all http.proxy
2019-12-01T22:02:32.3724820Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/66942/merge:refs/remotes/pull/66942/merge
---
2019-12-01T22:31:26.1694852Z fatal runtime error: stack overflow
2019-12-01T22:31:26.4482103Z error: could not compile `core`.
2019-12-01T22:31:26.4488313Z 
2019-12-01T22:31:26.4488461Z Caused by:
2019-12-01T22:31:26.4497869Z   process didn't exit successfully: `/checkout/obj/build/bootstrap/debug/rustc --edition=2018 --crate-name core src/libcore/lib.rs --error-format=json --json=diagnostic-rendered-ansi,artifacts --crate-type lib --emit=dep-info,metadata,link -C opt-level=2 -C codegen-units=1 -C debuginfo=0 -C metadata=8dab76f6898d904f -C extra-filename=-8dab76f6898d904f --out-dir /checkout/obj/build/x86_64-unknown-linux-gnu/stage1-std/x86_64-unknown-linux-gnu/release/deps --target x86_64-unknown-linux-gnu -L dependency=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-std/x86_64-unknown-linux-gnu/release/deps -L dependency=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-std/release/deps -Zexternal-macro-backtrace '-Clink-args=-Wl,-rpath,$ORIGIN/../lib' -Wrust_2018_idioms -Wunused_lifetimes -Dwarnings -Cprefer-dynamic -Zbinary-dep-depinfo` (signal: 6, SIGABRT: process abort signal)
2019-12-01T22:31:28.2430796Z error: build failed
2019-12-01T22:31:28.2458289Z command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "build" "-Zconfig-profile" "--target" "x86_64-unknown-linux-gnu" "-Zbinary-dep-depinfo" "-j" "2" "--release" "--locked" "--color" "always" "--features" "panic-unwind backtrace compiler-builtins-c" "--manifest-path" "/checkout/src/libtest/Cargo.toml" "--message-format" "json-render-diagnostics"
2019-12-01T22:31:28.2458491Z expected success, got: exit code: 101
2019-12-01T22:31:28.2473116Z failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
2019-12-01T22:31:28.2473116Z failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
2019-12-01T22:31:28.2473434Z Build completed unsuccessfully in 0:22:54
2019-12-01T22:31:28.2541034Z == clock drift check ==
2019-12-01T22:31:28.2558256Z   local time: Sun Dec  1 22:31:28 UTC 2019
2019-12-01T22:31:28.5220017Z   network time: Sun, 01 Dec 2019 22:31:28 GMT
2019-12-01T22:31:28.5224052Z == end clock drift check ==
2019-12-01T22:31:29.2487314Z 
2019-12-01T22:31:29.2599790Z ##[error]Bash exited with code '1'.
2019-12-01T22:31:29.2633297Z ##[section]Starting: Checkout
2019-12-01T22:31:29.2634905Z ==============================================================================
2019-12-01T22:31:29.2634953Z Task         : Get sources
2019-12-01T22:31:29.2634994Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@bors

This comment was marked as outdated.

Copy link
Contributor

bors commented Dec 2, 2019

☔️ The latest upstream changes (presumably #66944) made this pull request unmergeable. Please resolve the merge conflicts.

@davidtwco

This comment has been minimized.

Copy link
Member

davidtwco commented Dec 2, 2019

r? @eddyb
cc @Zoxc

@rust-highfive rust-highfive assigned eddyb and unassigned davidtwco Dec 2, 2019
@cjgillot cjgillot force-pushed the cjgillot:hirene-ty branch from bee43a3 to 18c6444 Dec 3, 2019
@bors

This comment was marked as resolved.

Copy link
Contributor

bors commented Dec 5, 2019

☔️ The latest upstream changes (presumably #66815) made this pull request unmergeable. Please resolve the merge conflicts.

@cjgillot cjgillot force-pushed the cjgillot:hirene-ty branch from 18c6444 to 7b44719 Dec 9, 2019
bors added a commit that referenced this pull request Dec 9, 2019
Allocate HIR on an arena 4/4

This is the fourth and last PR in the series started by #66931, #66936 and #66942.

The last commits should compile on their own.
The difference with the previous PR is given by cjgillot/rust@hirene-ty...hirene

A few more cleanups may be necessary, please tell me.

r? @eddyb like the other
cc @Zoxc
@bors

This comment was marked as resolved.

Copy link
Contributor

bors commented Dec 11, 2019

☔️ The latest upstream changes (presumably #67202) made this pull request unmergeable. Please resolve the merge conflicts.

@cjgillot cjgillot force-pushed the cjgillot:hirene-ty branch from 7b44719 to 0cda17b Dec 11, 2019
bors added a commit that referenced this pull request Dec 11, 2019
Allocate HIR on an arena 4/4

This is the fourth and last PR in the series started by #66931, #66936 and #66942.

The last commits should compile on their own.
The difference with the previous PR is given by cjgillot/rust@hirene-ty...hirene

A few more cleanups may be necessary, please tell me.

r? @eddyb like the other
cc @Zoxc
@bors

This comment was marked as resolved.

Copy link
Contributor

bors commented Dec 14, 2019

☔️ The latest upstream changes (presumably #65951) made this pull request unmergeable. Please resolve the merge conflicts.

@cjgillot cjgillot force-pushed the cjgillot:hirene-ty branch from 0cda17b to f654897 Dec 14, 2019
@bors

This comment was marked as resolved.

Copy link
Contributor

bors commented Dec 16, 2019

☔️ The latest upstream changes (presumably #67356) made this pull request unmergeable. Please resolve the merge conflicts.

src/librustc/hir/lowering/item.rs Outdated Show resolved Hide resolved
src/librustc/hir/lowering.rs Outdated Show resolved Hide resolved
src/librustc/hir/lowering.rs Outdated Show resolved Hide resolved
@cjgillot cjgillot force-pushed the cjgillot:hirene-ty branch from f654897 to af3d9db Dec 22, 2019
@bors

This comment was marked as resolved.

Copy link
Contributor

bors commented Dec 23, 2019

☔️ The latest upstream changes (presumably #67540) made this pull request unmergeable. Please resolve the merge conflicts.

@cjgillot cjgillot force-pushed the cjgillot:hirene-ty branch 2 times, most recently from 7246ea5 to 73c260a Dec 24, 2019
@bors

This comment was marked as resolved.

Copy link
Contributor

bors commented Dec 25, 2019

☔️ The latest upstream changes (presumably #67596) made this pull request unmergeable. Please resolve the merge conflicts.

@cjgillot cjgillot force-pushed the cjgillot:hirene-ty branch from 73c260a to a638a7f Dec 26, 2019
@cjgillot

This comment has been minimized.

Copy link
Contributor Author

cjgillot commented Dec 26, 2019

Rebased with review comments.

@Zoxc

This comment was marked as outdated.

Copy link
Contributor

Zoxc commented Dec 29, 2019

@bors r+

@bors

This comment was marked as outdated.

Copy link
Contributor

bors commented Dec 29, 2019

📌 Commit 71f7458 has been approved by Zoxc

@bors

This comment was marked as resolved.

Copy link
Contributor

bors commented Dec 29, 2019

⌛️ Testing commit 71f7458 with merge deb8822...

bors added a commit that referenced this pull request Dec 29, 2019
Allocate HIR on an arena 3/4 -- Ty

This is the third PR in the series started by #66931 and #66936

Once again, commits don't really make sense on their own.
They are mostly split by type of compile error.

The additional diff is here: cjgillot/rust@hirene-expr...hirene-ty
@bors

This comment was marked as resolved.

Copy link
Contributor

bors commented Dec 29, 2019

💔 Test failed - checks-azure

@rust-highfive

This comment was marked as resolved.

Copy link
Collaborator

rust-highfive commented Dec 29, 2019

The job x86_64-gnu of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
2019-12-29T15:15:39.7391119Z status: exit code: 2
2019-12-29T15:15:39.7391496Z command: "make" "make"
2019-12-29T15:15:39.7391855Z stdout:
2019-12-29T15:15:39.7392262Z ------------------------------------------
2019-12-29T15:15:39.7394489Z # We don't compile `opaque` with either optimizations or instrumentation.
2019-12-29T15:15:39.7398338Z # We don't compile `opaque` with either optimizations or instrumentation.
2019-12-29T15:15:39.7400363Z LD_LIBRARY_PATH="/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-make-fulldeps/pgo-branch-weights/pgo-branch-weights:/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib:/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-bootstrap-tools/x86_64-unknown-linux-gnu/release/deps:/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/lib" '/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc' --out-dir /checkout/obj/build/x86_64-unknown-linux-gnu/test/run-make-fulldeps/pgo-branch-weights/pgo-branch-weights -L /checkout/obj/build/x86_64-unknown-linux-gnu/test/run-make-fulldeps/pgo-branch-weights/pgo-branch-weights   opaque.rs
2019-12-29T15:15:39.7401993Z # Compile the test program with instrumentation
2019-12-29T15:15:39.7402630Z mkdir -p "/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-make-fulldeps/pgo-branch-weights/pgo-branch-weights"/prof_data_dir
2019-12-29T15:15:39.7403788Z LD_LIBRARY_PATH="/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-make-fulldeps/pgo-branch-weights/pgo-branch-weights:/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib:/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-bootstrap-tools/x86_64-unknown-linux-gnu/release/deps:/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/lib" '/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc' --out-dir /checkout/obj/build/x86_64-unknown-linux-gnu/test/run-make-fulldeps/pgo-branch-weights/pgo-branch-weights -L /checkout/obj/build/x86_64-unknown-linux-gnu/test/run-make-fulldeps/pgo-branch-weights/pgo-branch-weights   interesting.rs \
2019-12-29T15:15:39.7405115Z  -Cprofile-generate="/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-make-fulldeps/pgo-branch-weights/pgo-branch-weights"/prof_data_dir -O -Ccodegen-units=1
2019-12-29T15:15:39.7406209Z LD_LIBRARY_PATH="/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-make-fulldeps/pgo-branch-weights/pgo-branch-weights:/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib:/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-bootstrap-tools/x86_64-unknown-linux-gnu/release/deps:/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/lib" '/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc' --out-dir /checkout/obj/build/x86_64-unknown-linux-gnu/test/run-make-fulldeps/pgo-branch-weights/pgo-branch-weights -L /checkout/obj/build/x86_64-unknown-linux-gnu/test/run-make-fulldeps/pgo-branch-weights/pgo-branch-weights   main.rs -Cprofile-generate="/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-make-fulldeps/pgo-branch-weights/pgo-branch-weights"/prof_data_dir -O
2019-12-29T15:15:39.7406529Z # The argument below generates to the expected branch weights
2019-12-29T15:15:39.7407356Z LD_LIBRARY_PATH="/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-make-fulldeps/pgo-branch-weights/pgo-branch-weights:/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib:/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-bootstrap-tools/x86_64-unknown-linux-gnu/release/deps:/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/lib" /checkout/obj/build/x86_64-unknown-linux-gnu/test/run-make-fulldeps/pgo-branch-weights/pgo-branch-weights/main aaaaaaaaaaaa2bbbbbbbbbbbb2bbbbbbbbbbbbbbbbcc || exit 1
2019-12-29T15:15:39.7407801Z "/checkout/obj/build/x86_64-unknown-linux-gnu/llvm/build/bin"/llvm-profdata merge \
2019-12-29T15:15:39.7408167Z  -o "/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-make-fulldeps/pgo-branch-weights/pgo-branch-weights"/prof_data_dir/merged.profdata \
2019-12-29T15:15:39.7408875Z  "/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-make-fulldeps/pgo-branch-weights/pgo-branch-weights"/prof_data_dir
2019-12-29T15:15:39.7409871Z LD_LIBRARY_PATH="/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-make-fulldeps/pgo-branch-weights/pgo-branch-weights:/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib:/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-bootstrap-tools/x86_64-unknown-linux-gnu/release/deps:/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/lib" '/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc' --out-dir /checkout/obj/build/x86_64-unknown-linux-gnu/test/run-make-fulldeps/pgo-branch-weights/pgo-branch-weights -L /checkout/obj/build/x86_64-unknown-linux-gnu/test/run-make-fulldeps/pgo-branch-weights/pgo-branch-weights   interesting.rs \
2019-12-29T15:15:39.7410435Z  -Cprofile-use="/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-make-fulldeps/pgo-branch-weights/pgo-branch-weights"/prof_data_dir/merged.profdata -O \
2019-12-29T15:15:39.7410693Z  -Ccodegen-units=1 --emit=llvm-ir
2019-12-29T15:15:39.7411153Z cat "/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-make-fulldeps/pgo-branch-weights/pgo-branch-weights"/interesting.ll | "/checkout/obj/build/x86_64-unknown-linux-gnu/llvm/build/bin/FileCheck" filecheck-patterns.txt
2019-12-29T15:15:39.7411922Z ------------------------------------------
2019-12-29T15:15:39.7412196Z stderr:
2019-12-29T15:15:39.7412440Z ------------------------------------------
2019-12-29T15:15:39.7412440Z ------------------------------------------
2019-12-29T15:15:39.7412714Z filecheck-patterns.txt:5:8: error: CHECK: expected string not found in input
2019-12-29T15:15:39.7413053Z CHECK: define void @function_called_twice(i32 %c) {{.*}} !prof [[function_called_twice_id:![0-9]+]] {
2019-12-29T15:15:39.7413338Z <stdin>:1:1: note: scanning from here
2019-12-29T15:15:39.7413338Z <stdin>:1:1: note: scanning from here
2019-12-29T15:15:39.7413624Z ; ModuleID = 'interesting.3a1fbbbh-cgu.0'
2019-12-29T15:15:39.7413772Z <stdin>:7:1: note: possible intended match here
2019-12-29T15:15:39.7413772Z <stdin>:7:1: note: possible intended match here
2019-12-29T15:15:39.7413853Z define void @function_called_twice(i32 %c) unnamed_addr #0 {
2019-12-29T15:15:39.7413961Z ^
2019-12-29T15:15:39.7414036Z make: *** [Makefile:30: all] Error 1
2019-12-29T15:15:39.7414469Z ------------------------------------------
2019-12-29T15:15:39.7414529Z 
2019-12-29T15:15:39.7414562Z 
2019-12-29T15:15:39.7414593Z 
2019-12-29T15:15:39.7414593Z 
2019-12-29T15:15:39.7414668Z failures:
2019-12-29T15:15:39.7414898Z     [run-make] run-make-fulldeps/pgo-branch-weights
2019-12-29T15:15:39.7414961Z 
2019-12-29T15:15:39.7415234Z test result: FAILED. 199 passed; 1 failed; 6 ignored; 0 measured; 0 filtered out
2019-12-29T15:15:39.7415301Z 
2019-12-29T15:15:39.7415348Z 
2019-12-29T15:15:39.7415380Z 
2019-12-29T15:15:39.7420114Z command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "--compile-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib" "--run-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "--rustc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "--rustdoc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustdoc" "--src-base" "/checkout/src/test/run-make-fulldeps" "--build-base" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-make-fulldeps" "--stage-id" "stage2-x86_64-unknown-linux-gnu" "--mode" "run-make" "--target" "x86_64-unknown-linux-gnu" "--host" "x86_64-unknown-linux-gnu" "--llvm-filecheck" "/checkout/obj/build/x86_64-unknown-linux-gnu/llvm/build/bin/FileCheck" "--host-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--target-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--docck-python" "/usr/bin/python2.7" "--lldb-python" "/usr/bin/python2.7" "--gdb" "/usr/bin/gdb" "--llvm-version" "9.0.0-rust-1.42.0-nightly\n" "--cc" "cc" "--cxx" "c++" "--cflags" "-ffunction-sections -fdata-sections -fPIC -m64" "--llvm-components" "aarch64 aarch64asmparser aarch64codegen aarch64desc aarch64disassembler aarch64info aarch64utils aggressiveinstcombine all all-targets analysis arm armasmparser armcodegen armdesc armdisassembler arminfo armutils asmparser asmprinter binaryformat bitreader bitstreamreader bitwriter codegen core coroutines coverage debuginfocodeview debuginfodwarf debuginfogsym debuginfomsf debuginfopdb demangle dlltooldriver engine executionengine fuzzmutate globalisel gtest gtest_main hexagon hexagonasmparser hexagoncodegen hexagondesc hexagondisassembler hexagoninfo instcombine instrumentation interpreter ipo irreader jitlink libdriver lineeditor linker lto mc mca mcdisassembler mcjit mcparser mips mipsasmparser mipscodegen mipsdesc mipsdisassembler mipsinfo mirparser msp430 msp430asmparser msp430codegen msp430desc msp430disassembler msp430info native nativecodegen nvptx nvptxcodegen nvptxdesc nvptxinfo objcarcopts object objectyaml option orcjit passes powerpc powerpcasmparser powerpccodegen powerpcdesc powerpcdisassembler powerpcinfo profiledata remarks riscv riscvasmparser riscvcodegen riscvdesc riscvdisassembler riscvinfo riscvutils runtimedyld scalaropts selectiondag sparc sparcasmparser sparccodegen sparcdesc sparcdisassembler sparcinfo support symbolize systemz systemzasmparser systemzcodegen systemzdesc systemzdisassembler systemzinfo tablegen target testingsupport textapi transformutils vectorize webassembly webassemblyasmparser webassemblycodegen webassemblydesc webassemblydisassembler webassemblyinfo windowsmanifest x86 x86asmparser x86codegen x86desc x86disassembler x86info x86utils xray" "--llvm-cxxflags" "-I/checkout/src/llvm-project/llvm/include -I/checkout/obj/build/x86_64-unknown-linux-gnu/llvm/build/include -std=c++11   -fno-exceptions -fno-rtti -D_GNU_SOURCE -D_DEBUG -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS" "--ar" "ar" "--llvm-bin-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/llvm/build/bin" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--color" "always"
2019-12-29T15:15:39.7422386Z 
2019-12-29T15:15:39.7422419Z 
2019-12-29T15:15:39.7424357Z failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
2019-12-29T15:15:39.7424624Z Build completed unsuccessfully in 2:22:45
2019-12-29T15:15:39.7424624Z Build completed unsuccessfully in 2:22:45
2019-12-29T15:15:39.7537718Z == clock drift check ==
2019-12-29T15:15:39.7566173Z   local time: Sun Dec 29 15:15:39 UTC 2019
2019-12-29T15:15:40.2395761Z   network time: Sun, 29 Dec 2019 15:15:40 GMT
2019-12-29T15:15:40.2401545Z == end clock drift check ==
2019-12-29T15:15:51.0773462Z 
2019-12-29T15:15:51.0981290Z ##[error]Bash exited with code '1'.
2019-12-29T15:15:51.1054857Z ##[section]Starting: Checkout
2019-12-29T15:15:51.1056921Z ==============================================================================
2019-12-29T15:15:51.1057012Z Task         : Get sources
2019-12-29T15:15:51.1057078Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@Zoxc

This comment has been minimized.

Copy link
Contributor

Zoxc commented Dec 29, 2019

@bors retry

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Dec 29, 2019

⌛️ Testing commit 71f7458 with merge 2ba0d2a...

bors added a commit that referenced this pull request Dec 29, 2019
Allocate HIR on an arena 3/4 -- Ty

This is the third PR in the series started by #66931 and #66936

Once again, commits don't really make sense on their own.
They are mostly split by type of compile error.

The additional diff is here: cjgillot/rust@hirene-expr...hirene-ty
@bors

This comment has been minimized.

Copy link
Contributor

bors commented Dec 30, 2019

☀️ Test successful - checks-azure
Approved by: Zoxc
Pushing 2ba0d2a to master...

@bors bors added the merged-by-bors label Dec 30, 2019
@bors bors merged commit 71f7458 into rust-lang:master Dec 30, 2019
5 checks passed
5 checks passed
homu Test successful
Details
pr Build #20191227.32 succeeded
Details
pr (Linux mingw-check) Linux mingw-check succeeded
Details
pr (Linux x86_64-gnu-llvm-7) Linux x86_64-gnu-llvm-7 succeeded
Details
pr (Linux x86_64-gnu-tools) Linux x86_64-gnu-tools succeeded
Details
@rust-highfive

This comment has been minimized.

Copy link
Collaborator

rust-highfive commented Dec 30, 2019

📣 Toolstate changed by #66942!

Tested on commit 2ba0d2a.
Direct link to PR: #66942

💔 clippy-driver on windows: test-pass → build-fail (cc @mcarton @oli-obk @Manishearth @flip1995 @yaahc @phansch @llogiq, @rust-lang/infra).
💔 clippy-driver on linux: test-pass → build-fail (cc @mcarton @oli-obk @Manishearth @flip1995 @yaahc @phansch @llogiq, @rust-lang/infra).

rust-highfive added a commit to rust-lang-nursery/rust-toolstate that referenced this pull request Dec 30, 2019
Tested on commit rust-lang/rust@2ba0d2a.
Direct link to PR: <rust-lang/rust#66942>

💔 clippy-driver on windows: test-pass → build-fail (cc @mcarton @oli-obk @Manishearth @flip1995 @yaahc @phansch @llogiq, @rust-lang/infra).
💔 clippy-driver on linux: test-pass → build-fail (cc @mcarton @oli-obk @Manishearth @flip1995 @yaahc @phansch @llogiq, @rust-lang/infra).
JohnTitor added a commit to JohnTitor/rust-clippy that referenced this pull request Dec 30, 2019
@cjgillot cjgillot deleted the cjgillot:hirene-ty branch Dec 30, 2019
bors added a commit to rust-lang/rust-clippy that referenced this pull request Dec 30, 2019
Rustup to rust-lang/rust#66942

changelog: none
bors added a commit that referenced this pull request Dec 31, 2019
Allocate HIR on an arena 4/4

This is the fourth and last PR in the series started by #66931, #66936 and #66942.

The last commits should compile on their own.
The difference with the previous PR is given by cjgillot/rust@hirene-ty...hirene

A few more cleanups may be necessary, please tell me.

r? @eddyb like the other
cc @Zoxc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.