Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Const prop should finish propagation into user defined variables #67130

Merged
merged 1 commit into from Dec 21, 2019

Conversation

@wesleywiser
Copy link
Member

wesleywiser commented Dec 7, 2019

Fixes #66638

Temporarily rebased on top of #67015 to get those fixes.

r? @oli-obk

@wesleywiser

This comment was marked as outdated.

Copy link
Member Author

wesleywiser commented Dec 7, 2019

@bors try

@bors

This comment was marked as outdated.

Copy link
Contributor

bors commented Dec 7, 2019

⌛️ Trying commit aff458f with merge 409d60d...

bors added a commit that referenced this pull request Dec 7, 2019
Const prop should finish propagation into user defined variables

Fixes #66638

Temporarily rebased on top of #67015 to get those fixes.

r? @oli-obk
@bors

This comment was marked as outdated.

Copy link
Contributor

bors commented Dec 7, 2019

⌛️ Trying commit aff458f with merge fbd5e47...

bors added a commit that referenced this pull request Dec 7, 2019
Const prop should finish propagation into user defined variables

Fixes #66638

Temporarily rebased on top of #67015 to get those fixes.

r? @oli-obk
@wesleywiser

This comment was marked as outdated.

Copy link
Member Author

wesleywiser commented Dec 7, 2019

@rust-timer queue

@rust-timer

This comment was marked as outdated.

Copy link

rust-timer commented Dec 7, 2019

Awaiting bors try build completion

@rust-highfive

This comment was marked as outdated.

Copy link
Collaborator

rust-highfive commented Dec 7, 2019

Your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@Centril

This comment was marked as outdated.

Copy link
Member

Centril commented Dec 7, 2019

@bors try

@bors

This comment was marked as outdated.

Copy link
Contributor

bors commented Dec 7, 2019

⌛️ Trying commit aff458f with merge 556f29a...

bors added a commit that referenced this pull request Dec 7, 2019
Const prop should finish propagation into user defined variables

Fixes #66638

Temporarily rebased on top of #67015 to get those fixes.

r? @oli-obk
@rust-highfive

This comment was marked as outdated.

Copy link
Collaborator

rust-highfive commented Dec 7, 2019

The job x86_64-gnu-llvm-7 of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
2019-12-07T21:18:24.8317449Z ##[command]git remote add origin https://github.com/rust-lang/rust
2019-12-07T21:18:24.8336131Z ##[command]git config gc.auto 0
2019-12-07T21:18:24.8339577Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2019-12-07T21:18:24.8343793Z ##[command]git config --get-all http.proxy
2019-12-07T21:18:24.8348278Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/67130/merge:refs/remotes/pull/67130/merge
---
2019-12-07T22:13:23.3214581Z ........................................F........................................................... 1600/9336
2019-12-07T22:13:27.6781880Z .................................................................................................... 1700/9336
2019-12-07T22:13:39.0524211Z ................................................i................................................... 1800/9336
2019-12-07T22:13:46.6451710Z .................................................................................................... 1900/9336
2019-12-07T22:13:59.4170324Z .................................iiiii.............................................................. 2000/9336
2019-12-07T22:14:08.4429283Z .................................................................................................... 2200/9336
2019-12-07T22:14:10.7773195Z .................................................................................................... 2300/9336
2019-12-07T22:14:14.7297783Z .................................................................................................... 2400/9336
2019-12-07T22:14:34.6938273Z .................................................................................................... 2500/9336
---
2019-12-07T22:17:00.5965851Z ....................................i...............i............................................... 4800/9336
2019-12-07T22:17:09.3803054Z .................................................................................................... 4900/9336
2019-12-07T22:17:15.7485154Z ................................................................................i................... 5000/9336
2019-12-07T22:17:21.3509325Z .................................................................................................... 5100/9336
2019-12-07T22:17:30.2153524Z .............................................ii.ii...........i...................................... 5200/9336
2019-12-07T22:17:39.0685316Z .................................................................................................... 5400/9336
2019-12-07T22:17:48.1913586Z .................................................................................................... 5500/9336
2019-12-07T22:17:54.7844300Z ...........................i........................................................................ 5600/9336
2019-12-07T22:18:00.5424377Z .................................................................................................... 5700/9336
2019-12-07T22:18:00.5424377Z .................................................................................................... 5700/9336
2019-12-07T22:18:11.4369541Z .................................................................................................... 5800/9336
2019-12-07T22:18:21.4813561Z ...............ii...i..i.i..........i............................................................... 5900/9336
2019-12-07T22:18:37.6905397Z .................................................................................................... 6100/9336
2019-12-07T22:18:41.3120779Z .................................................................................................... 6200/9336
2019-12-07T22:18:41.3120779Z .................................................................................................... 6200/9336
2019-12-07T22:18:52.6138812Z ......................................i..ii......................................................... 6300/9336
2019-12-07T22:19:12.1440959Z .................................................................................................... 6500/9336
2019-12-07T22:19:14.0380916Z ..........i......................................................................................... 6600/9336
2019-12-07T22:19:16.1860692Z .................................................................................................... 6700/9336
2019-12-07T22:19:18.5591118Z .i.................................................................................................. 6800/9336
---
2019-12-07T22:20:49.5985174Z .................................................................................................... 7400/9336
2019-12-07T22:20:54.4111589Z .................................................................................................... 7500/9336
2019-12-07T22:21:00.6189423Z .................................................................................................... 7600/9336
2019-12-07T22:21:10.3934779Z .................................................................................................... 7700/9336
2019-12-07T22:21:16.1110894Z ..............iiii.................................................................................. 7800/9336
2019-12-07T22:21:29.0995375Z .................................................................................................... 8000/9336
2019-12-07T22:21:39.6149688Z .................................................................................................... 8100/9336
2019-12-07T22:21:51.3908449Z .................................................................................................... 8200/9336
2019-12-07T22:21:57.5717184Z .................................................................................................... 8300/9336
---
2019-12-07T22:23:42.9499458Z 8 
2019-12-07T22:23:42.9499867Z - error: this expression will panic at runtime
2019-12-07T22:23:42.9500327Z -   --> $DIR/const-prop-ice2.rs:4:20
2019-12-07T22:23:42.9500727Z -    |
2019-12-07T22:23:42.9501169Z - LL |     println!("{}", xs[Enum::One as usize]);
2019-12-07T22:23:42.9501693Z -    |                    ^^^^^^^^^^^^^^^^^^^^^^ index out of bounds: the len is 1 but the index is 1
2019-12-07T22:23:42.9502550Z - error: aborting due to 2 previous errors
2019-12-07T22:23:42.9502789Z + error: aborting due to previous error
2019-12-07T22:23:42.9502966Z 16 
2019-12-07T22:23:42.9503160Z 17 
2019-12-07T22:23:42.9503160Z 17 
2019-12-07T22:23:42.9503314Z 
2019-12-07T22:23:42.9505099Z 
2019-12-07T22:23:42.9505350Z The actual stderr differed from the expected stderr.
2019-12-07T22:23:42.9505874Z Actual stderr saved to /checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/consts/const-prop-ice2/const-prop-ice2.stderr
2019-12-07T22:23:42.9506343Z To update references, rerun the tests and pass the `--bless` flag
2019-12-07T22:23:42.9506856Z To only update this specific test, also pass `--test-args consts/const-prop-ice2.rs`
2019-12-07T22:23:42.9507258Z error: 1 errors occurred comparing output.
2019-12-07T22:23:42.9508513Z status: exit code: 1
2019-12-07T22:23:42.9508513Z status: exit code: 1
2019-12-07T22:23:42.9509729Z command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/consts/const-prop-ice2.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/consts/const-prop-ice2" "-Crpath" "-O" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/consts/const-prop-ice2/auxiliary" "-A" "unused"
2019-12-07T22:23:42.9510458Z ------------------------------------------
2019-12-07T22:23:42.9510696Z 
2019-12-07T22:23:42.9511289Z ------------------------------------------
2019-12-07T22:23:42.9511534Z stderr:
2019-12-07T22:23:42.9511534Z stderr:
2019-12-07T22:23:42.9511944Z ------------------------------------------
2019-12-07T22:23:42.9512226Z error: index out of bounds: the len is 1 but the index is 1
2019-12-07T22:23:42.9512667Z   --> /checkout/src/test/ui/consts/const-prop-ice2.rs:4:20
2019-12-07T22:23:42.9512947Z    |
2019-12-07T22:23:42.9513151Z LL |     println!("{}", xs[Enum::One as usize]); //~ ERROR the len is 1 but the index is 1
2019-12-07T22:23:42.9513554Z    |
2019-12-07T22:23:42.9513738Z    = note: `#[deny(const_err)]` on by default
2019-12-07T22:23:42.9513902Z 
2019-12-07T22:23:42.9514308Z error: aborting due to previous error
---
2019-12-07T22:23:42.9536302Z thread 'main' panicked at 'Some tests failed', src/tools/compiletest/src/main.rs:537:22
2019-12-07T22:23:42.9536637Z note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace.
2019-12-07T22:23:42.9551001Z 
2019-12-07T22:23:42.9551291Z 
2019-12-07T22:23:42.9553244Z command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "--compile-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib" "--run-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "--rustc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "--src-base" "/checkout/src/test/ui" "--build-base" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui" "--stage-id" "stage2-x86_64-unknown-linux-gnu" "--mode" "ui" "--target" "x86_64-unknown-linux-gnu" "--host" "x86_64-unknown-linux-gnu" "--llvm-filecheck" "/usr/lib/llvm-7/bin/FileCheck" "--host-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--target-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--docck-python" "/usr/bin/python2.7" "--lldb-python" "/usr/bin/python2.7" "--gdb" "/usr/bin/gdb" "--quiet" "--llvm-version" "7.0.0\n" "--system-llvm" "--cc" "" "--cxx" "" "--cflags" "" "--llvm-components" "" "--llvm-cxxflags" "" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--color" "always"
2019-12-07T22:23:42.9553895Z 
2019-12-07T22:23:42.9560659Z 
2019-12-07T22:23:42.9561231Z failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
2019-12-07T22:23:42.9561391Z Build completed unsuccessfully in 0:59:43
2019-12-07T22:23:42.9561391Z Build completed unsuccessfully in 0:59:43
2019-12-07T22:23:42.9610428Z == clock drift check ==
2019-12-07T22:23:42.9628125Z   local time: Sat Dec  7 22:23:42 UTC 2019
2019-12-07T22:23:43.2437228Z   network time: Sat, 07 Dec 2019 22:23:43 GMT
2019-12-07T22:23:43.2442749Z == end clock drift check ==
2019-12-07T22:23:44.0904341Z 
2019-12-07T22:23:44.1035903Z ##[error]Bash exited with code '1'.
2019-12-07T22:23:44.1067707Z ##[section]Starting: Checkout
2019-12-07T22:23:44.1069341Z ==============================================================================
2019-12-07T22:23:44.1069410Z Task         : Get sources
2019-12-07T22:23:44.1069454Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@bors

This comment was marked as outdated.

Copy link
Contributor

bors commented Dec 8, 2019

☀️ Try build successful - checks-azure
Build commit: 556f29a (556f29a19882b5611b6b72969739532774e61d65)

@rust-timer

This comment was marked as outdated.

Copy link

rust-timer commented Dec 8, 2019

Queued 556f29a with parent 5c5c8eb, future comparison URL.

@wesleywiser

This comment was marked as outdated.

Copy link
Member Author

wesleywiser commented Dec 8, 2019

@rust-timer

This comment was marked as outdated.

Copy link

rust-timer commented Dec 8, 2019

Queued 556f29a with parent 5c5c8eb, future comparison URL.

@kennytm

This comment was marked as outdated.

Copy link
Member

kennytm commented Dec 8, 2019

@rust-timer

This comment has been minimized.

Copy link

rust-timer commented Dec 8, 2019

Queued 556f29a with parent 5c5c8eb, future comparison URL.

@rust-timer

This comment has been minimized.

Copy link

rust-timer commented Dec 9, 2019

Finished benchmarking try commit 556f29a, comparison URL.

@wesleywiser wesleywiser force-pushed the wesleywiser:const_prop_into_locals branch 2 times, most recently from 66353c5 to 4db6649 Dec 11, 2019
@wesleywiser

This comment has been minimized.

Copy link
Member Author

wesleywiser commented Dec 11, 2019

Fixed failing unit test and rebased.

@oli-obk

This comment has been minimized.

Copy link
Contributor

oli-obk commented Dec 11, 2019

@bors r+

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Dec 11, 2019

📌 Commit 4db6649 has been approved by oli-obk

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Dec 12, 2019

⌛️ Testing commit 4db6649 with merge 098e203...

bors added a commit that referenced this pull request Dec 12, 2019
Const prop should finish propagation into user defined variables

Fixes #66638

~~Temporarily rebased on top of #67015 to get those fixes.~~

r? @oli-obk
@bors

This comment has been minimized.

Copy link
Contributor

bors commented Dec 13, 2019

💡 This pull request was already approved, no need to approve it again.

  • There's another pull request that is currently being tested, blocking this pull request: #67026
@bors

This comment has been minimized.

Copy link
Contributor

bors commented Dec 13, 2019

📌 Commit 0745b8c has been approved by oli-obk

Centril added a commit to Centril/rust that referenced this pull request Dec 13, 2019
… r=oli-obk

Const prop should finish propagation into user defined variables

Fixes rust-lang#66638

~~Temporarily rebased on top of rust-lang#67015 to get those fixes.~~

r? @oli-obk
bors added a commit that referenced this pull request Dec 14, 2019
Rollup of 5 pull requests

Successful merges:

 - #67130 (Const prop should finish propagation into user defined variables)
 - #67136 (Require stable/unstable annotations for the constness of all stable fns with a const modifier)
 - #67255 (Remove i686-unknown-dragonfly target)
 - #67267 (Fix signature of `__wasilibc_find_relpath`)
 - #67282 (Fix example code of OpenOptions::open)

Failed merges:

r? @ghost
@bors

This comment has been minimized.

Copy link
Contributor

bors commented Dec 14, 2019

⌛️ Testing commit 0745b8c with merge 17881ec...

bors added a commit that referenced this pull request Dec 14, 2019
Const prop should finish propagation into user defined variables

Fixes #66638

~~Temporarily rebased on top of #67015 to get those fixes.~~

r? @oli-obk
@rust-highfive

This comment has been minimized.

Copy link
Collaborator

rust-highfive commented Dec 14, 2019

The job x86_64-gnu-tools of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
2019-12-14T09:33:21.4862076Z {"message":"slicing may panic.","code":{"code":"clippy::indexing_slicing","explanation":null},"level":"error","spans":[{"file_name":"tests/ui/indexing_slicing.rs","byte_start":445,"byte_end":455,"line_start":15,"line_end":15,"column_start":6,"column_end":16,"is_primary":true,"text":[{"text":"    &x[..index];","highlight_start":6,"highlight_end":16}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[{"message":"Consider using `.get(..n)`or `.get_mut(..n)` instead","code":null,"level":"help","spans":[],"children":[],"rendered":null}],"rendered":"error: slicing may panic.\n  --> tests/ui/indexing_slicing.rs:15:6\n   |\nLL |     &x[..index];\n   |      ^^^^^^^^^^\n   |\n   = help: Consider using `.get(..n)`or `.get_mut(..n)` instead\n\n"}
2019-12-14T09:33:21.4863800Z {"message":"slicing may panic.","code":{"code":"clippy::indexing_slicing","explanation":null},"level":"error","spans":[{"file_name":"tests/ui/indexing_slicing.rs","byte_start":462,"byte_end":485,"line_start":16,"line_end":16,"column_start":6,"column_end":29,"is_primary":true,"text":[{"text":"    &x[index_from..index_to];","highlight_start":6,"highlight_end":29}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[{"message":"Consider using `.get(n..m)` or `.get_mut(n..m)` instead","code":null,"level":"help","spans":[],"children":[],"rendered":null}],"rendered":"error: slicing may panic.\n  --> tests/ui/indexing_slicing.rs:16:6\n   |\nLL |     &x[index_from..index_to];\n   |      ^^^^^^^^^^^^^^^^^^^^^^^\n   |\n   = help: Consider using `.get(n..m)` or `.get_mut(n..m)` instead\n\n"}
2019-12-14T09:33:21.4865426Z {"message":"slicing may panic.","code":{"code":"clippy::indexing_slicing","explanation":null},"level":"error","spans":[{"file_name":"tests/ui/indexing_slicing.rs","byte_start":492,"byte_end":519,"line_start":17,"line_end":17,"column_start":6,"column_end":33,"is_primary":true,"text":[{"text":"    &x[index_from..][..index_to]; // Two lint reports, one for [index_from..] and another for [..index_to].","highlight_start":6,"highlight_end":33}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[{"message":"Consider using `.get(..n)`or `.get_mut(..n)` instead","code":null,"level":"help","spans":[],"children":[],"rendered":null}],"rendered":"error: slicing may panic.\n  --> tests/ui/indexing_slicing.rs:17:6\n   |\nLL |     &x[index_from..][..index_to]; // Two lint reports, one for [index_from..] and another for [..index_to].\n   |      ^^^^^^^^^^^^^^^^^^^^^^^^^^^\n   |\n   = help: Consider using `.get(..n)`or `.get_mut(..n)` instead\n\n"}
2019-12-14T09:33:21.4867716Z {"message":"slicing may panic.","code":{"code":"clippy::indexing_slicing","explanation":null},"level":"error","spans":[{"file_name":"tests/ui/indexing_slicing.rs","byte_start":492,"byte_end":507,"line_start":17,"line_end":17,"column_start":6,"column_end":21,"is_primary":true,"text":[{"text":"    &x[index_from..][..index_to]; // Two lint reports, one for [index_from..] and another for [..index_to].","highlight_start":6,"highlight_end":21}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[{"message":"Consider using `.get(n..)` or .get_mut(n..)` instead","code":null,"level":"help","spans":[],"children":[],"rendered":null}],"rendered":"error: slicing may panic.\n  --> tests/ui/indexing_slicing.rs:17:6\n   |\nLL |     &x[index_from..][..index_to]; // Two lint reports, one for [index_from..] and another for [..index_to].\n   |      ^^^^^^^^^^^^^^^\n   |\n   = help: Consider using `.get(n..)` or .get_mut(n..)` instead\n\n"}
2019-12-14T09:33:21.4869651Z {"message":"slicing may panic.","code":{"code":"clippy::indexing_slicing","explanation":null},"level":"error","spans":[{"file_name":"tests/ui/indexing_slicing.rs","byte_start":767,"byte_end":779,"line_start":20,"line_end":20,"column_start":6,"column_end":18,"is_primary":true,"text":[{"text":"    &x[5..][..10]; // Two lint reports, one for out of bounds [5..] and another for slicing [..10].","highlight_start":6,"highlight_end":18}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[{"message":"Consider using `.get(..n)`or `.get_mut(..n)` instead","code":null,"level":"help","spans":[],"children":[],"rendered":null}],"rendered":"error: slicing may panic.\n  --> tests/ui/indexing_slicing.rs:20:6\n   |\nLL |     &x[5..][..10]; // Two lint reports, one for out of bounds [5..] and another for slicing [..10].\n   |      ^^^^^^^^^^^^\n   |\n   = help: Consider using `.get(..n)`or `.get_mut(..n)` instead\n\n"}
2019-12-14T09:33:21.4871491Z {"message":"range is out of bounds","code":{"code":"clippy::out_of_bounds_indexing","explanation":null},"level":"error","spans":[{"file_name":"tests/ui/indexing_slicing.rs","byte_start":769,"byte_end":770,"line_start":20,"line_end":20,"column_start":8,"column_end":9,"is_primary":true,"text":[{"text":"    &x[5..][..10]; // Two lint reports, one for out of bounds [5..] and another for slicing [..10].","highlight_start":8,"highlight_end":9}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[{"message":"`-D clippy::out-of-bounds-indexing` implied by `-D warnings`","code":null,"level":"note","spans":[],"children":[],"rendered":null}],"rendered":"error: range is out of bounds\n  --> tests/ui/indexing_slicing.rs:20:8\n   |\nLL |     &x[5..][..10]; // Two lint reports, one for out of bounds [5..] and another for slicing [..10].\n   |        ^\n   |\n   = note: `-D clippy::out-of-bounds-indexing` implied by `-D warnings`\n\n"}
2019-12-14T09:33:21.4874358Z {"message":"slicing may panic.","code":{"code":"clippy::indexing_slicing","explanation":null},"level":"error","spans":[{"file_name":"tests/ui/indexing_slicing.rs","byte_start":885,"byte_end":896,"line_start":22,"line_end":22,"column_start":6,"column_end":17,"is_primary":true,"text":[{"text":"    &x[1..][..5];","highlight_start":6,"highlight_end":17}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[{"message":"Consider using `.get(..n)`or `.get_mut(..n)` instead","code":null,"level":"help","spans":[],"children":[],"rendered":null}],"rendered":"error: slicing may panic.\n  --> tests/ui/indexing_slicing.rs:22:6\n   |\nLL |     &x[1..][..5];\n   |      ^^^^^^^^^^^\n   |\n   = help: Consider using `.get(..n)`or `.get_mut(..n)` instead\n\n"}
2019-12-14T09:33:21.4875766Z {"message":"indexing may panic.","code":{"code":"clippy::indexing_slicing","explanation":null},"level":"error","spans":[{"file_name":"tests/ui/indexing_slicing.rs","byte_start":1112,"byte_end":1116,"line_start":30,"line_end":30,"column_start":5,"column_end":9,"is_primary":true,"text":[{"text":"    y[0];","highlight_start":5,"highlight_end":9}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[{"message":"Consider using `.get(n)` or `.get_mut(n)` instead","code":null,"level":"help","spans":[],"children":[],"rendered":null}],"rendered":"error: indexing may panic.\n  --> tests/ui/indexing_slicing.rs:30:5\n   |\nLL |     y[0];\n   |     ^^^^\n   |\n   = help: Consider using `.get(n)` or `.get_mut(n)` instead\n\n"}
2019-12-14T09:33:21.4878159Z {"message":"slicing may panic.","code":{"code":"clippy::indexing_slicing","explanation":null},"level":"error","spans":[{"file_name":"tests/ui/indexing_slicing.rs","byte_start":1123,"byte_end":1130,"line_start":31,"line_end":31,"column_start":6,"column_end":13,"is_primary":true,"text":[{"text":"    &y[1..2];","highlight_start":6,"highlight_end":13}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[{"message":"Consider using `.get(n..m)` or `.get_mut(n..m)` instead","code":null,"level":"help","spans":[],"children":[],"rendered":null}],"rendered":"error: slicing may panic.\n  --> tests/ui/indexing_slicing.rs:31:6\n   |\nLL |     &y[1..2];\n   |      ^^^^^^^\n   |\n   = help: Consider using `.get(n..m)` or `.get_mut(n..m)` instead\n\n"}
2019-12-14T09:33:21.4879839Z {"message":"slicing may panic.","code":{"code":"clippy::indexing_slicing","explanation":null},"level":"error","spans":[{"file_name":"tests/ui/indexing_slicing.rs","byte_start":1137,"byte_end":1145,"line_start":32,"line_end":32,"column_start":6,"column_end":14,"is_primary":true,"text":[{"text":"    &y[0..=4];","highlight_start":6,"highlight_end":14}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[{"message":"Consider using `.get(n..m)` or `.get_mut(n..m)` instead","code":null,"level":"help","spans":[],"children":[],"rendered":null}],"rendered":"error: slicing may panic.\n  --> tests/ui/indexing_slicing.rs:32:6\n   |\nLL |     &y[0..=4];\n   |      ^^^^^^^^\n   |\n   = help: Consider using `.get(n..m)` or `.get_mut(n..m)` instead\n\n"}
---
2019-12-14T10:16:01.1249387Z Verifying status of clippy-driver...
2019-12-14T10:16:01.1249464Z Verifying status of miri...
2019-12-14T10:16:01.1249762Z Verifying status of embedded-book...
2019-12-14T10:16:01.1250022Z Verifying status of rustc-guide...
2019-12-14T10:16:01.1250331Z error: Tool `clippy-driver` should be test-pass but is test-fail during beta week.
2019-12-14T10:16:01.1250771Z Build completed unsuccessfully in 0:00:01
2019-12-14T10:16:01.1335734Z == clock drift check ==
2019-12-14T10:16:01.1351479Z   local time: Sat Dec 14 10:16:01 UTC 2019
2019-12-14T10:16:01.4159517Z   network time: Sat, 14 Dec 2019 10:16:01 GMT
2019-12-14T10:16:01.4159517Z   network time: Sat, 14 Dec 2019 10:16:01 GMT
2019-12-14T10:16:01.4160286Z == end clock drift check ==
2019-12-14T10:16:01.9700094Z 
2019-12-14T10:16:01.9804201Z ##[error]Bash exited with code '1'.
2019-12-14T10:16:01.9849683Z ##[section]Starting: Checkout
2019-12-14T10:16:01.9865293Z ==============================================================================
2019-12-14T10:16:01.9865398Z Task         : Get sources
2019-12-14T10:16:01.9865499Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Dec 14, 2019

💔 Test failed - checks-azure

@oli-obk

This comment has been minimized.

Copy link
Contributor

oli-obk commented Dec 14, 2019

oh no 🙈 this PR changes diagnostics in clippy. I guess lets keep it on hold until after the beta cutoff

@wesleywiser

This comment has been minimized.

Copy link
Member Author

wesleywiser commented Dec 19, 2019

I guess this is ready to go?

@oli-obk

This comment has been minimized.

Copy link
Contributor

oli-obk commented Dec 19, 2019

@bors r+

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Dec 19, 2019

💡 This pull request was already approved, no need to approve it again.

  • This pull request previously failed. You should add more commits to fix the bug, or use retry to trigger a build again.
  • There's another pull request that is currently being tested, blocking this pull request: #67435
@bors

This comment has been minimized.

Copy link
Contributor

bors commented Dec 19, 2019

📌 Commit 0745b8c has been approved by oli-obk

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Dec 19, 2019

🌲 The tree is currently closed for pull requests below priority 100, this pull request will be tested once the tree is reopened

@bors bors added S-waiting-on-bors and removed S-blocked labels Dec 19, 2019
Centril added a commit to Centril/rust that referenced this pull request Dec 20, 2019
… r=oli-obk

Const prop should finish propagation into user defined variables

Fixes rust-lang#66638

~~Temporarily rebased on top of rust-lang#67015 to get those fixes.~~

r? @oli-obk
bors added a commit that referenced this pull request Dec 21, 2019
Rollup of 6 pull requests

Successful merges:

 - #67130 (Const prop should finish propagation into user defined variables)
 - #67163 (Split up ptr/mod.rs in libcore...)
 - #67314 (Don't suppress move errors for union fields)
 - #67392 (Fix unresolved type span inside async object)
 - #67404 (Separate region inference logic from error handling better)
 - #67428 (`is_binding_pat`: use explicit match & include or-pats in grammar)

Failed merges:

r? @ghost
@bors bors merged commit 0745b8c into rust-lang:master Dec 21, 2019
4 of 5 checks passed
4 of 5 checks passed
homu Test failed
Details
pr #20191213.12 succeeded
Details
pr (Linux mingw-check) Linux mingw-check succeeded
Details
pr (Linux x86_64-gnu-llvm-7) Linux x86_64-gnu-llvm-7 succeeded
Details
pr (Linux x86_64-gnu-tools) Linux x86_64-gnu-tools succeeded
Details
matthiaskrgr added a commit to matthiaskrgr/rust-clippy that referenced this pull request Dec 21, 2019
bors added a commit to rust-lang/rust-clippy that referenced this pull request Dec 21, 2019
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Dec 21, 2019
Changes:
````
rustup rust-lang#67130
rustup rust-lang#67455
Update lints for `iterator_step_by_zero` changes
Fix 'redudant' spelling in redundant_clone docs
Fix documentation example for unnecessary_filter_map.
Fix `expect_fun_call` false negative on references
Fix `iterator_step_by_zero` description in declaration
Fix `iterator_step_by_zero` definition
Correct `iterator_step_by_zero` documentation
Update iterator_step_by_zero
Prevent `cmp_nan` when inside constants
Detect comparisons with NAN constants
Fix clippy build failure
````
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Dec 21, 2019
Changes:
````
rustup "Merge `ast::Mutability` and `mir::Mutability`"
rustup rust-lang#67130
rustup rust-lang#67455
There are no per-file copyright headers anymore
Update lints for `iterator_step_by_zero` changes
Fix 'redudant' spelling in redundant_clone docs
Fix documentation example for unnecessary_filter_map.
Fix `expect_fun_call` false negative on references
Fix `iterator_step_by_zero` description in declaration
Fix `iterator_step_by_zero` definition
Correct `iterator_step_by_zero` documentation
Update iterator_step_by_zero
Prevent `cmp_nan` when inside constants
Detect comparisons with NAN constants
Fix clippy build failure
````
bors added a commit that referenced this pull request Dec 22, 2019
submodules: update clippy from 69f99e74 to acbc609a

Changes:
````
rustup "Merge `ast::Mutability` and `mir::Mutability`"
rustup #67130
rustup #67455
Update lints for `iterator_step_by_zero` changes
Fix 'redudant' spelling in redundant_clone docs
Fix documentation example for unnecessary_filter_map.
Fix `expect_fun_call` false negative on references
Fix `iterator_step_by_zero` description in declaration
Fix `iterator_step_by_zero` definition
Correct `iterator_step_by_zero` documentation
Update iterator_step_by_zero
Prevent `cmp_nan` when inside constants
Detect comparisons with NAN constants
Fix clippy build failure
````

r? @oli-obk  @Manishearth
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.