Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LinkedList: drop remaining items when drop panics #67243

Merged
merged 1 commit into from Dec 13, 2019

Conversation

@jonas-schievink
Copy link
Member

jonas-schievink commented Dec 11, 2019

#67235, but for LinkedList, which has the same issue.

I've also copied over the other drop-related tests from VecDeque since AFAICT LinkedList didn't have any.

@rust-highfive

This comment has been minimized.

Copy link
Collaborator

rust-highfive commented Dec 11, 2019

r? @KodrAus

(rust_highfive has picked a reviewer for you, use r? to override)

@KodrAus

This comment has been minimized.

Copy link
Contributor

KodrAus commented Dec 12, 2019

@bors r+

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Dec 12, 2019

📌 Commit 5e32da1 has been approved by KodrAus

Centril added a commit to Centril/rust that referenced this pull request Dec 12, 2019
…KodrAus

LinkedList: drop remaining items when drop panics

rust-lang#67235, but for `LinkedList`, which has the same issue.

I've also copied over the other drop-related tests from `VecDeque` since AFAICT `LinkedList` didn't have any.
bors added a commit that referenced this pull request Dec 13, 2019
Rollup of 7 pull requests

Successful merges:

 - #67224 (Revert stabilization of never type)
 - #67235 (VecDeque: drop remaining items on destructor panic)
 - #67243 (LinkedList: drop remaining items when drop panics)
 - #67247 (Don't suggest wrong snippet in closure)
 - #67250 (Remove the `DelimSpan` from `NamedMatch::MatchedSeq`.)
 - #67251 (Require `allow_internal_unstable` for stable min_const_fn using unsta…)
 - #67255 (Remove i686-unknown-dragonfly target)

Failed merges:

r? @ghost
Centril added a commit to Centril/rust that referenced this pull request Dec 13, 2019
…KodrAus

LinkedList: drop remaining items when drop panics

rust-lang#67235, but for `LinkedList`, which has the same issue.

I've also copied over the other drop-related tests from `VecDeque` since AFAICT `LinkedList` didn't have any.
bors added a commit that referenced this pull request Dec 13, 2019
Rollup of 6 pull requests

Successful merges:

 - #66341 (Match `VecDeque::extend` to `Vec::extend_desugared`)
 - #67243 (LinkedList: drop remaining items when drop panics)
 - #67247 (Don't suggest wrong snippet in closure)
 - #67250 (Remove the `DelimSpan` from `NamedMatch::MatchedSeq`.)
 - #67251 (Require `allow_internal_unstable` for stable min_const_fn using unsta…)
 - #67269 (parser: recover on `&'lifetime mut? $pat`.)

Failed merges:

r? @ghost
@bors bors merged commit 5e32da1 into rust-lang:master Dec 13, 2019
4 checks passed
4 checks passed
pr #20191211.68 succeeded
Details
pr (Linux mingw-check) Linux mingw-check succeeded
Details
pr (Linux x86_64-gnu-llvm-7) Linux x86_64-gnu-llvm-7 succeeded
Details
pr (Linux x86_64-gnu-tools) Linux x86_64-gnu-tools succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.