Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert #65244 for performance reasons #67768

Merged
merged 1 commit into from Jan 3, 2020

Conversation

@wesleywiser
Copy link
Member

wesleywiser commented Jan 1, 2020

This reverts commit f35517e.

Revert #65244 so we can see if it is the cause of the performance issue in #67706

cc #67644

This reverts commit f35517e.
@rust-highfive

This comment has been minimized.

Copy link
Collaborator

rust-highfive commented Jan 1, 2020

r? @zackmdavis

(rust_highfive has picked a reviewer for you, use r? to override)

@wesleywiser

This comment has been minimized.

Copy link
Member Author

wesleywiser commented Jan 1, 2020

r? @ghost

@bors try

@rust-timer queue

@rust-timer

This comment has been minimized.

Copy link

rust-timer commented Jan 1, 2020

Awaiting bors try build completion

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Jan 1, 2020

⌛️ Trying commit 717702d with merge 5671b03...

bors added a commit that referenced this pull request Jan 1, 2020
[perf] DO NOT MERGE test reverting #65244

This reverts commit f35517e.

Revert #65244 so we can see if it is the cause of the performance issue in #67706
@bors

This comment has been minimized.

Copy link
Contributor

bors commented Jan 1, 2020

☀️ Try build successful - checks-azure
Build commit: 5671b03 (5671b03c0b64dbbec704a3846ddc7966a6a7eb59)

@rust-timer

This comment has been minimized.

Copy link

rust-timer commented Jan 1, 2020

Queued 5671b03 with parent 119307a, future comparison URL.

@rust-timer

This comment has been minimized.

Copy link

rust-timer commented Jan 1, 2020

Finished benchmarking try commit 5671b03, comparison URL.

@wesleywiser wesleywiser closed this Jan 1, 2020
@wesleywiser wesleywiser changed the title [perf] DO NOT MERGE test reverting #65244 Revert #65244 for performance reasons Jan 2, 2020
@wesleywiser wesleywiser reopened this Jan 2, 2020
@wesleywiser

This comment has been minimized.

Copy link
Member Author

wesleywiser commented Jan 2, 2020

Per compiler team triage meeting (see #67706 (comment)), I'm reopening this for merging.

r? @Mark-Simulacrum

@Mark-Simulacrum

This comment has been minimized.

Copy link
Member

Mark-Simulacrum commented Jan 2, 2020

@bors r+ p=1 rollup=never

Approving this per compiler team decision and prioritizing as a regression fix. Also marking as no-rollup since we want to avoid the fixes here masking some other regression.

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Jan 2, 2020

📌 Commit 717702d has been approved by Mark-Simulacrum

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Jan 3, 2020

⌛️ Testing commit 717702d with merge 4877e16...

bors added a commit that referenced this pull request Jan 3, 2020
…crum

Revert #65244 for performance reasons

This reverts commit f35517e.

Revert #65244 so we can see if it is the cause of the performance issue in #67706

cc #67644
@bors

This comment has been minimized.

Copy link
Contributor

bors commented Jan 3, 2020

☀️ Test successful - checks-azure
Approved by: Mark-Simulacrum
Pushing 4877e16 to master...

@bors bors added the merged-by-bors label Jan 3, 2020
@bors bors merged commit 717702d into rust-lang:master Jan 3, 2020
5 checks passed
5 checks passed
homu Test successful
Details
pr Build #20200102.33 succeeded
Details
pr (Linux mingw-check) Linux mingw-check succeeded
Details
pr (Linux x86_64-gnu-llvm-7) Linux x86_64-gnu-llvm-7 succeeded
Details
pr (Linux x86_64-gnu-tools) Linux x86_64-gnu-tools succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.