Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Formatting an example for method Vec.retain #67929

Merged
merged 1 commit into from Jan 7, 2020
Merged

Conversation

@mgrachev
Copy link
Contributor

mgrachev commented Jan 6, 2020

No description provided.

@rust-highfive

This comment has been minimized.

Copy link
Collaborator

rust-highfive commented Jan 6, 2020

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @shepmaster (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@jonas-schievink

This comment has been minimized.

Copy link
Member

jonas-schievink commented Jan 6, 2020

Thanks!

@bors r+ rollup

r? @jonas-schievink

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Jan 6, 2020

📌 Commit e6d95ce has been approved by jonas-schievink

Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Jan 6, 2020
Formatting an example for method Vec.retain
bors added a commit that referenced this pull request Jan 6, 2020
Rollup of 5 pull requests

Successful merges:

 - #67875 (Distinguish between private items and hidden items in rustdoc)
 - #67880 (Handle multiple error fix suggestions carefuly)
 - #67887 (`Option::{expect,unwrap}` and `Result::{expect, expect_err, unwrap, unwrap_err}` have `#[track_caller]`)
 - #67908 (rustdoc: HTML escape const values)
 - #67929 (Formatting an example for method Vec.retain)

Failed merges:

r? @ghost
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Jan 6, 2020
Formatting an example for method Vec.retain
bors added a commit that referenced this pull request Jan 6, 2020
Rollup of 8 pull requests

Successful merges:

 - #67566 (Add an unstable conversion from thread ID to u64)
 - #67727 (Stabilise vec::remove_item)
 - #67877 (Omit underscore constants from rustdoc)
 - #67908 (rustdoc: HTML escape const values)
 - #67929 (Formatting an example for method Vec.retain)
 - #67934 (Clean up E0178 explanation)
 - #67936 (fire "non_camel_case_types" for associated types)
 - #67943 (Missing module std in example.)

Failed merges:

r? @ghost
JohnTitor added a commit to JohnTitor/rust that referenced this pull request Jan 7, 2020
Formatting an example for method Vec.retain
bors added a commit that referenced this pull request Jan 7, 2020
Rollup of 13 pull requests

Successful merges:

 - #67566 (Add an unstable conversion from thread ID to u64)
 - #67671 (Account for `type X = impl Trait;` in lifetime suggestion)
 - #67727 (Stabilise vec::remove_item)
 - #67877 (Omit underscore constants from rustdoc)
 - #67880 (Handle multiple error fix suggestions carefuly)
 - #67898 (Improve hygiene of `newtype_index`)
 - #67908 (rustdoc: HTML escape const values)
 - #67909 (Fix ICE in const pretty printing and resolve FIXME)
 - #67929 (Formatting an example for method Vec.retain)
 - #67934 (Clean up E0178 explanation)
 - #67936 (fire "non_camel_case_types" for associated types)
 - #67943 (Missing module std in example.)
 - #67962 (Update books)

Failed merges:

r? @ghost
@bors bors merged commit e6d95ce into rust-lang:master Jan 7, 2020
4 checks passed
4 checks passed
pr Build #20200106.24 succeeded
Details
pr (Linux mingw-check) Linux mingw-check succeeded
Details
pr (Linux x86_64-gnu-llvm-7) Linux x86_64-gnu-llvm-7 succeeded
Details
pr (Linux x86_64-gnu-tools) Linux x86_64-gnu-tools succeeded
Details
@mgrachev mgrachev deleted the mgrachev:patch-1 branch Jan 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.