Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Account for non-types in substs for opaque type error messages #68438

Merged
merged 1 commit into from Jan 24, 2020

Conversation

@Aaron1011
Copy link
Contributor

Aaron1011 commented Jan 21, 2020

Fixes #68368

Previously, I assumed that the substs contained only types, which caused
the computed index number to be wrong.

Fixes #68368

Previously, I assumed that the substs contained only types, which caused
the computed index number to be wrong.
@rust-highfive

This comment has been minimized.

Copy link
Collaborator

rust-highfive commented Jan 21, 2020

r? @estebank

(rust_highfive has picked a reviewer for you, use r? to override)

@estebank

This comment has been minimized.

Copy link
Contributor

estebank commented Jan 23, 2020

@bors r+

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Jan 23, 2020

📌 Commit 4ee4287 has been approved by estebank

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Jan 23, 2020

⌛️ Testing commit 4ee4287 with merge 09c65b0...

bors added a commit that referenced this pull request Jan 23, 2020
Account for non-types in substs for opaque type error messages

Fixes #68368

Previously, I assumed that the substs contained only types, which caused
the computed index number to be wrong.
@bors

This comment has been minimized.

Copy link
Contributor

bors commented Jan 23, 2020

💔 Test failed - checks-azure

@Aaron1011

This comment has been minimized.

Copy link
Contributor Author

Aaron1011 commented Jan 23, 2020

@estebank: The failure looks spurious.

@estebank

This comment has been minimized.

Copy link
Contributor

estebank commented Jan 23, 2020

@bors retry

tmandry added a commit to tmandry/rust that referenced this pull request Jan 24, 2020
…estebank

Account for non-types in substs for opaque type error messages

Fixes rust-lang#68368

Previously, I assumed that the substs contained only types, which caused
the computed index number to be wrong.
bors added a commit that referenced this pull request Jan 24, 2020
Rollup of 8 pull requests

Successful merges:

 - #68080 (Address inconsistency in using "is" with "declared here")
 - #68424 (Suggest borrowing `Vec<NonCopy>` in for loop)
 - #68438 (Account for non-types in substs for opaque type error messages)
 - #68469 (Avoid overflow in `std::iter::Skip::count`)
 - #68473 (Enable ASan on Fuchsia)
 - #68479 (Implement `unused_parens` for block return values)
 - #68483 (Add my (@flip1995) name to .mailmap)
 - #68500 (Clear out std, not std tools)

Failed merges:

r? @ghost
tmandry added a commit to tmandry/rust that referenced this pull request Jan 24, 2020
…estebank

Account for non-types in substs for opaque type error messages

Fixes rust-lang#68368

Previously, I assumed that the substs contained only types, which caused
the computed index number to be wrong.
bors added a commit that referenced this pull request Jan 24, 2020
Rollup of 7 pull requests

Successful merges:

 - #68424 (Suggest borrowing `Vec<NonCopy>` in for loop)
 - #68438 (Account for non-types in substs for opaque type error messages)
 - #68469 (Avoid overflow in `std::iter::Skip::count`)
 - #68473 (Enable ASan on Fuchsia)
 - #68479 (Implement `unused_parens` for block return values)
 - #68483 (Add my (@flip1995) name to .mailmap)
 - #68500 (Clear out std, not std tools)

Failed merges:

r? @ghost
@bors bors merged commit 4ee4287 into rust-lang:master Jan 24, 2020
4 of 5 checks passed
4 of 5 checks passed
homu Test failed
Details
pr Build #20200121.70 succeeded
Details
pr (Linux mingw-check) Linux mingw-check succeeded
Details
pr (Linux x86_64-gnu-llvm-7) Linux x86_64-gnu-llvm-7 succeeded
Details
pr (Linux x86_64-gnu-tools) Linux x86_64-gnu-tools succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

5 participants
You can’t perform that action at this time.